5.48

Fixes fatal error - function doesn't exist

As per https://developer.wordpress.org/reference/functions/is_favicon/ this function was only added in 5.4.0
meaning CiviCRM now breaks if installed on a site running Wordpress < 5.4.0

5.47

Conditionally make CiviCRM's menu position an integer

wp-cli/civicrm.php - Add 'civicrm pipe' subcommand

Streamline and enhance the plugin load procedure (rebased)

This reproduces some of the cleanups from
921af8ecad9bfacd84ed90fcdd84cbe222854031 - specifically, the parts dealing with
the method `CiviCRM_Command::install()`

haystack authored Nov 24, 2021 and totten committed Jan 14, 2022

This is a rebased/cherry-picked version of 921af8ecad9bfacd84ed90fcdd84cbe222854031. However,
it skips the changes in`wp-cli/civicrm.php`'s `CiviCRM_Command::install` because these
have conflicts.

I'll try to reproduce those changes as a separate/smaller commit.

Add support for subcommand `wp civicrm pipe`

Before
------------

Longer commands:

```bash
wp eval 'civicrm_initialize(); Civi::pipe();'
wp eval 'civicrm_initialize(); Civi::pipe("vlu");'
````

After
-------------

Shorter commands:

```bash
wp civicrm pipe
wp civicrm pipe vlu
```

Comment
--------------

If the command is successful, it will show a welcome/header line, e.g.

```javascript
{"Civi::pipe":{"v":"5.47.alpha1","l":["nologin"],"u":"untrusted"}}
```

You may then send JSON-RPC 2.0 requests, e.g.

```javascript
// Send request for `echo("hello world")`
{"jsonrpc":"2.0","method":"echo","params":["hello world"],"id":null}
// Receive response "hello world"
{"jsonrpc":"2.0","result":["hello world"],"id":null}
```

(core#1615) wp-cli - Perform CLI installations using Civi\Setup

HookTest - Fix execution on PHP 8

Before
------

Test fails on PHP 8

```
CiviWP\HookTest::testFoo
Undefined array key "hook_was_called"

/home/jenkins/bknix-dfl/build/wp-265-47vsb/web/wp-content/plugins/civicrm/tests/phpunit/CiviWP/HookTest.php:22
```

After
-----

Test passes

Comments
--------

This is a superficial change - the point of the assertion is to validate the
starting circumstance (asserting that the hook has not yet run). This is just
a cleaner assertion that the hook has not yet run.

Inadvertently dropped when switching from civicrm/install to civirm/setup.
Fixing within same branch/PR.

The installation process involves a few distinct steps, eg *activating* the CiviCRM WP plugin
and *running the setup logic* (eg DB/data-file init). But which one should execute first?

Before
-----

The web and CLI flows differ:

* Web flow: Activation then setup-logic
* CLI flow: Activation is optional. If you skip it, it will auto-activate _after_ setup-logic.
  (Note opposite order of operations.)

The CLI flow produces a large number of warnings and erroneous-behavior like

```
Warning: file_get_contents(CIVICRM_PLUGIN_DIRcivicrm/extension-compatibility.json): failed to open stream:
  No such file or directory in /home/fixme/public_html/wp-content/plugins/civicrm/civicrm/CRM/Extension/System.php on line 301
```

After
-----

The order is consistent - the plugin will always activate before running setup-logic.

The above warning goes away. `CIVICRM_PLUGIN_DIR` is reliably available during setup-logic.

Overview
--------

Per core#1615, change how `wp civicrm install` performs installation.
Using the `Civi\Setup` means that:

* There's more shared installation code (eg WP GUI / WP-CLI / cv CLI). Less duplicated installation code.
* Supports more install-time options (`$setup->getModel()`) to configure extensions, components, settings, etc
* Some options are impelmented more correctly (eg `$setup->getModel()->lang`).

Before
-------

* Loads the old installer, which (eg) does not have the ability to activate extensions or apply settings.

After
-----

* Loads `civicrm-setup` (aka `Civi\Setup`) which (a) has more functionality and (b) is used by the WP+Drupal GUIs and by `cv` CLI.

Technical details
-------------------

To test, here was my process:

* Setup an empty WordPress site and load the CiviCRM code (but don't run the installer yet).
    * Specifically, I used `wpmaster`. But I hacked `buildkit/app/wp-demo/install.sh` to skip Civi install. Then I ran `civibuild reinstall wpmaster`.
    * Alternatively, you might install a new WordPress site and download the tarball -- then apply the patches.
    * Alternatively, you might use `wpmaster` and uninstall Civi (deactivate plugin, delete `wp-content/uploads/civicrm`, drop SQL tables).
* Make a DB snapshot with the empty Civi+WP DBs (`civibuild snapshot wpmaster`)
* Run a series of commands like this:
    ```bash
    rm ~/bknix/build/wpmaster/web/wp-content/uploads/civicrm/ -rf
    civibuild restore wpmaster
    wp plugin activate civicrm
    wp civicrm install --dbhost=127.0.0.1:3307 --dbname=FIXME --dbuser=FIXME --dbpass=FIXME --lang=fr_FR
    ```

Comments
--------

This includes tangential changes in `--lang` handling:

* In `wp-cli/civicrm.php`, only require `--langtarfile` if we're missing the l10n data.
  It's OK to use pre-existing l10n data.
* Use `Civi::setup()` for lang setup. This loads the localized data *and also* updates
  the initial `civicrm_setting`s to use the the language. (The prior routine neglected
  to set the active language.)*

Before: Suppose you are trying to install with existing source code. If you specify `--lang`, it will complain
that `--langtarfile=...` is required (even if the language files already exist).

After: You can install a language using *either* `--langtarfile=...` *or* an existing l10n file.

Comment: If you try to install with a language that you don't have, then it will still complain, ie:

```
Error: Failed to find data for language (fr_US). Please download valid language data with --langtarfile=<path/to/tarfile>.
```

Some upcoming patches will want to the $crmPath. Make this available sooner.

CiviCRM WordPress shortcode remove the display of default text and instead just return blank if the shortcode cannot be rendered.

Resolve conflict with AIOSEO stomping on CiviCRM Shortcode

CIVICRM-1896 CiviCRM WordPress shortcode remove the display of default text and instead just return blank if the shortcode cannot be rendered

Prevent fatal error when the "the_title" filter has only one param

Check recursively for CiviCRM Shortcodes in post content

Introduce "Shortcode Display Mode" setting and functionality

Fix unreplaced template vars in civicrm.settings.php when using wp-cli installer

Add deduping to Quick Add Dashboard Widget

revert #240 Remove Base Page content filter once it has been used

Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>