Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Translation
Translation
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • TranslationTranslation
  • Issues
  • #61

Closed
Open
Opened Jan 07, 2021 by bgm@bgmOwner

docURL and ts, or how ConfigTaskList.tpl has odd translation strings

When running the string extraction, these strings end up in the .pot files:

#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviContribute" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviPledge" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviEvent" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviMember" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviMail" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviCampaign" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviCase" 
msgstr "" 
 
#: templates/CRM/Admin/Page/ConfigTaskList.tpl 
msgid "$componentTitles.CiviGrant" 
msgstr "" 

To test:

civistrings templates/CRM/Admin/Page/ConfigTaskList.tpl 

Is it because of an incorrect use of ts, or is it because civistrings should ignore crmURL?

Code:

    <tr class="even">
        <td class="tasklist nowrap" style="width: 10%;">{docURL page="user/contributions/what-is-civicontribute" text=$componentTitles.CiviContribute}</td>
        <td>{ts}Online fundraising and donor management, as well as offline contribution processing and tracking.{/ts}</td>
    </tr>

Example of docURL strings that should be extracted:

templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkCustom}{docURL page="user/organising-your-data/custom-fields" text="custom fields"}{/capture}
templates/CRM/Contribute/Form/ContributionPage/Custom.hlp:{capture assign=docLinkProfile}{docURL page="user/organising-your-data/profiles" text="profiles"}{/capture}
templates/CRM/Case/Page/ConfigureError.tpl:{capture assign=docLink}{docURL page="user/case-management/set-up" text="CiviCase Setup documentation"}{/capture}
templates/CRM/Contact/Form/OnBehalfOf.tpl:                    {ts}Latitude and longitude may be automatically populated by enabling a Mapping Provider.{/ts} {docURL page="user/initial-set-up/installation-and-basic-set-up" text="(Refer to the Mapping and Geocoding section in the Installation and Basic Setup Chapter)"}</span>

I feel like we should instead use 'ts' in the docURL call, instead of assuming it. There are 22 instances where it would need fixing.

grep -r docURL templates/ | grep text | grep -v componentTitle

@totten @seamuslee Any thoughts?

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/translation#61