Deprecate `getBasicContactFields` in favor of `getColumns('Contact')`
@eileen has ported some of the cleaner code for defining report specs from Extended Reports to core in the form of getColumns()
and getContactColumns()
. Since this appears to be the direction we're headed in, I think it makes sense to deprecate getBasicContactColumns()
, which does a similar job. However, getBasicContactColumns()
adds a bunch of fields to core reports that getContactColumns
doesn't.
My PR adds all the missing fields to getContactColumns
(except for "Organization Name"; this seems unnecessary since it will virtually always match the display name). I also mark getBasicContactFields()
as deprecated so future cleanup can target reports using it.