Financial issueshttps://lab.civicrm.org/dev/financial/-/issues2023-11-21T03:45:45Zhttps://lab.civicrm.org/dev/financial/-/issues/221Contribution date no longer has a time on the form2023-11-21T03:45:45ZDaveDContribution date no longer has a time on the formhttps://chat.civicrm.org/civicrm/pl/sgxqjrxq6pyaxftxftwtexf56a
The field itself still stores a time, but it's the "current" time which may or may not make sense.
If I remove this line it comes back: https://github.com/civicrm/civicrm-c...https://chat.civicrm.org/civicrm/pl/sgxqjrxq6pyaxftxftwtexf56a
The field itself still stores a time, but it's the "current" time which may or may not make sense.
If I remove this line it comes back: https://github.com/civicrm/civicrm-core/blob/9eaef13ef15da8bac6b73148d570fd989529789d/CRM/Utils/Date.php#L1990
Seems to be from https://github.com/civicrm/civicrm-core/pull/27003, so works in 5.65 but not 5.66.
Also receipt date, so it probably affects any date field that isn't somehow specified as TIMESTAMP. I'm not sure where it gets that "metadata" and whether datetime and timestamp here mean the same thing as they do for db fields.5.67.2https://lab.civicrm.org/dev/financial/-/issues/220With tax enabled Total Amount is confusing in online receipt and tax amount l...2023-11-15T18:37:43ZDaveDWith tax enabled Total Amount is confusing in online receipt and tax amount line is wrongIt used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/i...It used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/issues/206 just in the interim changes have caused the problem to shift.
Also the confirm and thankyou pages make no mention of the tax and there's now a php warning about a missing tax var on those pages.
![untitled7](/uploads/8fcb99238d074a7dd4a53ec000bf51b1/untitled7.png)
![untitled8](/uploads/ebb164e557d99a76bb0f90381b0525c9/untitled8.png)
One way to reproduce:
1. Turn on tax and invoicing. https://docs.civicrm.org/user/en/latest/contributions/sales-tax-and-vat/
* In my case I set up a non-deductible financial type called t-shirts and a corresponding sales tax account that has 5% tax.
2. Create a price set for it.
* There's one price field. I used type text/quantity. Field is required although that's not relevant just makes sense here. Financial type t-shirts.
3. Set up the dummy payment processor.
4. Create a contribution page with that processor and financial type t-shirts and use the price set. Set it to send a receipt.
5. Buy a t-shirt.5.68.0https://lab.civicrm.org/dev/financial/-/issues/219the Price Set labels are showing html2023-11-02T00:23:16ZJoeMurraythe Price Set labels are showing htmlDmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)Dmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)5.68.0eileeneileenhttps://lab.civicrm.org/dev/financial/-/issues/213Imported has completed successfully, but that's not true2023-01-15T21:04:15ZKarinGImported has completed successfully, but that's not trueCiviCRM 5.56.2
Contributions -> Import via UI ->
Client also noted (and I confirmed) that Contact Type appears to be no longer relevant/required.
Previous behaviour: CiviCRM generates an import_error file noting the contributions which...CiviCRM 5.56.2
Contributions -> Import via UI ->
Client also noted (and I confirmed) that Contact Type appears to be no longer relevant/required.
Previous behaviour: CiviCRM generates an import_error file noting the contributions which could not be imported and the reason - in this case Contact ID does not exist.
Screenshots (really awesome client report):
![image](/uploads/e569fd7fac5fb380e64318731aab5925/image.png)
![image](/uploads/713ee8a4cb0112b052a82fac53fe98e7/image.png)
![image](/uploads/736818ab47519bee7944120f5d577097/image.png)
![image](/uploads/1162ab9a29299db21546bf2e295a3d22/image.png)
![image](/uploads/9e3a4cf72ead03397d48542c24baa751/image.png)
![image](/uploads/60a57e3362cadf8710e9a194331a4159/image.png)5.57.0https://lab.civicrm.org/dev/financial/-/issues/209Disabled Financial Types are listed when creating a Price Field2022-11-02T00:34:40ZpetednzDisabled Financial Types are listed when creating a Price FieldReplicated on dmaster.
1/ create a new Financial Type - set it as disabled.
2/ create new price set / field and note that the disabled Type is showing
3/ try to save - spinny spin spin if using pop ups - if not using pop-up get
4/ Finan...Replicated on dmaster.
1/ create a new Financial Type - set it as disabled.
2/ create new price set / field and note that the disabled Type is showing
3/ try to save - spinny spin spin if using pop ups - if not using pop-up get
4/ Financial Type for Price Field Option is either disabled or does not exist
is there a logic for showing disabled fields in this interface - can't personally think of one esp the pain of users sitting for 10 mins waiting for things to save.
Possibly related to https://lab.civicrm.org/dev/financial/-/issues/198 though that seems the other end of the problem, ie a Price Field is using a Fin Type that has since been set to be disabled5.56.0colemanwcolemanwhttps://lab.civicrm.org/dev/financial/-/issues/208Download invoice button on contribution view gives fatal error2022-09-02T00:36:12ZDaveDDownload invoice button on contribution view gives fatal errorMy guess is it happened here: https://github.com/civicrm/civicrm-core/commit/f436aaf2501fbf20ed411e5976d2dd14c588d1b6#diff-b96eb626cc73750f3b681bd12d980236b7062d1633e9d067d3d00d07cdb37a98R243
TypeError: Argument 3 passed to CRM_Contribu...My guess is it happened here: https://github.com/civicrm/civicrm-core/commit/f436aaf2501fbf20ed411e5976d2dd14c588d1b6#diff-b96eb626cc73750f3b681bd12d980236b7062d1633e9d067d3d00d07cdb37a98R243
TypeError: Argument 3 passed to CRM_Contribute_Form_Task_PDF::getElements() must be of the type array, int given, called in .../CRM/Contribute/Form/Task/Invoice.php on line 225 in CRM_Contribute_Form_Task_PDF::getElements() (line 243 in .../CRM/Contribute/Form/Task/PDF.php).
Probably it needs to be more tolerant that it could sometimes receive a single contact id not an array?5.54.0https://lab.civicrm.org/dev/financial/-/issues/199Additional Details section on Recurring Contribution template edit screen doe...2022-06-15T00:25:33ZDaveDAdditional Details section on Recurring Contribution template edit screen doesn't load anymoreSomewhat related to https://lab.civicrm.org/dev/financial/-/issues/197
If you look at screenshot 5 there, in the Additional Details section, note the spinning icon and "Loading...". This is coming from https://github.com/civicrm/civicrm...Somewhat related to https://lab.civicrm.org/dev/financial/-/issues/197
If you look at screenshot 5 there, in the Additional Details section, note the spinning icon and "Loading...". This is coming from https://github.com/civicrm/civicrm-core/pull/21471/files#diff-74e8144a14bfd4d8bf9cf4279c90cded28c43351c70a338d4502612d6e0f1c36R448 where it's trying to freeze the status field but there is no status field on the Additional Details section.5.51.0https://lab.civicrm.org/dev/financial/-/issues/197Can no longer update Amount for Recurring Contributions even if it only has o...2022-06-17T01:12:06ZKarinGCan no longer update Amount for Recurring Contributions even if it only has one Lineitem1. Scenario:
A native CiviCRM Contribution page for people to start a Monthly Donation. People can select an amount or enter a custom amount:
![image](/uploads/f804e779d8a59e8c700d71d553ef1d44/image.png)
2. It uses a Priceset:
![imag...1. Scenario:
A native CiviCRM Contribution page for people to start a Monthly Donation. People can select an amount or enter a custom amount:
![image](/uploads/f804e779d8a59e8c700d71d553ef1d44/image.png)
2. It uses a Priceset:
![image](/uploads/5fe1c1c85e7a8ea0046a3752381ac306/image.png)
3. Admin used to be able to update the recurring amount to be transacted here ->
![image](/uploads/8746e3b2aed512d1d467e5c178f1441c/image.png)
4. There is a note at the top that one now needs to edit the Template Contribution ->
![image](/uploads/2c175648b6e4a24839b70220df96135a/image.png)
5. But it can't be edited ->
![image](/uploads/f00911e26a76b1741999c943ed891d8d/image.png)
6. Even though there is only one line item:
![image](/uploads/b88571a041f8473d3885a05994298729/image.png)
7. I've also tested a simpler priceset with only ONE field -> same result - one can not edit the amount
![image](/uploads/a9384f511a03dbb39827cff3526367f6/image.png)
![image](/uploads/ec375efd47b0964c6e8f7894611f7aac/image.png)
![image](/uploads/1e7590cea80ad145580866fd2fc6e6d6/image.png)5.51.0https://lab.civicrm.org/dev/financial/-/issues/194Unable to edit amount of recurring series2022-06-13T16:42:23ZKarinGUnable to edit amount of recurring seriesWe just noted a regression affecting all latest releases 5.45.x ESR through 5.50.x -> our iATS clients are not able to update amounts for recurring contributions -> Alan @adixon and I confirmed it on two separate sites D9 and D7 and two ...We just noted a regression affecting all latest releases 5.45.x ESR through 5.50.x -> our iATS clients are not able to update amounts for recurring contributions -> Alan @adixon and I confirmed it on two separate sites D9 and D7 and two different methods (credit card and ACH) -> we have clients who have been using CiviCRM for 10y - who have over 10k of these series to manage and they can't bump e.g. this donor from $20 to $25
![image](/uploads/cfc1a9d1a87409946be83be31b8ce860/image.png)
It looks like a form issue -> note the errors:
`Cannot change contribution status from Template to .`
and
`Date Received is a required field`
Marking as regression as in the past admins were able to update recurring series amounts.https://lab.civicrm.org/dev/financial/-/issues/1805.41 rc - order api stores totals incorrectly when line items not passed in2021-08-27T05:28:36ZKarinG5.41 rc - order api stores totals incorrectly when line items not passed inReproduced on automated testing ->
5.41rc fails ->
![image](/uploads/9b90e5365869ca73f41a5f32b53ff22d/image.png)
We'll need to check if 5.40 is ok - more later!Reproduced on automated testing ->
5.41rc fails ->
![image](/uploads/9b90e5365869ca73f41a5f32b53ff22d/image.png)
We'll need to check if 5.40 is ok - more later!5.41.0https://lab.civicrm.org/dev/financial/-/issues/171False positive message about missing INTL PHP extension on membership type form2021-03-31T23:26:43ZDaveDFalse positive message about missing INTL PHP extension on membership type formHappens on dmaster.demo too so it's not windows or anything weird.
1. Click add membership type.
2. Click cancel. It happens if you fill it out too but this is quicker and is enough to see it.
There might be a couple things here.
One ...Happens on dmaster.demo too so it's not windows or anything weird.
1. Click add membership type.
2. Click cancel. It happens if you fill it out too but this is quicker and is enough to see it.
There might be a couple things here.
One is that the message is tied partly to whether the value is numeric, which doesn't really have anything to do with the missing php extension.
The second is that for whatever reason the $amount value is being passed in as `<input size="6" maxlength="14" name="minimum_fee" type="text" id="minimum_fee" class="six crm-form-text" />`. I'm not sure yet what the mismatch is there.
It's kind of a regression because of the numeric part, but the form value might be old.5.37.0https://lab.civicrm.org/dev/financial/-/issues/166Account IIF Export Amount Format improper2021-03-01T02:27:36ZLoganBearAccount IIF Export Amount Format improperBatches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel...Batches created before 5.34 export simple value amounts:
```
12.00
-12.00
```
Batches after the upgrade to 5.34 adds a dollar sign to the amount:
```
$12.00
-$12.00
```
I can't get these files imported without loading them into Excel and changing the formatting.5.35.0https://lab.civicrm.org/dev/financial/-/issues/151Event register orange Paypal Button with Paypal Pro results in form validatio...2020-10-10T00:09:10ZStoobEvent register orange Paypal Button with Paypal Pro results in form validation jquery errorReproduce by:
1. setting up Paypal Pro processor
1. go to civicrm/event/register clicking the orange button *should* send you to Paypay.com to login instead of paying by card
1. instead it immediately triggers the jquery form validation...Reproduce by:
1. setting up Paypal Pro processor
1. go to civicrm/event/register clicking the orange button *should* send you to Paypay.com to login instead of paying by card
1. instead it immediately triggers the jquery form validation required fields for card
![ppp](/uploads/48f714fc58bfdcee7f03e14397c3b259/ppp.png)
This issue was resolved for Contribution pages already but persists for Event Registration https://lab.civicrm.org/dev/financial/-/issues/1475.30.0https://lab.civicrm.org/dev/financial/-/issues/149Contributions fail with "Authorization failed" (in master only)2020-09-14T01:06:52ZDaveDContributions fail with "Authorization failed" (in master only)You can see this at https://dmaster.demo.civicrm.org/civicrm/contribute/transact?id=1&reset=1 just complete the transaction to the end (as an anonymous user) and you get `Payment Processor Error message :Failed to update contribution in ...You can see this at https://dmaster.demo.civicrm.org/civicrm/contribute/transact?id=1&reset=1 just complete the transaction to the end (as an anonymous user) and you get `Payment Processor Error message :Failed to update contribution in database`, but the actual error "Authorization Failed" is coming from https://github.com/civicrm/civicrm-core/commit/62a721eda743ba248cf3b1a571a83f5fdbc72a56#diff-7a5b0e2d131dabc49178460fc63328c0R4430
----
Why you don't see the actual error is a [separate weirdness](https://github.com/civicrm/civicrm-core/blob/a31cdda9e9acda454f02790e3e8d1aca1f02ea2c/CRM/Contribute/Form/Contribution/Confirm.php#L2475-L2490), i.e. why does the api throw an exception on successful transactions, and even if that's ok, then why throw a new exception when caught - just rethrow the actual $e so that you can see the actual error.5.31.0https://lab.civicrm.org/dev/financial/-/issues/147Clicking orange Paypal Button with Paypal Pro results in form validation jque...2020-10-06T16:44:40ZStoobClicking orange Paypal Button with Paypal Pro results in form validation jquery error![ppp](/uploads/71d9a6ca4181196465ce3259f771e76e/ppp.png)
Reproduce by:
1. setting up Paypal Pro processor
2. clicking the orange button *should* send you to Paypayl.com to login instead of paying by card
3. instead it immediately trigg...![ppp](/uploads/71d9a6ca4181196465ce3259f771e76e/ppp.png)
Reproduce by:
1. setting up Paypal Pro processor
2. clicking the orange button *should* send you to Paypayl.com to login instead of paying by card
3. instead it immediately triggers the jquery form validation required fields for card5.29.1https://lab.civicrm.org/dev/financial/-/issues/120CiviCRM upgrade to 5.23.0 breaks payment processor2020-03-13T13:24:55ZlaybergerFCiviCRM upgrade to 5.23.0 breaks payment processorOn a Joomla! 3.9.15 system, after upgrading from CiviCRM 5.22.0 to 5.23.0 payment processing for fails for both paypal (credit card) and pay later options. When either is selected, the request for additional information (e.g. credit car...On a Joomla! 3.9.15 system, after upgrading from CiviCRM 5.22.0 to 5.23.0 payment processing for fails for both paypal (credit card) and pay later options. When either is selected, the request for additional information (e.g. credit card selection, billing address, etc) is not display and the 'submit' for the form no longer works (it gets grayed out). The work-around is go back to version 5.22.0 (with the 5.23.0 database). The payment processing and form submission then works.5.23.2https://lab.civicrm.org/dev/financial/-/issues/69Recording one payment against a "Pending (Incomplete Transaction)" results in...2019-10-15T06:15:33ZJonGoldRecording one payment against a "Pending (Incomplete Transaction)" results in two paymentsTo replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why thi...To replicate:
* Create a pending contribution (via API, more on this below).
* Record a payment against the contribution.
* Note that two payments are created - one for the full amount, one for the partial amount.
I investigated why this didn't happen via the UI, and it's because the UI creates "Pending (Pay Later)" records. If you pass `is_pay_later = 1` via API, this bug doesn't occur.
The "Pending (Incomplete Transaction)" generates a record in `civicrm_financial_trxn`, which seems odd if the payment didn't happen - but if that IS correct, it should be consistent about whether it appears when you view payments in the UI.5.18.3https://lab.civicrm.org/dev/financial/-/issues/66[regression] Thank-you date is lost on editing contributions2019-08-28T05:12:40ZJonGold[regression] Thank-you date is lost on editing contributionsA rather serious regression which IMO merits an out-of-band release.
**To replicate**
* Open a contribution for editing that has a thank-you date.
That's it. The page loads without the contribution date, and so it's lost on save.
Thi...A rather serious regression which IMO merits an out-of-band release.
**To replicate**
* Open a contribution for editing that has a thank-you date.
That's it. The page loads without the contribution date, and so it's lost on save.
This was introduced by https://github.com/civicrm/civicrm-core/commit/b4e8c2b4c3f3730a7193824dfb6452b86d5e31d7 which shipped with 5.16.0.
My quick fix is just to revert it, but others, particularly @pfigel, may want to chime in.5.16.3JonGoldJonGoldhttps://lab.civicrm.org/dev/financial/-/issues/65Editing a financial account pops up a blank new form2019-08-15T01:07:22ZDaveDEditing a financial account pops up a blank new formSeems like this combo of recent commits prevents the $this->_values from getting filled in and so it ends up in a limbo of thinking it's an edit but with no existing values. Given the nature of the second one I'm not sure the best fix - ...Seems like this combo of recent commits prevents the $this->_values from getting filled in and so it ends up in a limbo of thinking it's an edit but with no existing values. Given the nature of the second one I'm not sure the best fix - revert both?
https://github.com/civicrm/civicrm-core/commit/e03e16417a7054d229ee8b28952afae44cd6825c#diff-15cfbac79d793ca9dc2cb062a8cc44da
https://github.com/civicrm/civicrm-core/commit/f93f8e8b642fde961d8f878af58e3e585417e95e5.16.2https://lab.civicrm.org/dev/financial/-/issues/59[Unreleased regression] Undefined method when viewing Contribution Batch Sear...2019-09-04T14:42:48ZJonGold[Unreleased regression] Undefined method when viewing Contribution Batch Search screenThis exists on `master` but not the `5.13` branch.
To replicate: Go to **Contributions » Accounting Batches » New Batch**, then press **Save** on the next screen.
You'll receive an "Undefined Method" error:
```
[29-May-2019 21:24:28 U...This exists on `master` but not the `5.13` branch.
To replicate: Go to **Contributions » Accounting Batches » New Batch**, then press **Save** on the next screen.
You'll receive an "Undefined Method" error:
```
[29-May-2019 21:24:28 UTC] PHP Fatal error: Uncaught Error: Call to undefined method CRM_Financial_Form_BatchTransaction::addSearchFieldMetadata() in /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Contribute/BAO/Query.php:945
Stack trace:
#0 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Financial/Form/BatchTransaction.php(134): CRM_Contribute_BAO_Query::buildSearchForm(Object(CRM_Financial_Form_BatchTransaction))
#1 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Core/Form.php(606): CRM_Financial_Form_BatchTransaction->buildQuickForm()
#2 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Core/QuickForm/Action/Display.php(92): CRM_Core_Form->buildForm()
#3 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Financial_Form_BatchTransaction), 'display')
#4 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Financial_Form_Bat in /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Contribute/BAO/Query.php on line 945
```
I assume this is because a method got shifted to another file.
**Note** When someone tried to replicate this, it didn't occur until they cleared their cache. I'm assuming that's why this isn't happening on the demo sites.5.15.0