Confusing text on Refund receipt
As pointed out by @magnolia
https://github.com/civicrm/civicrm-core/pull/15705#issuecomment-549041527
A side-catch I discovered is a wrong amount for the amount paid in the notification mail This should be:
Total amount: 50
You paid: 100
Refund amount: -50
I don't think this is a regression - we assign $totalPaid to the template & it is used as
{if $isRefund}
<tr>
<th {$headerStyle}>{ts}Refund Details{/ts}</th>
</tr>
<tr>
<td {$labelStyle}>
{ts}Total Amount{/ts}
</td>
<td {$valueStyle}>
{$totalAmount|crmMoney}
</td>
</tr>
<tr>
<td {$labelStyle}>
{ts}You Paid{/ts}
</td>
<td {$valueStyle}>
{$totalPaid|crmMoney}
</td>
</tr>
<tr>
<td {$labelStyle}>
{ts}Refund Amount{/ts}
</td>
<td {$valueStyle}>
{$refundAmount|crmMoney}
<td>
</tr>
{else}
@magnolia - perhaps we can tweak the tpl to make more sense without making too much change here? Even a simplification
If we can come up with a simple tpl tweak I'm OK to squeeze it into 5.20 - even if it is branched - due to the general tpl load in there