[Unreleased regression] Undefined method when viewing Contribution Batch Search screen
This exists on master
but not the 5.13
branch.
To replicate: Go to Contributions » Accounting Batches » New Batch, then press Save on the next screen.
You'll receive an "Undefined Method" error:
[29-May-2019 21:24:28 UTC] PHP Fatal error: Uncaught Error: Call to undefined method CRM_Financial_Form_BatchTransaction::addSearchFieldMetadata() in /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Contribute/BAO/Query.php:945
Stack trace:
#0 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Financial/Form/BatchTransaction.php(134): CRM_Contribute_BAO_Query::buildSearchForm(Object(CRM_Financial_Form_BatchTransaction))
#1 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Core/Form.php(606): CRM_Financial_Form_BatchTransaction->buildQuickForm()
#2 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Core/QuickForm/Action/Display.php(92): CRM_Core_Form->buildForm()
#3 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Financial_Form_BatchTransaction), 'display')
#4 /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Financial_Form_Bat in /srv/www/wpcvmaster/wp-content/plugins/civicrm/civicrm/CRM/Contribute/BAO/Query.php on line 945
I assume this is because a method got shifted to another file.
Note When someone tried to replicate this, it didn't occur until they cleared their cache. I'm assuming that's why this isn't happening on the demo sites.