Financial issueshttps://lab.civicrm.org/dev/financial/-/issues2023-11-21T03:45:45Zhttps://lab.civicrm.org/dev/financial/-/issues/221Contribution date no longer has a time on the form2023-11-21T03:45:45ZDaveDContribution date no longer has a time on the formhttps://chat.civicrm.org/civicrm/pl/sgxqjrxq6pyaxftxftwtexf56a
The field itself still stores a time, but it's the "current" time which may or may not make sense.
If I remove this line it comes back: https://github.com/civicrm/civicrm-c...https://chat.civicrm.org/civicrm/pl/sgxqjrxq6pyaxftxftwtexf56a
The field itself still stores a time, but it's the "current" time which may or may not make sense.
If I remove this line it comes back: https://github.com/civicrm/civicrm-core/blob/9eaef13ef15da8bac6b73148d570fd989529789d/CRM/Utils/Date.php#L1990
Seems to be from https://github.com/civicrm/civicrm-core/pull/27003, so works in 5.65 but not 5.66.
Also receipt date, so it probably affects any date field that isn't somehow specified as TIMESTAMP. I'm not sure where it gets that "metadata" and whether datetime and timestamp here mean the same thing as they do for db fields.5.67.2https://lab.civicrm.org/dev/financial/-/issues/220With tax enabled Total Amount is confusing in online receipt and tax amount l...2023-11-15T18:37:43ZDaveDWith tax enabled Total Amount is confusing in online receipt and tax amount line is wrongIt used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/i...It used to show the amount before tax and the tax amount. But now it looks like this. There was $2 tax.
![untitled3](/uploads/2d19419c080ae6f6f009d1e6f7eff44d/untitled3.png)
This is the same as https://lab.civicrm.org/dev/financial/-/issues/206 just in the interim changes have caused the problem to shift.
Also the confirm and thankyou pages make no mention of the tax and there's now a php warning about a missing tax var on those pages.
![untitled7](/uploads/8fcb99238d074a7dd4a53ec000bf51b1/untitled7.png)
![untitled8](/uploads/ebb164e557d99a76bb0f90381b0525c9/untitled8.png)
One way to reproduce:
1. Turn on tax and invoicing. https://docs.civicrm.org/user/en/latest/contributions/sales-tax-and-vat/
* In my case I set up a non-deductible financial type called t-shirts and a corresponding sales tax account that has 5% tax.
2. Create a price set for it.
* There's one price field. I used type text/quantity. Field is required although that's not relevant just makes sense here. Financial type t-shirts.
3. Set up the dummy payment processor.
4. Create a contribution page with that processor and financial type t-shirts and use the price set. Set it to send a receipt.
5. Buy a t-shirt.5.68.0https://lab.civicrm.org/dev/financial/-/issues/219the Price Set labels are showing html2023-11-02T00:23:16ZJoeMurraythe Price Set labels are showing htmlDmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)Dmaster issue reported by @petednz at https://chat.civicrm.org/civicrm/pl/r95fm7gwqtnddc8umph8hqrtrh
![image](/uploads/691ef07d945339396267b24937e190c7/image.png)5.68.0eileeneileenhttps://lab.civicrm.org/dev/financial/-/issues/216Financial Batches: remove the creation of activities for New/Edit2023-08-09T18:28:27ZbgmFinancial Batches: remove the creation of activities for New/EditI fell down a rabbit hole while testing the New Financial Batch form, and noticed that it creates an activity whenever a batch is created or edited. It also creates an activity when the batch is exported, but not when closed or deleted.
...I fell down a rabbit hole while testing the New Financial Batch form, and noticed that it creates an activity whenever a batch is created or edited. It also creates an activity when the batch is exported, but not when closed or deleted.
The "Create Batch" and "Edit Batch" activities do not seem useful to me. I would leave the "Export Accounting Batch" activity for now.
Any objections to removing?
(I'm creating this issue for visibility, but will send a PR that might be more clear)
cc @JoeMurray5.66.0https://lab.civicrm.org/dev/financial/-/issues/214Link to record payment from within participant change selections links it to ...2023-05-27T14:08:26ZDaveDLink to record payment from within participant change selections links it to wrong contribution, or crashes if that doesn't exist1. Register an event participant for a paid event.
2. In the record payment section of the registration, change the amount to less than the total so it's just a partial payment.
3. Save.
4. View/edit the participant record. Note the id i...1. Register an event participant for a paid event.
2. In the record payment section of the registration, change the amount to less than the total so it's just a partial payment.
3. Save.
4. View/edit the participant record. Note the id in the url.
5. Click Change Selections.
6. Click View Payments.
7. Click Record Payment. Note the id in the url. It's the participant id not the contribution id. If a contribution with that id doesn't exist then at this point it crashes.
8. If it does exist, note now at this point the balance owed displayed may be incorrect because it's from an unrelated contribution.
9. Fill it out and save.
10. Note it takes you to a different contact and has applied the payment to the unrelated contribution.
This is only from the Change Selections section. The other Record Payment link found at the bottom of the participant record when you expand the triangle is correct.
Can reproduce on dmaster. I doubt this is recent.5.63.0https://lab.civicrm.org/dev/financial/-/issues/213Imported has completed successfully, but that's not true2023-01-15T21:04:15ZKarinGImported has completed successfully, but that's not trueCiviCRM 5.56.2
Contributions -> Import via UI ->
Client also noted (and I confirmed) that Contact Type appears to be no longer relevant/required.
Previous behaviour: CiviCRM generates an import_error file noting the contributions which...CiviCRM 5.56.2
Contributions -> Import via UI ->
Client also noted (and I confirmed) that Contact Type appears to be no longer relevant/required.
Previous behaviour: CiviCRM generates an import_error file noting the contributions which could not be imported and the reason - in this case Contact ID does not exist.
Screenshots (really awesome client report):
![image](/uploads/e569fd7fac5fb380e64318731aab5925/image.png)
![image](/uploads/713ee8a4cb0112b052a82fac53fe98e7/image.png)
![image](/uploads/736818ab47519bee7944120f5d577097/image.png)
![image](/uploads/1162ab9a29299db21546bf2e295a3d22/image.png)
![image](/uploads/9e3a4cf72ead03397d48542c24baa751/image.png)
![image](/uploads/60a57e3362cadf8710e9a194331a4159/image.png)5.57.0https://lab.civicrm.org/dev/financial/-/issues/210Changing contribution financial type from non-deductible to deductible does n...2023-07-05T23:48:38ZlarsssandergreenChanging contribution financial type from non-deductible to deductible does not change non-deductible amount, resulting in inability to issue tax receiptsSuppose someone enters a donation with an event fee financial type by mistake. The non-deductible amount is set to the full amount of the contribution. If they then change the financial type to a donation type, the non-deductible amount ...Suppose someone enters a donation with an event fee financial type by mistake. The non-deductible amount is set to the full amount of the contribution. If they then change the financial type to a donation type, the non-deductible amount remains the full amount of the contribution, so no tax receipt can be issued for the donation. Since most people probably don't use non-deductible amount regularly, if at all, they aren't likely to check this. Not a big deal if you then try to issue a tax receipt for the single contribution as it will be obvious that something is wrong (though perhaps frustrating because it isn't clear what), but if you are issuing them in bulk, you may not notice this at all, resulting in a donor not getting their tax receipt — a pretty bad outcome from a donor stewardship perspective.
We probably don't want to change non-deductible amounts in the background for existing contributions, but how about a warning that pops up when the financial type is changed from non-deductible to deductible, advising the user to check the non-deductible amount? Perhaps this wouldn't matter to some users, who don't care at all about deductible versus non-deductible, but this does seem worth warning about because it can produce unexpected results in the background.
Something like:
```You've changed the financial type for this $NNN contribution from non-tax deductible to tax deductible, but the non-deductible amount of $NNN has not been changed. This could prevent a tax receipt from being issued. You may want to edit the non-deductible amount.```https://lab.civicrm.org/dev/financial/-/issues/209Disabled Financial Types are listed when creating a Price Field2022-11-02T00:34:40ZpetednzDisabled Financial Types are listed when creating a Price FieldReplicated on dmaster.
1/ create a new Financial Type - set it as disabled.
2/ create new price set / field and note that the disabled Type is showing
3/ try to save - spinny spin spin if using pop ups - if not using pop-up get
4/ Finan...Replicated on dmaster.
1/ create a new Financial Type - set it as disabled.
2/ create new price set / field and note that the disabled Type is showing
3/ try to save - spinny spin spin if using pop ups - if not using pop-up get
4/ Financial Type for Price Field Option is either disabled or does not exist
is there a logic for showing disabled fields in this interface - can't personally think of one esp the pain of users sitting for 10 mins waiting for things to save.
Possibly related to https://lab.civicrm.org/dev/financial/-/issues/198 though that seems the other end of the problem, ie a Price Field is using a Fin Type that has since been set to be disabled5.56.0colemanwcolemanwhttps://lab.civicrm.org/dev/financial/-/issues/208Download invoice button on contribution view gives fatal error2022-09-02T00:36:12ZDaveDDownload invoice button on contribution view gives fatal errorMy guess is it happened here: https://github.com/civicrm/civicrm-core/commit/f436aaf2501fbf20ed411e5976d2dd14c588d1b6#diff-b96eb626cc73750f3b681bd12d980236b7062d1633e9d067d3d00d07cdb37a98R243
TypeError: Argument 3 passed to CRM_Contribu...My guess is it happened here: https://github.com/civicrm/civicrm-core/commit/f436aaf2501fbf20ed411e5976d2dd14c588d1b6#diff-b96eb626cc73750f3b681bd12d980236b7062d1633e9d067d3d00d07cdb37a98R243
TypeError: Argument 3 passed to CRM_Contribute_Form_Task_PDF::getElements() must be of the type array, int given, called in .../CRM/Contribute/Form/Task/Invoice.php on line 225 in CRM_Contribute_Form_Task_PDF::getElements() (line 243 in .../CRM/Contribute/Form/Task/PDF.php).
Probably it needs to be more tolerant that it could sometimes receive a single contact id not an array?5.54.0https://lab.civicrm.org/dev/financial/-/issues/206"Amount before tax" is wrong on online contribution receipt2023-11-08T15:33:16ZDaveD"Amount before tax" is wrong on online contribution receiptIt's because totalTaxAmount seems to have gone missing, so the amount before tax ends up the same as after tax. The total is correct though.
To reproduce:
1. Turn on and set up taxes: https://docs.civicrm.org/user/en/latest/contribution...It's because totalTaxAmount seems to have gone missing, so the amount before tax ends up the same as after tax. The total is correct though.
To reproduce:
1. Turn on and set up taxes: https://docs.civicrm.org/user/en/latest/contributions/sales-tax-and-vat/
2. Create a price set using that financial type.
3. Create an online donation for it where it's set up to send a receipt. It also happens if you use the send receipt action later from find contributions, since this also uses the online template (as opposed to editing the contribution and checking the box to send receipt, which uses the offline template).
I don't know exactly when it started. It's not working in 5.52 or master.5.69.0https://lab.civicrm.org/dev/financial/-/issues/199Additional Details section on Recurring Contribution template edit screen doe...2022-06-15T00:25:33ZDaveDAdditional Details section on Recurring Contribution template edit screen doesn't load anymoreSomewhat related to https://lab.civicrm.org/dev/financial/-/issues/197
If you look at screenshot 5 there, in the Additional Details section, note the spinning icon and "Loading...". This is coming from https://github.com/civicrm/civicrm...Somewhat related to https://lab.civicrm.org/dev/financial/-/issues/197
If you look at screenshot 5 there, in the Additional Details section, note the spinning icon and "Loading...". This is coming from https://github.com/civicrm/civicrm-core/pull/21471/files#diff-74e8144a14bfd4d8bf9cf4279c90cded28c43351c70a338d4502612d6e0f1c36R448 where it's trying to freeze the status field but there is no status field on the Additional Details section.5.51.0https://lab.civicrm.org/dev/financial/-/issues/197Can no longer update Amount for Recurring Contributions even if it only has o...2022-06-17T01:12:06ZKarinGCan no longer update Amount for Recurring Contributions even if it only has one Lineitem1. Scenario:
A native CiviCRM Contribution page for people to start a Monthly Donation. People can select an amount or enter a custom amount:
![image](/uploads/f804e779d8a59e8c700d71d553ef1d44/image.png)
2. It uses a Priceset:
![imag...1. Scenario:
A native CiviCRM Contribution page for people to start a Monthly Donation. People can select an amount or enter a custom amount:
![image](/uploads/f804e779d8a59e8c700d71d553ef1d44/image.png)
2. It uses a Priceset:
![image](/uploads/5fe1c1c85e7a8ea0046a3752381ac306/image.png)
3. Admin used to be able to update the recurring amount to be transacted here ->
![image](/uploads/8746e3b2aed512d1d467e5c178f1441c/image.png)
4. There is a note at the top that one now needs to edit the Template Contribution ->
![image](/uploads/2c175648b6e4a24839b70220df96135a/image.png)
5. But it can't be edited ->
![image](/uploads/f00911e26a76b1741999c943ed891d8d/image.png)
6. Even though there is only one line item:
![image](/uploads/b88571a041f8473d3885a05994298729/image.png)
7. I've also tested a simpler priceset with only ONE field -> same result - one can not edit the amount
![image](/uploads/a9384f511a03dbb39827cff3526367f6/image.png)
![image](/uploads/ec375efd47b0964c6e8f7894611f7aac/image.png)
![image](/uploads/1e7590cea80ad145580866fd2fc6e6d6/image.png)5.51.0https://lab.civicrm.org/dev/financial/-/issues/195Using the line item editor on a contribution template does not update the mat...2022-07-07T07:51:33ZAlanDixonUsing the line item editor on a contribution template does not update the matching recurring contribution total amountThis is a follow up issue to https://lab.civicrm.org/dev/financial/-/issues/194
as per: https://lab.civicrm.org/dev/financial/-/issues/194#note_75215
It's a similar issue to this one: https://github.com/civicrm/civicrm-core/pull/21473
...This is a follow up issue to https://lab.civicrm.org/dev/financial/-/issues/194
as per: https://lab.civicrm.org/dev/financial/-/issues/194#note_75215
It's a similar issue to this one: https://github.com/civicrm/civicrm-core/pull/21473
Note that if you go back and just save the contribution template, then the issue can be worked around as an administrator!
i.e. part of the problem is that the line item editor is assuming it's living in an isolated world that it knows everything instead of behaving like a responsible citizen.https://lab.civicrm.org/dev/financial/-/issues/194Unable to edit amount of recurring series2022-06-13T16:42:23ZKarinGUnable to edit amount of recurring seriesWe just noted a regression affecting all latest releases 5.45.x ESR through 5.50.x -> our iATS clients are not able to update amounts for recurring contributions -> Alan @adixon and I confirmed it on two separate sites D9 and D7 and two ...We just noted a regression affecting all latest releases 5.45.x ESR through 5.50.x -> our iATS clients are not able to update amounts for recurring contributions -> Alan @adixon and I confirmed it on two separate sites D9 and D7 and two different methods (credit card and ACH) -> we have clients who have been using CiviCRM for 10y - who have over 10k of these series to manage and they can't bump e.g. this donor from $20 to $25
![image](/uploads/cfc1a9d1a87409946be83be31b8ce860/image.png)
It looks like a form issue -> note the errors:
`Cannot change contribution status from Template to .`
and
`Date Received is a required field`
Marking as regression as in the past admins were able to update recurring series amounts.https://lab.civicrm.org/dev/financial/-/issues/193After import of contribution: User deprecated function: Deprecated function C...2022-06-10T09:05:04ZTobias KrauseAfter import of contribution: User deprecated function: Deprecated function CRM_Core_OptionGroup::getValueWe get the above warning after the import of contributions on CiviCRM 5.48.2 with Drupal 9. The full message is:
`User deprecated function: Deprecated function CRM_Core_OptionGroup::getValue, use CRM_Core_PseudoConstant::getKey. in CRM_...We get the above warning after the import of contributions on CiviCRM 5.48.2 with Drupal 9. The full message is:
`User deprecated function: Deprecated function CRM_Core_OptionGroup::getValue, use CRM_Core_PseudoConstant::getKey. in CRM_Core_Error::deprecatedFunctionWarning() (line 1043 of /vendor/civicrm/civicrm-core/CRM/Core/Error.php).`5.51.0https://lab.civicrm.org/dev/financial/-/issues/192CiviCRM crashes when I select ZMK as default currency2022-09-09T13:10:06ZmitoworksCiviCRM crashes when I select ZMK as default currencyA clean install of CiviCRM on Wordpress crashes whenever I select ZMK as default currency. My installation details are:
> WordPress version 5.9.2
> Current theme: Twenty Twenty-Two (version 1.1)
> Current plugin: CiviCRM (version 5.4...A clean install of CiviCRM on Wordpress crashes whenever I select ZMK as default currency. My installation details are:
> WordPress version 5.9.2
> Current theme: Twenty Twenty-Two (version 1.1)
> Current plugin: CiviCRM (version 5.47.2)
> PHP version 8.0.16
```
Error Details
=============
An error of type E_ERROR was caused in line 19 of the file /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/brick/money/src/Exception/UnknownCurrencyException.php. Error message: Uncaught Brick\Money\Exception\UnknownCurrencyException: Unknown currency code: ZMK in /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/brick/money/src/Exception/UnknownCurrencyException.php:19
Stack trace:
#0 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/brick/money/src/ISOCurrencyProvider.php(120): Brick\Money\Exception\UnknownCurrencyException::unknownCurrency()
#1 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/brick/money/src/Currency.php(91): Brick\Money\ISOCurrencyProvider->getCurrency()
#2 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/brick/money/src/Money.php(189): Brick\Money\Currency::of()
#3 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Utils/Money.php(209): Brick\Money\Money::of()
#4 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Utils/Money.php(88): CRM_Utils_Money::formatUSLocaleNumericRounded()
#5 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Core/Resources/Common.php(219): CRM_Utils_Money::format()
#6 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Core/Resources/Common.php(128): CRM_Core_Resources_Common::coreResourceList()
#7 /home/monkey/public_html/civic/wp-content/uploads/civicrm/templates_c/CachedCiviContainer.a02b080bd0d8fdf7053d123f1aecc5d2.php(807): CRM_Core_Resources_Common::createFullBundle()
#8 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/vendor/symfony/dependency-injection/Container.php(306): CachedCiviContainer->getBundle_CoreResourcesService()
#9 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/Civi.php(174): Symfony\Component\DependencyInjection\Container->get()
#10 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Core/Resources.php(214): Civi::service()
#11 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm/CRM/Core/Resources.php(382): CRM_Core_Resources->addBundle()
#12 /home/monkey/public_html/civic/wp-content/plugins/civicrm/civicrm.php(1087): CRM_Core_Resources->addCoreResources()
#13 /home/monkey/public_html/civic/wp-content/plugins/civicrm/includes/civicrm.admin.php(761): CiviCRM_For_WordPress->add_core_resources()
#14 /home/monkey/public_html/civic/wp-includes/class-wp-hook.php(307): CiviCRM_For_WordPress_Admin->admin_page_load()
#15 /home/monkey/public_html/civic/wp-includes/class-wp-hook.php(331): WP_Hook->apply_filters()
#16 /home/monkey/public_html/civic/wp-includes/plugin.php(474): WP_Hook->do_action()
#17 /home/monkey/public_html/civic/wp-admin/admin.php(237): do_action()
#18 {main}
thrown
```
After this, I can't do anything else under the CiviCRM menu
It looks like a change in currency to ZMW in 2013 is causing the issue.5.54.0https://lab.civicrm.org/dev/financial/-/issues/191PaymentProcessor.pay should bubble up the error returned from the processor2022-03-07T22:53:09ZJonGoldPaymentProcessor.pay should bubble up the error returned from the processor`PaymentProcessor.pay` returns the same message - `Payment Failed` - no matter the cause. This makes it impossible to tell the user why their credit card was declined.
### Steps to Replicate
* Install the dummy processor.
* Submit `Pay...`PaymentProcessor.pay` returns the same message - `Payment Failed` - no matter the cause. This makes it impossible to tell the user why their credit card was declined.
### Steps to Replicate
* Install the dummy processor.
* Submit `PaymentProcessor.pay` with an expiration date in 2021 or earlier.
* Alternatively, create a Webform, install WFC, and submit your payment that way.
### Expected Result
`Invalid expiry date`
### Actual Result
`Payment failed`
I don't know if there's a good reason for this or not. @KarinG has expressed interest to me in bubbling up the message from the payment processor.5.49.0JonGoldJonGoldhttps://lab.civicrm.org/dev/financial/-/issues/187[regression-ish] When a recurring contribution template has no line items, th...2021-10-05T19:14:26ZJonGold[regression-ish] When a recurring contribution template has no line items, the contact contribution tab crashes### Overview
There are some contributions that don't have line items. I suspect that shouldn't be, but I found at least a couple in every database I checked.
Now, with PR [#20784](https://github.com/civicrm/civicrm-core/pull/20784), i...### Overview
There are some contributions that don't have line items. I suspect that shouldn't be, but I found at least a couple in every database I checked.
Now, with PR [#20784](https://github.com/civicrm/civicrm-core/pull/20784), if you have a recurring contribution, and the template (pseudo-template, I suppose) contribution has no line items, it causes a 500 error:
```
PHP Fatal error: Uncaught TypeError: Return value of CRM_Financial_BAO_Order::getPriceSetID() must be of the type int, null returned in /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Financial/BAO/Order.php:455"
Stack trace:"
#0 /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contribute/BAO/ContributionRecur.php(557): CRM_Financial_BAO_Order->getPriceSetID()"
#1 /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Page/Tab.php(61): CRM_Contribute_BAO_ContributionRecur::getTemplateContribution(632)"
#2 /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Page/Tab.php(324): CRM_Contribute_Page_Tab::recurLinks(632)"
#3 /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Page/Tab.php(288): CRM_Contribute_Page_Tab->buildRecurringContributionsArray(Array)"
#4 /var/www/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Contribute/Page/Tab.php(256): CRM_Contri..."
```
So while this is technically a regression, it's more of a data error - but it seems like a fairly widespread data error.5.42.0https://lab.civicrm.org/dev/financial/-/issues/184Using GHC as a default currency causes a fatal error with Brick/Money2022-08-31T15:25:46ZbgmUsing GHC as a default currency causes a fatal error with Brick/MoneyTo reproduce:
* Go to dmaster
* Admin > Localisation > Language etc
* Set the default currency to "GHC"
Result:
> Brick\Money\Exception\UnknownCurrencyException: Unknown currency code: GHC in Brick\Money\Exception\UnknownCurrencyExcep...To reproduce:
* Go to dmaster
* Admin > Localisation > Language etc
* Set the default currency to "GHC"
Result:
> Brick\Money\Exception\UnknownCurrencyException: Unknown currency code: GHC in Brick\Money\Exception\UnknownCurrencyException::unknownCurrency() (line 19 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/brick/money/src/Exception/UnknownCurrencyException.php).
And CiviCRM is ironically bricked, i.e. CiviCRM will systematically fatal.
The ISO code for Ghana is "GHS", which is what Brick/Money uses.
https://en.wikipedia.org/wiki/Ghanaian_cedi5.45.0https://lab.civicrm.org/dev/financial/-/issues/183Order API is not Order AI2021-09-06T19:14:49ZKarinGOrder API is not Order AI[copied notes from Mattermost]
Towards 'making this sane' and could be implemented immediately -> for example - one would be to immediately start returning ->
````a notice -> 'warning: incompatible set of input params - Order API can ...[copied notes from Mattermost]
Towards 'making this sane' and could be implemented immediately -> for example - one would be to immediately start returning ->
````a notice -> 'warning: incompatible set of input params - Order API can not create coherent line-item(s)'.````
When being presented with incompatible data -> e.g. if
total_amount = 10;
tax_amount = 0.25;
financial_type_id = 1;
That's an impossible set of input params. Yes - they are still being handled right now - but results will be unpredictable b/c it is simply impossible to create a co-herent line_item with those input params.
I have some more notes in 21187 - will park them in my own atrium for now. Key one is that one 👆
Another one could be that if presented with line_items and a total_amount at the Contribution level - then that all better be adding up or else ->
````a notice -> 'warning: incompatible set of input params - Order API can not create coherent line-item(s)'.````
At this stage the API can still attempt - but alerting people would be a first step towards to no longer accept incoherent input. Order API is not Order AI :-)