Financial issueshttps://lab.civicrm.org/dev/financial/-/issues2019-07-31T20:48:05Zhttps://lab.civicrm.org/dev/financial/-/issues/36Bug, cannot import Contributions because the import requires the payment meth...2019-07-31T20:48:05Zjustinfreeman (Agileware)Bug, cannot import Contributions because the import requires the payment method, payment instrument ID, not the payment instrument labelBug, cannot import Contributions because the import requires the payment method, payment instrument ID, not the payment instrument label.
For example: Contributions being imported with payment instrument (payment method) of "Credit card...Bug, cannot import Contributions because the import requires the payment method, payment instrument ID, not the payment instrument label.
For example: Contributions being imported with payment instrument (payment method) of "Credit card", "Cheque" will fail to import. However if these labels are replaced with the values, 1 (Credit card) and 4 (Cheque) then the import will succeed.
Importing contribution payment_instrument_id is formatted in following line of code.
https://github.com/agileware/civicrm-core/blob/master/CRM/Utils/DeprecatedUtils.php#L246
Code gets the option Value instead of a Name, the contribution API accepts the payment_instrument by Value. Logic is updated in Utils to consider name instead of ID. This function is getting called from only Contribution import.
PR submitted, see https://github.com/civicrm/civicrm-core/pull/13125
Agileware Ref: CIVICRM-11035.17.0justinfreeman (Agileware)justinfreeman (Agileware)