"Self-service eligibility" has incorrect behavior when "hours to cancel" is zero
Steps to replicate:
- Create an event with self-service cancel/transfer enabled, with the default "up to 0 hours before the event".
- Register a contact, get the cancellation link in your email.
- Set the event's begin/end date in the past.
- Attempt to cancel.
Expected result
The event shouldn't allow you to cancel because it's in the past.
Actual result
Cancellation is permitted.
This is just an isset()
vs. !empty()
issue. I made some grammatical fixes while I was in there though.