Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
E
Events
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards
  • Development
  • Events
  • Issues
  • #41

Closed
Open
Opened Aug 23, 2020 by DaveD@DaveDDeveloper

Balance owed visually not updated and multiple definitions of function display() in ParticipantFeeSelection form

This came out of PR review for https://github.com/civicrm/civicrm-core/pull/18238

There's probably multiple ways of getting here and different configurations might have different outcomes but take a stock demo install and do

  1. Find participants.
  2. Pick one and click View, e.g. for the rainforest event.
  3. Click the blue Change Selections link.
  4. Change the selected price.
  5. Nothing happens. No errors in console. At the very least I'd expect the balance owed field to visually update. Saving seems to change the selection as expected.

If you view-source, you can see the display() javascript function is defined 3 times apparently in global space each time. Doing some js debugging the one that gets run is the one from CRM/Price/Form/Calculate.tpl, which itself seems to be included twice so two of the display() functions are identical since they're both from there.

I can't see where the first function is used in civi - the one from CRM/Event/Form/ParticipantFeeSelection.tpl - but there might be many configurations that lead here and do different things.

Edited Aug 23, 2020 by DaveD
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/event#41