Drupal8: CiviCRM menu does not use the correct locale

On it

@bgm this seems strange that after fixing the CRM_Utils_System::languageNegotiationURL() I still didn't get the language prefix in URL. However, when I debugged the output it surely does return the URL with the current enabled language prefix as in https://example.org/

Here's the patch https://gist.github.com/monishdeb/72ee79c0759a943237c43f992038580c . Looking on the code all the (token/)links use CRM_Utils_System::url() to generate url but that fn doesn't have any impact, is there anything I am missing?

NOTE: In D8 it's the language core module where some of the setting is shipped from locale module.

added Concept approved sig:compatibility triaged type:proposal labels

removed sig:bug label

The patch in #19 (closed) seems to fix this issue.

More specifically, this PR: https://github.com/civicrm/civicrm-core/pull/12152

@bgm if you could review the PR then we might be able to close this. Thanks again for your various useful improvements that it would be good to get into core.

mentioned in issue #44 (closed)

It seems like with KAM, this issue has shifted a bit. #19 (closed) is still a very valid issue, since it affects the l10n-js (and #19 (closed) fixes that), but with KAM the translation of the menu manifests itself differently.

In short, CiviCRM calls this:

https://example/civicrm/ajax/navmenu?code=sKuHQWeH&locale=en_US&cid=131

but it should call with the language prefix.

l10n-js is added via PHP from CRM_Core_Resources, but the new navmenu is called from JS.

And it seems like it's more a general issue with the CRM.url() function:

on Drupal7:

CRM.url('civicrm');
/fr/civicrm

on Drupal8:

CRM.url('civicrm');
/civicrm

Debug notes, tplURL initialization on Drupal7 has the lang prefix, but d8 does not:

Object { back: "/fr/*path*?*query*", front: "/fr/*path*?*query*" }

Possibly causing odd behaviour because D8 doesn't like the asterisk prefix:

\Drupal\Core\Url::fromUri("internal:/*path*")->toString();
/%2Apath%2A

\Drupal\Core\Url::fromUri("internal:/civicrm/*path*")->toString();
/en/civicrm/%2Apath%2A

Tentative workaround:

  public function url(
    $path = '',
    $query = '',
    $absolute = FALSE,
    $fragment = NULL,
    $frontend = FALSE,
    $forceBackend = FALSE
  ) {
    $query = html_entity_decode($query);

    // dev/drupal#21 Drupal8 does not like this path, so it would output '/*path*'
    // instead of the expected '/en/*path*' when using multilingual.
    if ($path == '*path*') {
      $path = 'civicrm/*path*';
    }

    $url = \Drupal\civicrm\CivicrmHelper::parseURL("{$path}?{$query}");
    $base = $absolute ? $config->userFrameworkBaseURL : 'internal:/';

    // Not all links that CiviCRM generates are Drupal routes, so we use the weaker ::fromUri method.
    try {
      $url = \Drupal\Core\Url::fromUri("{$base}{$url['path']}", [
        'query' => $url['query'],
        'fragment' => $fragment,
        'absolute' => $absolute,
      ])->toString();
    }
    catch (Exception $e) {
      // @Todo: log to watchdog
      $url = '';
    }

    // Special case: CiviCRM passes us "*path*?*query*" as a skeleton, but asterisks
    // are invalid and Drupal will attempt to escape them. We unescape them here:
    if ($path == 'civicrm/*path*') {
      // First remove trailing equals sign that has been added since the key '?*query*' has no value.
      $url = rtrim($url, '=');
      $url = urldecode($url);

      // Remove the civicrm prefix that we added earlier in this function
      $url = str_replace('civicrm/*path*', '*path*', $url);
    }

    return $url;
  }

but I will wait for PR 12152 to be merged before submitting a patch.

This is not very elegant, and I looked at changing crmURL so that it uses civicrm/*path* instead of just *path*, but that would require more QA on WordPress and others (but WordPress has a specific check on addslashes, so it seems more tricky).

https://github.com/civicrm/civicrm-core/pull/14281

https://github.com/civicrm/civicrm-core/pull/14474

mentioned in commit core@bee660d8

mentioned in issue #74 (closed)

This was fixed in PR 14474 (CiviCRM 5.16?). Closing.

closed

changed milestone to %5.16.2

mentioned in issue #126 (closed)

Drupal8: CiviCRM menu does not use the correct locale

Child items ...

Activity