OG Sync Problem on ACL Groups
This is in CiviCRM 5.24.4
When I look at the ACL setup created by OG Sync, I see the following in the ACL Assign Users to Roles page. For each OG ACL Group there is one entry with the appropriate ACL Role assigned, and a variable number of entries with the ACL Role column blank.
This page corresponds to the acl_entity_role table in the database, which joins the civicrm_group id to the acl_role_id (which is a key to the option_value table). The rows which have the ACL Role column blank on the Assign Users to Roles page contain acl_role_id values which do not appear in the option_value table, while the valid entry has a valid option_value.
It would appear that this situation has been caused by the following bug. When an OG Group Page on the website is edited (with a simple text edit), the system deletes the previous value in the option_value table and creates a new one in its place. It also creates a new entry in the acl_entity_role table, linked to the new option_value, and leaves the old entry in the acl_entity_role table behind. (There may be other actions which cause the same result, I haven't checked.)
I don't think this is causing functional misbehaviour, but it is administratively annoying (and steadily getting worse) and is clearly bad coding.