Replace jcalendar instances with datepicker
We have been phasing out jcalendar since ? 4.x? there are a handful of instances left to switch over.
Once they are all gone we should be able to remove some php handling - datepicker handles date format at the js layer meaning the php/ form layer only needs to handle one format of dates
Note that removing jcalendar will remove a number of points of fragility as the datepicker is more robust
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- eileen mentioned in issue #558 (closed)
mentioned in issue #558 (closed)
- Owner
doing a grep shows me here are all the places that it currently resides
templates/CRM/Grant/Form/Task/Update.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=decision_date}<br /> templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_high} templates/CRM/Contact/Form/Search/Custom.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=$element}</td> templates/CRM/Contact/Form/Search/Custom/ActivitySearch.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$element} templates/CRM/Contact/Form/Search/Custom/EventDetails.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=start_date}</td> templates/CRM/Contact/Form/Search/Custom/EventDetails.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=end_date}</td> templates/CRM/Pledge/Form/Payment.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=scheduled_date}</td> templates/CRM/Price/Form/Field.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=active_on} templates/CRM/Price/Form/Field.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=expire_on} templates/CRM/Contribute/Form/Task/Status.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=$element_name}</td> templates/CRM/Contribute/Form/ContributionPage/Amount.tpl: <span id="pledge_calendar_date_field"> {include file="CRM/common/jcalendar.tpl" elementName=pledge_calendar_date}</span> templates/CRM/Contribute/Form/Contribution/Main.tpl: <div class="label">{$form.start_date.label}</div><div class="content">{include file="CRM/common/jcalendar.tpl" elementName=start_date}</div> templates/CRM/Contribute/Form/AdditionalInfo/Premium.tpl: <td class="html-adjust">{include file="CRM/common/jcalendar.tpl" elementName=fulfilled_date}</td> templates/CRM/Activity/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Activity/Form/FollowUp.tpl: {include file="CRM/common/jcalendar.tpl" elementName=followup_date} templates/CRM/Member/Form/MembershipCommon.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=receive_date}</td> templates/CRM/Member/Form/MembershipRenewal.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=renewal_date}</td> templates/CRM/Campaign/Form/Task/Interview.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fieldName elementIndex=$voterId batchUpdate=1} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=end_date}</td> templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=end_date} templates/CRM/Admin/Form/ScheduleReminders.tpl: <td colspan="3">{include file="CRM/common/jcalendar.tpl" elementName=absolute_date} <strong id='OR'>OR</strong><br /></td> templates/CRM/Core/AgeRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$dateName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fromName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$toName} templates/CRM/Case/Form/Activity/OpenCase.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Case/Form/Activity/ChangeCaseStartDate.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=start_date}</td> templates/CRM/Case/Form/Activity/ChangeCaseType.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=reset_date_time}</td> templates/CRM/Case/Form/Activity.tpl: <div style="display: none;">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</div> templates/CRM/Case/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activitylow} templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activityhigh} templates/CRM/Mailing/Form/Schedule.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=start_date}
- Owner
Places still left without a PR
templates/CRM/Grant/Form/Task/Update.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=decision_date}<br /> templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_high} templates/CRM/Contact/Form/Search/Custom.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=$element}</td> templates/CRM/Price/Form/Field.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=active_on} templates/CRM/Price/Form/Field.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=expire_on} templates/CRM/Contribute/Form/Task/Status.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=$element_name}</td> templates/CRM/Contribute/Form/ContributionPage/Amount.tpl: <span id="pledge_calendar_date_field"> {include file="CRM/common/jcalendar.tpl" elementName=pledge_calendar_date}</span> templates/CRM/Contribute/Form/Contribution/Main.tpl: <div class="label">{$form.start_date.label}</div><div class="content">{include file="CRM/common/jcalendar.tpl" elementName=start_date}</div> templates/CRM/Contribute/Form/AdditionalInfo/Premium.tpl: <td class="html-adjust">{include file="CRM/common/jcalendar.tpl" elementName=fulfilled_date}</td> templates/CRM/Activity/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Activity/Form/FollowUp.tpl: {include file="CRM/common/jcalendar.tpl" elementName=followup_date} templates/CRM/Member/Form/MembershipCommon.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=receive_date}</td> templates/CRM/Member/Form/MembershipRenewal.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=renewal_date}</td> templates/CRM/Campaign/Form/Task/Interview.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fieldName elementIndex=$voterId batchUpdate=1} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=end_date}</td> templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=end_date} templates/CRM/Admin/Form/ScheduleReminders.tpl: <td colspan="3">{include file="CRM/common/jcalendar.tpl" elementName=absolute_date} <strong id='OR'>OR</strong><br /></td> templates/CRM/Core/AgeRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$dateName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fromName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$toName} templates/CRM/Case/Form/Activity/OpenCase.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Case/Form/Activity/ChangeCaseStartDate.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=start_date}</td> templates/CRM/Case/Form/Activity/ChangeCaseType.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=reset_date_time}</td> templates/CRM/Case/Form/Activity.tpl: <div style="display: none;">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</div> templates/CRM/Case/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activitylow} templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activityhigh}
@seamuslee good effort - I'd be happy to stagger the next lot until after the rc is cut
- Owner
Yep and i'm happy to do tick tac review as well to try to close these out. also @eileen there is one small bug with your revision of one of my PRs submitted.
- Owner
So after latest bunch of PRs are merged we will be down to
templates/CRM/Grant/Form/Task/Update.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=decision_date}<br /> templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_application_received_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_decision_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_money_transfer_date_high} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_low} templates/CRM/Grant/Form/Search/Common.tpl: {include file="CRM/common/jcalendar.tpl" elementName=grant_due_date_high} templates/CRM/Contribute/Form/Task/Status.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=$element_name}</td> templates/CRM/Contribute/Form/ContributionPage/Amount.tpl: <span id="pledge_calendar_date_field"> {include file="CRM/common/jcalendar.tpl" elementName=pledge_calendar_date}</span> templates/CRM/Contribute/Form/Contribution/Main.tpl: <div class="label">{$form.start_date.label}</div><div class="content">{include file="CRM/common/jcalendar.tpl" elementName=start_date}</div> templates/CRM/Contribute/Form/AdditionalInfo/Premium.tpl: <td class="html-adjust">{include file="CRM/common/jcalendar.tpl" elementName=fulfilled_date}</td> templates/CRM/Activity/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Activity/Form/FollowUp.tpl: {include file="CRM/common/jcalendar.tpl" elementName=followup_date} templates/CRM/Member/Form/MembershipCommon.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=receive_date}</td> templates/CRM/Member/Form/MembershipRenewal.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=renewal_date}</td> templates/CRM/Campaign/Form/Task/Interview.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fieldName elementIndex=$voterId batchUpdate=1} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Campaign.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=end_date}</td> templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Campaign/Form/Search/Campaign.tpl: {include file="CRM/common/jcalendar.tpl" elementName=end_date} templates/CRM/Admin/Form/ScheduleReminders.tpl: <td colspan="3">{include file="CRM/common/jcalendar.tpl" elementName=absolute_date} <strong id='OR'>OR</strong><br /></td> templates/CRM/Core/AgeRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$dateName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$fromName} templates/CRM/Core/DateRange.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$toName} templates/CRM/Case/Form/Activity/OpenCase.tpl: {include file="CRM/common/jcalendar.tpl" elementName=start_date} templates/CRM/Case/Form/Activity/ChangeCaseStartDate.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=start_date}</td> templates/CRM/Case/Form/Activity/ChangeCaseType.tpl: <td>{include file="CRM/common/jcalendar.tpl" elementName=reset_date_time}</td> templates/CRM/Case/Form/Activity.tpl: <div style="display: none;">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</div> templates/CRM/Case/Form/Activity.tpl: <td class="view-value">{include file="CRM/common/jcalendar.tpl" elementName=activity_date_time}</td> templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activitylow} templates/CRM/Case/Form/ActivityTab.tpl: {include file="CRM/common/jcalendar.tpl" elementName=$activityhigh}
- Developer
@monish.deb as a medium priority (I know you're busy) for core work this month could you work on the Grant Form replacement? I see @eileen has some ideas about how it should work https://chat.civicrm.org/civicrm/pl/u65txqogcbynbe4o7sg9bwwair so perhaps there is a PR out there somewhere.
@JoeMurray @monish.deb - it looks like Eileen already has submitted https://github.com/civicrm/civicrm-core/pull/13211 for the grant form.
Great work @seamuslee and @eileen and @mattwire. I'll work on the Activity/Case forms next.
- Developer