Test assertions should include message describing the assertion
While checking test failures for a PR, received the test error:
Failed asserting that true is false.
On quick review of the refs in the phpunit tests directory, I found that almost none of the assertFalse calls in the test suite use the second argument to provide a descriptive message about the assertion. The assumption is then that the other assertion types are in the same situation.
The provides a less than stellar testing environment, as you have to check a source code reference to understand your test failure.
We should improve the tests so that they explain (summarise) the assertion that failed.