CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-11-30T04:28:06Zhttps://lab.civicrm.org/dev/core/-/issues/4794Premiums notices on Contribution Page2023-11-30T04:28:06ZJoeMurrayPremiums notices on Contribution PageOn dmaster just now (5.69.alpha1) on Help Support CiviCRM! which has a mug Premium on live page (https://dmaster.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=1) I get:
Warning: Undefined array key "thumbnail" in include() (li...On dmaster just now (5.69.alpha1) on Help Support CiviCRM! which has a mug Premium on live page (https://dmaster.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=1) I get:
Warning: Undefined array key "thumbnail" in include() (line 39 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%DF/DF4/DF4B6A64%%PremiumBlock.tpl.php).
Warning: Undefined array key "image" in include() (line 39 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%DF/DF4/DF4B6A64%%PremiumBlock.tpl.php).
Warning: Undefined array key "allowAutoRenewMembership" in include() (line 420 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%3D/3D1/3D13F2BA%%Main.tpl.php).
First two appear to be related to Mug premium.5.68.0https://lab.civicrm.org/dev/core/-/issues/4793Manage Premiums notices2024-03-08T20:20:54ZJoeMurrayManage Premiums noticesOn dmaster just now (5.69.alpha1), navigating to Administer > CiviContribute > Premiums (Thank-you gifts) https://dmaster.demo.civicrm.org/civicrm/admin/contribute/managePremiums?reset=1 titled Manage Premiums, I get notices:
Warning: U...On dmaster just now (5.69.alpha1), navigating to Administer > CiviContribute > Premiums (Thank-you gifts) https://dmaster.demo.civicrm.org/civicrm/admin/contribute/managePremiums?reset=1 titled Manage Premiums, I get notices:
Warning: Undefined array key "cost" in include() (line 38 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%3F/3F3/3F34E079%%ManagePremiums.tpl.php).
Warning: Undefined array key "financial_type" in include() (line 38 of /srv/buildkit/app/private/dmaster/default/civicrm/templates_c/en_US/%%3F/3F3/3F34E079%%ManagePremiums.tpl.php).5.69.0https://lab.civicrm.org/dev/core/-/issues/4792Filter for SearchKit "Manage Groups" missing (deleted contacts)2023-11-23T14:21:22ZTobias Voigttobias.voigt@civiservice.deFilter for SearchKit "Manage Groups" missing (deleted contacts)This is a quick fix:
I wondered why the number of contacts in a group in the overview "Manage Groups" doesn't reflect the actual number of contacts.
The reason: One additional filter is needed for the entity "contacts" in this SearchKi...This is a quick fix:
I wondered why the number of contacts in a group in the overview "Manage Groups" doesn't reflect the actual number of contacts.
The reason: One additional filter is needed for the entity "contacts" in this SearchKit that excludes contacts that are in the trash.https://lab.civicrm.org/dev/core/-/issues/4791Set cache folder for dompdf2023-11-23T03:24:45ZwmortadaSet cache folder for dompdfOverview
----------------------------------------
The cache folder for dompdf isn't set so cache files are created in the font folder (`vendor/dompdf/dompdf/lib/fonts`). This is messy and can cause issues if you deploy the codebase via ...Overview
----------------------------------------
The cache folder for dompdf isn't set so cache files are created in the font folder (`vendor/dompdf/dompdf/lib/fonts`). This is messy and can cause issues if you deploy the codebase via git or if you mount the codebase in a read only volume.
For example after creating a PDF letter via the UI, you will see the following untracked files in git:
```
Untracked files:
(use "git add <file>..." to include in what will be committed)
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Helvetica-Bold.afm.json
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Helvetica-Bold.afm.php
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Helvetica.afm.json
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Helvetica.afm.php
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Times-Bold.afm.json
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Times-Roman.afm.json
src/drupal/sites/all/modules/civicrm/vendor/dompdf/dompdf/lib/fonts/Times-Roman.afm.php
```
Current behaviour
----------------------------------------
The cache folder for dompdf isn't set so cache files are created in the font folder.
Proposed behaviour
----------------------------------------
CiviCRM defines the cache folder for dompdf that is outside of the codebase. Files are not generated within the codebase which keeps the codebase tidier and means that the codebase can be mounted read only.5.69.0https://lab.civicrm.org/dev/core/-/issues/4789Custom entity reference field on event can't be edited post creation2024-02-09T01:48:11Ztoby-fzCustom entity reference field on event can't be edited post creationOverview
----------------------------------------
I was trying to create an event with a custom field of type entity reference on CiviCRM 5.67.beta1 and after I set that when I went back to view it, the field was empty again (but still s...Overview
----------------------------------------
I was trying to create an event with a custom field of type entity reference on CiviCRM 5.67.beta1 and after I set that when I went back to view it, the field was empty again (but still set in the database). When I went to test on dmaster I could view the field fine after setting it initially but if I tried to change it I would get an infinite loading screen. See the steps below.
I'm not sure if this issue and my original issue are related or not.
Reproduction steps
----------------------------------------
Create a new custom field of type entity reference, for events.
Create a new event
Edit that event and try to change the contact in the entity reference field
It loads infinitely.
Current behaviour
----------------------------------------
Trying to change the contact in the entity reference and it won't stop loading
![image](/uploads/33344d5c1c6b518da67ca2e3fe663072/image.png)
I tried to add the logviewer ext to see the logs on dmaster but it didn't seem to be able to access them5.71.0https://lab.civicrm.org/dev/core/-/issues/4787Standalone mobile support2023-11-20T13:42:15ZbgmStandalone mobile supportCurrently accessing CiviCRM (standalone) on mobile does not work well:
- Missing viewport meta, so the text is tiny (zoomed out)
- ~~Mobile menu is not visible~~Currently accessing CiviCRM (standalone) on mobile does not work well:
- Missing viewport meta, so the text is tiny (zoomed out)
- ~~Mobile menu is not visible~~5.69.0https://lab.civicrm.org/dev/core/-/issues/4786Afform - Add shortcuts to Edit Forms and related Searchs on Search Forms2023-11-19T22:37:15ZfrancescbassasAfform - Add shortcuts to Edit Forms and related Searchs on Search FormsOverview
----------------------------------------
Since CiviCRM 5.67 there are no links on the Search Forms to quickly edit form settings. Before this release, it was possible to do it from breadcrumbs:
![imatge](/uploads/635e47f2f262a0...Overview
----------------------------------------
Since CiviCRM 5.67 there are no links on the Search Forms to quickly edit form settings. Before this release, it was possible to do it from breadcrumbs:
![imatge](/uploads/635e47f2f262a00c07d17062fb0448e2/imatge.png)
Current behaviour
----------------------------------------
There is no link to go to Edit form or related Search on Search Forms.
Proposed behaviour
----------------------------------------
Add a settings dropdown gear icon avalaible for allowed users with related "Edit Form" and "Edit Search" links.
![imatge](/uploads/e9f3ce66022cfbc68c1c0fb8cb079169/imatge.png)
Comments
----------------------------------------
For submission forms, gear icon with "Edit form" link appears on hover. I suggest removing hover effect for accessibility reasons and make it always visible (if you have sufficient permissions).
This is a ToDo from https://github.com/civicrm/civicrm-core/pull/27618https://lab.civicrm.org/dev/core/-/issues/4785Note 'View' not displaying data for a valid contact Note2024-01-08T00:23:25Zct_itsupportNote 'View' not displaying data for a valid contact Note## Overview
Upgrading to 5.67.1 from 5.66 has caused the View link to display a blank form for a previously populated note. If you click on 'Edit', you can see the note data.
Using Drupal 10.1.6 as the CMS
## Reproduction steps
1. Do...## Overview
Upgrading to 5.67.1 from 5.66 has caused the View link to display a blank form for a previously populated note. If you click on 'Edit', you can see the note data.
Using Drupal 10.1.6 as the CMS
## Reproduction steps
1. Do a fresh installation for Drupal 10.1.x with CiviCRM 5.67.1, with the loadGenerated=1 to create some dummy contact data
2. Search on all Individuals and chose a contact
3. Add a note to the contact
4. Click on 'View' on the newly created note - no data is displayed, the form is blank
5. Click on 'Edit' on the newly created note and the correct data is present
## Expected behaviour
I would expect the note data to populate the form as it has done in 5.66.x and before
## Environment information
* **Browser:** _Chrome, Edge_
* **CiviCRM:** _5.67.1_
* **PHP:** _8.1.x_
* **CMS:** _Drupal 10.1.6_
* **Database:** _MySQL 8.0.x_
* **Web Server:** _Apache 2.4.x_
## Comments
I did check recent log messages in Drupal Watchdog. There are a very large number of 'Undefined array Key 2...' generated just by opening the contact and clicking on the Note tab. It is so easy to reproduce that I have not included any of the message here.5.68.1https://lab.civicrm.org/dev/core/-/issues/4784SearchKit: Undefined index notices when adding mailing recipients2023-11-17T15:41:30Zaiden_gSearchKit: Undefined index notices when adding mailing recipientsWe're getting a whole lot of notices when users use the autocomplete to add recipients to a mailing.
Notice: Undefined index: label in Civi\Api4\Action\SearchDisplay\AbstractRunAction->getValue() (line 178 of xxx/sites/all/modules/civic...We're getting a whole lot of notices when users use the autocomplete to add recipients to a mailing.
Notice: Undefined index: label in Civi\Api4\Action\SearchDisplay\AbstractRunAction->getValue() (line 178 of xxx/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php)
It's happening when $data in the function is a sent mailing array. When getSelectExpression() is called for several of the keys the 'fields' item in the returned value is an empty array. The condition that follows assumes $key exists in 'fields'.
Appears it's just a case for an isset(), or is the empty fields array indicative of another issue? Haven't yet dug deeper.https://lab.civicrm.org/dev/core/-/issues/4783Clone/ copy contribution page doesn't work when admin UI is enabled2023-11-17T20:03:55ZeileenClone/ copy contribution page doesn't work when admin UI is enabledBecause the copy / clone action is overloaded onto the manage contribution page url it stops working when Admin UI is enabled - ie the url is
https://dmaster.localhost:32353/civicrm/admin/contribute?action=copy&gid=2
& it is handled th...Because the copy / clone action is overloaded onto the manage contribution page url it stops working when Admin UI is enabled - ie the url is
https://dmaster.localhost:32353/civicrm/admin/contribute?action=copy&gid=2
& it is handled through
![image](/uploads/0ef0992ba9de624b35e149272115246e/image.png)
- It would probably be best to split it out to it's own url
FYI @colemanw @ayduns5.68.0https://lab.civicrm.org/dev/core/-/issues/4781CiviCRM 5.67.0 - PHP Fatal error: Uncaught TypeError: CRM_Import_Parser::getF...2024-01-12T04:49:21Zjustinfreeman (Agileware)CiviCRM 5.67.0 - PHP Fatal error: Uncaught TypeError: CRM_Import_Parser::getFieldMetadata when using a Import MappingsThis site was upgraded from CiviCRM 5.64.4 to CiviCRM 5.67.0 and then this problem was reported.
When using a Import Mappings for a membership import, immediately throws a PHP fatal error after the field mapping step.
```PHP message: PH...This site was upgraded from CiviCRM 5.64.4 to CiviCRM 5.67.0 and then this problem was reported.
When using a Import Mappings for a membership import, immediately throws a PHP fatal error after the field mapping step.
```PHP message: PHP Fatal error: Uncaught TypeError: CRM_Import_Parser::getFieldMetadata(): Return value must be of type array, null returned```
Screenshots below indicate the cause of the issue. Discarding that field mapping and starting again is the only solution. None of the drop-downs have the "Do not import" available.
![image](/uploads/7f811efc1cb83c792fb077b0cb5c8e92/image.png)
![image](/uploads/854e8fc2b521b546e381d683375cfdd7/image.png)
Agileware Ref: CIVICRM-2194
Historically this was fixed before https://lab.civicrm.org/dev/core/-/issues/3511 and https://github.com/civicrm/civicrm-core/pull/237605.69.2https://lab.civicrm.org/dev/core/-/issues/4780when processing bounce emails, don't exit on fatal error if verp unverified2023-11-18T01:34:31Zlcdwebwhen processing bounce emails, don't exit on fatal error if verp unverifiedWhen cycling through bounced emails, the current behavior is to exit with a fatal error if Verp handling is enabled and the email is not verified. This effectively prevents any bounces from processing. Instead we should skip the problem ...When cycling through bounced emails, the current behavior is to exit with a fatal error if Verp handling is enabled and the email is not verified. This effectively prevents any bounces from processing. Instead we should skip the problem email and continue processing.5.68.0lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/4778Menu missing - error in console2023-12-05T10:17:19ZDaveDMenu missing - error in consoleI updated a dev site and now I get an error which mangles the menu.
```
"Undefined array key "adv_search_legacy""
...\sites\all\modules\civicrm\CRM\Admin\Page\AJAX.php(89)
```
Likely here: https://github.com/civicrm/civicrm-core/pull/2...I updated a dev site and now I get an error which mangles the menu.
```
"Undefined array key "adv_search_legacy""
...\sites\all\modules\civicrm\CRM\Admin\Page\AJAX.php(89)
```
Likely here: https://github.com/civicrm/civicrm-core/pull/28072/files5.68.0https://lab.civicrm.org/dev/core/-/issues/4775CiviCRM 5.67.0, Scheduled Job, fetch_bounces - CiviCRM does not process the e...2023-12-08T19:40:28Zjustinfreeman (Agileware)CiviCRM 5.67.0, Scheduled Job, fetch_bounces - CiviCRM does not process the email sent to the unsubscribe email address; contact is not unsubscribedCiviCRM 5.67.0, Scheduled Job, fetch_bounces - CiviCRM does not process the email sent to the unsubscribe email address; contact is not unsubscribed.
Problem occurs when VERP is enabled on the CiviCRM site. Untested when VERP is disabl...CiviCRM 5.67.0, Scheduled Job, fetch_bounces - CiviCRM does not process the email sent to the unsubscribe email address; contact is not unsubscribed.
Problem occurs when VERP is enabled on the CiviCRM site. Untested when VERP is disabled.
When is_create_activities=1 then the email is processed by CiviCRM, but the contact is still not unsubscribed.
Similar to https://lab.civicrm.org/dev/core/-/issues/2801
Agileware Ref: CIVICRM-2193
CiviCRM 5.67.0https://lab.civicrm.org/dev/core/-/issues/4774Queue: hook_QueueTaskError missing some params2023-11-13T20:53:09ZdamilareQueue: hook_QueueTaskError missing some paramsSetting up 4 parameters in the hook_QueueTaskError in an extension throws an exception stating the function got 2 parameters instead of 4.
Error:
```
WD php: ArgumentCountError: Too few arguments to function wmf_civicrm_civicrm_queueTas...Setting up 4 parameters in the hook_QueueTaskError in an extension throws an exception stating the function got 2 parameters instead of 4.
Error:
```
WD php: ArgumentCountError: Too few arguments to function wmf_civicrm_civicrm_queueTaskError(), 2 passed in /home/cividev/buildkit/build/wmff/drupal/sites/all/modules/civicrm/CRM/Utils/Hook.php on line 276 and exactly 4 expected in wmf_civicrm_civicrm_queueTaskError() (line 612 of [error]
/home/cividev/buildkit/build/wmff/drupal/sites/default/civicrm/extensions/wmf-civicrm/wmf_civicrm.php).
ArgumentCountError: Too few arguments to function wmf_civicrm_civicrm_queueTaskError(), 2 passed in /home/cividev/buildkit/build/wmff/drupal/sites/all/modules/civicrm/CRM/Utils/Hook.php on line 276 and exactly 4 expected in wmf_civicrm_civicrm_queueTaskError() (line 612 of /home/cividev/buildkit/build/wmff/drupal/sites/default/civicrm/extensions/wmf-civicrm/wmf_civicrm.php).
```
Here is the code in `CRM/Utils/Hooks.php`:
```
public static function queueTaskError(CRM_Queue_Queue $queue, $item, &$outcome, ?Throwable $exception) {
$null = NULL;
return self::singleton()->invoke(['job', 'params'], $queue, $item,
$outcome, $exception, $null, $null,
'civicrm_queueTaskError'
);
}
```5.69.0https://lab.civicrm.org/dev/core/-/issues/4773ACL revamp causes crashes on many SearchKit queries in 5.672023-11-14T00:18:09ZJonGoldACL revamp causes crashes on many SearchKit queries in 5.67Overview
----------------------------------------
This is a separate 5.67 regression from the ACL revamp than I reported Friday. This causes many SearchKit searches with an `IN` operator to fail.
I've isolated the regression to commit ...Overview
----------------------------------------
This is a separate 5.67 regression from the ACL revamp than I reported Friday. This causes many SearchKit searches with an `IN` operator to fail.
I've isolated the regression to commit `77b6e5ac3377cd1bfb1ebbc18bc9925caf06ad38`, which is part of [PR #27472](https://github.com/civicrm/civicrm-core/pull/27472). I'm 99% certain it's [this chunk of code](https://github.com/civicrm/civicrm-core/commit/77b6e5ac3377cd1bfb1ebbc18bc9925caf06ad38#diff-36ab608da0b5718996afd18c10a8c12653c2a1675e81fd3c4dc3e40c2ebb25d2R340).
Reproduction steps
----------------------------------------
Import and run this SearchKit query:
```json
[
[
"SavedSearch",
"save",
{
"records": [
{
"name": "Individual_Donations_Membership_Corporate_Sponsorships_Totals",
"label": "Individual Donations, Membership, Corporate Sponsorships Totals",
"api_entity": "Contribution",
"api_params": {
"version": 4,
"select": [
"COUNT(id) AS COUNT_id",
"GROUP_CONCAT(DISTINCT Contribution_FinancialType_financial_type_id_01.name) AS GROUP_CONCAT_Contribution_FinancialType_financial_type_id_01_name",
"SUM(net_amount) AS SUM_net_amount"
],
"orderBy": [],
"where": [],
"groupBy": [
"financial_type_id"
],
"join": [
[
"FinancialType AS Contribution_FinancialType_financial_type_id_01",
"INNER",
[
"financial_type_id",
"=",
"Contribution_FinancialType_financial_type_id_01.id"
],
[
"Contribution_FinancialType_financial_type_id_01.id",
"IN",
[
"3"
]
]
]
],
"having": []
}
}
],
"match": [
"name"
]
}
]
]
```
Current behaviour
----------------------------------------
Crash.
Expected behaviour
----------------------------------------
No crash.https://lab.civicrm.org/dev/core/-/issues/4772unable to authenticate in Joomla using Authx2023-11-15T13:43:10Zlcdwebunable to authenticate in Joomla using AuthxWhen using Authx to authenticate external CURL API calls in Joomla, we receive the error:
`Class "CRM_Utils_FakeJoomlaSession" not found.`When using Authx to authenticate external CURL API calls in Joomla, we receive the error:
`Class "CRM_Utils_FakeJoomlaSession" not found.`5.69.0lcdweblcdwebhttps://lab.civicrm.org/dev/core/-/issues/4771Import - "Matching CiviCRM Field" sorted by name including special non fields2023-11-21T21:00:19ZsamuelsovImport - "Matching CiviCRM Field" sorted by name including special non fieldsIn import screen, the special non fields `- do not import -` and `- related contact info -` get sorted as normal fields which creates several issues:
* related contact fields are not under `- related contact info -` anymore
* on french ...In import screen, the special non fields `- do not import -` and `- related contact info -` get sorted as normal fields which creates several issues:
* related contact fields are not under `- related contact info -` anymore
* on french translation, `- related contact info -` becomes the first in the list, gets selected by default and crash the import if we don't manually select `- do not import -` for each field.
![screen20231113.png](/uploads/83645450246127460002b1565203a546/screen20231113.png)
On CiviCRM 5.60, this used to work as expected with `- related contact info -` at the bottom with the relationship types listed below. Since at least 5.65, this is broken.https://lab.civicrm.org/dev/core/-/issues/4770When adding a follow up activity on an existing case activity with multiple a...2023-11-15T16:16:35ZErikHommelWhen adding a follow up activity on an existing case activity with multiple assignees only one is savedOverview
----------------------------------------
When I add a follow up activity on an existing activity in a case (does not happen on non-case activities) and add more than 1 assignee, only the first assignee is actually saved on the a...Overview
----------------------------------------
When I add a follow up activity on an existing activity in a case (does not happen on non-case activities) and add more than 1 assignee, only the first assignee is actually saved on the activity.
Reproduction steps
----------------------------------------
1. Find an existing case activity
2. Add a follow up activity with multiple assignees
3. Hit save
Current behaviour
----------------------------------------
Only the first assignee is saved
Expected behaviour
----------------------------------------
All assignees should be saved
Environment information
----------------------------------------
CiviCRM 5.66.05.69.0ErikHommelErikHommelhttps://lab.civicrm.org/dev/core/-/issues/4769Regression - CiviCase and CiviCRM 5.67.0 - Unable to load any Activities2024-01-30T05:55:32Zjustinfreeman (Agileware)Regression - CiviCase and CiviCRM 5.67.0 - Unable to load any ActivitiesCiviCase and CiviCRM 5.67.0 - Unable to load any Activities, this impacts both the API and the user interface.
Looks like this problem was introduced with this change, https://github.com/civicrm/civicrm-core/pull/27722/files#diff-4eb5ab...CiviCase and CiviCRM 5.67.0 - Unable to load any Activities, this impacts both the API and the user interface.
Looks like this problem was introduced with this change, https://github.com/civicrm/civicrm-core/pull/27722/files#diff-4eb5abe9e478e4f37ae442a8852de89bb4280671be4aebc813e1f0ed573d77b0R26
Removing this function: [civi_case_civicrm_selectWhereClause](https://github.com/civicrm/civicrm-core/pull/27722/files#diff-4eb5abe9e478e4f37ae442a8852de89bb4280671be4aebc813e1f0ed573d77b0R26) - effectively reverts CiviCase Activities to a usable state.
Agileware Ref: CIVICRM-21915.67.1