CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2024-02-18T14:03:46Zhttps://lab.civicrm.org/dev/core/-/issues/4870consider adding type info to cache interfaces that extend PSR-16 Simple Cache?2024-02-18T14:03:46Zcomposerjkconsider adding type info to cache interfaces that extend PSR-16 Simple Cache?It looks like in August 2021, the PHP-FIG [PSR-16 Simple Cache](https://github.com/php-fig/simple-cache) interface had parameter and return type info added to the method definitions.
Noticed when the 2.1+ update to the [Breeze](https://...It looks like in August 2021, the PHP-FIG [PSR-16 Simple Cache](https://github.com/php-fig/simple-cache) interface had parameter and return type info added to the method definitions.
Noticed when the 2.1+ update to the [Breeze](https://wordpress.org/plugins/breeze/) WordPress cache plugin referenced the updated cache interface definition via the included [Mobile Detect](https://github.com/serbanghita/Mobile-Detect/) package.
Maybe there's an adjustment to be made or maybe they (Mobile Detect folk) are including the PSR definitions incorrectly? Have not investigated.
Here's the error message that caused me to notice and track down the issue:
`An error of type E_COMPILE_ERROR was caused in line 43 of the file /…/wp-content/plugins/civicrm/civicrm/CRM/Utils/Cache/Interface.php. Error message: Declaration of CRM_Utils_Cache_Interface::get($key, $default = null) must be compatible with Psr\SimpleCache\CacheInterface::get(string $key, mixed $default = null): mixed`
Initial PSR-16 implementation inclusion was in issue #174.https://lab.civicrm.org/dev/core/-/issues/4869Mailing labels do not work with custom tokens anymore2024-01-06T00:51:57ZMariaVMailing labels do not work with custom tokens anymoreI thought I have seen this issue already but I could not find it. In case there is, feel free to close.
Since 5.64.4 or probably earlier, the mailing labels do not work with custom tokens anymore.
An update to 5.67.3 did not help. The p...I thought I have seen this issue already but I could not find it. In case there is, feel free to close.
Since 5.64.4 or probably earlier, the mailing labels do not work with custom tokens anymore.
An update to 5.67.3 did not help. The page is just blank with no labels at all.
My colleague and I were trying to analyze this problem a bit further but could not find a solution.
The custom token itself works when creating a document.
In case it would be interesting to have a look on the code, I have attached the files.
The custom token produces also warnings for non-existent array indices:
```
PHP Warning: Undefined array key "County" in /html/wordpress/wp-content/plugins/civicrm/civicrm/CRM/Admin/Form/Preferences/Address.php on line 83
PHP Warning: Undefined array key "Street Address Parsing" in /html/wordpress/wp-content/plugins/civicrm/civicrm/CRM/Admin/Form/Preferences/Address.php on line 95
PHP Warning: Undefined array key "county" in /html/wordpress/wp-content/uploads/civicrm/templates_c/de_DE/%%B0/B09/B09DCA78%%Location.tpl.php on line 78
PHP Warning: Trying to access array offset on value of type null in /html/wordpress/wp-content/uploads/civicrm/templates_c/de_DE/%%B0/B09/B09DCA78%%Location.tpl.php on line 78
```
Does anybody have an idea what could be a problem? Could it be an incompatibility with PHP8?
[csaddressemployer.inc](/uploads/7602180cf302b3fc9e2d67d49b62f61e/csaddressemployer.inc)
[tokenhelpers.inc](/uploads/9702807fed78d384f2226aadf99a173c/tokenhelpers.inc)5.69.0https://lab.civicrm.org/dev/core/-/issues/4867civi_case/civi_campaign extensions not configured properly on a fresh install2024-01-05T03:42:41ZDaveDcivi_case/civi_campaign extensions not configured properly on a fresh installLeads to crash if you try to enable the extension from the extension screen. They enable properly from the components screen.
Might be from https://github.com/civicrm/civicrm-core/commit/9640b86f59daf80991989f0848e02c01ead202d7? I'm not...Leads to crash if you try to enable the extension from the extension screen. They enable properly from the components screen.
Might be from https://github.com/civicrm/civicrm-core/commit/9640b86f59daf80991989f0848e02c01ead202d7? I'm not sure because I don't use the extension screen to manage these, and on all the PR sites and dmaster.demo they are enabled already at install, so I don't have a good sense of when it started.
PR coming shortly5.69.0https://lab.civicrm.org/dev/core/-/issues/4866Advance search fails for tag search2023-12-18T16:10:50ZPradeep Nayakpradpnayak@gmail.comAdvance search fails for tag searchWhen using advanced search for contacts based on tag and activity created within this month fails to search and export.
![Screen_Recording_2023-12-16_at_13.39.26](/uploads/d27cab973f06ef4b2b61cbd1024b976a/Screen_Recording_2023-12-16_at...When using advanced search for contacts based on tag and activity created within this month fails to search and export.
![Screen_Recording_2023-12-16_at_13.39.26](/uploads/d27cab973f06ef4b2b61cbd1024b976a/Screen_Recording_2023-12-16_at_13.39.26.mov)5.70.0https://lab.civicrm.org/dev/core/-/issues/4864Edit contribution Undefined array key on dmaster2024-03-12T17:47:47ZJoeMurrayEdit contribution Undefined array key on dmasterTrying to edit contribution created at https://lab.civicrm.org/dev/core/-/issues/4863 leads to page of php/smarty issues:
Warning: Undefined array key "defaultContribution" in include() (line 86 of /srv/buildkit/build/dmaster/.civibuild...Trying to edit contribution created at https://lab.civicrm.org/dev/core/-/issues/4863 leads to page of php/smarty issues:
Warning: Undefined array key "defaultContribution" in include() (line 86 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%6F/6F7/6F7BB438%%Contribution.tpl.php).
Warning: Undefined array key "displayLineItemFinancialType" in include() (line 24 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 32 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 37 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 44 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "displayLineItemFinancialType" in include() (line 57 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 70 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 74 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 90 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "getTaxDetails" in include() (line 102 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "pricesetFieldsCount" in include() (line 124 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).
Warning: Undefined array key "hookDiscount" in include() (line 151 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%F2/F21/F21A46C1%%LineItem.tpl.php).https://lab.civicrm.org/dev/core/-/issues/4863contribution ThankYou.tpl.php notice errors on dmaster, contribution total am...2023-12-19T22:08:35ZJoeMurraycontribution ThankYou.tpl.php notice errors on dmaster, contribution total amount $0Scenario 1: On dmaster, with default value for mug premium ($12.50), on live Donation page, choose $50 donation, ask for mug, complete credit card info, no honoree, no title for donor, then on thank you page you get errors below.
Simpli...Scenario 1: On dmaster, with default value for mug premium ($12.50), on live Donation page, choose $50 donation, ask for mug, complete credit card info, no honoree, no title for donor, then on thank you page you get errors below.
Simplifying scenario 2: on dmaster Donate page, leave default $10 amount, no premium, fill in required fields for Billing Name and Address as shown, credit card info, then on thank you page get errors below. Note that Title field is not provided on page, and honoree sections not on page. Need to change template to make them optional is my guess.
![2023-12-15_18-00-19](/uploads/05ba7c9c528596b757c01845da3e03ff/2023-12-15_18-00-19.png)
BUG: in both cases, it shows total paid was $0.00.
![2023-12-15_18-09-17](/uploads/f263bd2a81e8f222c4a8672dec0ad49b/2023-12-15_18-09-17.png)
Warning: fopen(/srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/ConfigAndLog/CiviCRM.1.daaf15586b7efa7b235b62c7.log): Failed to open stream: Permission denied in Log_file->open() (line 216 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/pear/log/Log/file.php).
Warning: fopen(/srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/ConfigAndLog/CiviCRM.1.daaf15586b7efa7b235b62c7.log): Failed to open stream: Permission denied in Log_file->open() (line 216 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/pear/log/Log/file.php).
Warning: Undefined array key "honoreeProfileFields" in include() (line 232 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%0D/0D2/0D2EEFAF%%ThankYou.tpl.php).
Warning: Undefined array key "title" in include() (line 377 of /srv/buildkit/build/dmaster/.civibuild/private/default/civicrm/templates_c/en_US/%%0D/0D2/0D2EEFAF%%ThankYou.tpl.php).
![2023-12-15_17-58-12](/uploads/2f7129203c925d45366ad241efc25eac/2023-12-15_17-58-12.png)5.69.0https://lab.civicrm.org/dev/core/-/issues/4862Standalone: cannot update unauthenticated 'everyone' permissions2024-02-05T17:57:44ZRichStandalone: cannot update unauthenticated 'everyone' permissionsThe `CRM_Standaloneusers_BAO_Role::_checkAccess()` method won't let us update the everyone role.
We're supposed to not be allowed to *delete* the everyone role, but we should be able to update the permissions of it.The `CRM_Standaloneusers_BAO_Role::_checkAccess()` method won't let us update the everyone role.
We're supposed to not be allowed to *delete* the everyone role, but we should be able to update the permissions of it.RichRichhttps://lab.civicrm.org/dev/core/-/issues/4861addressee communication prefs seems a bit messed up2023-12-13T20:27:32ZDaveDaddressee communication prefs seems a bit messed upI'm not sure yet if this is just from demo sample data, but at the very least the dropdown on edit seems the wrong type?
![untitled3](/uploads/b1a2100f8eb24985554fa83b94fa70f2/untitled3.png)
![untitled4](/uploads/95eb53af0acf99e8bdcced...I'm not sure yet if this is just from demo sample data, but at the very least the dropdown on edit seems the wrong type?
![untitled3](/uploads/b1a2100f8eb24985554fa83b94fa70f2/untitled3.png)
![untitled4](/uploads/95eb53af0acf99e8bdcced58e8508323/untitled4.png)https://lab.civicrm.org/dev/core/-/issues/4860VTIMEZONE block in ICS file publishes DSTART in wrong timezone2024-01-17T23:01:42ZjamieVTIMEZONE block in ICS file publishes DSTART in wrong timezoneA lot of great work went into fixing our ICS timezone support in #2887!
But, I _think_ there is still one small problem with timezone support.
I'm testing with the ICS file generated by the Montreal Developer Training on February 26th ...A lot of great work went into fixing our ICS timezone support in #2887!
But, I _think_ there is still one small problem with timezone support.
I'm testing with the ICS file generated by the Montreal Developer Training on February 26th (https://civicrm.org/civicrm/event/ical?reset=1&id=1745). The event is supposed to start at 9:00 AM America/New_York time.
I'm using Thunderbird. I have my Thunderbird timezone set to America/Los_Angeles. It's important to set your calendar timezone to a timezone that does not match the event time zone to replicate the problem.
When I import the ICS file, my calendar shows it as starting at 1:00 am America/Los_Angeles time, which would be 4:00 am America/New_York time. The reason it's off is because Thunderbird percieves the correct time to be 9:00 am UTC rather than 9:00 am America/New_York.
Here are the relevant parts of the ICS file.
First, the timezone is defined:
```
BEGIN:VTIMEZONE
TZID:America/New_York
BEGIN:STANDARD
TZOFFSETFROM:-0500
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:20240226T140000
END:STANDARD
END:VTIMEZONE
```
Then, the event date start is defined:
```
TSTAMP;TZID=America/New_York:20240226T090000
DTSTART;TZID=America/New_York:20240226T090000
DTEND;TZID=America/New_York:20240227T170000
```
The problem is with the timezone definition, specifically:
`DTSTART:20240226T140000`
This represents the start time in UTC. But, the [standards](https://www.rfc-editor.org/rfc/rfc5545#section-3.6.5) says:
> The mandatory "DTSTART" property gives the effective onset date
and local time for the time zone sub-component definition.
"DTSTART" in this usage MUST be specified as a date with a local
time value.
In other words, it should be the local time, not UTC. In this case: `DTSTART:20240226T090000`.
Making that adjustment causes it to import properly in Thunderbird.
I'm happy to work on this, but would love some feedback to make sure I'm not offbase on anything. I know @justinfreeman did a lot of work on this in #2887 so maybe has some thoughts.5.71.0https://lab.civicrm.org/dev/core/-/issues/4856Search criteria sections no longer collapse on search forms when there are re...2024-01-05T03:42:41ZDaveDSearch criteria sections no longer collapse on search forms when there are results, and subsections no longer open when there aren'tI know there's been some accordion work so I'm sure it's related but not sure if it's a known issue.
Example 1:
1. Advanced search
2. Open contributions tab and search for an id like 30 that you know exists.
3. It finds the results, bu...I know there's been some accordion work so I'm sure it's related but not sure if it's a known issue.
Example 1:
1. Advanced search
2. Open contributions tab and search for an id like 30 that you know exists.
3. It finds the results, but all the criteria are still open. It didn't used to do that because now you have to scroll all the way down. (Compare to Find Contributions which still collapses after finding results.)
Example 2:
1. Advanced search
2. Open contributions tab and search for an id like -1 or 10000 that you know doesn't exist.
3. It used to redisplay the form showing no results but with the contributions tab open so you could see what you had selected.5.69.0https://lab.civicrm.org/dev/core/-/issues/4855Searchkit: Notes tab and relationships tab on contact crashing with DOMDocume...2024-01-11T22:54:12ZDaveDSearchkit: Notes tab and relationships tab on contact crashing with DOMDocument::loadHTML(): Tag crm-search-display-table invalid in EntityWhether it's a crash or not depends on the strictness of your setup but I don't remember seeing this before so might be some recent change? But I'm not 100% sure about that.
The error comes up as a 500 error in the network tab and the e...Whether it's a crash or not depends on the strictness of your setup but I don't remember seeing this before so might be some recent change? But I'm not 100% sure about that.
The error comes up as a 500 error in the network tab and the error itself is in the ajax response.5.69.0https://lab.civicrm.org/dev/core/-/issues/4853Inherited permissions don't always work (permissions may be too restrictive)2023-12-12T16:24:41ZRichInherited permissions don't always work (permissions may be too restrictive)Overview
----------------------------------------
Group count zero in tab; no groups listed.
Reproduction steps
----------------------------------------
On a demo site, e.g.
```
civibuild create so3 --type standalone-dev --civi-ve...Overview
----------------------------------------
Group count zero in tab; no groups listed.
Reproduction steps
----------------------------------------
On a demo site, e.g.
```
civibuild create so3 --type standalone-dev --civi-ver master
```
*observable at https://smaster.demo.civicrm.org/civicrm*
Go to Contacts » Manage Groups. Click Contacts for the Advisory Board. Click to view a contact, e.g. Rosario. Their contact summary screen shows Groups (0) in the tab, and no groups are listed.
Expected behaviour
----------------------------------------
Group count and group list should be correct.
Comments
----------
Not sure when this stopped working. Seems to be `CRM_Core_Permission::getPermissionedStaticGroupClause` returning `(0)` for its where clause.
This worked in 5.67 standalone, but not 5.68 so is probably to do with recent permissions work.
## Edit
This is not standalone specific. It exhibited in standalone because we changed the admin role to just have "administer all CiviCRM ACLS and permissions" - but this does not correctly bestow permissions as it suggests.
https://chat.civicrm.org/civicrm/pl/r8qgwtzw9bbwbgbxgjprtpm69oRichRichhttps://lab.civicrm.org/dev/core/-/issues/4852Viewing contact notes is broken2023-12-13T17:32:08ZDaveDViewing contact notes is broken1. Create a contact note
2. View it - the fields are blank.
3. Also it's an edit form, so it's almost like it's taking you to a new note edit screen, except it has an id.
Affects 5.68 [according to reports](https://civicrm.stackexchange...1. Create a contact note
2. View it - the fields are blank.
3. Also it's an edit form, so it's almost like it's taking you to a new note edit screen, except it has an id.
Affects 5.68 [according to reports](https://civicrm.stackexchange.com/questions/46064/using-the-view-button-on-notes-tab-returns-blank-form).5.68.1colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/4851unable to install social_auth_google 4.02024-01-05T14:48:48Zolivierunable to install social_auth_google 4.0Overview
----------------------------------------
After upgrading Drupal from 9 to 10 it is not possible to update social_auth_google. Version conflict.
Reproduction steps
----------------------------------------
- uninstall drupal/soci...Overview
----------------------------------------
After upgrading Drupal from 9 to 10 it is not possible to update social_auth_google. Version conflict.
Reproduction steps
----------------------------------------
- uninstall drupal/social_auth_google (otherwise, upgrade is not possible if civicrm is installed)
- upgrade site to drupal 10
- install drupal/social_auth_google : composer require drupal/social_auth_google
Current behaviour
----------------------------------------
composer require 'drupal/social_auth_google:^4.0'
./composer.json has been updated
Running composer update drupal/social_auth_google
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires drupal/social_auth_google ^4.0 -> satisfiable by drupal/social_auth_google[4.0.0-beta1, 4.0.0, 4.0.1, 4.0.x-dev].
- drupal/social_auth_google[4.0.0-beta1, ..., 4.0.x-dev] require league/oauth2-google ^4.0 -> found league/oauth2-google[4.0.0, 4.0.1] but the package is fixed to 3.0.4 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
```
Expected behaviour
----------------------------------------
Installation without error
Environment information
----------------------------------------
* __CiviCRM:__ _5.68.0_
* __PHP:__ _8.1.18__
* __CMS:__ _Drupal 10.1.7_
* __Database:__ _10.5.21-MariaDB_
* __Web Server:__ _Apache_
Comments
----------------------------------------
league/oauth2-google version is fixed in civicrm-core
composer why league/oauth2-google
civicrm/civicrm-core 5.68.0 requires league/oauth2-google (^3.0)5.70.0https://lab.civicrm.org/dev/core/-/issues/4843CronJob for smart group rebuild / cache purge not working2024-01-15T13:12:26ZTobias Voigttobias.voigt@civiservice.deCronJob for smart group rebuild / cache purge not workingI love the idea of being able to use smart / dynamic groups for our client's projects. In one particular case I'm heavily relying on CiviCRM relationships to mirror the organization's structures. Yet I would like to set up accompanying s...I love the idea of being able to use smart / dynamic groups for our client's projects. In one particular case I'm heavily relying on CiviCRM relationships to mirror the organization's structures. Yet I would like to set up accompanying smart groups, that reflect certain relationships (or combination of relationships) to be able to address those smart groups in mailings or use them in the context of ACLs.
The problem I experienced over and over is that **the rebuild process of the smart group cache doesn't work reliably.**
I tested the two existing cronjobs for the rebuild process **Job.group_rebuild** and **Job.group_cache_flush** - yet they don't actually do what they're supposed to do, independent of the sequence in which I trigger them.
Only when I manually purge the system's cache (after I executed those cronjobs), the rebuilt smart groups are shown in the system. It might be possible that only the "**Job.group_cache_flush**" doesn't work correctly and therefore the smart groups are rebuilt by "**Job.group_rebuild**" but the result isn't shown in the system since the cache doesn't get purged.
I was able to reproduce this behaviour on several systems.https://lab.civicrm.org/dev/core/-/issues/4841Unable to send bulk mail from SearchKit search page results, 'send test' and ...2024-01-05T03:42:46Zfreeform.stephUnable to send bulk mail from SearchKit search page results, 'send test' and 'next' buttons remain greyed-outOverview
----------------------------------------
There appears to be an issue with inconsistent (or broken) use of required tokens feature between mailings sent from a core search versus from SearchKit results. As a result:
1. When atte...Overview
----------------------------------------
There appears to be an issue with inconsistent (or broken) use of required tokens feature between mailings sent from a core search versus from SearchKit results. As a result:
1. When attempting to send from the results of a SearchKit search: the 'send test' and 'next' buttons remain greyed-out whether you do or do not include the required address and unsubscribe links
2. This happens even when the option to not require these tokens is set in the system settings
3. When attempting to send from the results of a regular search page it will allow you to send even if the tokens are set as required but not included in your message
Reproduction steps
----------------------------------------
* (issue 1) Create a custom search using search kit, select some results, choose action "Email - schedule/send via CiviMail", include all required elements and you'll see you're stuck
* (issue 2) go to Administer>CiviMail/CiviMail Component Settings and select "Disable check for mandatory tokens"; repeat step 1, same result
* (issue 3) Ensure mandatory tokens are enabled; use Search>Find Contacts, choose action "Email - schedule/send via CiviMail", do not include the tokens in your mailing and you'll see you can still proceed without getting an error (if you save the draft and then continue your draft it will work as expected)
Current behaviour
----------------------------------------
Unable to send mail from results of a SearchKit page; mail from a core search allows sending messages with missing tokens.
Environment information
----------------------------------------
* __Browser:__ Chrome 119.0.6045.199
* __CiviCRM:__ 5.66.2, 5.69.alpha1 (https://dmaster.demo.civicrm.org/)
* __PHP:__ 8.1
* __CMS:__ Drupal 7 (I believe I also tested on Drupal 10)
Comments
----------------------------------------
Workaround for issue 1 - if you save your draft and then clone your mailing, the clone works as expected5.69.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/4839Message templates not always sent2023-12-06T01:46:11ZtottenMessage templates not always sentOverview
----------------------------------------
There appears to be some subtle breakage in how message-templates are sent. I believe this is why the "Password Reset" emails aren't being sent (cc @pfigel @artfulrobot).
Reproduction s...Overview
----------------------------------------
There appears to be some subtle breakage in how message-templates are sent. I believe this is why the "Password Reset" emails aren't being sent (cc @pfigel @artfulrobot).
Reproduction steps
----------------------------------------
Setup a fake email service (eg MailHog)
Run this script:
```php
function do_wfmsg_a() {
$msg = \Civi\WorkflowMessage\WorkflowMessage::create('petition_sign', [
'from' => '"Foo" <foo@bar.com>',
'contactId' => 204,
]);
$msg->setTo('demo@example.com');
return $msg->sendTemplate([
'messageTemplate' => [
'msg_subject' => 'My Subject ' . __FUNCTION__,
'msg_text' => 'Hello',
'msg_html' => '<p>Hello</p>',
]
]);
}
```
Observe whether the email is received
Current behaviour
----------------------------------------
The email is not actually delivered (circa 5.64.0).
Expected behaviour
----------------------------------------
The email is actually delivered (circa 5.63.3).
Comments
----------------------------------------
I did a `git bisect`, and I believe it originates from:
https://github.com/civicrm/civicrm-core/commit/ba4b246234e4dd58e23050138455aec6497ac988
Probably related: When I watched this in the debugger, I noticed that `CRM_Core_BAO_MessageTemplate::renderTemplateRaw()` calls `WorkflowMessage::importAll()`. At this point, it wipes out the `$model->to` property.5.68.0https://lab.civicrm.org/dev/core/-/issues/4836Importing Custom Data: Import of multiselect-fields for fieldgroup with multi...2024-02-08T10:40:26ZTobias Voigttobias.voigt@civiservice.deImporting Custom Data: Import of multiselect-fields for fieldgroup with multiple records not possibleI'm trying to import custom data to a custom field group **with multiple records** for a client.
In this field group I have a checkbox (multiselect) field.
In my import CSV I use the format "1,2,3" as a value for this multiselect field...I'm trying to import custom data to a custom field group **with multiple records** for a client.
In this field group I have a checkbox (multiselect) field.
In my import CSV I use the format "1,2,3" as a value for this multiselect field. Yet this value - even though it is possible when entering data manually - simply won't be accepted when importing via CSV.
Just to examine this behaviour further, I tried the same thing with a field group **that doesn't allow mutliple records**. Here the format "1,2,3" works as expected for my checkbox / multiselect field and gets imported without problems.
It should be possible to import multiselect fields for custom data with multiple records - so this seems like a bug at first glance. Or maybe I'm overseeing something here?5.71.0https://lab.civicrm.org/dev/core/-/issues/4835Standalone - Iterate on Roles2024-02-05T11:05:00ZkcristianoStandalone - Iterate on RolesFollow up to https://lab.civicrm.org/dev/core/-/issues/4466
At the Ashbourne Sprint, discussion was had on roles and Standalone now has 3 roles:
- Everyone, including anonymous users
- Staff
- Administrator
One possible concern is th...Follow up to https://lab.civicrm.org/dev/core/-/issues/4466
At the Ashbourne Sprint, discussion was had on roles and Standalone now has 3 roles:
- Everyone, including anonymous users
- Staff
- Administrator
One possible concern is that the `Administrator` role can be changed. Recent PRs have made it that the role cannot be removed, but the capabilities are editable. If the capabilities were changed by an existing admin, the system will become unusable/
Steps to reproduce
- Login as an admin
- remove all permissions for the administrator role except AuthX.
- Log out
- Log in
- Error - with too many redirects as the admin account cannopt access CiviCRM
We should protect against this by
- not having any permissions show for the administrator account
- make the internal name unchangeable
- The label can be changed by the site admin
- programmatically granting all permissions to the `administrator` role
In addition, there is a potential UX issue with assigning permissions.
The Search kit multi-select is useful if we only want a few permissions, but difficult if a role needs many permissions.
Rather than revert to the existing laundry list of permission that are used by Drupal and WP, we should consider using a cjheckbox approach by 'category'
@andyburns sugested an interface that is similar to the following:
![image](/uploads/d047d54bae7dcd3cf7caa0a02f2369db/image.png)
This interface is from the User Role Editor plugin from WordPress.
It categorizes permissions by type, allows filtering and has a checkbox interface. I think this would be a nice improvement to be considered.jaapjansmajaapjansmahttps://lab.civicrm.org/dev/core/-/issues/4833Authorize.net webhooks fail, because processor expects Integer for x_invoice_...2024-01-05T03:42:40ZAllenShawAuthorize.net webhooks fail, because processor expects Integer for x_invoice_num, while some have 20-character alphanumericI have a situation in which some Authorize.net ARB webhook notifications are not being processed successfully.
This appears to be because:
- CiviCRM expects an integer for the webhook value of x_invoice_num
- These webhooks have a 20-ch...I have a situation in which some Authorize.net ARB webhook notifications are not being processed successfully.
This appears to be because:
- CiviCRM expects an integer for the webhook value of x_invoice_num
- These webhooks have a 20-character alphanumeric string (e.g. "512def29489e1bcc8856") for this value.
More details:
- Affected recurring contributions were all created before Nov 2021
- This x_invoice_num string (e.g. "512def29489e1bcc8856") does appear in the database, only in these places:
- `civicrm_contribution` for the first contribution in the recurring series:
- civicrm_contribution.invoice_id contains a 32-character alphanumeric string, the first 20 characters of which are this x_invoice_num value
- civicrm_contribution.trxn_id contains two strings, joined by a comma; the first is this x_invoice_num value; the second is an integer which appears to be an FK to civicrm_financial_trxn.order_reference.
Technical assessment:
1. I'm guessing that older civicrm versions used to handle things this way (passing 20-character alphanumeric to Authorize.net, so that it gets returned in webhook's x_invoice_num value), and that way of things has changed at some point since Nov 2021.
I can work on a PR, but first I thought someone might know of a previous issue/commit that removed some code relevant to this process.
I'm at the sprint now and aim to work on a fix either way.
(Joinery reference: F#1270)5.70.0