CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2024-01-31T08:51:22Zhttps://lab.civicrm.org/dev/core/-/issues/4937(regression) FormBuilder forms with yes/no and autocomplete fail in Firefox2024-01-31T08:51:22ZJonGold(regression) FormBuilder forms with yes/no and autocomplete fail in FirefoxOverview
----------------------------------------
In Civi 5.69 (and master) forms that meet certain criteria fail to submit in Firefox. I believe there are scenarios other than the one I describe below, but this represents a relatively ...Overview
----------------------------------------
In Civi 5.69 (and master) forms that meet certain criteria fail to submit in Firefox. I believe there are scenarios other than the one I describe below, but this represents a relatively simple replicable case.
I did a `git bisect` and tracked it down to https://github.com/civicrm/civicrm-core/pull/28452 (no Gitlab bot that's not a pull request for this issue).
Reproduction steps
----------------------------------------
I've attached a FormBuilder form that's a relatively simple replication case. This requires a field of type "Yes/No" called `yesno` in a custom group with name `contact_fields2`.
Select "yes" or "no" on the custom field, press "Submit".
Current behaviour
----------------------------------------
If you submit this form in Firefox, you see the error "Sorry an error occurred and your information was not saved.", but then the page reloads, though the URL changes:
e.g.:
```
# original
http://dmaster.localhost/civicrm/org-member-renewal
# post-submit
http://dmaster.localhost/civicrm/org-member-renewal?contact-fields-2-yesno-1=0
```
In Chrome, the page submits successfully.
There's also a ton of JS console errors.
On my civicrm-buildkit site, they looked like this:
```
Error: [$rootScope:infdig] http://errors.angularjs.org/1.8.2/$rootScope/infdig?p0=10&p1=%5B%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%5D
Angular 41
jQuery 2
<anonymous> Angular
jQuery 7
<anonymous> Common.js:1659
jQuery 8
angular.js:15697:15
```
On my 5.69.2 non-buildkit site, it looked like this:
```
Uncaught Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: [[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":{}},"oldVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."}}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}]]
https://errors.angularjs.org/1.8.2/$rootScope/infdig?p0=10&p1=%5B%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%5D
Angular 8
$onChanges http://reamp.local/wp-content/plugins/civicrm/civicrm/ang/crmUi.js?r=GUtKAen_US:789
Angular 34
jQuery 2
<anonymous> Angular
jQuery 7
<anonymous> http://reamp.local/wp-content/plugins/civicrm/civicrm/js/Common.js?r=GUtKAen_US:1659
jQuery 8
angular.js:138:12
```
Expected behaviour
----------------------------------------
Form should always submit successfully.
Environment information
----------------------------------------
* __Browser:__ Firefox 120.0.1
* __CiviCRM:__ master
* __PHP:__ 8.1
* __CMS:__ Drupal 7
* __Database:__ Replicated w/ MariaDB 10.6 and 10.11
* __Web Server:__ Apache 2.45.69.4https://lab.civicrm.org/dev/core/-/issues/4932Outbound SMS and Send Email action missing when viewing contact summary2024-01-24T16:39:34ZDaveDOutbound SMS and Send Email action missing when viewing contact summaryI think it's from https://github.com/civicrm/civicrm-core/pull/27973/files. Note how it used to check for special types [BEFORE](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-dfbc52a8403be6cfef3ecfd332d7b7fcc2e3ca579b325d...I think it's from https://github.com/civicrm/civicrm-core/pull/27973/files. Note how it used to check for special types [BEFORE](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-dfbc52a8403be6cfef3ecfd332d7b7fcc2e3ca579b325d4a419c39a3226fdbd7L90) checking filter=1. But now it includes the filter [up front](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-6edb9e1abb30f7ec07c2ea0cecde36eefe0bebf9535022ecd8e8625f02517192R85) so it doesn't get a chance to check for SMS.5.70.0https://lab.civicrm.org/dev/core/-/issues/4931Auto-renew checkbox hidden by default2024-01-29T03:48:57ZpatricklamAuto-renew checkbox hidden by defaultOverview
----------------------------------------
When signing up for a membership, where the membership type has auto-renew being available as an option, the auto-renew checkbox is initially hidden and only shows up after clicking on th...Overview
----------------------------------------
When signing up for a membership, where the membership type has auto-renew being available as an option, the auto-renew checkbox is initially hidden and only shows up after clicking on the membership type.
Reproduction steps
----------------------------------------
1. Create a membership type with auto-renew optional.
2. Create a contribution page with auto-renew optional.
3. Visit the contribution page. Membership amount shown, but not the "Please renew my membership automatically" checkbox.
4. Clicking on the membership amount causes the autorenew checkbox to appear.
Current behaviour
----------------------------------------
Autorenew checkbox is initially invisible and only appears after clicking on the membership amount.
Expected behaviour
----------------------------------------
Autorenew checkbox should appear on page load.
Environment information
----------------------------------------
Can reproduce on the demo sandbox with Firefox and Chrome.
Comments
----------------------------------------
Patch available: https://github.com/civicrm/civicrm-core/pull/290235.70.0https://lab.civicrm.org/dev/core/-/issues/4930Activity count is incorrect if contact is source and target2024-01-28T20:05:48ZbgmActivity count is incorrect if contact is source and targetRegression on 5.70/RC:
- Disable the AdminUI extension
- Go to a contact record
- New activity / Meeting
- Enter the same contact in the fields "with contact" and "assigned to contact"
- Save
The activity count displayed on the tab wil...Regression on 5.70/RC:
- Disable the AdminUI extension
- Go to a contact record
- New activity / Meeting
- Enter the same contact in the fields "with contact" and "assigned to contact"
- Save
The activity count displayed on the tab will count will be 3 instead of 1:
![image](/uploads/f4feac6831c8b35d58e88547129de366/image.png)
The AdminUI core-ext mitigates this problem by re-calculating, but we still see the incorrect count for a few seconds.5.70.0https://lab.civicrm.org/dev/core/-/issues/4928Event registration crashes under Windows - is this a Smarty3 issue?2024-01-31T17:12:28ZspalmstromEvent registration crashes under Windows - is this a Smarty3 issue?## Overview
I raised this in Stackexchange and have had some feedback ([Is this the end of the road for CiviCRM under Windows?](https://civicrm.stackexchange.com/questions/46268/is-it-the-end-of-the-road-for-civicrm-under-windows?noredi...## Overview
I raised this in Stackexchange and have had some feedback ([Is this the end of the road for CiviCRM under Windows?](https://civicrm.stackexchange.com/questions/46268/is-it-the-end-of-the-road-for-civicrm-under-windows?noredirect=1#comment55813_46268))
## Reproduction steps
1. Create an event.
2. Fill in details for two people and click Review.
3. Click Register.
4. Got a cannot write file error:
```plaintext
SmartyException: "unable to write file <Drupal root>\web\sites\default\files\civicrm\templates_c\en_GB\c3\0d\eb\c30deb6712dca60a591491c1b9b34a88872d619f_0.string.{eval var=$smartySingleUseString|smarty:nodefaults}.php"
```
5. After replacing string: with eval: in line 1040 of \`\`\`\\vendor\\civicrm\\civicrm-core\\CRM\\Utils\\String.php\`\` got
```plaintext
Civi\Crypto\Exception\CryptoException: Failed to find key by ID or tag (z6BNl0_wDYQft0x4mbQidOEKlHk) in <Drupal root>\vendor\civicrm\civicrm-core\Civi\Crypto\CryptoToken.php on line 143
```
## Current behaviour
See above. The file write error is because Windows doesn't support colons and other unusual characters in file names.
## Expected behaviour
Registration should be successful.
## Environment information
* **Browser:** _IIS_ but probably not relevant.
* **CiviCRM:** _5.71.Alpha1 but also seen in 5.69.2_ The issue in the latter is stopping us updating our live environment.
* **PHP:** \_8.3.1_\_
* **CMS:** _Drupal 10.2.2_
* **Database:** _MySQL 8.0_
* **Web Server:** _IIS 10_
## Comments
Smarty is clearly intended to support Windows as there are references to it in the code. It looks as though the syntax for smartySingleUseString requires file names that are incompatible with running under Windows, or maybe I have misunderstood something. My knowledge of the mail system doesn't readily lend itself to discovering where the encryption keys or tags should be found, but maybe somebody reading this has a better knowledge than I.
I have not cluttered the issue with the long stack traces.5.71.0https://lab.civicrm.org/dev/core/-/issues/4927unrelease regression (master) Event with no participant yet is still full2024-01-28T19:35:40Zspalmstromunrelease regression (master) Event with no participant yet is still fullOverview
----------------------------------------
If you create an event on the Demo site and attempt to register, you are told it is full, though the event is new.
Reproduction steps
----------------------------------------
1. Create a...Overview
----------------------------------------
If you create an event on the Demo site and attempt to register, you are told it is full, though the event is new.
Reproduction steps
----------------------------------------
1. Create a new event with Online Registration.
1. Attempt to register.
1. You are told the event is full.
2.
Current behaviour
----------------------------------------
You are told the event is full.
```
Expected behaviour
----------------------------------------
You should be able to register for the event.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Edge_. but probably irrelevant.
* __CiviCRM:__ _5.1.Alpha1_ The demo system.
* __PHP:__ _8.1__
* __CMS:__ _Whatever Demo is running on._
* __Database:__ _Whatever Demo uses_
* __Web Server:__ _Whatever Demo uses_
Comments
----------------------------------------
I saw this problem on the Demo system. I'm unable to investigate on my local system due to another issue that I shall be raising.5.71.0https://lab.civicrm.org/dev/core/-/issues/4918All my events say "currently full"2024-01-29T14:17:43ZDaveDAll my events say "currently full"If you don't put in any value for the max number of participants, then on the event info page it will always say the event is full.
Probably from https://github.com/civicrm/civicrm-core/pull/28984?If you don't put in any value for the max number of participants, then on the event info page it will always say the event is full.
Probably from https://github.com/civicrm/civicrm-core/pull/28984?5.71.0https://lab.civicrm.org/dev/core/-/issues/4917Contribution Radio Buttons Incorrectly add other Amount2024-01-28T22:13:07ZtreseroContribution Radio Buttons Incorrectly add other Amount## Overview
With the focus fix for Contribution (Main.tpl), there is still an issue with the Other Amount being added to the original, default amount.
The Other Amount should not be adding to the original, unchecked amount.
## Reprodu...## Overview
With the focus fix for Contribution (Main.tpl), there is still an issue with the Other Amount being added to the original, default amount.
The Other Amount should not be adding to the original, unchecked amount.
## Reproduction steps
1. Click on your public facing Contribute page, civicrm/contribute/transact/?reset=1&id=1
2. Clicked in Other Amount text box and added $20
3. This added $20 to the default amount resulting in $70 for the amount, instead of $20
## Current behaviour
## Expected behaviour
This should clear the initial amount and only show the Other Amount, and move focus to the Other Amount button.
## Environment information
* **CiviCRM:** _5.69.2_
* **PHP:** _8.1_
* **CMS:** _Wordpress_
## Comments
![Screenshot 2024-01-16 161324.png](/uploads/68f7a46cac54e4256937d6d472a868c2/Screenshot_2024-01-16_161324.png)5.70.0https://lab.civicrm.org/dev/core/-/issues/4913[PHP 8.2] mail wrongly formatted2024-01-18T02:51:14Zaydunsaidan.saunders@squiffle.uk[PHP 8.2] mail wrongly formattedOverview
----------------------------------------
When running CiviCRM on PHP8 on Linux, email can be badly formatted.
See https://civicrm.stackexchange.com/q/45782/225 for a description, analysis and fix.
Current behaviour
----------...Overview
----------------------------------------
When running CiviCRM on PHP8 on Linux, email can be badly formatted.
See https://civicrm.stackexchange.com/q/45782/225 for a description, analysis and fix.
Current behaviour
----------------------------------------
Some email headers are not correctly formatted, including the Content-Type boundary specifier. The boundary is ignored and the mail is displayed wrongly.
Solution
--------
The problem is in the Pear Mail library. ~~A [fix](https://github.com/pear/Mail/pull/24) was committed in November for the [2.0.0 release](https://github.com/pear/Mail/issues/33) but this has not yet been released.~~
Environment information
----------------------------------------
* __CiviCRM:__ _Master_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.2_5.71.0https://lab.civicrm.org/dev/core/-/issues/4912Since civicrm 5.69, "Other amount" field cannot be filled on many themes.2024-01-27T18:38:38ZChabadrichmondSince civicrm 5.69, "Other amount" field cannot be filled on many themes.## Overview
Since upgrading to 5.69 users cannot fill out the other amount field on contribution pages on many themes, I tried, Divi, Blocksy, Kadence, Astra and all have the issue, I did notice that it works on 2023 and 2024)
EDIT (@k...## Overview
Since upgrading to 5.69 users cannot fill out the other amount field on contribution pages on many themes, I tried, Divi, Blocksy, Kadence, Astra and all have the issue, I did notice that it works on 2023 and 2024)
EDIT (@kcristiano ) Not CMS specific - see https://d10-master.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=4
https://chat.civicrm.org/civicrm/pl/nbsyhud8kiyd7nutzqiqcyfhzo
* **Browser:** _any_
* **CiviCRM:** _5.69+_
* **CMS:** _Any_
Screenshot posted below
![civi other amount.gif](/uploads/b4ff148f46514ade2106c07e56d2c0b8/civi_other_amount.gif)5.69.3https://lab.civicrm.org/dev/core/-/issues/4910Create New Contact with Sub-Type Brings Up Wrong Custom Field Sets2024-01-17T21:48:17ZpbarmakCreate New Contact with Sub-Type Brings Up Wrong Custom Field SetsAs of v5.69 (maybe earlier, not sure), whenever we go to "Contacts / Create Individual / Create [specific sub-type] ... " to create one of our sub-types, the sub-type-specific custom fields do not show up. They do show up when creating j...As of v5.69 (maybe earlier, not sure), whenever we go to "Contacts / Create Individual / Create [specific sub-type] ... " to create one of our sub-types, the sub-type-specific custom fields do not show up. They do show up when creating just an Individual and then selecting the sub-type from the field, but not via the URL with the sub-type in it.
Please see the full description here: https://civicrm.stackexchange.com/questions/46210/create-new-contact-with-sub-type-brings-up-wrong-custom-field-sets5.69.3https://lab.civicrm.org/dev/core/-/issues/4904"unreachable code price set is always set here"2024-02-07T18:46:09ZDaveD"unreachable code price set is always set here"I'm trying to review https://github.com/civicrm/civicrm-core/pull/28399 - event approval isn't a workflow I use anywhere. After doing the online reg, this comes up:
`unreachable code price set is always set here - passed as a hidden fie...I'm trying to review https://github.com/civicrm/civicrm-core/pull/28399 - event approval isn't a workflow I use anywhere. After doing the online reg, this comes up:
`unreachable code price set is always set here - passed as a hidden field although we could just load... Caller: CRM_Core_Form::mainProcess`
This is with the default rainforest event but with the extra participant statuses enabled and then approval turned on for the online registration.5.71.0eileeneileenhttps://lab.civicrm.org/dev/core/-/issues/4903New Individual on-the-fly popup has `Undefined variable $cancelURL`2024-01-11T01:23:41ZDaveDNew Individual on-the-fly popup has `Undefined variable $cancelURL`This must be pretty recent, probably in master. There's a couple ways to see it. Here's one:
1. Open the browser network tab.
2. New Contribution
3. In the contact field click New Individual.
4. Note the url of the ajax call in the brow...This must be pretty recent, probably in master. There's a couple ways to see it. Here's one:
1. Open the browser network tab.
2. New Contribution
3. In the contact field click New Individual.
4. Note the url of the ajax call in the browser network tab, and remove the snippet param and then visit it in another tab: `/civicrm/profile/create?reset=1&context=dialog&gid=4&returnExtra=display_name,sort_name,email&crmAngularModules=crmResource`
5. `Warning: Undefined variable $cancelURL in CRM_Profile_Form_Edit->buildQuickForm() (line 199 of .../CRM/Profile/Form/Edit.php)`5.70.0https://lab.civicrm.org/dev/core/-/issues/4898Regression - missing getLinks fails too hard2024-01-11T22:46:52ZeileenRegression - missing getLinks fails too hardOn dmaster with civi-import enabled I can't access search kit after some importing has been done
![image](/uploads/3b3e39405088c7bf20465d031e652b50/image.png)
@colemanw I can take a look at fixing for civi-import but I think this shoul...On dmaster with civi-import enabled I can't access search kit after some importing has been done
![image](/uploads/3b3e39405088c7bf20465d031e652b50/image.png)
@colemanw I can take a look at fixing for civi-import but I think this should degrade more gracefull5.70.0https://lab.civicrm.org/dev/core/-/issues/4893No event registration confirmation email sent for free events2024-01-12T04:49:21ZBobSNo event registration confirmation email sent for free events## Overview
Upon registering for a free event, no confirmation email is sent.
## Reproduction steps
1. Register for an event configured with `Paid Event` = No and `Send Confirmation Email` = Yes.
## Current behaviour
No confirmation...## Overview
Upon registering for a free event, no confirmation email is sent.
## Reproduction steps
1. Register for an event configured with `Paid Event` = No and `Send Confirmation Email` = Yes.
## Current behaviour
No confirmation email is sent.
## Expected behaviour
A confirmation email is sent.
## Environment information
**CiviCRM:** _5.69.1_
## Comments
Regression introduced by https://github.com/civicrm/civicrm-core/commit/36723fe908973f72dc5cd57a249ee236fcfec868
Specifically, the Issue is caused by a change to CRM_Event_Form_Registration::processRegistration:
* From: `if ($this->_contributeMode != 'checkout' || $this->_contributeMode != 'notify')`
* To: `if ($this->getPaymentProcessorObject()->supports('noReturn'))`
This returns FALSE if there is no payment processor, causing the email to not be sent.5.69.2https://lab.civicrm.org/dev/core/-/issues/4892[PHP 8.1] Weight notices @ Import/Export Mappings2024-01-12T04:49:22Zjofranzfranz@systopia.de[PHP 8.1] Weight notices @ Import/Export MappingsSame as #4891
Here needs to be data to see it: https://dmaster.demo.civicrm.org/civicrm/admin/mapping?reset=1
_systopia reference: 23444_Same as #4891
Here needs to be data to see it: https://dmaster.demo.civicrm.org/civicrm/admin/mapping?reset=1
_systopia reference: 23444_5.69.2https://lab.civicrm.org/dev/core/-/issues/4889deleted-files-list needs some fine-tuning2024-02-21T03:00:39ZDaveDdeleted-files-list needs some fine-tuningI tried updating it after the case_activity [workflow PR](https://github.com/civicrm/civicrm-core/pull/28800) using the script, because the status check is now saying "old files", but the output seemed off. But it's because the 5.70 bran...I tried updating it after the case_activity [workflow PR](https://github.com/civicrm/civicrm-core/pull/28800) using the script, because the status check is now saying "old files", but the output seemed off. But it's because the 5.70 branching made some changes that don't make sense: https://github.com/civicrm/civicrm-core/commit/0524dba18c932062c431d3f337506c7ad2ca80a1#diff-41b67b01f75a3da4825936805e68a5ee46f7b883e7b2bfd85766a181a6562ea3R154
And we've seen before that the `tools/extensions/phpstorm/.phpstorm.meta.php` line is a false-positive if you don't have that extension installed, which I'm guessing only 2 people do.
As a general comment I'm not crazy about the concept behind the deleted-list file. I'm not familiar with joomla but can't joomla admins just delete the folder before upgrade the same way everyone else does? The docs even suggest it as a troubleshooting step, so it must be doable?
Technically a regression, but not the same as usual.
FYI @colemanw5.71.0https://lab.civicrm.org/dev/core/-/issues/4886[5.68.1] Smarty3 fails to render contacts import summary page2024-01-05T05:36:10ZDmitry Smirnov[5.68.1] Smarty3 fails to render contacts import summary pageOn 5.68.1, contact imports created new contacts successfully (as expected) but Smarty3 failed to render import summary page in the end (showing "critical error" after import progress):
```
PHP Deprecated: Creation of dynamic property S...On 5.68.1, contact imports created new contacts successfully (as expected) but Smarty3 failed to render import summary page in the end (showing "critical error" after import progress):
```
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$assignByRef is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$_foreach is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Variable::$do_else is deprecated in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/ea/e9/36/eae936c43239450b358ccf951825467f837bd49a_0.file.CMSPrint.tpl.php on line 47
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiler is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$_codeFrame is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$_filterHandler is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getLiterals is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$addLiterals is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$setLiterals is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$getTemplateVars is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Extension_Handler::$_writeFile is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_extension_handler.php on line 182
PHP Deprecated: Creation of dynamic property Smarty_Internal_Template::$compiled is deprecated in /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php on line 719
PHP Deprecated: Creation of dynamic property Smarty_Variable::$do_else is deprecated in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/97/37/f0/9737f0315707fe307f61433aafb3cf128d36ad32_0.file.Summary.tpl.php on line 328
PHP Warning: Array to string conversion in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/97/37/f0/9737f0315707fe307f61433aafb3cf128d36ad32_0.file.Summary.tpl.php on line 354
PHP Deprecated: Creation of dynamic property Smarty_Variable::$do_else is deprecated in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/97/37/f0/9737f0315707fe307f61433aafb3cf128d36ad32_0.file.Summary.tpl.php on line 355
PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/97/37/f0/9737f0315707fe307f61433aafb3cf128d36ad32_0.file.Summary.tpl.php:359
Stack trace:
#0 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_6596ac2030b090_68456159()
#1 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#2 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render()
#3 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(385): Smarty_Internal_Template->render()
#4 /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/cf/b0/8e/cfb08ecadba5e8b29bf41e9aae04d99380f0a23d_0.file.default.tpl.php(53): Smarty_Internal_Template->_subTemplateRender()
#5 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_6596abd7042ff2_38540251()
#6 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#7 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render()
#8 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(385): Smarty_Internal_Template->render()
#9 /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/ea/e9/36/eae936c43239450b358ccf951825467f837bd49a_0.file.CMSPrint.tpl.php(100): Smarty_Internal_Template->_subTemplateRender()
#10 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_6596abd701e460_46797449()
#11 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#12 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render()
#13 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(385): Smarty_Internal_Template->render()
#14 /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/9c/3f/c1/9c3fc145555d7a857fab0827e120d82b83d12571_0.file.wordpress.tpl.php(31): Smarty_Internal_Template->_subTemplateRender()
#15 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_6596abd7001831_48089199()
#16 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#17 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled->render()
#18 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(232): Smarty_Internal_Template->render()
#19 /usr/share/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(116): Smarty_Internal_TemplateBase->_execute()
#20 /usr/share/civicrm/CRM/Core/QuickForm/Action/Display.php(117): Smarty_Internal_TemplateBase->fetch()
#21 /usr/share/civicrm/CRM/Core/QuickForm/Action/Display.php(83): CRM_Core_QuickForm_Action_Display->renderForm()
#22 /usr/share/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform()
#23 /usr/share/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle()
#24 /usr/share/civicrm/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle()
#25 /usr/share/civicrm/CRM/Utils/Wrapper.php(98): CRM_Core_Controller->run()
#26 /usr/share/civicrm/CRM/Core/Invoke.php(292): CRM_Utils_Wrapper->run()
#27 /usr/share/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#28 /usr/share/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#29 /usr/share/wordpress/wp-content/plugins/civicrm/civicrm.php(1201): CRM_Core_Invoke::invoke()
#30 /usr/share/wordpress/wp-includes/class-wp-hook.php(308): CiviCRM_For_WordPress->invoke()
#31 /usr/share/wordpress/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters()
#32 /usr/share/wordpress/wp-includes/plugin.php(517): WP_Hook->do_action()
#33 /usr/share/wordpress/wp-admin/admin.php(259): do_action()
#34 {main}
thrown in /var/lib/wordpress/wordpress.deblab/uploads/civicrm/templates_c/en_AU/97/37/f0/9737f0315707fe307f61433aafb3cf128d36ad32_0.file.Summary.tpl.php on line 359
```
This is on Debian 12 "Bookworm" with PHP-8.2. (CiviCRM caches cleared before reproducing.)
There is no error with Smarty2.5.69.0https://lab.civicrm.org/dev/core/-/issues/4884"CiviCRM News" on Backdrop has awkward accordions on default themes2024-01-04T22:21:56Ztotten"CiviCRM News" on Backdrop has awkward accordions on default themesOn Backdrop (eg https://bmaster.demo.civicrm.org/civicrm/ ; user: `demo`; pass: `demo`) with default themes, the "CiviCRM News" dashlet is looking weird:
![Screenshot_2024-01-03_at_9.08.21_PM](/uploads/8d22ff7703e5f9eaf856a9e413be66dd/...On Backdrop (eg https://bmaster.demo.civicrm.org/civicrm/ ; user: `demo`; pass: `demo`) with default themes, the "CiviCRM News" dashlet is looking weird:
![Screenshot_2024-01-03_at_9.08.21_PM](/uploads/8d22ff7703e5f9eaf856a9e413be66dd/Screenshot_2024-01-03_at_9.08.21_PM.png)
Theories:
* At first blush, it feels like it would be a regression related to the accordion updates circa 5.69.x (eg https://lab.civicrm.org/dev/user-interface/-/issues/60). However, there's a similar problem in 5.68. This suggests that it's not a simple regression:
![Screenshot_2024-01-03_at_10.21.14_PM](/uploads/ebe6ad88b770ba5337a965cc887d194b/Screenshot_2024-01-03_at_10.21.14_PM.png)
(Note: Slightly different visual appearance with double arrows)
* Could it be that there's always been a bug like this.
* Could it be that the accordion cleanup led to changes in the news feed? In which case, maybe the question is about infra: How to make the feed(s) work with different versions of Civi?
* Interestingly, I went to an old/local copy of `bcmaster`, updated to 5.68+5.69+master, and... it seemed to display fine. But on clean builds of 5.68 and master, it didn't. (This suggests that it might still be some kind of regression.)
* (*It could be that I have a cache of an older feed? This might support the idea of an issue in how the feed works with different client environments?*)5.69.0https://lab.civicrm.org/dev/core/-/issues/4883[5.68.1] pre-minified source-less file: "bower_components/es-module-shims/dis...2024-01-29T10:13:51ZDmitry Smirnov[5.68.1] pre-minified source-less file: "bower_components/es-module-shims/dist/es-module-shims.js"`bower_components/es-module-shims/dist/es-module-shims.js` is bundled in pre-minified source-less form, which is bad practice.
Please bundle original un-compressed/un-obfuscated source, readable and modifiable by humans.
It looks like ...`bower_components/es-module-shims/dist/es-module-shims.js` is bundled in pre-minified source-less form, which is bad practice.
Please bundle original un-compressed/un-obfuscated source, readable and modifiable by humans.
It looks like bundling the following file should suffice: https://github.com/guybedford/es-module-shims/blob/1.7.2/src/es-module-shims.js
Thanks.5.70.0