CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2019-01-03T00:27:11Zhttps://lab.civicrm.org/dev/core/-/issues/619Custom field of type contact reference stopped working2019-01-03T00:27:11ZPradeep Nayakpradpnayak@gmail.comCustom field of type contact reference stopped workingCustom field of type contact reference stopped working for address field when upgraded to 5.8.1 from 4.7.31
The commit that might have caused this break is https://github.com/civicrm/civicrm-core/pull/12790/files#diff-bdea9a3ec62827e6c9...Custom field of type contact reference stopped working for address field when upgraded to 5.8.1 from 4.7.31
The commit that might have caused this break is https://github.com/civicrm/civicrm-core/pull/12790/files#diff-bdea9a3ec62827e6c90a70202ea9f7ccL1066
![Screen_Shot_2018-12-22_at_23.25.10](/uploads/0b37ef9862869048426f122485447c15/Screen_Shot_2018-12-22_at_23.25.10.png)5.9https://lab.civicrm.org/dev/core/-/issues/615PHP 7.2 compatibility: PHP warnings for improper usage of count()2018-12-19T20:02:57ZjensschuppePHP 7.2 compatibility: PHP warnings for improper usage of count()#118 took care of some of those warnings, but seems to have missed Smarty template code, which yields those warnings in the rendered PHP templates in templates_c.
An example: Line 20 in CRM/Contribute/Form/Contribution/OnBehalfOf.tpl:
...#118 took care of some of those warnings, but seems to have missed Smarty template code, which yields those warnings in the rendered PHP templates in templates_c.
An example: Line 20 in CRM/Contribute/Form/Contribution/OnBehalfOf.tpl:
```smarty
{if $onBehalfOfFields|@count}
```5.9https://lab.civicrm.org/dev/core/-/issues/606Wrong redirection when view/editing Option Groups inside a modal2018-12-18T20:26:39ZDavi AlexandreWrong redirection when view/editing Option Groups inside a modalThis seems like a regression caused by #259.
Before it, when opening the Option Group page via a modal, the behavior of clicking the "Done" button was to just close the modal so that people could continue filling the form:
![541](/uplo...This seems like a regression caused by #259.
Before it, when opening the Option Group page via a modal, the behavior of clicking the "Done" button was to just close the modal so that people could continue filling the form:
![541](/uploads/a1be12ccd111ef1c8a5926a6f0b3235c/541.gif)
After it, when clicking the "Done" button, the user is now redirected to the Option Groups page and lose all the data they might have already entered:
![581](/uploads/81741dc567d72fb1d583c43b045e7007/581.gif)5.9https://lab.civicrm.org/dev/core/-/issues/3610Jira Issue CRM-21666 still exists in 5.8.12022-06-11T14:56:07ZjeffmikelsJira Issue CRM-21666 still exists in 5.8.1https://issues.civicrm.org/jira/browse/CRM-21666
CRM/Mailing/DAO/Mailing.php
and
CRM/Mailing/BAO/Mailing.php
still have a discrepancy regarding the naming of the mailing_date field
messageNotice: Undefined property: CRM_Mailing_BAO...https://issues.civicrm.org/jira/browse/CRM-21666
CRM/Mailing/DAO/Mailing.php
and
CRM/Mailing/BAO/Mailing.php
still have a discrepancy regarding the naming of the mailing_date field
messageNotice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report()5.9https://lab.civicrm.org/dev/core/-/issues/594WYSIWYG Editor affected in CiviCRM 5.8.02018-12-28T08:55:55Zvakeesan26WYSIWYG Editor affected in CiviCRM 5.8.0After changing Display preference Wysiwig Editor setting from Text-Area to CKEditor
the editor not loaded anywhere.
Also the Configure CKEditor button is not visible in display preference page.
![image](/uploads/bf12c40db9672e5b0ad876...After changing Display preference Wysiwig Editor setting from Text-Area to CKEditor
the editor not loaded anywhere.
Also the Configure CKEditor button is not visible in display preference page.
![image](/uploads/bf12c40db9672e5b0ad8767f211260e7/image.png)
**New Activity**
![image](/uploads/ba87691aaab34031a6f363e7a6136fc2/image.png)
**Manage Events**
![image](/uploads/c74efdd95f623d4eac15fd7735e350a1/image.png)5.9https://lab.civicrm.org/dev/core/-/issues/563Duplicate Case manager role2018-12-05T10:41:12ZMonish DebDuplicate Case manager roleSteps to replicate:
1. Create case
2. Go to 'Manage case' and change case manager to someone else
3. Change case manager back to original contact: error - duplicate relationship
4. From the contact's relationship tab, enable a relationsh...Steps to replicate:
1. Create case
2. Go to 'Manage case' and change case manager to someone else
3. Change case manager back to original contact: error - duplicate relationship
4. From the contact's relationship tab, enable a relationship
-- note that the end date is preserved, which may mean that the newly re-enabled relationship is still considered inactive
-- note that in the manage case roles panel the newly re-enabled relationship is not listed as the case manager
5. From the manage case roles panel, add a new role with the same case manager type, to one of the existing contacts: error, duplicate relationship
-- so if you change the case manager, there's currently no way to go back and set the original contact as case manager again5.9Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/551Bookkeeping Transactions Report insufficient permissions2018-11-28T20:33:36ZfrancescbassasBookkeeping Transactions Report insufficient permissionsWhen a user without administer_civicrm permission try to run the Bookeeping Transactions Report finds the following error comes up:
`"API permission check failed for FinancialAccount/get call;
insufficient permission: require administe...When a user without administer_civicrm permission try to run the Bookeeping Transactions Report finds the following error comes up:
`"API permission check failed for FinancialAccount/get call;
insufficient permission: require administer CiviCRM"`
As noted [here](https://civicrm.stackexchange.com/q/23135/104), it seems that it occurs at least since version 4.29.5.9https://lab.civicrm.org/dev/core/-/issues/539Create a hook for custom relative date filters (CRM-16195)2024-03-25T15:18:49ZJonGoldCreate a hook for custom relative date filters (CRM-16195)To summarize: From the time relative date filters debuted in 4.2(?) until 4.7, each release added a number of relative date filters that one person needed and the rest of the world didn't. To prevent this happening forever, we moved rel...To summarize: From the time relative date filters debuted in 4.2(?) until 4.7, each release added a number of relative date filters that one person needed and the rest of the world didn't. To prevent this happening forever, we moved relative dates into an OptionGroup, and intended to give the ability to create new ones.
I worked on this last year but some cleanup PRs got stalled. They're all merged now so I'm submitting this.
While @eileen did work recently to support relative dates like "32 months in the past", it's still not possible to do relative dates like, "from 6 months ago to the end of this year", or "from Thanksgiving to Christmas". A former client of mine had reports that went from October to September, but this was NOT their fiscal year.
A simple hook facilitates the creation of custom relative date filters. I'll submit tests, but you can see an extension that uses it here: https://github.com/MegaphoneJon/com.megaphonetech.relativedatetest5.9JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/532Multi-select field not respected in batch search2018-12-10T17:15:43ZPradeep Nayakpradpnayak@gmail.comMulti-select field not respected in batch searchThe "Search by Financial Type" is a multi-select, but if you try to search by multiple values it fails validation (see screenshot 653 attached).
![Selection_653](/uploads/a61c238371a509c511a625d116d56413/Selection_653.png)
PR:https://...The "Search by Financial Type" is a multi-select, but if you try to search by multiple values it fails validation (see screenshot 653 attached).
![Selection_653](/uploads/a61c238371a509c511a625d116d56413/Selection_653.png)
PR:https://github.com/civicrm/civicrm-core/pull/131215.9https://lab.civicrm.org/dev/core/-/issues/528Advanced Search -> Contribution Tab and Contribution Dashboard returns a fata...2018-11-17T02:37:46ZjitendraAdvanced Search -> Contribution Tab and Contribution Dashboard returns a fatal error.On Dmaster
https://dmaster.demo.civicrm.org/civicrm/contact/search/advanced?reset=1 -> Expanding the contribution div section displays a network error
![image](/uploads/1fe2c8909315b51ebded571fcb0d023d/image.png)
Similarly, Contributi...On Dmaster
https://dmaster.demo.civicrm.org/civicrm/contact/search/advanced?reset=1 -> Expanding the contribution div section displays a network error
![image](/uploads/1fe2c8909315b51ebded571fcb0d023d/image.png)
Similarly, Contribution Dashboard returns a fatal error - https://dmaster.demo.civicrm.org/civicrm/contribute?reset=15.9jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/526Feedback cannot be translated when saving Contribution Page forms in language...2018-11-15T19:32:34ZhaystackFeedback cannot be translated when saving Contribution Page forms in languages other than EnglishWhen saving forms to configure a Contribution Page in languages other than English, the feedback given is not translated or translatable.
Example below (FWIW that's the CiviCRM Admin Utilities theme):
![Screen_Shot_2018-11-15_at_12.37....When saving forms to configure a Contribution Page in languages other than English, the feedback given is not translated or translatable.
Example below (FWIW that's the CiviCRM Admin Utilities theme):
![Screen_Shot_2018-11-15_at_12.37.55](/uploads/a7b2bf0762d271e82c595b4bdc490a16/Screen_Shot_2018-11-15_at_12.37.55.png)
This can be rectified by applying [the same logic as exists for Event Management forms](https://github.com/civicrm/civicrm-core/blob/master/CRM/Event/Form/ManageEvent.php#L376-L378).5.9https://lab.civicrm.org/dev/core/-/issues/525Extraneous br-tags in rendered note-fields2018-11-16T00:44:05Zthomas_SYSTOPIAExtraneous br-tags in rendered note-fieldsHow to reproduce on a fresh 5.7er CiviCRM:
* Create a contact-inline-custom-group and a note-field with a TextArea- or a RichTextEditor-FieldType.
* Save this field with a multiline text on an arbitrary Contact.
You may see all linebrea...How to reproduce on a fresh 5.7er CiviCRM:
* Create a contact-inline-custom-group and a note-field with a TextArea- or a RichTextEditor-FieldType.
* Save this field with a multiline text on an arbitrary Contact.
You may see all linebreaks displayed doubly.5.9https://lab.civicrm.org/dev/core/-/issues/518Lybunt performance improvement2019-02-19T04:55:07ZeileenLybunt performance improvementA couple of years back I did some work on the performance of the Lybunt report https://issues.civicrm.org/jira/browse/CRM-17837 which succeeded in improving the query enough that it would run for prior years there is still an exponential...A couple of years back I did some work on the performance of the Lybunt report https://issues.civicrm.org/jira/browse/CRM-17837 which succeeded in improving the query enough that it would run for prior years there is still an exponential inefficiency in the query which means that 2 years later & some large number of donations later we are back to it not running.
The current query is
```
CREATE TEMPORARY TABLE civicrm_tmp_e_rptlybunt_20181114_5beb5dc8d8e46 DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci
SELECT SQL_CALC_FOUND_ROWS contact_civireport.id as cid FROM civicrm_tmp_e_rptgrp_20181114_5beb5dc8d1b4b group_temp_table INNER JOIN civicrm_contact contact_civireport
ON group_temp_table.id = contact_civireport.id INNER JOIN civicrm_contribution contribution_civireport ON contribution_civireport.contact_id = contact_civireport.id
AND contribution_civireport.is_test = 0
AND contribution_civireport.receive_date BETWEEN '20170101000000' AND '20171231235959'
LEFT JOIN civicrm_contribution cont_exclude ON cont_exclude.contact_id = contact_civireport.id
AND cont_exclude.receive_date BETWEEN '2018-01-01' AND '20181231235959' WHERE cont_exclude.id IS NULL AND 1 AND 1
GROUP BY contact_civireport.id;
```
and it takes 394 seconds
to return only a few hundred rows (the group has only 730 contacts).
Playing around I was able to reduce this time to .24 second by re-writing the query as
```
SELECT SQL_CALC_FOUND_ROWS contact_civireport.id as cid
FROM civicrm_tmp_d_dflt_3b5e17ad9138b8cc56282f75b2967e9e group_temp_table INNER JOIN civicrm_contact contact_civireport
ON group_temp_table.id = contact_civireport.id
WHERE group_temp_table.id IN
(
SELECT group_temp_table.id FROM civicrm_tmp_d_dflt_3b5e17ad9138b8cc56282f75b2967e9e group_temp_table
INNER JOIN civicrm_contribution contribution_civireport ON contribution_civireport.contact_id = group_temp_table.id
AND contribution_civireport.is_test = 0
AND contribution_civireport.receive_date BETWEEN '20170101000000' AND '20171231235959'
)
AND group_temp_table.id IN
(
SELECT group_temp_table.id FROM civicrm_tmp_d_dflt_3b5e17ad9138b8cc56282f75b2967e9e group_temp_table LEFT JOIN
civicrm_contribution cont_exclude ON cont_exclude.contact_id = group_temp_table.id
AND cont_exclude.receive_date BETWEEN '2018-01-01' AND '20181231235959'
WHERE cont_exclude.id IS NULL
)
GROUP BY contact_civireport.id;
```
I experimented on our staging site on running the query on our WHOLE data base (ie. without the group constraint) and it completed in 720 seconds - which is outrageously good really since that legitimately queries a LOT of records.
I'm going to look at how to fix up the LYBUNT report to use the above query. There are already some tests from last time I worked on performance on this report.5.9https://lab.civicrm.org/dev/core/-/issues/513Contribution Transact API - Use the payment processor payment method instead ...2018-11-11T00:10:14Zomar_compucorpContribution Transact API - Use the payment processor payment method instead of the payment_type field## Problem
When using the Contribution.Transact API, CiviCRM will either change the payment instrument to "Credit Card" or "Debit Card" based on the the value of payment_type field.
## How should it work
This is wrong and the payment...## Problem
When using the Contribution.Transact API, CiviCRM will either change the payment instrument to "Credit Card" or "Debit Card" based on the the value of payment_type field.
## How should it work
This is wrong and the payment instrument type should be taken form the used payment processor payment_instrument_id field.5.9https://lab.civicrm.org/dev/core/-/issues/511Membership Dashboard shows incorrect month2018-11-09T22:11:45Zaydunsaidan.saunders@squiffle.ukMembership Dashboard shows incorrect month![Screenshot_from_2018-11-08_11-56-38](/uploads/1778dee40d7c1e2aa1ecfdb9c80a362a/Screenshot_from_2018-11-08_11-56-38.png)
Last month = October - correct
This month = April - incorrect. Should be November
This problem was introduced i...![Screenshot_from_2018-11-08_11-56-38](/uploads/1778dee40d7c1e2aa1ecfdb9c80a362a/Screenshot_from_2018-11-08_11-56-38.png)
Last month = October - correct
This month = April - incorrect. Should be November
This problem was introduced in 4.7.23-rc5.9aydunsaidan.saunders@squiffle.ukaydunsaidan.saunders@squiffle.ukhttps://lab.civicrm.org/dev/core/-/issues/505Allow for Extensions to set the CRM Type and PHP Type when dealing with unusu...2018-11-29T10:05:35ZseamusleeAllow for Extensions to set the CRM Type and PHP Type when dealing with unusual MySQL TypesAt present the type specified in the DAO when your dealing with an unusual MySQL type is set by whatever is the column type however there may not be that CRM_Utils_Type:: defined var for it so sometimes an extension may want to set it so...At present the type specified in the DAO when your dealing with an unusual MySQL type is set by whatever is the column type however there may not be that CRM_Utils_Type:: defined var for it so sometimes an extension may want to set it so that the DAO can operate sensibly5.9https://lab.civicrm.org/dev/core/-/issues/503Editing Rich Text custom field on relationship non-functional2018-11-13T03:11:11ZmclarkeEditing Rich Text custom field on relationship non-functional## Summary
Editing a Note/RichTextEditor custom field on a relationship causes the HTML tags to be encoded into the content. Each time you edit the field the tags get literally added to the content, piling up.
## Steps to Reproduce
- ad...## Summary
Editing a Note/RichTextEditor custom field on a relationship causes the HTML tags to be encoded into the content. Each time you edit the field the tags get literally added to the content, piling up.
## Steps to Reproduce
- add a custom field set on relationships
- add a custom field to the set of type Note->Rich Text Editor
- add a relevant relationship to a contact, put in any content to the rich field, save
- re-edit the relationship
- note that the paragraph tags are rendered into the rich editor as literals
- rinse, repeat to see the tags continue to pile up
[Screenshot_2018-11-02_14.15.10](/uploads/1e3e5bc6158cf32813ce73dade0b25a8/Screenshot_2018-11-02_14.15.10.png)5.9https://lab.civicrm.org/dev/core/-/issues/498Undefined index in mailing report for mailing_modified_date; and room for ref...2018-12-14T23:17:06ZJKingsnorthUndefined index in mailing report for mailing_modified_date; and room for refactoringNotice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on ...Notice: Undefined property: CRM_Mailing_BAO_Mailing::$mailing_modified_date in CRM_Mailing_BAO_Mailing::report() (line 1821 of /home/developer/buildkit/build/civicrmdev/sites/all/modules/civicrm/CRM/Mailing/BAO/Mailing.php).
Appears on pages like: /civicrm/mailing/report?mid=7&reset=1
This is because the DAO key for the field is 'mailing_modified_date' - but the name is 'modified_date'.
And the way the field values are assigned to the object does not account for this difference.
This is a very minor issue as the modified date doesn't actually get used in the report!
We should probably refactor the query/code to only load the fields we're actually interested in; and get rid of the raw SQL in the file at the same time: https://github.com/civicrm/civicrm-core/blob/f87c35c7308fc6876e1a4fea8ac3ea908d3d9453/CRM/Mailing/BAO/Mailing.php#L18075.9https://lab.civicrm.org/dev/core/-/issues/467Case Start Date and End Date don't work properly in Batch Update2018-11-15T11:18:29ZRayWrightCase Start Date and End Date don't work properly in Batch UpdateWhen trying to batch update a case start date or end date you get the following error: Notice: Undefined index: formatType in CRM_Utils_Date::addDateMetadataToField() (line 1878 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/C...When trying to batch update a case start date or end date you get the following error: Notice: Undefined index: formatType in CRM_Utils_Date::addDateMetadataToField() (line 1878 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Utils/Date.php).
This results in
Start Date: the current date being filled into all values
End Date: if it's not already filled in, you can only select today's date.5.9https://lab.civicrm.org/dev/core/-/issues/442Misc form issues2018-12-08T21:12:48ZAkA84Misc form issuesFound a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (`v5.8.alpha1`)
## Wrong layout in "...Found a handful of form-related issues that are pretty quick to fix, just wanted to have the green light on them before opening the PR. All screenshots are taken from https://dmaster.demo.civicrm.org (`v5.8.alpha1`)
## Wrong layout in "Tags and Groups" accordion of "New Individual" form
The "Tag(s)" label+select group is missing a `<br>`
*Before*
![tags-before](/uploads/69da499d7792714de2dcf417981cfab7/tags-before.png)
*After*
![tags-after](/uploads/1fc640e4a276e0e0e6b7d70917d7337a/tags-after.png)
## Missing class on text fields in "Dedupe exceptions"
The input fields are missing the standard `crm-form-text class
*Before*
![dedupe-before](/uploads/0861f7c3c98f5b0a8a722b98a858fe92/dedupe-before.png)
*After*
![dedupe-after](/uploads/ca670378bf85ed8b3b8d8caba04764d4/dedupe-after.png)
## Wrong class on `<select>`s in "Submit Credit Card Contribution" modal
The <select> elements have the wrong class: `crm-form-date`
![contribute-select-before](/uploads/09ec405fac0bac56fe5c5cd10db1589f/contribute-select-before.png)
Applying the correct class, `crm-form-select` doesn't change much, but allows Shoreditch to style the selects correctly
![contribute-select-after](/uploads/3fd8125dcae0301d83381e329f543a3e/contribute-select-after.png)
## Textareas instead of text input in "Word Replacements" form
This one I'm not really sure is really a markup error, but it looks to me that instead of `<textarea>` elements, the form would benefit by using `input[type="text"]` fields instead (see how the checkboxes get a vertical alignment, for example)
*Before*
![replacement-before](/uploads/47d5a07307d2bb2d2a19850626ad8ee3/replacement-before.png)
*After*
![replacement-after](/uploads/362b5b8591a1171121562e31ca46dded/replacement-after.png)5.9