CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-08-02T09:25:10Zhttps://lab.civicrm.org/dev/core/-/issues/296api - CustomValue::get - return multiple fields fails via api explorer2018-08-02T09:25:10Ztschuettlerapi - CustomValue::get - return multiple fields fails via api explorerThe API call fails with error message when using the api explorer:
![image](/uploads/142b60a1551c11bf34f32b47bd9ae42e/image.png)
```
{
"is_error": 1,
"error_message": "'name' specified in OR group but not added to params"
}
```...The API call fails with error message when using the api explorer:
![image](/uploads/142b60a1551c11bf34f32b47bd9ae42e/image.png)
```
{
"is_error": 1,
"error_message": "'name' specified in OR group but not added to params"
}
```
The generated PHP-Code however does produces the expected results.https://lab.civicrm.org/dev/core/-/issues/245Duplicate activities shown on case tab2018-08-06T21:11:10Zmattwiremjw@mjwconsult.co.ukDuplicate activities shown on case tabWhen a case activity has multiple target/assignee contacts they appear as duplicates on the case activities tab.
Additionally, during investigation it was identified that the link to edit an activity which is only allowed once for a cas...When a case activity has multiple target/assignee contacts they appear as duplicates on the case activities tab.
Additionally, during investigation it was identified that the link to edit an activity which is only allowed once for a case contains the value "data" instead of the activity ID and hence does not work.
In this screenshot, this is the same activity (you can see the target contact is different):
![localhost_8000_civicrm_duplicatecases](/uploads/a1350fa7d94ea867acc4af7faeeca841/localhost_8000_civicrm_duplicatecases.png)
PR: https://github.com/civicrm/civicrm-core/pull/124445.6https://lab.civicrm.org/dev/core/-/issues/273"Recipient phone number is invalid or recipient does not want to receive SMS"...2018-08-18T21:44:11Zjyothi"Recipient phone number is invalid or recipient does not want to receive SMS" error and Contacts with DoNotSms preference failing to filter out during Mass Sms in 5.x"Recipient phone number is invalid or recipient does not want to receive SMS" error occurs during individual SMS. https://civicrm.stackexchange.com/questions/25478/clickatell-sms-recipient-phone-number-is-invalid-or-recipient-does-not-wa..."Recipient phone number is invalid or recipient does not want to receive SMS" error occurs during individual SMS. https://civicrm.stackexchange.com/questions/25478/clickatell-sms-recipient-phone-number-is-invalid-or-recipient-does-not-want-to.
Contacts marked as 'donotsms' is not filtered out during mass SMS.5.5.0https://lab.civicrm.org/dev/core/-/issues/226use decimal point from config to fix european numbers format2018-08-19T22:52:39Zsuniluse decimal point from config to fix european numbers formatFormat Amount using hardcoded decimal point, which is not fit for european format.Format Amount using hardcoded decimal point, which is not fit for european format.5.6https://lab.civicrm.org/dev/core/-/issues/295Default 'from' mail address is not the default one showing in 'send email'2018-08-27T11:18:09ZjitendraDefault 'from' mail address is not the default one showing in 'send email'SE Post - https://civicrm.stackexchange.com/questions/25562/why-does-the-default-from-email-address-not-show-as-the-first-option-when-usin
If I add a second email address to the list of "from" emails at /civicrm/admin/options/from_email...SE Post - https://civicrm.stackexchange.com/questions/25562/why-does-the-default-from-email-address-not-show-as-the-first-option-when-usin
If I add a second email address to the list of "from" emails at /civicrm/admin/options/from_email_address?reset=1 and set it to default, i expect it to be selected as the first option when using "Send an Email' but it continues to be the second in the list.
If i change the Order of the From emails so my default is first, it continues to show as the second when using "Send an Email' (though perhaps a clear of caches would fix it, but fundamentally something seems wrong here.jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/297permission "access my cases and activities" is broken by CRM-214612018-08-28T01:29:10ZDaveDpermission "access my cases and activities" is broken by CRM-21461See https://civicrm.stackexchange.com/questions/25950/problem-with-civicase. CRM_Case_BAO_Case::getCases() used to return a list keyed on case_id. Now it returns a sequentially keyed list. I'm not sure if anything new is depending on the...See https://civicrm.stackexchange.com/questions/25950/problem-with-civicase. CRM_Case_BAO_Case::getCases() used to return a list keyed on case_id. Now it returns a sequentially keyed list. I'm not sure if anything new is depending on the new keys, but since that seems unlikely, replacing "$key" with "$case['case_id']" around line 680 and later instances would fix this?https://lab.civicrm.org/dev/core/-/issues/349Scheduled reminders list default sort does not work2018-08-28T11:11:10Zmagnolia61Scheduled reminders list default sort does not workThe Scheduled Reminder list default sort does not work because of a small typo.
This PR corrects that.The Scheduled Reminder list default sort does not work because of a small typo.
This PR corrects that.5.6https://lab.civicrm.org/dev/core/-/issues/352Ensure that when adding recipients of previous mailings that contacts who are...2018-08-28T21:41:11ZseamusleeEnsure that when adding recipients of previous mailings that contacts who are being excluded are removedAt present in the mailing code base when adding in recipients or a previous mailing there is no checking to ensure that contacts that are to be excluded are properly excludedAt present in the mailing code base when adding in recipients or a previous mailing there is no checking to ensure that contacts that are to be excluded are properly excluded5.6seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/325Fatal error 'DB Error: no such field' on Contribution detail report2018-08-28T21:55:40ZPradeep Nayakpradpnayak@gmail.comFatal error 'DB Error: no such field' on Contribution detail report![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/12660![before-patch](/uploads/a1f168c003724bf724eb8e4c0998e54c/before-patch.gif)
PR: https://github.com/civicrm/civicrm-core/pull/126605.6https://lab.civicrm.org/dev/core/-/issues/367Fatal error / SQL timeout in A-Z pager for advanced search by relationship wi...2018-08-29T14:26:22ZAllenShawFatal error / SQL timeout in A-Z pager for advanced search by relationship with target group for reciprocal relationship typesPull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site h...Pull request: https://github.com/civicrm/civicrm-core/pull/12740
Similar issue but not directly related: https://issues.civicrm.org/jira/browse/CRM-21811
On many sites, this is not an issue, but the more "spouse" relationships a site has, the more likely it happens (and not just spouse; this applies for "partner of" and any other reciprocally named relationship type).
**Steps to reproduce:**
1. Start with a site having:
1. Several thousand active relationships of a reciprocal type (where the name for both related positions is the same – e.g., "spouse of" <=> "spouse of"; "sibling of" <=> "sibling of"; "partner of" <=> "partner of"). This recipe uses "Spouse of".
1. At least one group (smart group or static group).
1. Perform an Advanced Search with these criteria:
1. Relationships > Relationship Type: "Spouse of"
1. Relationships > Target Contact(s) in Group: [any one or more groups]
1. Submit the search form and observe a very long page load; depending on the number of relationships, server configuration, and server resources, this search may end in a WSOD, or take dozens of minutes to complete.
**Analysis:**
* When this actually times out, you get a fatal error from MySQL: "Query execution was interrupted (max_statement_time exceeded)"
* Backtrace indicates that the long-running query is the one used to generate the A-Z pager controls in search results; this query includes as join to a temporary table which is created without indices.
**Proposed solution:**
Add indices and column definitions to the temporary table, so that the join can use the indices and run in a timely manner.5.6https://lab.civicrm.org/dev/core/-/issues/343Long lines in contact name or address overflow mailing labels2018-08-30T12:07:06ZAndrew ThompsonLong lines in contact name or address overflow mailing labelsIf very long lines (long enough to wrap to next line) are present in the address or addressee, PDF mailing labels will overflow the right boundary of the label. This is due to the code not subtracting the left & right padding from the wi...If very long lines (long enough to wrap to next line) are present in the address or addressee, PDF mailing labels will overflow the right boundary of the label. This is due to the code not subtracting the left & right padding from the width.
PR coming soon.
Steps to reproduce:
1. Create a contact with a name and/or street address long enough to wrap to a new line
2. Create mailing labels. I used Avery L7163.
3. Compare to official Avery template, e.g. https://www.averyproducts.com.au/word-template-l7163. The right side of the label will overflow the label.https://lab.civicrm.org/dev/core/-/issues/376Contact Detail report breaks when adding clause using selectWhereClause()2018-09-14T04:16:17ZPradeep Nayakpradpnayak@gmail.comContact Detail report breaks when adding clause using selectWhereClause()5.7https://lab.civicrm.org/dev/core/-/issues/382DB Error generated when updating a group with an organisation record attached...2018-09-16T20:36:52ZseamusleeDB Error generated when updating a group with an organisation record attached where the id in the civicrm_group_organisation does not match the id in civicrm_groupIf the id of the group does not = the id of its civicrm_group_organisation record then a db error can be generated when trying to update the group.If the id of the group does not = the id of its civicrm_group_organisation record then a db error can be generated when trying to update the group.5.7seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/370No new tasks and documents get added to workflow if all built-in ones are del...2018-09-21T01:46:12ZajesamsonNo new tasks and documents get added to workflow if all built-in ones are deletedIn civi case types, when all built-in tasks and documents are deleted from the Standard Timeline of a workflow, no new tasks and documents get saved to that workflow.
![case_type](/uploads/61dbf15272ad0c9d65312b10977c1e88/case_type.gif...In civi case types, when all built-in tasks and documents are deleted from the Standard Timeline of a workflow, no new tasks and documents get saved to that workflow.
![case_type](/uploads/61dbf15272ad0c9d65312b10977c1e88/case_type.gif)
The desired result would be ability to add new task(s) after existing tasks are deleted.5.7https://lab.civicrm.org/dev/core/-/issues/281Fix invoice number in message template2018-09-22T20:38:51ZyashodhaFix invoice number in message templateSteps to replicate:
-------------------
1. Find Contributions with status *Pending*.
2. Choose a contribution record and from bulk actions choose *Invoices - Print or Email*.
3. The invoice still shows invoice id instead of human readab...Steps to replicate:
-------------------
1. Find Contributions with status *Pending*.
2. Choose a contribution record and from bulk actions choose *Invoices - Print or Email*.
3. The invoice still shows invoice id instead of human readable invoice id.
![inv_pending_before](/uploads/64692c28aa1df83078dad24401e15f81/inv_pending_before.png)5.7yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/399Relationship form inputs are reversed2018-09-25T00:28:19ZRudloffRelationship form inputs are reversedHello,
I am using CiviCRM 5.5.1 on WordPress.
It seems that since https://lab.civicrm.org/dev/core/issues/34, the relationship edit form sets the wrong permissions.
The AB radio input sets the BA permission and the BA radio input sets ...Hello,
I am using CiviCRM 5.5.1 on WordPress.
It seems that since https://lab.civicrm.org/dev/core/issues/34, the relationship edit form sets the wrong permissions.
The AB radio input sets the BA permission and the BA radio input sets the AB permission.5.6https://lab.civicrm.org/dev/core/-/issues/61Split edit message templates permission2018-10-05T01:39:35ZajesamsonSplit edit message templates permissionThe `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system...The `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system workflow messages.
It is therefore better to split `edit message templates` into two granular permissions (`edit user-driven message templates` and `edit system workflow message templates`) so that user access can be better managed.
![before](/uploads/896ebbdb81b419fb607750667c569486/before.gif)5.3.0https://lab.civicrm.org/dev/core/-/issues/418Can't add relationship to group of search results if relationship type is any...2018-10-09T16:11:32ZjamieCan't add relationship to group of search results if relationship type is any to anyIf you create a relationship type that relates a contact of any type to a contact of any type, that relationship will not be available to select when adding a relationship to a group of search results.If you create a relationship type that relates a contact of any type to a contact of any type, that relationship will not be available to select when adding a relationship to a group of search results.5.8https://lab.civicrm.org/dev/core/-/issues/163Disabled Groups used for mailings block access to mailing reports2018-10-14T00:59:59ZseamusleeDisabled Groups used for mailings block access to mailing reportsWhen a group that was used to send a mailing is disabled, that blocks access to the past mailing as the mailingACLIDs only checks for enabled groupsWhen a group that was used to send a mailing is disabled, that blocks access to the past mailing as the mailingACLIDs only checks for enabled groups5.3.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/97Improve the process and documentation for "How to Contribute" so that Proposa...2018-10-14T22:43:57Zjustinfreeman (Agileware)Improve the process and documentation for "How to Contribute" so that Proposals can be discussed, reviewed and accepted (rejected) before a PR is createdCreating this issue to start the discussion about how we as a community can improve the process and documentation for "How to Contribute", the relevant pages are:
* https://docs.civicrm.org/dev/en/latest/core/contributing/
* https://doc...Creating this issue to start the discussion about how we as a community can improve the process and documentation for "How to Contribute", the relevant pages are:
* https://docs.civicrm.org/dev/en/latest/core/contributing/
* https://docs.civicrm.org/dev/en/latest/tools/issue-tracking/#guidelines
This specifically relates to adding new features to CiviCRM core or changing existing features in CiviCRM core (I'll just call these collectively "Proposal"). It could equally apply to CiviCRM extensions, since the approach is the same - just the ecosystem is more distributed.
The current documented process revolves around submitting a PR on Github with the associated code. The problem with this process is it has high potential to be rejected, because no prior process of discussion, review or approval has been sought for the Proposal. When you think about it the current state, it's a bit backwards. So this is incredibly frustrating for people wishing to contribute to the project and a huge waste of time. If the PR never had a chance of being accepted conceptually, then there is no point at all in spending time on writing code, testing it, documenting it etc. PRs cost money to produce and no one likes wasting money!
So the process change I would like to see is to move away from PRs being the initial step for the Proposal. The PR should be the resultant of the Proposal process.
A Proposal should be created in Gitlab (not a PR in Github). The reasoning for the change and the proposed approach for implementing the change should be documented with the Proposal.
The Proposal should be available for review and feedback on Gitlab for a set period of time, 2 to 4 weeks maximum (for example). This step is important, Proposals should not languish, unattended.
At the conclusion of that time, the Proposal should be: Accepted, Rejected or Require Further Review; by a **new team** (CiviCRM Proposal Team) responsible for reviewing Proposals. **This should not be the responsibility of the existing CiviCRM Core Team, which are currently under resourced and over worked**. For the CiviCRM Proposal Team, we need new people to step up and own this process, so that the work load can be shared between Proposals and PRs. CiviCRM Core Team should not have to do both processes - we want to reduce their work load. This is why I think establishing a new CiviCRM Proposal Team to review Proposals is fundamental to this improvement.
If the Proposal is Accepted then related PR(s) can be created and they individually can go through the code review process.
The key change here is that the PR(s) for this Proposal will be accepted following passing code reviews. Any debate about the merits of the change or new features should occur on the Proposal, during the Proposal review stage. Not during a review of the PRs.
Proposals are for planning and implementation.
PRs are for code management.
This issue has also been raised on separate the discussion being had on this PR, https://github.com/civicrm/civicrm-core/pull/11956#issuecomment-385849221
Thanks @eileen
Let's discuss!justinfreeman (Agileware)justinfreeman (Agileware)