CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-10-29T20:49:47Zhttps://lab.civicrm.org/dev/core/-/issues/477Print Summary is missing some contact info2018-10-29T20:49:47ZJonGoldPrint Summary is missing some contact infoFrom Stack Exchange: https://civicrm.stackexchange.com/q/27063/12
To replicate:
* Open any individual's contact.
* From the "Actions" button, select "Print Summary".
**Expected**
The contact's employer/job title should be in the print...From Stack Exchange: https://civicrm.stackexchange.com/q/27063/12
To replicate:
* Open any individual's contact.
* From the "Actions" button, select "Print Summary".
**Expected**
The contact's employer/job title should be in the print summary.
**Actual**
It's not.
The last line of `<civiroot>/templates/CRM/Contact/Page/View/Print.tpl` is:
```js
cj('#contact-summary' ).children(':first').remove();
```
The reason for this is lost to the ages, but I suspect this referred to some other DOM element that's long since been removed.
Personally I'd deprecate this whole functionality - but apparently folks are using it, so let's make it work.
If someone wants to mark this "concept: approved" I'll submit the PR.5.8https://lab.civicrm.org/dev/core/-/issues/445Proposal - Custom Fields, Is this Field Searchable? option should be enabled ...2021-04-13T03:25:40Zjustinfreeman (Agileware)Proposal - Custom Fields, Is this Field Searchable? option should be enabled by default, currently it is disabled by defaultWhen creating Custom Fields the option **Is this Field Searchable?** is **disabled by default** and as a result any new Custom Field is not searchable. This is frustrating since there is rarely a case when you would not want a field to b...When creating Custom Fields the option **Is this Field Searchable?** is **disabled by default** and as a result any new Custom Field is not searchable. This is frustrating since there is rarely a case when you would not want a field to be available in search. For end users the experience of adding a Custom Field in CiviCRM is like this:
1. Add the Custom Field
1. Add some data to CiviCRM using the new Custom Field
1. Open Search and try to search using the new Custom Field, it is not shown
1. Confusion about why it is not shown in Search
1. Finally, navigate back to the Custom Field and enable the option, Is this Field Searchable?
1. Return to Search and bingo! There it is.
1. Repeat steps for every Custom Field created.
**Proposed Change**
The **Is this Field Searchable?** option should be **enabled by default**, making new Custom Fields available in Search when created - reducing potential confusion as noted above. The user would then have to explicitly disable this option to remove from search.
Agileware Ref: CIVICRM-964https://lab.civicrm.org/dev/core/-/issues/412Avoid truncated UTF-8 strings when using substr()2018-10-24T20:56:26ZjensschuppeAvoid truncated UTF-8 strings when using substr()[`CRM_Core_BAO_Mapping::getCustomGroupName()`](https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/Mapping.php#L1000-1002) truncates custom group names when longer than 10 characters using `substr()`, which causes multibyte charact...[`CRM_Core_BAO_Mapping::getCustomGroupName()`](https://lab.civicrm.org/dev/core/blob/master/CRM/Core/BAO/Mapping.php#L1000-1002) truncates custom group names when longer than 10 characters using `substr()`, which causes multibyte characters being cut in half when at the truncating position.
This should use `CRM_Utils_String::ellipsify()` instead, which utilises `mb_substr()`.
Maybe someone with more core code insight should inspect a `grep substr(` result for more places where that happens.
Steps to reproduce:
1. Create a custom field group with a name with a multibyte character at the 10th position, e.g. German umlaut `ö`
2. Add any custom field
3. Do a contact search, select some contacts, choose "export" action
4. Choose "Select fields to export"
5. Notice a JavaScript console error: "Uncaught syntax error: Unexpected token ,", inspect the source and notice the missing custom field name for the field in the custom field group
Edit: It should be noted that this causes the export field selection screen not working (no fields can be selected) anymore because of the JavaScript error
Patch: [avoid-truncated-utf-8-strings-when-using-substr.diff](/uploads/5af89995ffab165ccab95d8fed961a8e/avoid-truncated-utf-8-strings-when-using-substr.diff)5.8https://lab.civicrm.org/dev/core/-/issues/389When using custom fields for smart group criteria with relative dates the gro...2019-12-03T07:22:12ZjasonobrownWhen using custom fields for smart group criteria with relative dates the group does not respect the relative date over timeIf you create a smart group using the relative (dynamic, rolling, "this week", etc...) dates for a custom field, once you save the smart group the dates are no longer relative. It creates/updates the group with static dates that match yo...If you create a smart group using the relative (dynamic, rolling, "this week", etc...) dates for a custom field, once you save the smart group the dates are no longer relative. It creates/updates the group with static dates that match your relative dates at the time you save it.
https://issues.civicrm.org/jira/browse/CRM-20499e5.8https://lab.civicrm.org/dev/core/-/issues/373Custom field set behaving incorrectly in Contributions2022-09-16T05:03:38ZAndy ClarkCustom field set behaving incorrectly in ContributionsA custom field set that is flagged to appear only for 'Donations' correctly appears when a contribution is made. However if a field in that set isn't completed or is in error, an error message is correctly shown but the custom field set ...A custom field set that is flagged to appear only for 'Donations' correctly appears when a contribution is made. However if a field in that set isn't completed or is in error, an error message is correctly shown but the custom field set disappears and is replaced by 'Additional Details' which is opened up. To enter the custom field set you have to start again with the contribution. This only happens when the custom field set is **not ** set to 'Any'. The problem found in 5.4.1, and can be reproduced on the demo sites which today are at 5.6 alpha1. Problem is also present in 5.1.2 but not sure about 5.2 or 5.3.https://lab.civicrm.org/dev/core/-/issues/371Be environmentally friendly. Remove the sentence: "Please print this page for...2019-10-13T19:27:08Zjustinfreeman (Agileware)Be environmentally friendly. Remove the sentence: "Please print this page for your records." from the various CiviCRM tpls. We like trees!Be environmentally friendly. Remove the sentence: "Please print this page for your records." from the various CiviCRM tpls. We like trees!
A quick grep found this text in the following locations. There may be other similar on other tpls...Be environmentally friendly. Remove the sentence: "Please print this page for your records." from the various CiviCRM tpls. We like trees!
A quick grep found this text in the following locations. There may be other similar on other tpls/translations too.
templates/CRM/Contribute/Form/Contribution/ThankYou.tpl:66: <div>{ts 1=$paymentProcessor.name}Your contribution has been submitted to %1 for processing. Please print this page for your records.{/ts}</div>
templates/CRM/Contribute/Form/Contribution/ThankYou.tpl:77: <div>{ts}Your transaction has been processed successfully. Please print this page for your records.{/ts}</div>
templates/CRM/Event/Form/Registration/ThankYou.tpl:74: <p>{ts 1=$paymentProcessor.name}Your registration payment has been submitted to %1 for processing. Please print this page for your records.{/ts}</p>
templates/CRM/Event/Form/Registration/ThankYou.tpl:79: <p>{ts}Your registration has been processed successfully. Please print this page for your records.{/ts}</p>
ext/iatspayments/templates/CRM/iATS/ContributeThankYouExtra_UKDD.tpl:23: <p>Please print this page for your records.</p>
Binary file l10n/de_DE/LC_MESSAGES/civicrm.mo matches
Binary file l10n/uk_UA/LC_MESSAGES/civicrm.mo matches
Binary file l10n/fr_FR/LC_MESSAGES/civicrm.mo matches
Binary file l10n/ca_ES/LC_MESSAGES/civicrm.mo matches
Binary file l10n/es_MX/LC_MESSAGES/civicrm.mo matches
Binary file l10n/et_EE/LC_MESSAGES/civicrm.mo matches
Binary file l10n/pl_PL/LC_MESSAGES/civicrm.mo matches
Binary file l10n/zh_TW/LC_MESSAGES/civicrm.mo matches
Binary file l10n/cs_CZ/LC_MESSAGES/civicrm.mo matches
Binary file l10n/es_ES/LC_MESSAGES/civicrm.mo matches
Binary file l10n/nl_NL/LC_MESSAGES/civicrm.mo matches
Binary file l10n/hu_HU/LC_MESSAGES/civicrm.mo matches
Binary file l10n/ja_JP/LC_MESSAGES/civicrm.mo matches
Binary file l10n/en_AU/LC_MESSAGES/civicrm.mo matches
Binary file l10n/sl_SI/LC_MESSAGES/civicrm.mo matches
Binary file l10n/ru_RU/LC_MESSAGES/civicrm.mo matches
Binary file l10n/da_DK/LC_MESSAGES/civicrm.mo matches
Binary file l10n/el_GR/LC_MESSAGES/civicrm.mo matches
Binary file l10n/ar_EG/LC_MESSAGES/civicrm.mo matches
Binary file l10n/en_CA/LC_MESSAGES/civicrm.mo matches
Binary file l10n/de_CH/LC_MESSAGES/civicrm.mo matches
Binary file l10n/tr_TR/LC_MESSAGES/civicrm.mo matches
Binary file l10n/sv_SE/LC_MESSAGES/civicrm.mo matches
Binary file l10n/fr_CA/LC_MESSAGES/civicrm.mo matches
Binary file l10n/pt_BR/LC_MESSAGES/civicrm.mo matches
Binary file l10n/pt_PT/LC_MESSAGES/civicrm.mo matches
Binary file l10n/en_GB/LC_MESSAGES/civicrm.mo matches
Binary file l10n/zh_CN/LC_MESSAGES/civicrm.mo matches
Binary file l10n/nb_NO/LC_MESSAGES/civicrm.mo matches
Binary file l10n/hi_IN/LC_MESSAGES/civicrm.mo matches
Binary file l10n/lv_LV/LC_MESSAGES/civicrm.mo matches
Binary file l10n/it_IT/LC_MESSAGES/civicrm.mo matches
Agileware Reference: SUP-6032https://lab.civicrm.org/dev/core/-/issues/337QuickForm Error on Contact Search Form when using select custom field of type...2021-01-06T22:42:24ZPradeep Nayakpradpnayak@gmail.comQuickForm Error on Contact Search Form when using select custom field of type IntegerTo Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Ar...To Replicate:
Create a 'Select' custom field of type Integer or Number with 'Is this Field Searchable?' checked.
The Advance search form throws fatal error
```
Aug 17 10:16:57 [info] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -3
[message] => QuickForm Error: nonexistent html element
[mode] => 16
[debug_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[type] => HTML_QuickForm_Error
[user_info] => Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()
[to_string] => [html_quickform_error: message="nonexistent html element" code=-3 mode=callback callback=CRM_Core_Error::handle prefix="QuickForm Error: " info="Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()"]
)
Aug 17 10:16:57 [info] $backTrace = #0 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Error.php(232): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 [internal function](): CRM_Core_Error::handle(Object(HTML_QuickForm_Error))
#2 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(921): call_user_func((Array:2), Object(HTML_QuickForm_Error))
#3 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(2084): PEAR_Error->__construct("nonexistent html element", -3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#4 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(575): HTML_QuickForm_Error->__construct(-3, 16, (Array:2), "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()")
#5 [internal function](): PEAR::_raiseError(NULL, NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#6 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/PEAR.php(237): call_user_func_array((Array:2), (Array:8))
#7 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::__callStatic("raiseError", (Array:7))
#8 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm.php(1076): PEAR::raiseError(NULL, -3, NULL, 512, "Element 'custom_8_from' does not exist in HTML_QuickForm::addRule()", "HTML_QuickForm_Error", TRUE)
#9 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php(1103): HTML_QuickForm->addRule("custom_8_from", "number-select From must be a number (with or without decimal point).", "numeric")
#10 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Criteria.php(567): CRM_Core_BAO_CustomField::addQuickFormElement(Object(CRM_Contact_Form_Search_Advanced), "custom_8", "8", FALSE, TRUE)
#11 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Contact/Form/Search/Advanced.php(150): CRM_Contact_Form_Search_Criteria::custom(Object(CRM_Contact_Form_Search_Advanced))
#12 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Form.php(606): CRM_Contact_Form_Search_Advanced->buildQuickForm()
#13 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(92): CRM_Core_Form->buildForm()
#14 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Contact_Form_Search_Advanced), "display")
#15 /var/www/html/civicrm-master/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contact_Form_Search_Advanced), "display")
#16 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Controller.php(351): HTML_QuickForm_Page->handle("display")
#17 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(309): CRM_Core_Controller->run((Array:4), (Array:0))
#18 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(84): CRM_Core_Invoke::runItem((Array:13))
#19 /var/www/html/civicrm-master/sites/all/modules/civicrm/CRM/Core/Invoke.php(52): CRM_Core_Invoke::_invoke((Array:4))
#20 /var/www/html/civicrm-master/sites/all/modules/civicrm/drupal/civicrm.module(445): CRM_Core_Invoke::invoke((Array:4))
#21 [internal function](): civicrm_invoke("contact", "search", "advanced")
#22 /var/www/html/civicrm-master/includes/menu.inc(527): call_user_func_array("civicrm_invoke", (Array:3))
#23 /var/www/html/civicrm-master/index.php(21): menu_execute_active_handler()
#24 {main}
```
When i checked the field through database i found that this field has 'is_search_range' set to TRUE which should be only incase of text or date field i believe.5.9https://lab.civicrm.org/dev/core/-/issues/310Incorrect allocation of payment on an edited multi-line item event registration2018-10-23T15:30:07ZJoeMurrayIncorrect allocation of payment on an edited multi-line item event registrationOn default data set on dmaster, create new Financial Type Event Fees 2. At Administer > Financial Accounts, navigate to the Financial Account this creates also called Event Fees 2 and enter 4301 as the Accounting Code.
1. Create event ...On default data set on dmaster, create new Financial Type Event Fees 2. At Administer > Financial Accounts, navigate to the Financial Account this creates also called Event Fees 2 and enter 4301 as the Accounting Code.
1. Create event with priceset with two fields, first with financial Type Event fees, second with FT of Event Fees 2.
2. Register in event with payment of say $25 for first ticket (Event Fees) and $10 for second ticket (Event fees 2), total $35.
3. Edit Event registration. Click Change selections. Change quantity for second field from 1 to 5, line item total of $50, contribution total of $75, total paid $35. Save. Balance is $40.
4. Click Record Payment.
To review the database records that would be sent to accounting applications, you can:
5. Navigation to Contributions > Accounting Batches > New Batch, create a batch, assign the relevant transactions of $35 (original payment), $40 (edit with implied purchase with pay later) and $40 (payment of outstanding balance) to the new batch and export to csv.
6. At Contributions > Accounting Batches > Open Batches, select the batch just created and export as csv, open and view the resulting transactions:
[Financial_Transactions_3_20180807210702.csv](/uploads/cd4c2989ca42cff4e7f6bba22b8ddfa1/Financial_Transactions_3_20180807210702.csv)
The initial purchase (first two lines) and the edit of the order to increase the number of event fees from $10 to $50 are (the third line) are all correct. However, the payment of the outstanding balance is incorrect. Instead of a single line with a $40 payment (Debit Bank Account 1150, Credit Accounts Receivable 1200), there are two lines:
Debit Bank Account 1150, Credit Accounts Receivable 1200: $16.67, Item description: Member
Debit Bank Account 1150, Credit Accounts Receivable 1200: $23.33, Item description: Guest
It seems the payment is being equally allocated to the two line items in proportion to their current line item total. If there had been a simple partial payment, this would be correct. The algorithm for determining the allocation should not be based on the line item totals (or more accurately, their corresponding financial_item.amount), but on the amount of each financial item that has been paid so far (entity_financial_trxn.amount for the entries linking financial_trxn records to these financial_item records.
We should first verify that the entity_financial_trxn.amount fields are being properly recorded. Then it will be apparent that sum(entity_financial_trxn.amount) pointing to first financial_item is $25, the same as its financial_item.amount, while sum(entity_financial_trxn.amount) pointing to second financial_item is $10, which is $40 less than the financial_item.amount. So all of the second payment would be allocated to a single new entity_financial_trxn.amount of $40 pointing to the second financial_item.
This is not a high priority since the two entries add up to the same as the proposed single entry from an accounting perspective. Having two general journal entries is confusing, and the item description of one is inaccurate, so a fix would be good.Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/280Deleting membership types do not remove price field values from online member...2022-09-09T05:03:27ZyashodhaDeleting membership types do not remove price field values from online membership formsSteps to replicate:
------------------
1. Create a price field with options(select/checkbox/radio).
2. Choose an option related to a membership type.
3. Delete the membership type and it sets NULL membership type for the price option wi...Steps to replicate:
------------------
1. Create a price field with options(select/checkbox/radio).
2. Choose an option related to a membership type.
3. Delete the membership type and it sets NULL membership type for the price option without any indications.
Desired behavior:
-----------------
**Delete membership**
I would like to get some input about the behavior-
1. When admin tries to delete a membership type, check for any related price fields and if yes, throw a form rule implying them to delete the price field first.
2. Or just show warning message with list of membership type used in price field and allow anyway.
**Disabled Membership Type**
I would like to get some input about the behavior-
1. Show warning Message on disable action and if yes, skip building price field option related to disabled membership type.
2. User can dismiss warning message but can't continue with disablement of membership typeyashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/268PHP Warnings when 'name' of relationship types are duplicated2023-02-10T05:03:35ZJKingsnorthPHP Warnings when 'name' of relationship types are duplicatedThis is a tenuous edge-case, but:
Steps to recreate:
- Administer relationship types: https://dmaster.demo.civicrm.org/civicrm/admin/reltype?reset=1
- Add a new relationship type
- Enter 'Foo of' for both a-b and b-a labels, save
- Edit...This is a tenuous edge-case, but:
Steps to recreate:
- Administer relationship types: https://dmaster.demo.civicrm.org/civicrm/admin/reltype?reset=1
- Add a new relationship type
- Enter 'Foo of' for both a-b and b-a labels, save
- Edit the relationship, change the label for a-b to 'Foo not of'
- Save
- View a contact record, flush caches:
Warning: array_combine(): Both parameters should have an equal number of elements in CRM_Contact_BAO_Relationship::buildRelationshipTypeOptions() (line 2239 of .../civicrm/CRM/Contact/BAO/Relationship.php).
This is because the removeRelationshipTypeDuplicates method is removing the duplicate 'names' but not the duplicate 'labels', which creates an imbalance for the array_combine()
I'm pretty confused about why these methods are going to so much trouble to build and dedupe and list of relationship types anyway?
But the issue is, this means that CRM_Contact_BAO_Relationship::buildRelationshipTypeOptions() actually returns FALSE, when we're not on a form, because it couldn't combine the array. I haven't seen where this is causing a breakage yet, but it gives me the heebie-jeebies.
Related to https://github.com/civicrm/civicrm-core/pull/11853https://lab.civicrm.org/dev/core/-/issues/267Proposal - remove net_amount from contribution edit form - at least in edit m...2018-11-16T06:59:41ZeileenProposal - remove net_amount from contribution edit form - at least in edit mode.When people edit the total_amount on a contribution they have to edit the net_amount to match - why? We can calculate it.
**What happens now?**
For new contributions with no fees it is enough for the user to enter total amount. Howeve...When people edit the total_amount on a contribution they have to edit the net_amount to match - why? We can calculate it.
**What happens now?**
For new contributions with no fees it is enough for the user to enter total amount. However, if there is a fee they need to enter the fee AND calculate net_amount and enter them. If they edit the amount they need to update the net amount to be the same as the total amount less the fee amount.
The current behaviour dates back to svn days - however since 2015 the BAO has handled the possibility
of it not being set.
**What issues are there with this**
1. It causes pain for users
1. In addition we have had code issues with the comparison around [currency & float comparison issues](https://github.com/civicrm/civicrm-core/pull/11485) and [sales tax](https://lab.civicrm.org/dev/core/issues/260). In both cases the user cannot enter the correct data.
1. It undermines our unit testing - in Mar 2017 [the unit tests were edited](https://github.com/civicrm/civicrm-core/pull/9948/files#diff-40e2e0f106ba620465acf3a9a81f2498L1535) to remove net_amount from the form submission values in our unit tests. New tests written since then have been based on these net_amountless tests.
**[Proposed change Remove the field altogether from the form]
(https://github.com/eileenmcnaughton/civicrm-core/commit/0bee3ce6fa18fa24d75c7bb9e86618ff0ac1f025)**
**Risks**
I would hope some people would commit to testing the rc - but as mentioned above our tests already expect it not to be set so we are already testing the proposed scenario.
there is a risk that some people really like the fact that when the edit the total_amount and not the fee_amount they get a validation error - IF that seems to be a real issue - not just me flailing around for reasons - then we could either move the fee_amount field or have some UI sugar mentioning the fee_amount next to total_amount.
Here is the BAO function that calculates it.
```
/**
* Calculate net_amount & fee_amount if they are not set.
*
* Net amount should be total - fee.
* This should only be called for new contributions.
*
* @param array $params
* Params for a new contribution before they are saved.
* @param int|null $contributionID
* Contribution ID if we are dealing with an update.
*
* @throws \CiviCRM_API3_Exception
*/
public static function calculateMissingAmountParams(&$params, $contributionID) {
if (!$contributionID && !isset($params['fee_amount'])) {
if (isset($params['total_amount']) && isset($params['net_amount'])) {
$params['fee_amount'] = $params['total_amount'] - $params['net_amount'];
}
else {
$params['fee_amount'] = 0;
}
}
if (!isset($params['net_amount'])) {
if (!$contributionID) {
$params['net_amount'] = $params['total_amount'] - $params['fee_amount'];
}
else {
if (isset($params['fee_amount']) || isset($params['total_amount'])) {
// We have an existing contribution and fee_amount or total_amount has been passed in but not net_amount.
// net_amount may need adjusting.
$contribution = civicrm_api3('Contribution', 'getsingle', array(
'id' => $contributionID,
'return' => array('total_amount', 'net_amount'),
));
$totalAmount = isset($params['total_amount']) ? $params['total_amount'] : CRM_Utils_Array::value('total_amount', $contribution);
$feeAmount = isset($params['fee_amount']) ? $params['fee_amount'] : CRM_Utils_Array::value('fee_amount', $contribution);
$params['net_amount'] = $totalAmount - $feeAmount;
}
}
}
}
```5.6https://lab.civicrm.org/dev/core/-/issues/251Fix batch copy for membership type field2019-05-01T06:03:03ZyashodhaFix batch copy for membership type fieldSteps to replicate :
1. Create a profile with membership type field.
2. Click Find Memberships and select a few members and do Update multiple memberships with above profile.
3. Click on copy icon for membership type, it doesn't copy ov...Steps to replicate :
1. Create a profile with membership type field.
2. Click Find Memberships and select a few members and do Update multiple memberships with above profile.
3. Click on copy icon for membership type, it doesn't copy over 1st row to the restyashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/237Hide Drupal8 Administer Menu bar on CiviCRM pages2018-08-12T23:41:09ZMonish DebHide Drupal8 Administer Menu bar on CiviCRM pagesCurrently on Drupal8-Civi instance, when you visit any CiviCRM page you will find a Drupal8 Admin menu bar behind the CiviCRM menu bar:
![Screen_Shot_2018-07-06_at_2.01.21_PM](/uploads/ac5b9febff84a27b494d2d009aaf3910/Screen_Shot_2018-07...Currently on Drupal8-Civi instance, when you visit any CiviCRM page you will find a Drupal8 Admin menu bar behind the CiviCRM menu bar:
![Screen_Shot_2018-07-06_at_2.01.21_PM](/uploads/ac5b9febff84a27b494d2d009aaf3910/Screen_Shot_2018-07-06_at_2.01.21_PM.png)
Proposal
---------
It won't be a good idea to expand the CiviCRM menu bar to the width of Drupal8 menu bar, instead hide the Drupal8 menu bar when we are on Civi page. To restore the Drupal8 menu, you can use the existing CiviCRM actions to toggle CiviCRM menu on any Civi page.Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/214Suppress inappropriate error when trying to schedule mailing for today2022-08-17T05:03:36ZJoeMurraySuppress inappropriate error when trying to schedule mailing for todayWhen trying to schedule a mailing, there are two fields: one for date and one for time. If you select today for date a popup error immediately says that 'Error
The scheduled date and time is in the past'. It would be better if this was d...When trying to schedule a mailing, there are two fields: one for date and one for time. If you select today for date a popup error immediately says that 'Error
The scheduled date and time is in the past'. It would be better if this was delayed somewhat, though there are many possibilities. User ends up thinking Civi doesn't know correct date.
How about if validation changed so that if date==today and time is null, then set time=now()+1 minute?Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/206Filter webform dropdown through relationship type2018-10-15T12:00:57ZshitijgFilter webform dropdown through relationship type**Overview:**
This ticket is targeted at improving the data filtering capabilities of the ‘Existing Contact’ field of the Webform CiviCRM.
With this new filtering - we will be able to filter the existing contact field with values deri...**Overview:**
This ticket is targeted at improving the data filtering capabilities of the ‘Existing Contact’ field of the Webform CiviCRM.
With this new filtering - we will be able to filter the existing contact field with values derived from a particular relation type that a contact has with another contact.
**How it works currently:**
Currently we have the ability to filter through Groups and Tags
We also currently have the ability for the existing contact field on the webform to autoload static value through a predefined relationship to another ‘existing contact’ field on the webform.
i.e.
If Contact 1 is the Case Client and has a relationship: ‘Employee of’ with Ashville School, we can add another contact field on the webform and enable the relationship fields on it to:
‘Employee of’.
![Screen_Shot_2018-06-25_at_18.39.01](/uploads/c00aa3024f6e72160d7f781b1778f302/Screen_Shot_2018-06-25_at_18.39.01.png)
We will also have to edit the ‘Existing Contact’ field and select it’s default value to load from a relationship.
![Screen_Shot_2018-06-25_at_18.40.02](/uploads/0b316d87ec5e6fb5055765411b4dea1e/Screen_Shot_2018-06-25_at_18.40.02.png)
This would mean that Contact 2 on the webform will be the value coming from the ‘Employee of’ relationship with Contact 1 (in this case - for our selected case client - it would be ‘Ashville School’)
In this way we are able to load the value from a relationship that 2 contacts have, however, we can not do this dynamically.
I.e.
Contact 3 (another contact on the webform) cannot be set to filter and give back a list of all the students at Ashville School (have a relationship ‘Student at’ with ‘Ashville School’, so that the user filling the form can select one of the students.
**How we would like to improve the functionality:**
With this new implementation, we will be able to filter values for an ‘Existing Contact’ field on the webform through specifying a relationship and relationship with.
Continuing from our previous example where:
Contact 1 - Joe Bloggs (Case Client)
Contact 2 - Ashville School (Has the relationship ‘Employer of’ with Joe Bloggs)
Contact 3 - We need a list of all students at Ashville School and be able to select this on the form
To achieve this - we will need the following configurations in the filters section of the ‘Existing Contact’ field:
![Screen_Shot_2018-06-25_at_18.36.55](/uploads/b5ab2bbe9d46659399bae4739b6010e3/Screen_Shot_2018-06-25_at_18.36.55.png)
In the above example, the user will be able to select:
Relationship Type - ‘Student at’
Contact - ‘Contact 2’
This would mean when the webform loads, it will populate all the students at Contact 2 (Ashville School) as option values for Contact 3.https://lab.civicrm.org/dev/core/-/issues/204Add testcases to civicrm-core PR #112912021-09-13T00:08:27ZvarshithAdd testcases to civicrm-core PR #11291Ref. https://github.com/civicrm/civicrm-core/pull/11291
The above PR adds case tokens support to email activities.
We need test cases for the above PR to complete it.Ref. https://github.com/civicrm/civicrm-core/pull/11291
The above PR adds case tokens support to email activities.
We need test cases for the above PR to complete it.https://lab.civicrm.org/dev/core/-/issues/100Membership Detail report throw DB error2018-05-25T05:45:46ZyashodhaMembership Detail report throw DB errorMembership Detail report throw DB error due to acl clause applied twice.Membership Detail report throw DB error due to acl clause applied twice.5.3.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/92Prevent deletion of groups which are used as search parameters of Smart Groups2023-04-20T08:59:49ZEvanPrevent deletion of groups which are used as search parameters of Smart GroupsIt seems that a group (static or Smart) being used a search parameter for a Smart Group can be deleted. Best case scenario is the Smart Group just has that many fewer contacts in it and we go on with life. We had an issue on a client sit...It seems that a group (static or Smart) being used a search parameter for a Smart Group can be deleted. Best case scenario is the Smart Group just has that many fewer contacts in it and we go on with life. We had an issue on a client site where there were so many contacts and so many groups, that rebuilding the Smart Group cache was causing a fatal DB error whether it (Updating Smart Group counts) was done manually or via the scheduled job. Proposed approach is to prevent deletion of groups that are dependencies for other groups. Example workflow:
1. A user with permissions to delete groups chooses to delete a group by selecting the "Delete" option from the "More" link on the Manage Groups page located here: Navigation Menu > Contacts > Manage Groups (this is the only place a user can delete a group, I believe)
1. The system (CiviCRM) does a check in the background to determine if the group being deleted is used as a search parameter in any active/non-deleted Smart Groups
1. If the group being deleted is determined to be "in use" by a Smart Group(s), don't allow the group to be deleted. Instead…
1. Show a message in the "Confirm Group Delete" notification that the group cannot be deleted as it's being used by a Smart Group(s). List the name of the Smart Group(s), preferably with the name(s) linked to that/those group(s)
I am inquiring with our client if they are willing to put funds (and how much) into fixing this. I have confirmed on demo master that one can delete a group that is a dependency for another group, though there were no ill effects. My assumption / theory is there just aren't enough contacts or groups for the rebuilding of Smart Group counts to fail.https://lab.civicrm.org/dev/core/-/issues/86CIVICRM_MAIL_LOG_AND_SEND does not work properly2018-11-18T21:03:25Zmattwiremjw@mjwconsult.co.ukCIVICRM_MAIL_LOG_AND_SEND does not work properlyIn the packages/Mail it is mistyped as "CIVICRM_MAIL_LOG_AND SEND" (ie. missing an underscore): https://github.com/civicrm/civicrm-packages/pull/204
In CiviCRM core the administrator is not notified if it is set: https://github.com/civi...In the packages/Mail it is mistyped as "CIVICRM_MAIL_LOG_AND SEND" (ie. missing an underscore): https://github.com/civicrm/civicrm-packages/pull/204
In CiviCRM core the administrator is not notified if it is set: https://github.com/civicrm/civicrm-core/pull/12037
In the docs it is missing altogether: https://github.com/civicrm/civicrm-dev-docs/pull/5265.2.0https://lab.civicrm.org/dev/core/-/issues/61Split edit message templates permission2018-10-05T01:39:35ZajesamsonSplit edit message templates permissionThe `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system...The `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system workflow messages.
It is therefore better to split `edit message templates` into two granular permissions (`edit user-driven message templates` and `edit system workflow message templates`) so that user access can be better managed.
![before](/uploads/896ebbdb81b419fb607750667c569486/before.gif)5.3.0