1. 29 Mar, 2020 3 commits
  2. 28 Mar, 2020 1 commit
  3. 26 Mar, 2020 3 commits
  4. 24 Mar, 2020 2 commits
    • totten's avatar
      (NFC) Update comments in PathsTest.php · 961b2006
      totten authored
    • totten's avatar
      joomla#26 - Fix path derivation when CMS is rooted in a subdir · d0cda11f
      totten authored
      CiviCRM is deployed inside a CMS. The CMS is usually deployed at the HTTP root (`http://example.org`),
      but it is sometimes deployed in a subdirectory (`http://example.org/my-cms`).
      Some asset URLs are computed using the variables `[civicrm.bower]`, `[civicrm.packages]`, and `[civicrm.vendor]`, which
      are derived from the value of `[civicrm.root]`.  However, if the site is deployed in a subdirectory, and if using v5.23,
      then the computation of `[civicrm.bower]` (etc) can misbehave.
      When the URL for `[civicrm.bower]` (or similar) is derived, it goes through multiple filters - first, from absolute to
      relative, and then later from relative back to absolute.  In the process, the base is inadvertently changed.
      When the URL is derived, it is computed in absolute format - and simply kept that way.
      Regarding test coverage, there are two relevant unit-tests. This PR only updates one.
      * `E2E\Core\PathUrlTest`: This is a more concrete smoke test which demonstrates functional problems with variables like
        `[civicrm.bower]`.  It should already catch problems like joomla#26...  but only if you run the E2E suite on a system
        where the CMS was deployed to a subdirectory.  `civibuild` doesn't currently include such a build-type.
      * `Civi\Core\PathsTest`: This is a more abstract, headless test to examine edge-cases in `Civi\Core\Paths`. It does not
        specifically check for `[civicrm.bower]` or similar variables (b/c the URL routing is ill-defined in a headless context).
        However, I've updated it to compare/contrast the working and non-working ways to derive variables.
  5. 23 Mar, 2020 2 commits
  6. 21 Mar, 2020 2 commits
  7. 20 Mar, 2020 3 commits
  8. 17 Mar, 2020 6 commits
  9. 16 Mar, 2020 2 commits
  10. 15 Mar, 2020 1 commit
  11. 14 Mar, 2020 2 commits
  12. 13 Mar, 2020 2 commits
  13. 12 Mar, 2020 1 commit
    • eileen's avatar
      [NFC] Test cleanup, remove duplicate test · 3b3a32a7
      eileen authored
      It turns out the removed test is identical to testEntityTagDeleteINDHH earlier in the class
      - probably consolidation of the functions called led to this
  14. 11 Mar, 2020 3 commits
  15. 10 Mar, 2020 7 commits