1. 18 Sep, 2020 1 commit
  2. 17 Sep, 2020 5 commits
  3. 16 Sep, 2020 2 commits
  4. 14 Sep, 2020 4 commits
    • eileen's avatar
      #1921 Further removal of iso date handling · 629c4d30
      eileen authored
      Overview
      ----------------------------------------
      Same deal as https://github.com/civicrm/civicrm-core/pull/18359
      
      Before
      ----------------------------------------
      Casting to ISO date to avoid 2014 bug
      
      After
      ----------------------------------------
      We are stuck in 2020
      
      Technical Details
      ----------------------------------------
      
      Comments
      ----------------------------------------
      relevant tests
      api_v3_CaseTest::testCaseMerge
      629c4d30
    • mattwire's avatar
      Fix parameters for MembershipTest · 73bf3812
      mattwire authored
      73bf3812
    • eileen's avatar
      [REF] Start the process of separating the search action from the participant form. · 8535cf1c
      eileen authored
      A lot code nastiness stems from the overloading of the participant registration form with the search task to register
      multiples. A more logical structure would be some shared functionality but separate classes. This starts that
      process, but with only the one property now separated to be a class property rather than a derived one. Later efforts
      can disentangle which functionality belongs to which class
      8535cf1c
    • eileen's avatar
      #1921 remove isoToMysql · dc4db260
      eileen authored
      Overview
      ----------------------------------------
      Remove unnecessary isoToDate function
      
      Before
      ----------------------------------------
      Code compatible with packages code of 6 years ago
      
      After
      ----------------------------------------
      will break if you revert 6 year old fix....
      
      Technical Details
      ----------------------------------------
      The test testMailerStats passes through this line of code - which
      I think is probably about the most we can confirm testing wise as we expect there
      to be no reason to cast to mysql anymore
      
      Comments
      ----------------------------------------
      #1921
      dc4db260
  5. 13 Sep, 2020 2 commits
  6. 11 Sep, 2020 4 commits
  7. 10 Sep, 2020 2 commits
  8. 09 Sep, 2020 6 commits
  9. 08 Sep, 2020 3 commits
    • eileen's avatar
      Fix formatLocaleNumericRoundedByCurrency · c9763347
      eileen authored
      The function was rounding by a max of 2 regardless of the number of places passed - it
      was only tested for 2 so seemed to work
      c9763347
    • eileen's avatar
      Remove error handling from loadObjects · 49ed4888
      eileen authored
      The processors now have their own try->catch so we don't need to catch here.
      
      I wasn't sure about the debug_log_message part so I copied it into the processors
      , at risk of duplicating
      49ed4888
    • eileen's avatar
      Implement 'super permissions' as described by @totten · 755a1835
      eileen authored
      This picks up on an idea Tim has pushed several times - ie that instead of giving out 'Administer CiviCRM' willy nilly
      we could deprioritise it in favour of 2 more granular permission bundles - ie Administer CiviCRM data & administe CiviCRM system.
      
      This allows us to make some permissions more 'locked away' without endlessly adding new 'administer Payment Processors'
      because we've realised not everyone who can create profiles needs to be able to see payment processor credentials.
      
      It also allows us to make system checks less broadly visible where they are not appropriate.
      
      Note that to proceed with this we would need to go through all places that check Administer CiviCRM & put in one
      or both of the 2 new permissions. Having Administer CiviCRM implicitly includes anything granted to the existing
      permissions so the implementation is smooth-ish there. However, I can imagine we would need a hook allowing people
      to categorise themselves or we would find ourselves litigating all sorts
      755a1835
  10. 07 Sep, 2020 1 commit
  11. 06 Sep, 2020 7 commits
  12. 05 Sep, 2020 3 commits