1. 10 May, 2019 1 commit
  2. 07 May, 2019 1 commit
  3. 06 May, 2019 7 commits
  4. 05 May, 2019 1 commit
  5. 02 May, 2019 10 commits
  6. 01 May, 2019 8 commits
  7. 30 Apr, 2019 12 commits
    • Eileen McNaughton's avatar
      Merge pull request #14164 from eileenmcnaughton/in_fix · f77a81cb
      Eileen McNaughton authored
      Fix deprecation handling [intra-rc-follow up] on #13999]
      f77a81cb
    • Seamus Lee's avatar
    • totten's avatar
      (flexmailer#29) civicrm/mailing/view - Generate content via Mailing.preview API · 640d3ea6
      totten authored
      A root cause of flexmailer#29 is that the flexmailer has to override
      multiple parts of CiviMail.  Case in point: it overrides the
      `civicrm/mailing/view` and forces it to generate content via
      `Mailing.preview` API.  This is unfortunate because flexmailer's variant is
      missing other features (regarding permissioning and contact IDs).
      
      This revision makes it unnecessary for flexmailer to override
      `civicrm/mailing/view`.
      640d3ea6
    • totten's avatar
    • totten's avatar
    • Seamus Lee's avatar
      flexmailer#26 Fix Flexmailer handling of annonmous user access to view... · f4377975
      Seamus Lee authored
      flexmailer#26 Fix Flexmailer handling of annonmous user access to view Mailings by porting handling of annon situation to api
      f4377975
    • eileen's avatar
      Fix deprecation handling · c3d06508
      eileen authored
      Turns out we were one of the sites naughtily using the BAO directly who needed this handling
      to work - but because we passed a number in quote it didn't - this fixes
      c3d06508
    • totten's avatar
      Merge pull request #14156 from totten/5.13-mail-tokens · 9d6c8f83
      totten authored
      CiviMail - Restore support for preview of "mailing"/"action" tokens via TokenProcessor/Flexmailer
      9d6c8f83
    • totten's avatar
      CRM_Mailing_TokensTest - Update spec to match expected behavior · d02df737
      totten authored
      The preceding commits revised the behavior of `{mailing.*}` and `{action.*}`
      when previewed via `TokenProcessor` (so that they match the preview
      logic in other cases).
      
      This simply changes the spec to match.
      d02df737
    • Eileen McNaughton's avatar
      Merge pull request #14155 from seamuslee001/php_7_2_bin_cli_class · dab9c393
      Eileen McNaughton authored
      #907 Fix Deprecation notice for PHP7.2 in bin/cli.class.php
      dab9c393
    • totten's avatar
      CiviMail - Restore support for previewing mailing-tokens via TokenProcessor/Flexmailer · fa373cad
      totten authored
      See preceding commit for general description - this simply applies the same
      concept for another set of tokens.
      fa373cad
    • totten's avatar
      CiviMail - Restore support for previewing action-tokens via TokenProcessor/Flexmailer · e026b9e4
      totten authored
      Overview
      --------
      
      When using `TokenProcessor` to generate a mailing (e.g.  as with Flexmailer/Mosaico), the action-tokens (e.g.
      `{action.optOutUrl}`) are generated via `CRM_Mailing_ActionTokens`.  To properly generate them,
      `CRM_Mailing_ActionTokens` relies on certain information (e.g.  mailing/job ID).  However, that information is no
      longer available when performing a "Preview" -- leading to misbehavior in previews.  This patch allows Flexmailer to
      restore parity for previewing those tokens.
      
      Before (Pre-5.6)
      ----------------
      
      * When a user begins composing a mailing, CiviMail creates a draft mailing with a concrete ID (e.g.  `mailing #123`).
      * To preview the mailing, the UI calls `Mailing.preview` API with the ID of the mailing.
      * Flexmailer/Mosaico generates the preview by calling `TokenProcessor` and therefore `CRM_Mailing_ActionTokens`.
      * `CRM_Mailing_ActionTokens` has strictness checks. These pass because the ID is available.
      
      Before (5.6-5.12)
      ----------------
      
      As a performance enhancement, CiviCRM 5.6 (PR #12509; [dev/mail#20](dev/mail#20)) revised
      the signature for `Mailing.preview` API to allow previews *without* having a specific mailing record/job/ID. Consequently:
      
      * When a user begins composing a mailing, CiviMail creates a draft mailing with a concrete ID (e.g.  `mailing #123`).
      * To preview the mailing, the UI calls `Mailing.preview` API ~~with~~ **without** the ID of the mailing.
      * Flexmailer/Mosaico generates the preview by calling `TokenProcessor` and therefore `CRM_Mailing_ActionTokens`.
      * `CRM_Mailing_ActionTokens` has strictness checks. These ~~pass~~ **fail** because the ID is ~~available~~ **unavailable**.
      
      After
      ----------------
      
      * When a user begins composing a mailing, CiviMail creates a draft mailing with a concrete ID (e.g.  `mailing #123`).
      * To preview the mailing, the UI calls `Mailing.preview` API ~~with~~ **without** the ID of the mailing.
      * Flexmailer/Mosaico generates the preview by calling `TokenProcessor` and therefore `CRM_Mailing_ActionTokens`.
      * `CRM_Mailing_ActionTokens` has ~~strictness~~ **less strict** checks. These **pass** because the `context[schema]` hints that
        a mailing ID *will be available* when needed.
      e026b9e4