1. 10 May, 2019 1 commit
  2. 20 Apr, 2019 1 commit
  3. 13 Apr, 2019 1 commit
    • totten's avatar
      (NFC) SchemaStructure.php - Fix up mismatch between stored+generated code · 3eb2aab1
      totten authored
      Overview
      --------
      
      The class `CRM_Core_I18n_SchemaStructure` is autogenerated via GenCode, and it is also commited to git.
      The two forms don't match because of the recent code-style cleanup.
      
      Before
      ------
      
      After running GenCode, there appears to be uncommitted changes in `CRM_Core_I18n_SchemaStructure`.
      The changes indicate a reversion in code-style (e.g. `null` vs `NULL`; some whitespace).
      
      After
      -----
      
      GenCode produces output which matches the recent cleanup.
      
      Comments
      --------
      
      Fixing `null` / `NULL` was easy. However, the whitespace mismatch was more subtle -- because the
      `PHP_Beautifier` was messing it up. To resolve, I disabled `PHP_Beautifier` for this file, and fixed
      the underlying templates to generate well-formed code.
      
      The output of the process matches the existing code; therefore, the change
      have no functional impact (NFC).  You can see this by running `setup.sh` and
      checking the `git status`.
      3eb2aab1
  4. 10 Apr, 2019 1 commit
  5. 09 Apr, 2019 2 commits
    • eileen's avatar
      Update new payment_processor.title field to be localisable · 4c257e17
      eileen authored
      Re-order upgrade to fix upgrade process and ensure there is the runSql step
      4c257e17
    • totten's avatar
      (REF) CRM_Core_Resources - Move hook declaration from addCoreResources() to Container.php · f22fb451
      totten authored
      tldr: It's easier to declare `hook_civicrm_buildAsset` listeners at a high-level.
      
      Asset building can use two modes -- production mode writes a static file to
      disk when it's being reference.  Debug mode just generates a URL for a
      web-service (which in turn dynamically renders the content in a separate
      page-view).
      
      If the only mode were production mode, then the code would be on pretty
      solid ground.  We could even simplify things a lot by changing the
      AssetBuilder contract to replace the hooks with callbacks, as in:
      
      ```php
      Civi::service('asset_builder')->getUrl('crm-menu.css', function() {
        return '...the css code...';
      });
      ```
      
      Why have a hook?  Because hooks are generally context-free and
      always-available.  If we use debug-mode (or if we add a feature to warm-up
      the caches during deployment), then we'll want to fire that hook from a
      different context (e.g.  web-service or CLI), and the hook-listener needs to
      be available in those other contexts.
      
      It would be nice if we could declare hooks generally without needing to edit
      the `Container.php` mega-file (e.g.  maybe some kind of annotation).  But,
      for the moment, I think this is the best spot that we have in `civicrm-core`
      for ensuring that hook listeners are fully/consistently registered.
      f22fb451
  6. 08 Apr, 2019 5 commits
  7. 07 Apr, 2019 1 commit
  8. 05 Apr, 2019 3 commits
  9. 04 Apr, 2019 1 commit
  10. 02 Apr, 2019 2 commits
  11. 31 Mar, 2019 2 commits
  12. 29 Mar, 2019 1 commit
  13. 28 Mar, 2019 1 commit
  14. 27 Mar, 2019 3 commits
  15. 26 Mar, 2019 1 commit
  16. 21 Mar, 2019 1 commit
    • eileen's avatar
      Allow payment processor to determine the text around 'continue' · e364c762
      eileen authored
      This text traditionally depends on the outdated payment processor 'mode' concept. Since the 'right' text depends
      on what the payment processor plans to do moving it out to the processor classes makes sense
      
      We could also do the same with 'button'
      e364c762
  17. 20 Mar, 2019 2 commits
  18. 19 Mar, 2019 2 commits
  19. 18 Mar, 2019 1 commit
  20. 16 Mar, 2019 1 commit
  21. 14 Mar, 2019 2 commits
  22. 13 Mar, 2019 2 commits
  23. 11 Mar, 2019 1 commit
    • eileen's avatar
      Standardise setTitle method on forms · d7188a5d
      eileen authored
      We have inconsistent methodology for setting the title. This is a minor simplification and
      consistency improvement. It also means hooks can call 'getTitle' - ideally all forms would call thi
      s & title handling would be consistent.... one day
      d7188a5d
  24. 07 Mar, 2019 1 commit
    • eileen's avatar
      #562 remove more instances of ->free() · fccb50a6
      eileen authored
      Per #562 we have been incrementally removing these as
      1) we free resources on DAO->_destruct now and
      2) in some edge cases freeing resources in an 'inner loop' can free outer loop
      resources - resulting in a hard-to-analyse bug
      fccb50a6
  25. 06 Mar, 2019 1 commit