1. 13 Apr, 2019 1 commit
    • totten's avatar
      (NFC) SchemaStructure.php - Fix up mismatch between stored+generated code · 3eb2aab1
      totten authored
      Overview
      --------
      
      The class `CRM_Core_I18n_SchemaStructure` is autogenerated via GenCode, and it is also commited to git.
      The two forms don't match because of the recent code-style cleanup.
      
      Before
      ------
      
      After running GenCode, there appears to be uncommitted changes in `CRM_Core_I18n_SchemaStructure`.
      The changes indicate a reversion in code-style (e.g. `null` vs `NULL`; some whitespace).
      
      After
      -----
      
      GenCode produces output which matches the recent cleanup.
      
      Comments
      --------
      
      Fixing `null` / `NULL` was easy. However, the whitespace mismatch was more subtle -- because the
      `PHP_Beautifier` was messing it up. To resolve, I disabled `PHP_Beautifier` for this file, and fixed
      the underlying templates to generate well-formed code.
      
      The output of the process matches the existing code; therefore, the change
      have no functional impact (NFC).  You can see this by running `setup.sh` and
      checking the `git status`.
      3eb2aab1
  2. 07 Apr, 2019 1 commit
  3. 01 Apr, 2019 1 commit
  4. 28 Mar, 2019 1 commit
  5. 22 Feb, 2019 1 commit
  6. 21 Feb, 2019 1 commit
  7. 27 Dec, 2018 1 commit
  8. 13 Dec, 2018 1 commit
  9. 03 Dec, 2018 1 commit
  10. 02 Dec, 2018 1 commit
  11. 30 Oct, 2018 1 commit
  12. 29 Oct, 2018 1 commit
  13. 24 Oct, 2018 1 commit
  14. 27 Sep, 2018 2 commits
  15. 22 Sep, 2018 1 commit
  16. 20 Sep, 2018 2 commits
  17. 11 Sep, 2018 1 commit
  18. 07 Sep, 2018 1 commit
    • eileen's avatar
      Genericise 'ending' date filter and add tests · ad336d61
      eileen authored
      Currently we have hard coded variants of 'ending_2.year' for 'Last 2 years including today' and
      for month, week and quarter we support last month ending today etc. This adds tests
      for the units already existing and also adds support (but no UI entries) for
      ending_n.month
      ending_n.week
      ending_n.year
      ending_n.day
      ending_n.quarter
      
      There is a complexity in that the current month entries are
      ending_2.month = 'Last 60 days ending today'
      ending.quarter = 'Last 90 days ending today'
      
      I think it was done this way primarily to get the language right but as the period gets longer
      (my interest is in supporting 18 months) the mismatch between 30 days & a month becomes more &
      more of an issue.
      
      I haven't focussed on any code rationalisation as I wanted to keep this to
      additional code not changes to current & discuss / agree if this approach (ie. for the 'n'
      entries we are respectful of actual month lengths & we leave it to future option value
      enterers to worry about the wording.
      
      I actually feel a pretty good case could be made for replacing the default
      entries so instead of
      
      ending_2.month = Last 60 days including today
      
      we have
      
      ending_60.day = Last 60 days including today
      
      (This makes that change on new installs only)
      ad336d61
  19. 23 Jul, 2018 1 commit
  20. 17 Jul, 2018 1 commit
  21. 14 Jul, 2018 1 commit
  22. 10 Jun, 2018 1 commit
  23. 08 Jun, 2018 1 commit
    • eileen's avatar
      @eileenmcnaughton · ac6fc3d1
      eileen authored
      Add contact greeting to membership online receipt text message template
      ac6fc3d1
  24. 19 May, 2018 1 commit
  25. 18 May, 2018 1 commit
  26. 15 May, 2018 2 commits
  27. 25 Apr, 2018 1 commit
  28. 13 Apr, 2018 2 commits
  29. 13 Mar, 2018 1 commit
  30. 09 Mar, 2018 1 commit
  31. 28 Feb, 2018 1 commit
  32. 21 Feb, 2018 1 commit
  33. 20 Feb, 2018 1 commit
  34. 27 Dec, 2017 1 commit
  35. 21 Dec, 2017 1 commit
  36. 14 Dec, 2017 1 commit