5.69 change? regression? improvement - contribution & membership amounts are separate line items

I've realised that when purchasing a quick config membership with an additional contribution as per

In 5.60 only one line item was created - in this case the total is $100 membership + $15 tax + $10 contribution + $1.50 tax and only the tax_amount on the contribution record is wrong

In 5.69 rc the current behaviour is to create 2 line items

• this feels more correct to me and I am loath to change it back unless people want to push for that.

I should note the financial type of the current line item is currently the same as that configured for the contribution page - on the same page as the configuration of the contribution amount in question. Once again this feels more logical to me but it could pick up the financial type of the membership being purchased if that was the case people wanted to argue.

Lastly I should note that there is code in the form (which could do with testing) to ensure that if both are purchased then only the membership amount is put in the recurring contribution.