Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C CiviCRM Core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,376
    • Issues 1,376
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • CiviCRM Core
  • Issues
  • #2789

Closed
Open
Created Aug 25, 2021 by DaveD@DaveDMaintainer

Print/merge document has awkward filename if activity subject uses non-english letters

For example if the activity subject is entered in russian the filename now looks like:

4hGbFjlOwHfeQx47ozW73rjd7qXWsDCm1BbViImz4fCo37Nu8577jElZKCx9swWWBnjEKX1sGMdMeaOKj6RjlRGZ9kBpgaAdME7LPEFWgV1tJQ01rhiYksubVULNej2OBxuaytIYl6WHe83wtEhb9tMTzmK7HkG0tcCDaqz69UI6rfJdlRZeKRkcU2xckpqNOuKtnXct.pdf

In french and similar it's not too bad but accents get replaced by _, e.g. reçu becomes re_u.pdf

It's from the use of munge() in https://github.com/civicrm/civicrm-core/pull/21006. It needs something to escape malicious input or avoid invalid filenames, but munge() might not be the best choice here.

That was just merged yesterday so only affects master.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking