Add option group for civicrm_payment_processor.payment_type
The value in the table civicrm_payment_processor.payment_type field is currently an integer which is mapped to either
1 => 'Credit Card' 2 => 'Debit Card'
There has been a todo in the core for ... ahem ... 6 years now to convert it to an option group - which is what I'm proposing to do.
The primary use for the key is assigning the label to the field in order to be presented on the form as a group header and for the name to be assigned as part of a css class.
The reason Omnipay overrides it is that the the credit card / debit card binary is too brittle.
It is entirely possible to override this in an extension - but my instinct is the data base is the right place as it puts the labelling in the hands of the site administrator - which feels right.
Note that the only reason this has come up now is that I'm adding another option group for a different pseudoconstant & figured I should do this at the same time - but if there is no buy in I will leave it