activity attachments short circuit
Found a nasty little bug with activity attachments. It appears that when we process activity attachments we short circuit once an empty value is found, and no further attachments are processed. Assuming the default setting allowing 3 max attachments:
- if the first field has a file, the attachment is uploaded
- if the first field is empty and either the second or third has a file, nothing is uploaded
- if the first and second or first, second, and third field has a file, all are uploaded
I'm still working through the code, but it seems the cycle short circuits once an empty attachment field is hit, and no additional attachments are processed.