Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 935
    • Issues 935
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #2097

Closed
Open
Opened Oct 07, 2020 by eileen@eileen🎱Owner

Remove CIVICRM_FLEXMAILER_HACK_DELIVER

I started looking at fixing the memory leaks in MailingJob::runJobs (see #2073) - which is tested via MailingJob:;testMailerSendTest_email but the fact we pass $job out - to use memory & queries efficiently $job should be a CRM_Core_DAO::executeQuery() object but it is a CRM_Mailing_BAO_MailingJob - there are also a couple of places that call functions on it that could be called statically if it were a $dao

Basically we should clear the mess up - or as a minimum for this ticket remove those weird constants CIVICRM_FLEXMAILER_HACK_DELIVER

@jamie @seamuslee @mattwire @totten

Edited Oct 07, 2020 by eileen
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#2097