use default membership status rule rather than hard-coded "New"
In CRM_Contribute_BAO_Contribution::updateMembershipBasedOnCompletionOfContribution() we update the membership status when a linked contribution is completed (the method name says it all...). The code that determines the calculated status defaults to a hard coded value of "New". I believe it should instead default to whatever status rule has been flagged as default... since that's kind of the point of having a default flag.
I'd like to add a method "getDefaultStatus()" to CRM_Member_BAO_MembershipStatus to retrieve whichever status rule has been flagged as default. Interestingly, there's a class static "$_defaultMembershipStatus" that as far as I can see is never used. I'll populate that and return the value for some caching love.
Looking for concept approval.