Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 918
    • Issues 918
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #1647

Closed
Open
Opened Mar 13, 2020 by seamuslee@seamusleeDeveloper

Make packages and bower_components tokens compataible with the CiviCRM Core Reources URL setting

One of the things that has been hightlighted by dev/Financial#120 is that since this commit https://github.com/civicrm/civicrm-core/commit/1143a7815b1abbcb7cfc0cab6c754e499d11d064#diff-ff63186dcddd8213d6b992efd57d70a4 from @totten not all resources urls are treated the same. What that causes is that all bower_components and packages urls now are relative to the CiviCRM Core root path as calculated by getCiviSourceStorage rather than the CiviCRM Core Resources URL setting. Where as assets loaded from the root folder e.g. js/common.js etc would all still continue to respect the setting. This ticket is about unifying them back together in a way that is sensible. Or at least we should update the documentation and other respects to indicate that the setting no longer applies to packages and bower_components urls

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#1647