New Contribution form gives fatal error when using ONLY_FULL_GROUP_BY
I'm not sure if this is something that's changed recently but my local setup has had mysql 5.7 with only_full_group_by for a while now so it seems like it would have come up, and I can't be the only one. The related code doesn't seem to have changed though. Maybe it only comes up in a certain configuration.
I can see the PR test sites don't have only_full_group_by so I assume dmaster.demo also doesn't, so I can't easily double-check on those.
SELECT
DISTINCT ( price_set_id ) as id, s.title
FROM
civicrm_price_set s
INNER JOIN civicrm_price_field f ON f.price_set_id = s.id
INNER JOIN civicrm_price_field_value v ON v.price_field_id = f.id
WHERE
is_quick_config = 0 AND s.is_active = 1 AND s.extends LIKE '%2%' AND s.financial_type_id IN (3,1,4,2) AND v.financial_type_id IN (3,1,4,2) GROUP BY s.id [nativecode=1055 ** 'f.price_set_id' isn't in GROUP BY]
0 ...\sites\all\modules\civicrm\CRM\Core\Error.php(192): CRM_Core_Error::backtrace("backTrace", TRUE)
1 ...\sites\all\modules\civicrm\vendor\pear\pear-core-minimal\src\PEAR.php(922): CRM_Core_Error::handle(Object(DB_Error))
2 ...\sites\all\modules\civicrm\packages\DB.php(997): PEAR_Error->__construct("DB Error: unknown error", -1, 16, (Array:2), "\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
3 ...\sites\all\modules\civicrm\vendor\pear\pear-core-minimal\src\PEAR.php(575): DB_Error->__construct(-1, 16, (Array:2), "\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
4 ...\sites\all\modules\civicrm\vendor\pear\pear-core-minimal\src\PEAR.php(223): PEAR->_raiseError(Object(DB_mysqli), NULL, -1, 16, (Array:2), "\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...", "DB_Error", TRUE)
5 ...\sites\all\modules\civicrm\packages\DB\common.php(1925): PEAR->__call("raiseError", (Array:7))
6 ...\sites\all\modules\civicrm\packages\DB\mysqli.php(935): DB_common->raiseError(-1, NULL, NULL, "\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...", "1055 ** 'f.price_set_id' isn't in GROUP BY")
7 ...\sites\all\modules\civicrm\packages\DB\mysqli.php(405): DB_mysqli->mysqliRaiseError()
8 ...\sites\all\modules\civicrm\packages\DB\common.php(1231): DB_mysqli->simpleQuery("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
9 ...\sites\all\modules\civicrm\packages\DB\DataObject.php(2691): DB_common->query("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
10 ...\sites\all\modules\civicrm\packages\DB\DataObject.php(1829): DB_DataObject->_query("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
11 ...\sites\all\modules\civicrm\CRM\Core\DAO.php(421): DB_DataObject->query("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
12 ...\sites\all\modules\civicrm\CRM\Core\DAO.php(1420): CRM_Core_DAO->query("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...", TRUE)
13 ...\sites\all\modules\civicrm\CRM\Price\BAO\PriceSet.php(403): CRM_Core_DAO::executeQuery("\n SELECT\n DISTINCT ( price_set_id ) as id, s.title\n FROM\n ...")
14 ...\sites\all\modules\civicrm\CRM\Contribute\Form\Contribution.php(716): CRM_Price_BAO_PriceSet::getAssoc(FALSE, "CiviContribute")
15 ...\sites\all\modules\civicrm\CRM\Core\Form.php(595): CRM_Contribute_Form_Contribution->buildQuickForm()
16 ...\sites\all\modules\civicrm\CRM\Core\QuickForm\Action\Display.php(76): CRM_Core_Form->buildForm()
17 ...\sites\all\modules\civicrm\packages\HTML\QuickForm\Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Contribute_Form_Contribution), "display")
18 ...\sites\all\modules\civicrm\packages\HTML\QuickForm\Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Contribute_Form_Contribution), "display")
19 ...\sites\all\modules\civicrm\CRM\Core\Controller.php(335): HTML_QuickForm_Page->handle("display")
20 ...\sites\all\modules\civicrm\CRM\Contribute\Page\Tab.php(316): CRM_Core_Controller->run()
21 ...\sites\all\modules\civicrm\CRM\Contribute\Page\Tab.php(372): CRM_Contribute_Page_Tab->edit()
22 ...\sites\all\modules\civicrm\CRM\Core\Invoke.php(268): CRM_Contribute_Page_Tab->run((Array:3), NULL)
23 ...\sites\all\modules\civicrm\CRM\Core\Invoke.php(68): CRM_Core_Invoke::runItem((Array:16))
24 ...\sites\all\modules\civicrm\CRM\Core\Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
25 ...\sites\all\modules\civicrm\drupal\civicrm.module(456): CRM_Core_Invoke::invoke((Array:3))
26 ...\includes\menu.inc(527): civicrm_invoke("contribute", "add")
27 ...\index.php(21): menu_execute_active_handler()
28 {main}