Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 935
    • Issues 935
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #1547

Closed
Open
Opened Jan 23, 2020 by jensschuppe@jensschuppe

Group search form template does not add Datatables CSS classes (DT_RowClass)

Overview

As noted in a TODO, the Group search form template does not use jquery.datatables for loading child rows. That might be ok, since it's working without it, but there are CSS classes in each response.data.DT_RowClass and maybe other properties that are not being injected into the template.

This makes it difficult to distinguish nested groups from their parents and subsequent non-nested groups, since the CSS class crm-group-child (which actually has CSS for visual nesting, see here) is being added to the DT_RowClass attribute here, but that is not added to the actual markup.

Reproduction steps

  1. Click on Contacts -> Manage Groups.
  2. Add a nested group
  3. Expand the parent group to see the nested group

Current behaviour

There is no indentiation, making the nested group not be visually distinguishable from neither its parent group (ok, the parent has a triangle) nor any subsequent groups that are not nested within the same parent group.

Expected behaviour

Nested groups should be visually distinguishable by indenting them.

It should be enough to add DT_RowClass to the markup for now, but using jquery.datatables would be the real solution, I guess.

Environment information

Can be reproduced on dmaster.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#1547