Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
Core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 912
    • Issues 912
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Development
  • Core
  • Issues
  • #1452

Closed
Open
Opened Dec 06, 2019 by larssg@larssg

Recurring contributions label on contribution pages is unstylable text, leading to problems with themes

On a contribution page with recurring contributions enabled, the label for the recurring selection shows up as: <label for="is_recur">I want to contribute this amount</label> every month (including some odd spacing around between the label and the word every). If you allow more than one option (e.g. weeks and months), only the word every is outside the label tags.

Because of this, any theme that changes the styling of the labels ends up looking very bad, as the words "every month" will be in a different font, size, etc. and there can also be some weird spacing. It seems like the fix would be to apply additional label tags around the words.

This is fixable on individual sites by applying styles to the divs that contain this label, but that's obviously not a great solution.

Confirmed on latest demo.

Edited Dec 06, 2019 by larssg
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: dev/core#1452