Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C CiviCRM Core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,375
    • Issues 1,375
    • List
    • Boards
    • Service Desk
    • Milestones
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • CiviCRM Core
  • Issues
  • #1336

Closed
Open
Created Oct 21, 2019 by seamuslee@seamusleeMaintainer

CRM_ACL_BAO_Cache::updateEntry is bonkers and possibly even broken

The function mentioned seems to be written in such a way as it is trying to do two jobs at once which seems very very odd indeed.

Firstly the $id param isn't clearly spelled out however when it calls the deleteEntry() function it seems that the $id is of the contact being viewed.

however later on when it calls getAllACLs for contact and also build the cache table it is now believing that $id is the contact id of the user trying to access the contacts. Which makes more sense but still feels very much odd ball.

Edited Oct 22, 2019 by mattwire
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking