CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-09-22T01:12:32Zhttps://lab.civicrm.org/dev/core/-/issues/4616js error on contribution pages - also prevents honoree section toggling from ...2023-09-22T01:12:32ZDaveDjs error on contribution pages - also prevents honoree section toggling from working`var quickConfig = ;`
templates/CRM/Contribute/Form/Contribution/Main.tpl is expecting the $quickConfig variable to be a 0 or 1 but it's a bool. Note there's also a second spot in the tpl where the smarty var is used.
I think it might ...`var quickConfig = ;`
templates/CRM/Contribute/Form/Contribution/Main.tpl is expecting the $quickConfig variable to be a 0 or 1 but it's a bool. Note there's also a second spot in the tpl where the smarty var is used.
I think it might be from here https://github.com/civicrm/civicrm-core/pull/27234/files.
Technically this affects events with pricesets too, except you don't notice because the end result is the same.5.67.0https://lab.civicrm.org/dev/core/-/issues/4566Unsubscribe group field is no longer shown when creating a Mosaico mailing fr...2023-09-26T18:25:40ZlarsssandergreenUnsubscribe group field is no longer shown when creating a Mosaico mailing from search resultsTo reproduce:
1. Enable Mosaico
1. Do a search, select some contacts
2. Select Email - schedule/send via CiviMail
Note that the Unsubscribe Group field is missing. It will be show for a traditional mailing.
I think this a core problem...To reproduce:
1. Enable Mosaico
1. Do a search, select some contacts
2. Select Email - schedule/send via CiviMail
Note that the Unsubscribe Group field is missing. It will be show for a traditional mailing.
I think this a core problem, rather than a Mosaico problem, as it showed up for us after upgrading to 5.65, but without having upgraded Mosaico versions. Verified this is still an issue on dmaster with latest Mosaico. Possibly related to [#26585](https://github.com/civicrm/civicrm-core/pull/26585) which changed the recipient fields?https://lab.civicrm.org/dev/core/-/issues/4563Sorting of "matching field" dropdown on contact import is messed up for "rela...2023-11-29T23:24:11ZDaveDSorting of "matching field" dropdown on contact import is messed up for "related contact info"1. Contact import
2. On the map fields page, the second item in the dropdown is "related contact info" but it's not connected to the relationships like before, and the relationships are now mixed in with regular fields instead of their o...1. Contact import
2. On the map fields page, the second item in the dropdown is "related contact info" but it's not connected to the relationships like before, and the relationships are now mixed in with regular fields instead of their own section.
Also I haven't confirmed if it happens elsewhere but on a site with a saved mapping the fields that were "do not import" came up as "related contact info" when using the saved mapping after upgrade (from 5.58).5.68.0https://lab.civicrm.org/dev/core/-/issues/4560On new mailing screen the widget for include/exclude doesn't filter by number...2023-09-25T15:33:27ZDaveDOn new mailing screen the widget for include/exclude doesn't filter by numbers the same way it used to, or the same way as lettersThis might be because of https://github.com/civicrm/civicrm-core/pull/26585 but the widget itself might have been like this before too. But the previous widget didn't behave this way.
1. Create a group like "2023 All Donors".
2. On a ne...This might be because of https://github.com/civicrm/civicrm-core/pull/26585 but the widget itself might have been like this before too. But the previous widget didn't behave this way.
1. Create a group like "2023 All Donors".
2. On a new mailing try filtering for that group by typing 2023. It doesn't filter the list until you press the spacebar after the 3. Whereas if you type "all" it starts filtering right away.5.66.0https://lab.civicrm.org/dev/core/-/issues/4551Single quote in "public" event page title throws smarty error on receipt2023-09-19T14:02:11ZelilisseckSingle quote in "public" event page title throws smarty error on receiptOverview
----------------------------------------
Reproduced on a blank 5.64.2 buildkit site. If a contribution page has a single quote in the title, is set to "is_share", and has receipts on, a user registering will receive this gross m...Overview
----------------------------------------
Reproduced on a blank 5.64.2 buildkit site. If a contribution page has a single quote in the title, is set to "is_share", and has receipts on, a user registering will receive this gross message during the registration process:
![image](/uploads/e105ff57ae8d9ea64bf4d30b81f08b35/image.png)
Reproduction steps
----------------------------------------
1. On 5.64.0+ add (or edit) an event page to have a single quote in the page title such as `What's a quote doing here`
2. Check off "is_share" and turn on receipt emails.
3. Run through a registration on the front-end to observe the issue.
Comments
----------------------------------------
It looks like maybe this commit introduced this but it's hard to follow: https://github.com/civicrm/civicrm-core/commit/e90b263a9ccd7c8106c98f5f7f82d4b267820f43#diff-2652c5ed241e0c2a68dc79d97ce2b6056ad2bc8ce37aee9bce8dd69678a160a8L167
Either way the issue is coming from this line in the workflow message template `{include file="CRM/common/SocialNetwork.tpl" emailMode=true url=$eventUrl title=$event.title pageURL=$eventUrl}` where the event title needs to have single quotes escaped or something of that nature to make it through smarty.5.65.0https://lab.civicrm.org/dev/core/-/issues/4550Crash when using Event repeat tab2023-09-06T00:33:15ZDaveDCrash when using Event repeat tab1. Create an event.
2. On the repeat tab choose something and save. I chose every 1 months on first tuesday for 6 times.
3. `INSERT INTO civicrm_action_schedule (entity_value , entity_status , start_action_offset , start_action_date , re...1. Create an event.
2. On the repeat tab choose something and save. I chose every 1 months on first tuesday for 6 times.
3. `INSERT INTO civicrm_action_schedule (entity_value , entity_status , start_action_offset , start_action_date , repetition_frequency_unit , repetition_frequency_interval , used_for ) VALUES ('7' , 'first tuesday' , 5 , '20230905000000' , 'month' , 1 , 'civicrm_event' ) [nativecode=1364 ** Field 'name' doesn't have a default value]`
I think there were some recent changes with action schedules but not 100% sure yet that it's recent.5.66.0https://lab.civicrm.org/dev/core/-/issues/4548SearchKit: Totals just keep loading forever2023-09-03T18:50:15ZlarsssandergreenSearchKit: Totals just keep loading foreverTo reproduce: Create any SearchKit search, then add a SearchDisplay and select Show Totals in Footer. When you view the display, the totals will just keep loading forever (even if there aren't any totals to load).
This is a regression i...To reproduce: Create any SearchKit search, then add a SearchDisplay and select Show Totals in Footer. When you view the display, the totals will just keep loading forever (even if there aren't any totals to load).
This is a regression in 5.65 due to [#26794](https://github.com/civicrm/civicrm-core/pull/26794), this [commit](https://github.com/civicrm/civicrm-core/commit/ef1cbd865976e4e34905d0a178b8d03373c90766). I don't see anything obvious in there on a quick look through, so I'll leave this one to you, @colemanw.https://lab.civicrm.org/dev/core/-/issues/4543SearchKit: Edit in place fields are duplicated when editing2023-09-06T01:46:06ZlarsssandergreenSearchKit: Edit in place fields are duplicated when editing![image](/uploads/4629e77383b65f5f7e6affa44de68c3f/image.png)
Not just duplicated, but underneath the buttons, which looks odd. Looks like this was found in [testing for the PR](https://github.com/civicrm/civicrm-core/pull/26473), but I...![image](/uploads/4629e77383b65f5f7e6affa44de68c3f/image.png)
Not just duplicated, but underneath the buttons, which looks odd. Looks like this was found in [testing for the PR](https://github.com/civicrm/civicrm-core/pull/26473), but I'm going to log it here as it looks pretty broken from a user perspective.
Is it a regression? I think so, since this didn't use to happen.https://lab.civicrm.org/dev/core/-/issues/4542ACLs' priority sometimes does the opposite of what it says it does2023-09-13T05:50:38ZRichACLs' priority sometimes does the opposite of what it says it doesWhen you're editing an ACL the **priority** field says:
> Higher priority ACL rules will override lower priority rules
![image](/uploads/445064fd12b8757ab42f221708abf3f1/image.png)
It appears that the relevant code is at [civicrm/CRM/...When you're editing an ACL the **priority** field says:
> Higher priority ACL rules will override lower priority rules
![image](/uploads/445064fd12b8757ab42f221708abf3f1/image.png)
It appears that the relevant code is at [civicrm/CRM/ACL/BAO/ACL::loadPermittedIDs()](https://github.com/civicrm/civicrm-core/blob/804dc3e1707f7d2baf0747016ca32370c8652e54/CRM/ACL/BAO/ACL.php#L459)
and this code orders by Priority ascending.
1. If the ACL grants(or denies) access to a *particular* group(/object) then it processes every ACL in turn, meaning, it works as described because the last one will have the last say; higher priority means higher priority.
2. But if it grants(or denies) access to *all* groups(/objects) then it **stops at the first one**, with a `break`. So the **lower priority** takes it.
So for rules that refer to "all" groups(/other entities), priority is reversed(!)
I'm not sure about the code in that loop
- if it's an Allow all groups(/objects) rule for the current permission type (Edit/View), then we do an odd loop to append the keys of allGroups to ids which seems odd: why not do `$ids = array_keys($allGroups);` and save on duplicates/time/code?
- if it's a Deny all groups(/objects) rule, then there's an `array_diff()` but if you remove *all* then surely that's just clearer as `$ids = [];`?
- Finally, if it's an ACL that affects *all* groups(/objects) but the *first* ACL doesn't match on permission type (e.g. we're looking for Edit perm and the first one found grants View), then there's a `break`. **This is the cause of the priority reversal**, but it also 'breaks' :laughing: other potential configurations. e.g.
- there's no point in having 2 rules about 'all' groups(/objects) - e.g. one for edit and one for view - the one with the lowest priority prevents Civi ever considering the 2nd. If that's because edit also grants view (does it?) then we ought to stop people making such rules in the UI.
- rules like: Grant edit to all groups, followed (higher priority) by a deny group X won't be honoured.
I *think* the correct thing to do here is just get rid of that `break`.
PIng @seamuslee who authored a recent [relevant commit](https://github.com/civicrm/civicrm-core/commit/b2f5462a066fa7dd36dc9281cb24af097391327a)5.66.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/4538Error "There might be a data problem, contribution id could not be loaded fro...2023-09-07T22:24:30ZBjörn EndresError "There might be a data problem, contribution id could not be loaded from the line item" - Part 2We are getting the "There might be a data problem, contribution id could not be loaded from the line item" message with certain line items in our `5.64.0` installation.
It looks like the system assumes that a line item should _always_ h...We are getting the "There might be a data problem, contribution id could not be loaded from the line item" message with certain line items in our `5.64.0` installation.
It looks like the system assumes that a line item should _always_ have a contribution linked to it. That however, might not always be the case - in our setup we have two scenarios:
* Event registrations without registration fee
* Line items after a contribution was deleted
**Remark**: Despite the title, this is a different from #4441.https://lab.civicrm.org/dev/core/-/issues/4537Event registration breaks when CiviContribute isn't enabled2023-09-02T05:12:02ZJonGoldEvent registration breaks when CiviContribute isn't enabledThis seems closely related to #4492. I wonder where else this might arise?
```
Error: Class "Civi\Api4\LineItem" not found in CRM_Event_WorkflowMessage_EventOnlineReceipt->setParticipantID() (line 97 of /var/www/reg.wiscience.wisc.edu/...This seems closely related to #4492. I wonder where else this might arise?
```
Error: Class "Civi\Api4\LineItem" not found in CRM_Event_WorkflowMessage_EventOnlineReceipt->setParticipantID() (line 97 of /var/www/reg.wiscience.wisc.edu/web/sites/all/modules/civicrm/CRM/Event/WorkflowMessage/ParticipantTrait.php).
```5.66.0https://lab.civicrm.org/dev/core/-/issues/4529Loading fails when searching for a group that starts with a number in CiviMail2023-08-23T18:54:15ZbrienneLoading fails when searching for a group that starts with a number in CiviMailOverview
----------------------------------------
Loading of the autocomplete select widget for the *Recipients* field fails within CiviMail if the user searches with a number.
Reproduction steps
---------------------------------------...Overview
----------------------------------------
Loading of the autocomplete select widget for the *Recipients* field fails within CiviMail if the user searches with a number.
Reproduction steps
----------------------------------------
1. Make sure you have at a mailing group that starts with a number. If not, create one.
1. Go to **Mailings > New Mailing**
1. In the *Recipients* (to include) field, start typing the name of the group that starts with a number
1. Get the error message **Loading Failed**
Current behaviour
----------------------------------------
A user cannot search for recipients within CiviMail if the group starts with a number.
![Selection_028](/uploads/eaae1b1a2724b791a5a9bce8de45f0da/Selection_028.png)
vs.
![Selection_029](/uploads/cc93726a78f637591554ddc6c861d468/Selection_029.png)
Expected behaviour
----------------------------------------
A user should be able to search for recipients regardless of if a group starts with a number, letter, or other character.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.64.1
Dev notes
----------------------------------------
PHP TypeError:
```
TypeError: Return value of Civi\Api4\Query\SqlField::render() must be of the type string, null returned in Civi\Api4\Query\SqlField->render() (line 34 of Civi/Api4/Query/SqlField.php).
```
Call stack
```
Civi\Api4\Query\SqlField->render (Civi/Api4/Query/SqlField.php:34)
Civi\Api4\Query\Api4SelectQuery->buildSelectClause (Civi/Api4/Query/Api4SelectQuery.php:201)
Civi\Api4\Query\Api4Query->getSql (Civi/Api4/Query/Api4Query.php:78)
Civi\Api4\Query\Api4Query->getResults (Civi/Api4/Query/Api4Query.php:89)
Civi\Api4\Query\Api4SelectQuery->run (Civi/Api4/Query/Api4SelectQuery.php:101)
Civi\Api4\Generic\DAOGetAction->getObjects (Civi/Api4/Generic/DAOGetAction.php:107)
Civi\Api4\Generic\DAOGetAction->_run (Civi/Api4/Generic/DAOGetAction.php:94)
Civi\Api4\Provider\ActionObjectProvider->invoke (Civi/Api4/Provider/ActionObjectProvider.php:72)
Civi\API\Kernel->runRequest (Civi/API/Kernel.php:158)
Civi\Api4\Generic\AbstractAction->execute (Civi/Api4/Generic/AbstractAction.php:249)
civicrm_api4 (api/api.php:85)
Civi\Api4\Service\Spec\Provider\SearchSegmentExtraFieldProvider::getSets (ext/search_kit/Civi/Api4/Service/Spec/Provider/SearchSegmentExtraFieldProvider.php:55)
Civi\Api4\Service\Spec\Provider\SearchSegmentExtraFieldProvider->modifySpec (ext/search_kit/Civi/Api4/Service/Spec/Provider/SearchSegmentExtraFieldProvider.php:25)
Civi\Api4\Service\Spec\SpecGatherer->getSpec (Civi/Api4/Service/Spec/SpecGatherer.php:70)
Civi\Api4\Generic\DAOGetFieldsAction->getRecords (Civi/Api4/Generic/DAOGetFieldsAction.php:43)
Civi\Api4\Generic\BasicGetFieldsAction->_run (Civi/Api4/Generic/BasicGetFieldsAction.php:97)
Civi\Api4\Provider\ActionObjectProvider->invoke (Civi/Api4/Provider/ActionObjectProvider.php:72)
Civi\API\Kernel->runRequest (Civi/API/Kernel.php:158)
Civi\Api4\Generic\AbstractAction->execute (Civi/Api4/Generic/AbstractAction.php:249)
civicrm_api4 (api/api.php:85)
```https://lab.civicrm.org/dev/core/-/issues/4523Regression: Unable to set price set on contribution page under membership page2023-09-02T05:12:00ZPradeep Nayakpradpnayak@gmail.comRegression: Unable to set price set on contribution page under membership pageReplicate:
1. Create price set for membership.
2. Add contribution page.
3. Do not enable contribution amount section
4. Enable Membership, set to the price set created at step 1.
Expected results:
Set the price set on contribution pa...Replicate:
1. Create price set for membership.
2. Add contribution page.
3. Do not enable contribution amount section
4. Enable Membership, set to the price set created at step 1.
Expected results:
Set the price set on contribution page
Actual results:
Validation error- You cannot enable both Membership Signup and a Contribution Price Set on the same online contribution page.
Regression from:
https://github.com/civicrm/civicrm-core/pull/27083
https://github.com/civicrm/civicrm-core/pull/27079
https://github.com/civicrm/civicrm-core/pull/27080https://lab.civicrm.org/dev/core/-/issues/4498Non-administrators can't select mailing groups on 5.642023-09-02T05:11:56ZJonGoldNon-administrators can't select mailing groups on 5.64Non-administrators get a "loading failed" when attempting to use the new mailing widgets in 5.64. Network tab shows a 403 error, backtrace is below.
As a secondary issue - I assume that the `{error_id}` in the first line is a token tha...Non-administrators get a "loading failed" when attempting to use the new mailing widgets in 5.64. Network tab shows a 403 error, backtrace is below.
As a secondary issue - I assume that the `{error_id}` in the first line is a token that's not resolving.
You can replicate this by removing "Administer CiviCRM" from a demo site's `civicrm_webtest_user` role, since they have most other permissions. Create a new user, assign it that role.
```
Aug 14 13:52:03 [debug] AJAX Error ({error_id}): failed with exception
Array
(
[error_id] => 4tEY-xebR-Pf4L
[exception] => Civi\API\Exception\UnauthorizedException: "Authorization failed"
#0 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Kernel->authorize()
#1 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(249): Civi\API\Kernel->runRequest()
#2 /var/www/mysite.org/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
#3 /var/www/mysite.org/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Action/SearchDisplay/Run.php(107): civicrm_api4()
#4 /var/www/mysite.org/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php(107): Civi\Api4\Action\SearchDisplay\Run->processResult()
#5 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php(72): Civi\Api4\Action\SearchDisplay\AbstractRunAction->_run()
#6 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/API/Kernel.php(158): Civi\Api4\Provider\ActionObjectProvider->invoke()
#7 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(249): Civi\API\Kernel->runRequest()
#8 /var/www/mysite.org/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php(83): Civi\Api4\Generic\AbstractAction->execute()
#9 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Generic/AutocompleteAction.php(183): Civi\Api4\Action\SearchDisplay\AbstractRunAction->execute()
#10 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php(72): Civi\Api4\Generic\AutocompleteAction->_run()
#11 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/API/Kernel.php(158): Civi\Api4\Provider\ActionObjectProvider->invoke()
#12 /var/www/mysite.org/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(249): Civi\API\Kernel->runRequest()
#13 /var/www/mysite.org/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
#14 /var/www/mysite.org/web/sites/all/modules/civicrm/CRM/Api4/Page/AJAX.php(116): civicrm_api4()
#15 /var/www/mysite.org/web/sites/all/modules/civicrm/CRM/Api4/Page/AJAX.php(55): CRM_Api4_Page_AJAX->execute()
#16 /var/www/mysite.org/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(319): CRM_Api4_Page_AJAX->run()
#17 /var/www/mysite.org/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem()
#18 /var/www/mysite.org/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke()
#19 /var/www/mysite.org/web/sites/all/modules/civicrm/drupal/civicrm.module(471): CRM_Core_Invoke::invoke()
#20 /var/www/mysite.org/web/includes/menu.inc(527): civicrm_invoke()
#21 /var/www/mysite.org/web/index.php(21): menu_execute_active_handler()
#22 {main}
```5.64.1https://lab.civicrm.org/dev/core/-/issues/4494Undefined $line and $value when sending offline email receipt2023-09-02T05:11:57ZDaveDUndefined $line and $value when sending offline email receiptLooks like some code was moved around and these vars don't make sense out of loop context: https://github.com/civicrm/civicrm-core/blob/effdba1ef120ca88b270606a0e28db5304e3e621/CRM/Event/Form/Participant.php#L1353Looks like some code was moved around and these vars don't make sense out of loop context: https://github.com/civicrm/civicrm-core/blob/effdba1ef120ca88b270606a0e28db5304e3e621/CRM/Event/Form/Participant.php#L13535.64.1https://lab.civicrm.org/dev/core/-/issues/4492(regression) Add/Edit Scheduled Reminders page does not load if CiviContribut...2023-09-02T05:11:57ZJonGold(regression) Add/Edit Scheduled Reminders page does not load if CiviContribute is disabledWorks on 5.63, not on 5.64. Hard to bisect because `getDefaultEntity()` becomes a required method somewhere along the line.
Easy to replicate:
* Disable CiviContribute.
* Try to create a scheduled reminder.
You'll get this error:
```...Works on 5.63, not on 5.64. Hard to bisect because `getDefaultEntity()` becomes a required method somewhere along the line.
Easy to replicate:
* Disable CiviContribute.
* Try to create a scheduled reminder.
You'll get this error:
```
Error: Class "Civi\Api4\ContributionRecur" not found in CRM_Contribute_Tokens->getRelatedTokens() (line 59 of /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Contribute/Tokens.php).
```
Seems related to #4123 (pinging @seamuslee) but that was merged in 5.63 and it seems fine in 5.63.
I'd throw a conditional into `CRM_Contribute_Tokens->getRelatedTokens()` to fix this but given all the work on moving to extensions, I suspect this is a deeper issue that needs looking at.https://lab.civicrm.org/dev/core/-/issues/4486Cannot change membership price set on contribution pages2023-08-17T21:36:53ZbrienneCannot change membership price set on contribution pagesOverview
----------------------------------------
On the Membership tab of a Contribution page, a user cannot successfully change the Membership Price Set after the initial configuration of the page.
Reproduction steps
-----------------...Overview
----------------------------------------
On the Membership tab of a Contribution page, a user cannot successfully change the Membership Price Set after the initial configuration of the page.
Reproduction steps
----------------------------------------
1. Go to **Memberships > Manage Price Sets** -> Create two price sets, each for memberships
1. Go to **Contributions > Manage Contribution Pages** -> Either create a new page, or if using a civibuild site you can use the pre-built Membership page
1. Click on the *Amounts* tab -> make sure *Contribution Amounts section enabled?* is unchecked
1. Click on the *Memberships* tab ->Set the *Membership Price Set* to your first Price Set
1. Click **Save**
1. Change the *Membership Price Set* to your second Price Set
1. Click **Save**
1. An error message will be displayed and the second price set will not have been saved as the selection:
Current behaviour
----------------------------------------
A user cannot switch the options for the *Membership Price Set* field, and instead get the follow error, despite that the *Amounts* tab is configured correctly (
```
You cannot enable both Membership Signup and a Contribution Price Set on the same online contribution page.
```
Expected behaviour
----------------------------------------
A user should be able to switch the options for the Membership Price Set without error.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.66.alpha1
Comments
----------------------------------------
This issue is being caused by a comparison value problem on line 249 in CRM/Member/Form/MembershipBlock.php. `getFieldValue()` is returning a string padded with non printable characters, and the following `if` statement is trying to compare that to a string without those additional characters, so the two values are determined to be unequal and this error is thrown.
I have a patch on GitHub to resolve this: [#27030](https://github.com/civicrm/civicrm-core/pull/27030)5.64.1https://lab.civicrm.org/dev/core/-/issues/4483(regression) SearchKit doesn't handle delegated access permissions correctly2023-09-02T22:17:28ZJonGold(regression) SearchKit doesn't handle delegated access permissions correctlyA git bisect traced this to https://github.com/civicrm/civicrm-core/pull/25969. It works in 5.60.
When a user does not have the 'all CiviCRM permissions and ACLs', making a contact field in-line editable that isn't on the primary entit...A git bisect traced this to https://github.com/civicrm/civicrm-core/pull/25969. It works in 5.60.
When a user does not have the 'all CiviCRM permissions and ACLs', making a contact field in-line editable that isn't on the primary entity causes a crash (and no search results returned).
**Steps to Replicate**
* Create a new user without 'all CiviCRM permissions and ACLs' permission, but otherwise an administrator. This may not be necessary on non-Drupal systems - but user 1 having all permissions blocks replication.
* Create the SearchKit query in the screenshot below (I've exported it for easier use).
* Create a table display, make the "Gender" field in-line editable.
* Press "Preview"
**Expected Result**
You see search results.
**Actual Result**
500 error - `getFieldValue failed`.
The issue is in `CRM_Contact_BAO_Contact::_checkAccess()`. This attempts to access `$record['id']` but after PR #25969, the record is passing `id_01.id`.
![Selection_1999](/uploads/5e6a7126c09291fc5c1cf4eb6e87c300/Selection_1999.png)
```json
[
[
"SavedSearch",
"save",
{
"records": [
{
"name": "delegated_permission_test",
"label": "delegated permission test",
"form_values": null,
"mapping_id": null,
"search_custom_id": null,
"api_entity": "Participant",
"api_params": {
"version": 4,
"select": [
"id",
"Participant_Contact_contact_id_01.display_name",
"Participant_Contact_contact_id_01.gender_id:label"
],
"orderBy": [],
"where": [],
"groupBy": [],
"join": [
[
"Contact AS Participant_Contact_contact_id_01",
"LEFT",
[
"contact_id",
"=",
"Participant_Contact_contact_id_01.id"
]
]
],
"having": []
},
"expires_date": null,
"description": null
}
]
}
],
[
"SearchDisplay",
"save",
{
"records": [
{
"name": "delegated_permission_test_Table_1",
"label": "delegated permission test Table 1",
"saved_search_id.name": "delegated_permission_test",
"type": "table",
"settings": {
"description": null,
"sort": [],
"limit": 50,
"pager": [],
"placeholder": 5,
"columns": [
{
"type": "field",
"key": "id",
"dataType": "Integer",
"label": "Participant ID",
"sortable": true
},
{
"type": "field",
"key": "Participant_Contact_contact_id_01.display_name",
"dataType": "String",
"label": "Participant Contact: Display Name",
"sortable": true,
"title": "Participant Contact: Display Name"
},
{
"type": "field",
"key": "Participant_Contact_contact_id_01.gender_id:label",
"dataType": "Integer",
"label": "Participant Contact: Gender",
"sortable": true,
"editable": true
}
],
"actions": true,
"classes": [
"table",
"table-striped"
]
},
"acl_bypass": false
}
]
}
]
]
```colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/4481View-only custom fields not getting merged2023-09-02T05:11:55ZDaveDView-only custom fields not getting mergedSee https://github.com/civicrm/civicrm-core/pull/26969See https://github.com/civicrm/civicrm-core/pull/269695.65.0https://lab.civicrm.org/dev/core/-/issues/4480Mail accounts help bubbles not working on edit form2023-09-02T05:11:56ZDaveDMail accounts help bubbles not working on edit form1. Go to edit an existing mail account.
1. If you have popups turned off it's more obvious there's a problem - red error box.
1. If it says bounce processing change the dropdown to activity.
1. For the fields that appear with help bubble...1. Go to edit an existing mail account.
1. If you have popups turned off it's more obvious there's a problem - red error box.
1. If it says bounce processing change the dropdown to activity.
1. For the fields that appear with help bubbles, click the bubbles. No help text.
1. Note it's ok on the add new form.
Works in 5.63.
I don't see the problem on other forms though so something different about this form.5.65.0