CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2024-01-31T08:51:22Zhttps://lab.civicrm.org/dev/core/-/issues/4937(regression) FormBuilder forms with yes/no and autocomplete fail in Firefox2024-01-31T08:51:22ZJonGold(regression) FormBuilder forms with yes/no and autocomplete fail in FirefoxOverview
----------------------------------------
In Civi 5.69 (and master) forms that meet certain criteria fail to submit in Firefox. I believe there are scenarios other than the one I describe below, but this represents a relatively ...Overview
----------------------------------------
In Civi 5.69 (and master) forms that meet certain criteria fail to submit in Firefox. I believe there are scenarios other than the one I describe below, but this represents a relatively simple replicable case.
I did a `git bisect` and tracked it down to https://github.com/civicrm/civicrm-core/pull/28452 (no Gitlab bot that's not a pull request for this issue).
Reproduction steps
----------------------------------------
I've attached a FormBuilder form that's a relatively simple replication case. This requires a field of type "Yes/No" called `yesno` in a custom group with name `contact_fields2`.
Select "yes" or "no" on the custom field, press "Submit".
Current behaviour
----------------------------------------
If you submit this form in Firefox, you see the error "Sorry an error occurred and your information was not saved.", but then the page reloads, though the URL changes:
e.g.:
```
# original
http://dmaster.localhost/civicrm/org-member-renewal
# post-submit
http://dmaster.localhost/civicrm/org-member-renewal?contact-fields-2-yesno-1=0
```
In Chrome, the page submits successfully.
There's also a ton of JS console errors.
On my civicrm-buildkit site, they looked like this:
```
Error: [$rootScope:infdig] http://errors.angularjs.org/1.8.2/$rootScope/infdig?p0=10&p1=%5B%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%7D%5D%5D
Angular 41
jQuery 2
<anonymous> Angular
jQuery 7
<anonymous> Common.js:1659
jQuery 8
angular.js:15697:15
```
On my 5.69.2 non-buildkit site, it looked like this:
```
Uncaught Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: [[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":{}},"oldVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."}}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}],[{"msg":"fn: fn","newVal":{"formName":"afform:afformOrganizationMembershipRenewal","fieldName":"Organization2:id","values":"..."},"oldVal":"..."}]]
https://errors.angularjs.org/1.8.2/$rootScope/infdig?p0=10&p1=%5B%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%7B%7D%7D%2C%22oldVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%2C%5B%7B%22msg%22%3A%22fn%3A%20fn%22%2C%22newVal%22%3A%7B%22formName%22%3A%22afform%3AafformOrganizationMembershipRenewal%22%2C%22fieldName%22%3A%22Organization2%3Aid%22%2C%22values%22%3A%22...%22%7D%2C%22oldVal%22%3A%22...%22%7D%5D%5D
Angular 8
$onChanges http://reamp.local/wp-content/plugins/civicrm/civicrm/ang/crmUi.js?r=GUtKAen_US:789
Angular 34
jQuery 2
<anonymous> Angular
jQuery 7
<anonymous> http://reamp.local/wp-content/plugins/civicrm/civicrm/js/Common.js?r=GUtKAen_US:1659
jQuery 8
angular.js:138:12
```
Expected behaviour
----------------------------------------
Form should always submit successfully.
Environment information
----------------------------------------
* __Browser:__ Firefox 120.0.1
* __CiviCRM:__ master
* __PHP:__ 8.1
* __CMS:__ Drupal 7
* __Database:__ Replicated w/ MariaDB 10.6 and 10.11
* __Web Server:__ Apache 2.45.69.4https://lab.civicrm.org/dev/core/-/issues/4932Outbound SMS and Send Email action missing when viewing contact summary2024-01-24T16:39:34ZDaveDOutbound SMS and Send Email action missing when viewing contact summaryI think it's from https://github.com/civicrm/civicrm-core/pull/27973/files. Note how it used to check for special types [BEFORE](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-dfbc52a8403be6cfef3ecfd332d7b7fcc2e3ca579b325d...I think it's from https://github.com/civicrm/civicrm-core/pull/27973/files. Note how it used to check for special types [BEFORE](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-dfbc52a8403be6cfef3ecfd332d7b7fcc2e3ca579b325d4a419c39a3226fdbd7L90) checking filter=1. But now it includes the filter [up front](https://github.com/civicrm/civicrm-core/pull/27973/files#diff-6edb9e1abb30f7ec07c2ea0cecde36eefe0bebf9535022ecd8e8625f02517192R85) so it doesn't get a chance to check for SMS.5.70.0https://lab.civicrm.org/dev/core/-/issues/4931Auto-renew checkbox hidden by default2024-01-29T03:48:57ZpatricklamAuto-renew checkbox hidden by defaultOverview
----------------------------------------
When signing up for a membership, where the membership type has auto-renew being available as an option, the auto-renew checkbox is initially hidden and only shows up after clicking on th...Overview
----------------------------------------
When signing up for a membership, where the membership type has auto-renew being available as an option, the auto-renew checkbox is initially hidden and only shows up after clicking on the membership type.
Reproduction steps
----------------------------------------
1. Create a membership type with auto-renew optional.
2. Create a contribution page with auto-renew optional.
3. Visit the contribution page. Membership amount shown, but not the "Please renew my membership automatically" checkbox.
4. Clicking on the membership amount causes the autorenew checkbox to appear.
Current behaviour
----------------------------------------
Autorenew checkbox is initially invisible and only appears after clicking on the membership amount.
Expected behaviour
----------------------------------------
Autorenew checkbox should appear on page load.
Environment information
----------------------------------------
Can reproduce on the demo sandbox with Firefox and Chrome.
Comments
----------------------------------------
Patch available: https://github.com/civicrm/civicrm-core/pull/290235.70.0https://lab.civicrm.org/dev/core/-/issues/4930Activity count is incorrect if contact is source and target2024-01-28T20:05:48ZbgmActivity count is incorrect if contact is source and targetRegression on 5.70/RC:
- Disable the AdminUI extension
- Go to a contact record
- New activity / Meeting
- Enter the same contact in the fields "with contact" and "assigned to contact"
- Save
The activity count displayed on the tab wil...Regression on 5.70/RC:
- Disable the AdminUI extension
- Go to a contact record
- New activity / Meeting
- Enter the same contact in the fields "with contact" and "assigned to contact"
- Save
The activity count displayed on the tab will count will be 3 instead of 1:
![image](/uploads/f4feac6831c8b35d58e88547129de366/image.png)
The AdminUI core-ext mitigates this problem by re-calculating, but we still see the incorrect count for a few seconds.5.70.0https://lab.civicrm.org/dev/core/-/issues/4927unrelease regression (master) Event with no participant yet is still full2024-01-28T19:35:40Zspalmstromunrelease regression (master) Event with no participant yet is still fullOverview
----------------------------------------
If you create an event on the Demo site and attempt to register, you are told it is full, though the event is new.
Reproduction steps
----------------------------------------
1. Create a...Overview
----------------------------------------
If you create an event on the Demo site and attempt to register, you are told it is full, though the event is new.
Reproduction steps
----------------------------------------
1. Create a new event with Online Registration.
1. Attempt to register.
1. You are told the event is full.
2.
Current behaviour
----------------------------------------
You are told the event is full.
```
Expected behaviour
----------------------------------------
You should be able to register for the event.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Edge_. but probably irrelevant.
* __CiviCRM:__ _5.1.Alpha1_ The demo system.
* __PHP:__ _8.1__
* __CMS:__ _Whatever Demo is running on._
* __Database:__ _Whatever Demo uses_
* __Web Server:__ _Whatever Demo uses_
Comments
----------------------------------------
I saw this problem on the Demo system. I'm unable to investigate on my local system due to another issue that I shall be raising.5.71.0https://lab.civicrm.org/dev/core/-/issues/4918All my events say "currently full"2024-01-29T14:17:43ZDaveDAll my events say "currently full"If you don't put in any value for the max number of participants, then on the event info page it will always say the event is full.
Probably from https://github.com/civicrm/civicrm-core/pull/28984?If you don't put in any value for the max number of participants, then on the event info page it will always say the event is full.
Probably from https://github.com/civicrm/civicrm-core/pull/28984?5.71.0https://lab.civicrm.org/dev/core/-/issues/4912Since civicrm 5.69, "Other amount" field cannot be filled on many themes.2024-01-27T18:38:38ZChabadrichmondSince civicrm 5.69, "Other amount" field cannot be filled on many themes.## Overview
Since upgrading to 5.69 users cannot fill out the other amount field on contribution pages on many themes, I tried, Divi, Blocksy, Kadence, Astra and all have the issue, I did notice that it works on 2023 and 2024)
EDIT (@k...## Overview
Since upgrading to 5.69 users cannot fill out the other amount field on contribution pages on many themes, I tried, Divi, Blocksy, Kadence, Astra and all have the issue, I did notice that it works on 2023 and 2024)
EDIT (@kcristiano ) Not CMS specific - see https://d10-master.demo.civicrm.org/civicrm/contribute/transact?reset=1&id=4
https://chat.civicrm.org/civicrm/pl/nbsyhud8kiyd7nutzqiqcyfhzo
* **Browser:** _any_
* **CiviCRM:** _5.69+_
* **CMS:** _Any_
Screenshot posted below
![civi other amount.gif](/uploads/b4ff148f46514ade2106c07e56d2c0b8/civi_other_amount.gif)5.69.3https://lab.civicrm.org/dev/core/-/issues/4910Create New Contact with Sub-Type Brings Up Wrong Custom Field Sets2024-01-17T21:48:17ZpbarmakCreate New Contact with Sub-Type Brings Up Wrong Custom Field SetsAs of v5.69 (maybe earlier, not sure), whenever we go to "Contacts / Create Individual / Create [specific sub-type] ... " to create one of our sub-types, the sub-type-specific custom fields do not show up. They do show up when creating j...As of v5.69 (maybe earlier, not sure), whenever we go to "Contacts / Create Individual / Create [specific sub-type] ... " to create one of our sub-types, the sub-type-specific custom fields do not show up. They do show up when creating just an Individual and then selecting the sub-type from the field, but not via the URL with the sub-type in it.
Please see the full description here: https://civicrm.stackexchange.com/questions/46210/create-new-contact-with-sub-type-brings-up-wrong-custom-field-sets5.69.3https://lab.civicrm.org/dev/core/-/issues/4903New Individual on-the-fly popup has `Undefined variable $cancelURL`2024-01-11T01:23:41ZDaveDNew Individual on-the-fly popup has `Undefined variable $cancelURL`This must be pretty recent, probably in master. There's a couple ways to see it. Here's one:
1. Open the browser network tab.
2. New Contribution
3. In the contact field click New Individual.
4. Note the url of the ajax call in the brow...This must be pretty recent, probably in master. There's a couple ways to see it. Here's one:
1. Open the browser network tab.
2. New Contribution
3. In the contact field click New Individual.
4. Note the url of the ajax call in the browser network tab, and remove the snippet param and then visit it in another tab: `/civicrm/profile/create?reset=1&context=dialog&gid=4&returnExtra=display_name,sort_name,email&crmAngularModules=crmResource`
5. `Warning: Undefined variable $cancelURL in CRM_Profile_Form_Edit->buildQuickForm() (line 199 of .../CRM/Profile/Form/Edit.php)`5.70.0https://lab.civicrm.org/dev/core/-/issues/4898Regression - missing getLinks fails too hard2024-01-11T22:46:52ZeileenRegression - missing getLinks fails too hardOn dmaster with civi-import enabled I can't access search kit after some importing has been done
![image](/uploads/3b3e39405088c7bf20465d031e652b50/image.png)
@colemanw I can take a look at fixing for civi-import but I think this shoul...On dmaster with civi-import enabled I can't access search kit after some importing has been done
![image](/uploads/3b3e39405088c7bf20465d031e652b50/image.png)
@colemanw I can take a look at fixing for civi-import but I think this should degrade more gracefull5.70.0https://lab.civicrm.org/dev/core/-/issues/4897Search Kit row links with comparison conditions broken2024-01-12T04:49:22ZufundoSearch Kit row links with comparison conditions brokenOverview
----------------------------------------
Search Kit row links with long conditionals seem to be broken in 5.69.
To reproduce
-----------------------------------------
Set up a Search Kit. Add a buttons column with a link that ...Overview
----------------------------------------
Search Kit row links with long conditionals seem to be broken in 5.69.
To reproduce
-----------------------------------------
Set up a Search Kit. Add a buttons column with a link that has a 3-part condition clause.
e.g.
![image](/uploads/8d73cea710d0b7309fb83b76f3f74737/image.png)
The links wont show on the right rows (the 1001 is getting overwritten with the domain ID)
To fix
------------------------------------------
https://github.com/civicrm/civicrm-core/pull/28944https://lab.civicrm.org/dev/core/-/issues/4896Conflict between cividiscount and public registrations2024-01-10T00:01:31ZtottenConflict between cividiscount and public registrationsOverview
----------------------------------------
There appears to be some conflict between CiviCRM 5.70-rc and cividiscount 3.8.9. I have not examined sufficiently to determine which one should be updated.
Reproduction steps
---------...Overview
----------------------------------------
There appears to be some conflict between CiviCRM 5.70-rc and cividiscount 3.8.9. I have not examined sufficiently to determine which one should be updated.
Reproduction steps
----------------------------------------
1. Install CiviCRM 5.70 and cividiscount 3.8.9 (current master, via git)
1. Create a free event with online registration. (I disabled confirmation-web-page and enabled conformation-email, FWIW.)
1. In a new/private window:
1. Open the event info page (`civicrm/event/info?reset=1&id=7`)
1. Open the event registration page (`civicrm/event/register?id=7&reset=1`)
Current behaviour
----------------------------------------
`civicrm/event/info` works but `civicrm/event/register` raises an error:
```
ReflectionException: "Property CRM_Event_Form_Registration_Register::$_contactID does not exist"
#0 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php(2114): ReflectionProperty->__construct(Object(CRM_Event_Form_Registration_Register), "_contactID")
#1 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/tools/extensions/cividiscount/cividiscount.php(453): CRM_Core_Form->getVar("_contactID")
#2 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/tools/extensions/cividiscount/cividiscount.php(95): _cividiscount_get_form_contact_id(Object(CRM_Event_Form_Registration_Register))
#3 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(276): cividiscount_civicrm_buildForm("CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register))
#4 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook/DrupalBase.php(73): CRM_Utils_Hook->runHooks((Array:60), "civicrm_buildForm", 2, "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL)
#5 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php(314): CRM_Utils_Hook_DrupalBase->invokeViaUF(2, "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL, "civicrm_buildForm")
#6 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(251): Civi\Core\CiviEventDispatcher::delegateToUF(Object(Civi\Core\Event\GenericHookEvent), "hook_civicrm_buildForm", Object(Civi\Core\UnoptimizedEventDispatcher))
#7 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/vendor/symfony/event-dispatcher/EventDispatcher.php(73): Symfony\Component\EventDispatcher\EventDispatcher->callListeners((Array:1), "hook_civicrm_buildForm", Object(Civi\Core\Event\GenericHookEvent))
#8 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Core/CiviEventDispatcher.php(263): Symfony\Component\EventDispatcher\EventDispatcher->dispatch(Object(Civi\Core\Event\GenericHookEvent), "hook_civicrm_buildForm")
#9 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(168): Civi\Core\CiviEventDispatcher->dispatch("hook_civicrm_buildForm", Object(Civi\Core\Event\GenericHookEvent))
#10 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/Hook.php(495): CRM_Utils_Hook->invoke((Array:2), "CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register), NULL, NULL, NULL, NULL, "civicrm_buildForm")
#11 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php(766): CRM_Utils_Hook::buildForm("CRM_Event_Form_Registration_Register", Object(CRM_Event_Form_Registration_Register))
#12 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(76): CRM_Core_Form->buildForm()
#13 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Event_Form_Registration_Register), "display")
#14 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Event_Form_Registration_Register), "display")
#15 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Controller.php(355): HTML_QuickForm_Page->handle("display")
#16 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(322): CRM_Core_Controller->run((Array:3), NULL)
#17 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(69): CRM_Core_Invoke::runItem((Array:18))
#18 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#19 /Users/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/drupal/civicrm.module(472): CRM_Core_Invoke::invoke((Array:3))
#20 /Users/totten/bknix/build/dmaster/web/includes/menu.inc(527): civicrm_invoke("event", "register")
#21 /Users/totten/bknix/build/dmaster/web/index.php(24): menu_execute_active_handler()
#22 {main}
```
Expected behaviour
----------------------------------------
Show registration screen
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ Firefox
* __CiviCRM:__ 5.70-rc
* __PHP:__ 8.1
* __CMS:__ D7
* __Database:__ MySQL 5.7
* __Web Server:__ Apachehttps://lab.civicrm.org/dev/core/-/issues/4894Fatal error when searching a contact2024-01-10T14:07:35ZGuillaumeSorelFatal error when searching a contactOn CiviCRM 5.69.1 when I do a simple contact search I get this error and can't see the contact
```[error]
$Fatal Error Details = array:3 [
"message" => """
Unexpected result from getcountArray\n
(\n
[error_code] => -2...On CiviCRM 5.69.1 when I do a simple contact search I get this error and can't see the contact
```[error]
$Fatal Error Details = array:3 [
"message" => """
Unexpected result from getcountArray\n
(\n
[error_code] => -2\n
[sql] => \n
[debug_info] => SELECT count(*) as c\n
FROM civicrm_activity a\n
LEFT JOIN civicrm_case_activity actjoin_case_id ON (actjoin_case_id.activity_id = a.id)\n
WHERE (((`a`.`activity_type_id` Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHERE contact_id = "27478"))\n
AND (actjoin_case_id.case_id IS NULL)\n
AND (a.is_current_revision = "1")\n
AND (a.activity_type_id IN ("1", "55", "56", "57", "58", "59", "70", "71", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "38", "39", "40", "41", "44", "45", "46", "47", "48", "49", "50", "51", "52", "53", "54", "60", "61", "62", "63", "64", "65", "66", "67", "68", "69", "72", "73", "74", "75", "76", "77", "78", "80", "82", "84", "86", "88", "89"))\n
AND (a.is_test = "0")\n
AND (a.is_deleted = "0")\n
[nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHE...' at line 4]\n
[entity] => Activity\n
[action] => get\n
[is_error] => 1\n
[error_message] => case_id is not valid : 1\n
[debug_information] => \n
)\n
"""
"code" => null
"exception" => CRM_Core_Exception {#36862
-errorData: array:5 [
"error_code" => 0
"entity" => "Activity"
"action" => "getcount"
"is_error" => 1
"error_message" => """
Unexpected result from getcountArray\n
(\n
[error_code] => -2\n
[sql] => \n
[debug_info] => SELECT count(*) as c\n
FROM civicrm_activity a\n
LEFT JOIN civicrm_case_activity actjoin_case_id ON (actjoin_case_id.activity_id = a.id)\n
WHERE (((`a`.`activity_type_id` Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHERE contact_id = "27478"))\n
AND (actjoin_case_id.case_id IS NULL)\n
AND (a.is_current_revision = "1")\n
AND (a.activity_type_id IN ("1", "55", "56", "57", "58", "59", "70", "71", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "38", "39", "40", "41", "44", "45", "46", "47", "48", "49", "50", "51", "52", "53", "54", "60", "61", "62", "63", "64", "65", "66", "67", "68", "69", "72", "73", "74", "75", "76", "77", "78", "80", "82", "84", "86", "88", "89"))\n
AND (a.is_test = "0")\n
AND (a.is_deleted = "0")\n
[nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHE...' at line 4]\n
[entity] => Activity\n
[action] => get\n
[is_error] => 1\n
[error_message] => case_id is not valid : 1\n
[debug_information] => \n
)\n
"""
]
#cause: null
-_trace: null
#message: """
Unexpected result from getcountArray\n
(\n
[error_code] => -2\n
[sql] => \n
[debug_info] => SELECT count(*) as c\n
FROM civicrm_activity a\n
LEFT JOIN civicrm_case_activity actjoin_case_id ON (actjoin_case_id.activity_id = a.id)\n
WHERE (((`a`.`activity_type_id` Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHERE contact_id = "27478"))\n
AND (actjoin_case_id.case_id IS NULL)\n
AND (a.is_current_revision = "1")\n
AND (a.activity_type_id IN ("1", "55", "56", "57", "58", "59", "70", "71", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "38", "39", "40", "41", "44", "45", "46", "47", "48", "49", "50", "51", "52", "53", "54", "60", "61", "62", "63", "64", "65", "66", "67", "68", "69", "72", "73", "74", "75", "76", "77", "78", "80", "82", "84", "86", "88", "89"))\n
AND (a.is_test = "0")\n
AND (a.is_deleted = "0")\n
[nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'Array)))\n
AND (a.id IN (SELECT activity_id FROM civicrm_activity_contact WHE...' at line 4]\n
[entity] => Activity\n
[action] => get\n
[is_error] => 1\n
[error_message] => case_id is not valid : 1\n
[debug_information] => \n
)\n
"""
#code: 0
#file: "/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/api/api.php"
#line: 138
trace: {
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/api/api.php:138 {
civicrm_api3(string $entity, string $action, array $params = [])
› if (is_array($result) && !empty($result['is_error'])) {
› throw new CRM_Core_Exception($result['error_message'], $result['error_code'] ?? 'undefined', $result);
› }
}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Activity/BAO/Activity.php:898 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Contact/BAO/Contact.php:2641 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Contact/Page/View/Summary.php:434 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Contact/Page/View/Summary.php:255 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Contact/Page/View/Summary.php:83 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php:322 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php:69 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php:36 { …}
/var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm.php:1231 { …}
/var/www/vhosts/domain/httpdocs/wp-includes/class-wp-hook.php:308 { …}
/var/www/vhosts/domain/httpdocs/wp-includes/class-wp-hook.php:332 { …}
/var/www/vhosts/domain/httpdocs/wp-includes/plugin.php:517 { …}
/var/www/vhosts/domain/httpdocs/wp-admin/admin.php:259 { …}
}
}
]
2024-01-08 13:30:57+0100 [debug] $backTrace = #0 /var/www/vhosts/smc-cse.fr/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Core/Error.php(443): CRM_Core_Error::backtrace("backTrace", TRUE)
#1 /var/www/vhosts/smc-cse.fr/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Core/Invoke.php(39): CRM_Core_Error::handleUnhandledException(Object(CRM_Core_Exception))
#2 /var/www/vhosts/domain/httpdocs/wp-content/plugins/civicrm/civicrm.php(1231): CRM_Core_Invoke::invoke((Array:3))
#3 /var/www/vhosts/domain/httpdocs/wp-includes/class-wp-hook.php(308): CiviCRM_For_WordPress->invoke("")
#4 /var/www/vhosts/domain/httpdocs/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters("", (Array:1))
#5 /var/www/vhosts/domain/httpdocs/wp-includes/plugin.php(517): WP_Hook->do_action((Array:1))
#6 /var/www/vhosts/domain/httpdocs/wp-admin/admin.php(259): do_action("toplevel_page_CiviCRM")
#7 {main}```https://lab.civicrm.org/dev/core/-/issues/4893No event registration confirmation email sent for free events2024-01-12T04:49:21ZBobSNo event registration confirmation email sent for free events## Overview
Upon registering for a free event, no confirmation email is sent.
## Reproduction steps
1. Register for an event configured with `Paid Event` = No and `Send Confirmation Email` = Yes.
## Current behaviour
No confirmation...## Overview
Upon registering for a free event, no confirmation email is sent.
## Reproduction steps
1. Register for an event configured with `Paid Event` = No and `Send Confirmation Email` = Yes.
## Current behaviour
No confirmation email is sent.
## Expected behaviour
A confirmation email is sent.
## Environment information
**CiviCRM:** _5.69.1_
## Comments
Regression introduced by https://github.com/civicrm/civicrm-core/commit/36723fe908973f72dc5cd57a249ee236fcfec868
Specifically, the Issue is caused by a change to CRM_Event_Form_Registration::processRegistration:
* From: `if ($this->_contributeMode != 'checkout' || $this->_contributeMode != 'notify')`
* To: `if ($this->getPaymentProcessorObject()->supports('noReturn'))`
This returns FALSE if there is no payment processor, causing the email to not be sent.5.69.2https://lab.civicrm.org/dev/core/-/issues/4888Location field on case activity isn't aligned properly2024-01-10T17:48:56ZDaveDLocation field on case activity isn't aligned properly![untitled3](/uploads/7571ef6057725f323e355fda70c7cd1c/untitled3.png)![untitled3](/uploads/7571ef6057725f323e355fda70c7cd1c/untitled3.png)https://lab.civicrm.org/dev/core/-/issues/4884"CiviCRM News" on Backdrop has awkward accordions on default themes2024-01-04T22:21:56Ztotten"CiviCRM News" on Backdrop has awkward accordions on default themesOn Backdrop (eg https://bmaster.demo.civicrm.org/civicrm/ ; user: `demo`; pass: `demo`) with default themes, the "CiviCRM News" dashlet is looking weird:
![Screenshot_2024-01-03_at_9.08.21_PM](/uploads/8d22ff7703e5f9eaf856a9e413be66dd/...On Backdrop (eg https://bmaster.demo.civicrm.org/civicrm/ ; user: `demo`; pass: `demo`) with default themes, the "CiviCRM News" dashlet is looking weird:
![Screenshot_2024-01-03_at_9.08.21_PM](/uploads/8d22ff7703e5f9eaf856a9e413be66dd/Screenshot_2024-01-03_at_9.08.21_PM.png)
Theories:
* At first blush, it feels like it would be a regression related to the accordion updates circa 5.69.x (eg https://lab.civicrm.org/dev/user-interface/-/issues/60). However, there's a similar problem in 5.68. This suggests that it's not a simple regression:
![Screenshot_2024-01-03_at_10.21.14_PM](/uploads/ebe6ad88b770ba5337a965cc887d194b/Screenshot_2024-01-03_at_10.21.14_PM.png)
(Note: Slightly different visual appearance with double arrows)
* Could it be that there's always been a bug like this.
* Could it be that the accordion cleanup led to changes in the news feed? In which case, maybe the question is about infra: How to make the feed(s) work with different versions of Civi?
* Interestingly, I went to an old/local copy of `bcmaster`, updated to 5.68+5.69+master, and... it seemed to display fine. But on clean builds of 5.68 and master, it didn't. (This suggests that it might still be some kind of regression.)
* (*It could be that I have a cache of an older feed? This might support the idea of an issue in how the feed works with different client environments?*)5.69.0https://lab.civicrm.org/dev/core/-/issues/4880Price field and value weights not respected in 5.682024-01-02T23:55:23ZJonGoldPrice field and value weights not respected in 5.68Overview
----------------------------------------
Price fields and values are sorted by primary key, not weight, on contribution pages.
Reproduction steps
----------------------------------------
1. Open up a price set.
1. Change the we...Overview
----------------------------------------
Price fields and values are sorted by primary key, not weight, on contribution pages.
Reproduction steps
----------------------------------------
1. Open up a price set.
1. Change the weight of some items.
1. See if it changed the contribution page..
Current behaviour
----------------------------------------
Sort by primary key.
Expected behaviour
----------------------------------------
Sort by weight.
Comments
----------------------------------------
PR is here: https://github.com/civicrm/civicrm-core/pull/28842
I wasn't going to make a lab.c.o ticket but I suspect that the "regression" tag here is what blocks a release, and with 5.69 almost upon us, I wanted to make sure this got seen.5.69.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4877Membership level is miscomputed if you use "Go back" to fix a mistake2024-01-05T03:42:45ZtottenMembership level is miscomputed if you use "Go back" to fix a mistake## Overview
When using a ContributionPage to choose a membership type, you have the option to "Go back" and change
## Reproduction steps
1. Create a site with demo data (_I'm using dmaster_). This includes a dummy payment processor, s...## Overview
When using a ContributionPage to choose a membership type, you have the option to "Go back" and change
## Reproduction steps
1. Create a site with demo data (_I'm using dmaster_). This includes a dummy payment processor, some membership types ("General", "Student"), and a ContributionPage.
2. In a private window, open the ContributionPage for membership registration (`civicrm/contribute/transact?reset=1&id=2`)
3. Choose the "General" membership type. Fill out dummy billing info. Continue to next page.
4. On the confirmation page, read the summary. __You see the "General" selection... and realize it's a mistake.__ You want to change.
5. Press "Go Back"
6. Change the membership to the correct/intended value ("Student"). Continue to the next page.
## Current behavior
On the confirmation page, you see contradictory information. One section reports "Student" membership, and the other section reports "General" membership.
![Screenshot_2023-12-31_at_7.15.05_PM](/uploads/9013a642427bc6685087c71088f15d83/Screenshot_2023-12-31_at_7.15.05_PM.png)
If you ignore this and proceed, then it will processed as a "General" membership -- using your original/mistaken value instead of final/corrected value.
The mistaken values (label/price/period) will appear in the email receipt, the `Contribution` record, and the `Membership` record.
## Expected behavior
After changing your choice to "Student", all screens/records/emails should use the final/corrected value.
## Environment information
* **Browser:** Firefox
* **CiviCRM:** 5.69
* **PHP:** 8.1
* **CMS:** D7
* **Database:** MySQL 8
* **Web Server:** Apache
## Comments
I noticed this while testing other issues, so my local setup involved some other configuration. These parts probably don't matter for this scenario. But just in case there's trouble with reproducing, here's a list of other config steps:
* Make a new membership type, "Part Time Student", which recurs every 6 months
* Update the ContributionPage to enable "Part Time Student" (along with "General" and "Student")
* Change the prices on all membership types to be values like $6, $7, $8, $10. (These values are [more convenient for testing iATS credit card mode](https://content.iatspayments.com/developers-test-credit-card-numbers).)
* Add payment processor for iATS CC (TEST88). But don't actually use it. It's just an extra one hanging around.5.69.0https://lab.civicrm.org/dev/core/-/issues/4867civi_case/civi_campaign extensions not configured properly on a fresh install2024-01-05T03:42:41ZDaveDcivi_case/civi_campaign extensions not configured properly on a fresh installLeads to crash if you try to enable the extension from the extension screen. They enable properly from the components screen.
Might be from https://github.com/civicrm/civicrm-core/commit/9640b86f59daf80991989f0848e02c01ead202d7? I'm not...Leads to crash if you try to enable the extension from the extension screen. They enable properly from the components screen.
Might be from https://github.com/civicrm/civicrm-core/commit/9640b86f59daf80991989f0848e02c01ead202d7? I'm not sure because I don't use the extension screen to manage these, and on all the PR sites and dmaster.demo they are enabled already at install, so I don't have a good sense of when it started.
PR coming shortly5.69.0https://lab.civicrm.org/dev/core/-/issues/4861addressee communication prefs seems a bit messed up2023-12-13T20:27:32ZDaveDaddressee communication prefs seems a bit messed upI'm not sure yet if this is just from demo sample data, but at the very least the dropdown on edit seems the wrong type?
![untitled3](/uploads/b1a2100f8eb24985554fa83b94fa70f2/untitled3.png)
![untitled4](/uploads/95eb53af0acf99e8bdcced...I'm not sure yet if this is just from demo sample data, but at the very least the dropdown on edit seems the wrong type?
![untitled3](/uploads/b1a2100f8eb24985554fa83b94fa70f2/untitled3.png)
![untitled4](/uploads/95eb53af0acf99e8bdcced58e8508323/untitled4.png)