CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2021-02-22T23:05:46Zhttps://lab.civicrm.org/dev/core/-/issues/2407Search kit uses a maria-db-reserved word2021-02-22T23:05:46ZeileenSearch kit uses a maria-db-reserved wordI found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a I...I found that when running the count query I was getting a db error - it turned out the word 'rows' in the below query is reserved in Maria DB from 10.2.4
```
SELECT count(*) AS `c` FROM ( SELECT `a`.`id` AS `id` FROM civicrm_contact a INNER JOIN `civicrm_contribution` `Contact_Contribution_contact_id_01` ON `Contact_Contribution_contact_id_01`.`contact_id` = `a`.`id` AND `a`.`id` = `Contact_Contribution_contact_id_01`.`contact_id` AND
blah blah
WHERE bla blah GROUP BY `a`.`id` ) AS rows;
```
https://mariadb.com/kb/en/reserved-words/5.35.0https://lab.civicrm.org/dev/core/-/issues/2406Add link from afform edit screen to the form url2021-02-23T09:18:58ZeileenAdd link from afform edit screen to the form urlMinor thing - but helpful as it's confusing for people to have to copy & past the url fragmentMinor thing - but helpful as it's confusing for people to have to copy & past the url fragment5.36.0seamusleeseamusleehttps://lab.civicrm.org/dev/core/-/issues/2404Afform permissions - open access didn't seem to work (search kit)2021-02-24T09:17:31ZeileenAfform permissions - open access didn't seem to work (search kit)I tried configuring an afform search with open access but going to the url treats it as NO access
![image](/uploads/f61b78579e271bb0b088fd10c7dae203/image.png)
![image](/uploads/fc6a010613dee1e0e5da6854bc4f29d3/image.png)
I am logged...I tried configuring an afform search with open access but going to the url treats it as NO access
![image](/uploads/f61b78579e271bb0b088fd10c7dae203/image.png)
![image](/uploads/fc6a010613dee1e0e5da6854bc4f29d3/image.png)
I am logged in as an admin user & see this when I have 'administer civicrm required
![image](/uploads/8058409fff66b60e352ad98200e0d9a7/image.png)
@totten @colemanw5.36.0https://lab.civicrm.org/dev/core/-/issues/2400APIv4 explorer, search kit - entity reference fields tricky if you know the id2021-02-24T21:53:21ZeileenAPIv4 explorer, search kit - entity reference fields tricky if you know the idOne of my annoyances with apiv4 explorer is now in search kit too. Quite often I know the id of the contact but not other details - in order to prevent leaking information we only pass around the id. While it makes sense in most use case...One of my annoyances with apiv4 explorer is now in search kit too. Quite often I know the id of the contact but not other details - in order to prevent leaking information we only pass around the id. While it makes sense in most use cases to use the entity reference look up that lookup is hard to use if you just know the id as you still need to enter 'something' to make it search.
![image](/uploads/8896341778d5e77cde2ea765964f7fe9/image.png)
With search kit this could impact when making the initial search and exposing in the dashlet (I would expect we will be quickly asked for some 'search by id afflets' as well as wanting entity references in other cases. I note the afflet currently renders contact id as an integer field - which is probably better than an entity reference for our current use cases but I think that we will want to be able to have more control (ie choose between an integer or entity reference field). I can see a case for making entity reference field better support entering the contact id - but I think we need to be mindful that when people are working with contact ids they are often doing data-entry type stuff that requires them to be able to enter the id & click go without many extra steps
![image](/uploads/d2f1e0c19237aea3b2622da2c7ceea68/image.png)5.36.0https://lab.civicrm.org/dev/core/-/issues/2398On mail accounts form, pressing save and test followed by save creates a dupl...2021-02-19T23:07:09ZDaveDOn mail accounts form, pressing save and test followed by save creates a duplicate accountIt's a regression in that the button itself is a recent addition and you couldn't make duplicates this way before, but it's not like something that was working is now broken, and it's easy to clean up after.
Haven't looked too close yet...It's a regression in that the button itself is a recent addition and you couldn't make duplicates this way before, but it's not like something that was working is now broken, and it's easy to clean up after.
Haven't looked too close yet but I think it's because the test button doesn't submit the form, so the form never gets an "id" set, so then when you click save after it's like a new form.5.36.0https://lab.civicrm.org/dev/core/-/issues/2394Decimal Separator - Incorrect format in some views and editions2023-02-16T13:30:23ZCésarDecimal Separator - Incorrect format in some views and editionsHello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field i...Hello,
The Money type fields are not working correctly when modifying the language, the decimal delimiter and the thousands separator are configured, detected with custom case fields and editing a contribution.
* Example custom field in case view: (version afected > 5.21.0)
![bug_separator](/uploads/3a6495402f7318f656bf94c73912cda2/bug_separator.gif)
* Example fields in contribution edit: (version afected 5.36.alpha1)
In v5.34.0 the value of total_amount is replaced by the default format value (Ex: 1.000,10 to 1,000.10) in edit form of contribution.
![bug_separator_contrib](/uploads/eb1a291ab6f1311a1e72fa19f0dba5a0/bug_separator_contrib.gif)5.35.0https://lab.civicrm.org/dev/core/-/issues/2392Deprecated force url for contribution dashboard links2021-02-17T23:06:15ZDaveDDeprecated force url for contribution dashboard links1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive...1. Contribution dashboard
2. Click the table layout "button" near the top.
3. Click on one of the "view details" links.
4. `User deprecated function: Deprecated function CRM_Contribute_Form_Search::setDeprecatedDefaults, use pass receive_date_high not end`5.36.0https://lab.civicrm.org/dev/core/-/issues/2391Do Not Trade Privacy option is missing from report template.2021-02-23T09:18:57ZtapashDo Not Trade Privacy option is missing from report template.Do Not Trade Privacy option is missing from core report template.Do Not Trade Privacy option is missing from core report template.5.36.0https://lab.civicrm.org/dev/core/-/issues/2390Add hook support for Activity Contact2021-03-21T21:40:18ZyashodhaAdd hook support for Activity ContactCurrently, there is no hook support for Activity Contact.Currently, there is no hook support for Activity Contact.5.37.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/2389Search kit navigation - once I've created an afform it's hard to edit it2021-02-23T09:20:59ZeileenSearch kit navigation - once I've created an afform it's hard to edit itIt's really hard to see how to edit a search afform once created -
![image](/uploads/fe400ccb1d640f22723af4fd55b49c50/image.png)
Even just an edit link from the form would help a lot
![image](/uploads/5e4cb7d544f36d6de72fa4c1c77d9d2c...It's really hard to see how to edit a search afform once created -
![image](/uploads/fe400ccb1d640f22723af4fd55b49c50/image.png)
Even just an edit link from the form would help a lot
![image](/uploads/5e4cb7d544f36d6de72fa4c1c77d9d2c/image.png)
@colemanw5.36.0https://lab.civicrm.org/dev/core/-/issues/2388Searchkit bug - not displaying grouped by field2021-02-21T22:07:08ZeileenSearchkit bug - not displaying grouped by fieldAt a url like
civicrm/admin/search#/create/Contribution?params=%7B"version":4,"select":%5B"financial_type_id:label","SUM(total_amount)%20AS%20SUM_total_amount"%5D,"orderBy":%7B%7D,"where":%5B%5D,"groupBy":%5B"financial_type_id"%5D,"join...At a url like
civicrm/admin/search#/create/Contribution?params=%7B"version":4,"select":%5B"financial_type_id:label","SUM(total_amount)%20AS%20SUM_total_amount"%5D,"orderBy":%7B%7D,"where":%5B%5D,"groupBy":%5B"financial_type_id"%5D,"join":%5B%5D,"having":%5B%5D%7D
the financial type field is empty
![image](/uploads/5297013039c6f27b591c1ce2d354d71b/image.png)
![image](/uploads/0f74b9e2b98d9e312018218ad43ac727/image.png)
@colemanw5.36.0https://lab.civicrm.org/dev/core/-/issues/2387'Recent Items' fails to show list of Recent Items2021-03-15T06:08:08Zspalmstrom'Recent Items' fails to show list of Recent ItemsOverview
----------------------------------------
The _Recent Items_ block fails to show the list of recent items, it only shows the current user. It is not manifest on the demo site ([CiviCRM Sandbox on Drupal](https://dmaster.demo.civi...Overview
----------------------------------------
The _Recent Items_ block fails to show the list of recent items, it only shows the current user. It is not manifest on the demo site ([CiviCRM Sandbox on Drupal](https://dmaster.demo.civicrm.org/civicrm)), but is manifest on _drupal9-clean_ _civibuild_ installation, both under Ubuntu 20.4 and ported to Windows. It is also manifest on a Drupal 9 installation running CiviCRM 5.34.0.
See _StackExchange_ entry [Recent Items Block Does Not Show Recent Items Unless There Are Report Results](https://civicrm.stackexchange.com/questions/38292/recent-items-block-does-not-show-recent-items-unless-there-are-report-results)
Reproduction steps
----------------------------------------
1. Click on **Search -> Find Contacts**.
1. Go to a contact and click **View**.
1. Contact name does not appear in **Recent Items**.
Current behaviour
----------------------------------------
Contact name does not appear in _Recent Items_, only the user.
![image](/uploads/0e47865da098da1752d530b072dee0fc/image.png)
Expected behaviour
----------------------------------------
The contact name should appear in _Recent Items_.
![image](/uploads/3d7254e6a538ecfcb3be37f799c73f4b/image.png)
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _MS Edge_ but probably irrelevant.
* __CiviCRM:__ _5.36.alpha1/5.34.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _7.3/7.4__ but probably irrelevant
* __CMS:__ _Drupal 9.x_
* __Database:__ _MySQL 8.x._ but probably irrelevant
* __Web Server:__ _Apache 2.4/IIS 10_ but probably irrelevant.
Comments
----------------------------------------
It may be that I am missing some CiviCRM setting or something really obvious. It seemed a good idea to flag the issue so as to create a branch name should it be necessary to create a pull request to solve the issue as I plan to do further research on it.5.36.0https://lab.civicrm.org/dev/core/-/issues/2385Investigate replacing civicase views with something that is not views2021-12-08T09:00:21ZDaveDInvestigate replacing civicase views with something that is not viewsRelated to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In additi...Related to https://lab.civicrm.org/dev/core/-/issues/2262.
CiviCase uses mysql views (as opposed to drupal views) and is the only component that does so. I'm not sure if they're still truly needed the way they originally were. In addition to the issue above, they hardcode activity status id and the number 14 (nothing against the number 14, but hey) making it difficult to override those.
I haven't looked at the full query lately but at one time it had a self-join on the view which was where it was convenient to have the view since at the time you couldn't self-join to temporary tables, which might still be true.5.37.0https://lab.civicrm.org/dev/core/-/issues/2384Remove text about email receipts for each recurring contribution.2021-03-19T21:23:23ZlarsssandergreenRemove text about email receipts for each recurring contribution.On a contribution page, when you select a recurring contribution, this is part of the message that appears: "You will receive an email receipt for each recurring contribution" if [email receipt is enabled for the contribution page.](http...On a contribution page, when you select a recurring contribution, this is part of the message that appears: "You will receive an email receipt for each recurring contribution" if [email receipt is enabled for the contribution page.](https://github.com/civicrm/civicrm-core/blob/e4c693f6e2114a1f536d406d2ef107fc56e7952c/CRM/Core/Payment.php#L596)
I'm sure we're not the only org that sends an email receipt for the first recurring contribution through the contribution page, but doesn't send a receipt for every contribution, making this text inaccurate. It would also be incorrect if a donor isn't entering an email address.
From the perspective of the person filing out the form, I'm not sure whether or not they'll receive an email receipt for every contribution is necessary information. My suggestion is to remove this sentence. I think this kind of information makes sense in an email receipt (where it is also more easily editable) rather than on a contribution page.
I would also suggest removing this sentence: "Your recurring contribution will be processed automatically." I think it is quite obvious that if someone is making a recurring contribution, it will be processed automatically.
If both these sentences were removed, then there is no additional text shown when someone makes a recurring contribution on a page where they can't select the number of instalments, which would be nice and simple.5.37.0https://lab.civicrm.org/dev/core/-/issues/2383contact custom data date field not working in scheduled reminder2021-04-09T01:59:24Zvakeesan26contact custom data date field not working in scheduled reminderWhen we use the contact custom date field in scheduled reminder condition, then it is not working as expected
![image](/uploads/b7084dc4297fe6a78732529c61d29434/image.png)
CRM_Core_BAO_ActionSchedule::prepareMailingQuery function addi...When we use the contact custom date field in scheduled reminder condition, then it is not working as expected
![image](/uploads/b7084dc4297fe6a78732529c61d29434/image.png)
CRM_Core_BAO_ActionSchedule::prepareMailingQuery function adding Inner join with contact id and custom value table ID field
Eg :-
SELECT reminder.id as reminderID, reminder.contact_id as contactID, reminder.entity_table as entityTable, reminder.*, e.id AS entityID, e.id as entityID, e.*
FROM civicrm_action_log reminder
**INNER JOIN civicrm_contact e ON e.id = reminder.entity_id**
WHERE (reminder.action_schedule_id = 22) AND (reminder.action_date_time IS NULL)5.37.0https://lab.civicrm.org/dev/core/-/issues/2379Geocoding saves values that web UI doesn't accept2023-06-26T12:56:40ZJonGoldGeocoding saves values that web UI doesn't acceptOverview
----------------------------------------
Geocoders can pass back a valid latitude/longitude that looks something like this: `-12.456789012345`. That's 16 characters. However, `CRM_Core_DAO::makeAttribute()` only allows saving `...Overview
----------------------------------------
Geocoders can pass back a valid latitude/longitude that looks something like this: `-12.456789012345`. That's 16 characters. However, `CRM_Core_DAO::makeAttribute()` only allows saving `float` values with a max of 14 characters. So attempting to edit an address with a long lat/lon results in a validation error.
Reproduction steps
----------------------------------------
* Manually enter into the database a `geo_code_1` value of `-12.456789012345` on an address.
* Attempt to edit the address.
Current behaviour
----------------------------------------
![Screen_Shot_2021-02-09_at_9.47.59_AM](/uploads/7627d641a1580c9461916299a97f50d7/Screen_Shot_2021-02-09_at_9.47.59_AM.png)
```
TIP: The best way to convey an error message is to copy it in here and use
three backtick ` symbols. You may edit the message to remove private
information (like passwords). The backticks will help to preserve any
special characters or spaces.
```
Expected behaviour
----------------------------------------
Geocode shouldn't trigger validation errors.5.36.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/2372Prevent double clicking submit button2021-03-21T21:41:08Zahed_compucorpPrevent double clicking submit buttonOverview
----------------------------------------
A typical problem with HTML forms that if you click fast enough, you can submit the form twice - or more, mostly if the server response was slow. CiviCRM is no exception.
Reproduction st...Overview
----------------------------------------
A typical problem with HTML forms that if you click fast enough, you can submit the form twice - or more, mostly if the server response was slow. CiviCRM is no exception.
Reproduction steps
----------------------------------------
- Any page that has a standard form - without Ajax. (e.g. Find Contributions or New Contribution or Some of the result actions).
- Click submit button fast enough.
![2021-02-08_16-26](/uploads/4b85a3b6e4b4fd659955b4e61ab267d7/2021-02-08_16-26.png)
Current behaviour
----------------------------------------
Find Contributions
![Peek_2021-02-08_16-06](/uploads/f552cc398264ba3ffc28de6eee7a1ea7/Peek_2021-02-08_16-06.gif)
New Contribution
![Peek_2021-02-08_16-10](/uploads/fe4c0118c1cba067fab6192c9c78000c/Peek_2021-02-08_16-10.gif)
Send Invoice - Search Action
Will send multiple emails.
![Peek_2021-02-08_16-40](/uploads/7020983f5986408972ea564f53f14e48/Peek_2021-02-08_16-40.gif)
Expected behaviour
----------------------------------------
Disable button during submission. Maybe something like Record Contribution (Ajax form Using the jQuery BlockUI Plugin)
![Peek_2021-02-08_16-14](/uploads/24c71d97550650e78b6629e249f9df76/Peek_2021-02-08_16-14.gif)
Any thoughts on this?
PR: https://github.com/civicrm/civicrm-core/pull/196105.36.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/2371Custom setting for boolean checkbox is serialized as int value2022-01-07T09:42:06Zsluc23Custom setting for boolean checkbox is serialized as int valueWhen developing a custom extension and adding a new setting for a boolean checkbox in `settings/myext.setting.php` file as:
```php
<?php
return [
'myext_boolField' => [
'name' => 'myext_boolField',
'type' => 'Boolean',
'htm...When developing a custom extension and adding a new setting for a boolean checkbox in `settings/myext.setting.php` file as:
```php
<?php
return [
'myext_boolField' => [
'name' => 'myext_boolField',
'type' => 'Boolean',
'html_type' => 'checkbox',
'default' => 1,
'is_domain' => 1,
'is_contact' => 0,
'title' => 'Boolean checkbox setting',
'description' => '',
],
];
```
When this value is saved in Admin Form, the value is serialized as **int** i.e.: `i:1;`. This invalidates the code that treat this setting as a boolean value like:
```php
// ** This won't work
if (Civi::settings()->get('myext_boolField') === TRUE) {
// Do something...
}
. . .
// ** This will work
if (Civi::settings()->get('myext_boolField') === 1) {
// Do something...
}
```
We need to treat this value as integer in the code, which is not a programming problem, but I think it gets confusing about variable types.
In my investigation looks like the culprit is this casting to integer:
https://github.com/civicrm/civicrm-core/blob/master/CRM/Admin/Form/SettingTrait.php#L3435.36.0https://lab.civicrm.org/dev/core/-/issues/2369Fatal error reported when photo cannot be found2021-05-31T15:47:08Zmagnolia61Fatal error reported when photo cannot be foundI use a profile for people to update their profile picture.
For some reason when their photo is not available anymore the error log logs a fatal error.
Also the reporterror extension sends an email on this but of course that's out of cor...I use a profile for people to update their profile picture.
For some reason when their photo is not available anymore the error log logs a fatal error.
Also the reporterror extension sends an email on this but of course that's out of core scope (reported it [there](https://lab.civicrm.org/extensions/reporterror/-/issues/3#note_53134) also)
I have been experiencing this since quite a few versions of CiviCRM back. Currently running 5.34 (Drupal 7.78)
Could it be that the code for this in core is a bit too harsh?
```
[error]
$Fatal Error Details = array:3 [
"message" => "Photo does not exist"
"code" => null
"exception" => CRM_Core_Exception {#3616
-errorData: array:1 [
"error_code" => 0
]
#cause: null
-_trace: null
#message: "Photo does not exist"
#code: 0
#file: "/var/www/vhosts/xyz/web/sites/all/modules/civicrm/CRM/Contact/Page/ImageFile.php"
#line: 58
trace: {
/var/www/vhosts/xyz/web/sites/all/modules/civicrm/CRM/Contact/Page/ImageFile.php:58 {
› else {
› throw new CRM_Core_Exception(ts('Photo does not exist'));
› }
}
/var/www/vhosts/xyz/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:312 { …}
/var/www/vhosts/xyz/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:68 { …}
/var/www/vhosts/xyz/web/sites/all/modules/civicrm/CRM/Core/Invoke.php:36 { …}
/var/www/vhosts/xyz/web/sites/all/modules/civicrm/drupal/civicrm.module:458 { …}
/var/www/vhosts/xyz/web/includes/menu.inc:527 { …}
/var/www/vhosts/xyz/web/index.php:21 { …}
}
}
]
```5.39.0https://lab.civicrm.org/dev/core/-/issues/2366php 7.4 - get_magic_quotes_gpc() deprecated in IDS_Monitor2021-04-13T00:10:20ZDaveDphp 7.4 - get_magic_quotes_gpc() deprecated in IDS_Monitor`Deprecated function: Function get_magic_quotes_gpc() is deprecated in IDS_Monitor->_detect() (line 338 of ...\vendor\civicrm\civicrm-packages\IDS\Monitor.php).`
Also line 342.
Function will be removed in php 8.
Hmm. This package is v...`Deprecated function: Function get_magic_quotes_gpc() is deprecated in IDS_Monitor->_detect() (line 338 of ...\vendor\civicrm\civicrm-packages\IDS\Monitor.php).`
Also line 342.
Function will be removed in php 8.
Hmm. This package is very old.5.37.0