CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2021-10-18T17:27:35Zhttps://lab.civicrm.org/dev/core/-/issues/2917Replace "Oops" with more appropriate language2021-10-18T17:27:35ZhaystackReplace "Oops" with more appropriate languageOverview
----------------------------------------
The word "Oops" appears throughout CiviCRM. I suggest changing the strings in which it appears to be more appropriate to their context.
Example changes...
#### Already registered for a...Overview
----------------------------------------
The word "Oops" appears throughout CiviCRM. I suggest changing the strings in which it appears to be more appropriate to their context.
Example changes...
#### Already registered for an Event:
* "Oops. It looks like you are already registered for this event. [...]"
* "It looks like you are already registered for this event. [...]"
The "Oops" is jarring. It's not a mistake when I revisit the form to register someone else.
#### Event full:
* "Oops, it looks like there are currently no available spaces for [...]"
* "Unfortunately there are currently no available spaces for [...]"
It's not a mistake that "there are currently no available spaces". "Oops" suggests that it is.
Etc etc.5.44.0haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/2916Alter default frequency for scheduled reminders job2021-11-05T17:46:04ZwmortadaAlter default frequency for scheduled reminders jobAs [discussed on Mattermost](https://chat.civicrm.org/civicrm/pl/hcnos88x3pdzdgfkqbjbdktggh) with @bgm, the default for sending scheduled reminders is daily. This seems too infrequent, particularly if you have event reminders to be sent ...As [discussed on Mattermost](https://chat.civicrm.org/civicrm/pl/hcnos88x3pdzdgfkqbjbdktggh) with @bgm, the default for sending scheduled reminders is daily. This seems too infrequent, particularly if you have event reminders to be sent and want to send a reminder e.g. 2 hours before the event starts.
I propose that the default is changed to hourly.
The default is set here: https://lab.civicrm.org/dev/core/-/blob/ca09f9073ec01ba0a67e1c435213dea878069299/xml/templates/civicrm_data.tpl#L16835.45.0https://lab.civicrm.org/dev/core/-/issues/2914Count of sent messages can be wrong in status popup for email form2021-10-18T14:28:03ZDaveDCount of sent messages can be wrong in status popup for email formMaster and 5.43 are broken right at this moment and you can't send any email, but in 5.43+ if you do this:
1. Contacts - New Email.
1. Add one of more valid recipients.
1. Fill it out and send.
1. The status popup will say 0 messages se...Master and 5.43 are broken right at this moment and you can't send any email, but in 5.43+ if you do this:
1. Contacts - New Email.
1. Add one of more valid recipients.
1. Fill it out and send.
1. The status popup will say 0 messages sent, even though they were sent. The number it shows is however many were prepopulated on the form when it first opened, and doesn't account for any you added or subtracted.
(This isn't about emails that were for deceased or on-hold etc.)
It worked in 5.42.5.43.0https://lab.civicrm.org/dev/core/-/issues/2912Can't save extra custom fields when inline and required2021-11-11T19:25:39Zaydunsaidan.saunders@squiffle.ukCan't save extra custom fields when inline and requiredOverview
----------------------------------------
If you have a custom field set that allows multiple records with a required field and uses the inline style, then one record can be created but a second fails with ' ... is a required fie...Overview
----------------------------------------
If you have a custom field set that allows multiple records with a required field and uses the inline style, then one record can be created but a second fails with ' ... is a required field' for all required fields.
Reproduction steps
----------------------------------------
Setup: Create a custom field set:
1. Click on **Administer -> Customize Data and Screens > Custom Fields**.
1. Click **Add Set of Custom Fields**
1. Set Name: 'Test fields', Used for: Contacts, Does this Custom Field Set allow multiple records?: ticked, Display Style: Inline
1. Click **Save**
1. Field Label: Test, Data Type: Alphanumeric, Field input type: single-line input, Required: ticked [NB seems to affect all types, key thing is this is Required]
1. Click **Save**
Create first record:
1. Choose a contact
1. In 'Test fields' custom fields section, click **Edit**, enter a value for 'Test' field, click **Save**
[Should succeed]
Try to create second record - need to use 'Edit Contact'
1. On contact view, click **Edit**
1. In 'Test fields' section, click **Another Test fields record**
1. Enter value, click **Save**
1. Get ```Please correct the following errors in the form fields below: Test is a required field.```
Current behaviour
----------------------------------------
Second field produces error
Expected behaviour
----------------------------------------
Second field saves without error
Environment information
----------------------------------------
* __CiviCRM:__ _5.41.0_, _Master._ This used to work seems to have changed somewhere between 5.36.1 and 5.41.0
Comments
----------------------------------------
* The field saves correctly if not 'required'.
* The field saves correctly if displayed as 'Tab' or 'Tab with Table'. Problem occurs only when both 'Required' and 'Inline'.5.45.0https://lab.civicrm.org/dev/core/-/issues/2910Remove the CiviCRM Connections functionality (Task 1 of 2) - Remove the menu ...2022-08-09T14:44:38Zjustinfreeman (Agileware)Remove the CiviCRM Connections functionality (Task 1 of 2) - Remove the menu item**CiviCRM Connections** is available under the System Settings menu. From what I can tell this feature is an artefact that is no longer being used. Happy to be educated on the subject if this is not the case.
Cannot find any references ...**CiviCRM Connections** is available under the System Settings menu. From what I can tell this feature is an artefact that is no longer being used. Happy to be educated on the subject if this is not the case.
Cannot find any references to it in the documentation:
- https://docs.civicrm.org/user/en/latest/
- https://docs.civicrm.org/sysadmin/en/latest/
Googling doesn't reveal anything relevant either.
So can we remove this code from the system?
![Screenshot_20211013_091315](/uploads/724bb11ee0a345f31be5b369b22af959/Screenshot_20211013_091315.png)
Agileware Ref: CIVIBLD-2865.44.0https://lab.civicrm.org/dev/core/-/issues/2909Repair "Norwegian Bokmål"2021-11-04T17:48:03ZhaystackRepair "Norwegian Bokmål"Overview
----------------------------------------
"Norwegian Bokmål" is corrupted in [this file](https://github.com/civicrm/civicrm-core/blob/5db0bc3c1f54eaca4307f103a73bda596ae914d6/install/langs.php#L32) and [this one](https://github.c...Overview
----------------------------------------
"Norwegian Bokmål" is corrupted in [this file](https://github.com/civicrm/civicrm-core/blob/5db0bc3c1f54eaca4307f103a73bda596ae914d6/install/langs.php#L32) and [this one](https://github.com/civicrm/civicrm-core/blob/5db0bc3c1f54eaca4307f103a73bda596ae914d6/xml/templates/languages.tpl#L136).
Current behaviour
----------------------------------------
"Norwegian Bokmål" renders as "Norwegian BokmÃ¥l"
Expected behaviour
----------------------------------------
"Norwegian Bokmål" FTW.5.44.0haystackhaystackhttps://lab.civicrm.org/dev/core/-/issues/2904Date fields are empty on memberships created with Order API Pending2021-10-14T06:25:33ZFrancis (Agileware)Date fields are empty on memberships created with Order API PendingSame problem as #2902.
Example Order.create API Call to reproduce:
```json
{
"contact_id": 202,
"total_amount": 100.00,
"financial_type_id": "Member Dues",
"contribution_status_id": "Pending",
"line_items" : [
{
"p...Same problem as #2902.
Example Order.create API Call to reproduce:
```json
{
"contact_id": 202,
"total_amount": 100.00,
"financial_type_id": "Member Dues",
"contribution_status_id": "Pending",
"line_items" : [
{
"params": {
"membership_type_id": "General",
"contact_id": 202,
"status_id": "Pending",
"skipStatusCal":1
},
"line_item": [
{
"entity_table":"civicrm_membership",
"price_field_id":"4",
"price_field_value_id":"7",
"qty":"1",
"unit_price":"100.00",
"line_total":"100.00"
}
]
}
]
}
```
Result on 5.39 is a pending Contribution and Membership with join_date, start_date, and end_date
Result on 5.40+ is a pending Contribution and Membership with *NO* join_date, start_date, or end_date
Including 5.43alpha with @eileen's [patch for #2902](https://github.com/civicrm/civicrm-core/pull/21784) applied
5.42+ works correctly *without* skipStatusCal set, however for backwards compatibility it should work with it also.5.42.1https://lab.civicrm.org/dev/core/-/issues/2902Date fields are empty on memberships (created with pay later OR with an API c...2021-10-14T04:08:04ZjitendraDate fields are empty on memberships (created with pay later OR with an API call)To replicate -
- Create a contribution page with Membership + Pay later.
- Submit the page in live mode.
- Date fields (join, start & end) are empty for the membership.
Found while writing this test - https://github.com/colemanw/webfor...To replicate -
- Create a contribution page with Membership + Pay later.
- Submit the page in live mode.
- Date fields (join, start & end) are empty for the membership.
Found while writing this test - https://github.com/colemanw/webform_civicrm/pull/622
Probably related to https://github.com/civicrm/civicrm-core/pull/20759 merge where api/v3 code used to calculate the dates for all NEW memberships. https://github.com/civicrm/civicrm-core/pull/20759/files#diff-74f06c64d06b6b6c191ff86ab31113f7198e73c0a1f8c5487116e7b3faef26fcL95
Now, in BAO, the membership date calculation is avoided if `skipStatusCal` is set in the params. See https://github.com/civicrm/civicrm-core/blob/master/CRM/Member/BAO/Membership.php#L260
I think a test with below API should be able to replicate it in the test
```
$membership = civicrm_api3('Membership', 'create', [
'membership_type_id' => "General",
'contact_id' => 2,
'status_id' => "Current", (or Pending, New, etc)
'skipStatusCal' => 1,
]);
// Verify if membership dates are correctly set. Currently, they're not.
```
I've confirmed that CiviCRM v5.35 sets the date on the above API call, but >5.40 does NOT. Does that seem to be an unintentional change of behavior?
Not sure what should be the desired result - Does the API call need to set start_date separately when `skipStatusCal` is enabled?
OR
`skipStatusCal` should only skip the calculation of "status" on the membership and continue to set the dates as it used to do in previous versions?
fyi - @KarinG @eileen5.42.1https://lab.civicrm.org/dev/core/-/issues/2901Find Activities + Send Email task always says the contact is on hold or decea...2021-10-10T12:48:05ZDaveDFind Activities + Send Email task always says the contact is on hold or deceased etcEven if all the communication prefs are good and the email is valid it still gives the warning message and doesn't let you send.
1. Find Activities.
2. Select one that has a valid With Contact who isn't deceased and doesn't have email o...Even if all the communication prefs are good and the email is valid it still gives the warning message and doesn't let you send.
1. Find Activities.
2. Select one that has a valid With Contact who isn't deceased and doesn't have email on hold etc.
3. From the actions dropdown choose send email
4. Choose With Contact.
5. Warning comes up and redirects you back to search. `Selected contact(s) do not have a valid email address, or communication preferences specify DO NOT EMAIL, or they are deceased or Primary email address is On Hold.`
I'm putting regression but not 100% sure it is recent.5.43.0https://lab.civicrm.org/dev/core/-/issues/2898URL Tokens - CiviMail BAO and FlexMailer disagree over duplicate `http://`2022-12-19T22:45:31ZtottenURL Tokens - CiviMail BAO and FlexMailer disagree over duplicate `http://`Overview
--------
CiviMail BAO and Flexmailer provide two mechanisms to rendering/delivering mail-blasts. To phase out BAO-rendering, we should eventually migrate existing sites to Flexmailer. However, small discrepancies between them c...Overview
--------
CiviMail BAO and Flexmailer provide two mechanisms to rendering/delivering mail-blasts. To phase out BAO-rendering, we should eventually migrate existing sites to Flexmailer. However, small discrepancies between them can be an obstacle. This issue asks how to deal with a discrepancy when handling certain URL tokens.
(The issue is an off-shoot from the review discussion on https://github.com/civicrm/civicrm-core/pull/21522. However, they are somewhat distinct as 21522 applies to new-sites and this problem is more pressing on upgrade-sites.)
Background
-----------
Suppose you have an email token which generates a URL (eg `{action.forward}` or `{action.unsubscribeUrl}`) . The most correct way to use this token in an HTML-email is to place it in a hyperlink (`<a href="{action.forward}>`).
However, if you use CKEditor to compose a message, the hyperlink dialog strongly encourages you to put `http://` at the front of any hyperlink. Thus, you can organically produce expressions like `<a href="http://{action.forward}">`.
![CkeditorHttpToken](/uploads/e2d9bbf4ab6ba12a6cdcd936955277a9/CkeditorHttpToken.mov)
CiviMail BAO has a feature which mitigates this - in effect, both notations give the same output. However, Flexmailer (TokenProcessor) does not have a similar mitigation. Thus:
| HTML Email Expression | BAO Output | Flexmailer Output |
| -- | -- | -- |
| `<a href="{action.forward}>` | `<a href="https://example.com/civicrm/mailing/forward?...` | `<a href="https://example.com/civicrm/mailing/forward?...` |
| `<a href="http://{action.forward}>` | `<a href="https://example.com/civicrm/mailing/forward?...` | `<a href="http://https://example.com/civicrm/mailing/forward?...` |
Note the duplicate URL scheme (`http://http://`).
Scenarios: Good
---------
There are several scenarios wherein this discrepancy does not matter:
* You use CKEditor + BAO-renderer. (*The BAO renderer mitigates extraneous `http://`.*)
* You use Mosaico + Flexmailer. (*Mosaico's UI doesn't create extraneous `http://`.*)
(I suspect these two cohorts are the largest.)
Scenarios: Bad
---------
The potential for difficulty arises when mixing CKEditor with Flexmailer -- you take some HTML that was composed with CKEditor, run it through Flexmailer, and now you have invalid URLs with `http://https://`.
If we flip over more existing sites to Flexmailer, then it is foreseeable that more sites will be in this mixed scenario.
There's a secondary consideration in who may experience problems -- templates. Most users are not in the habit of typing `{action.forward}` or `{action.unsubscribeUrl}` regularly. Anecdotally, the typical practice is to put these kinds of tokens into a template, eg
* (A) Add a "User-Defined Template" (edited w/CKEditor in web; stored in `civicrm_msg_template`), or...
* (B) Reuse/copy a previous "Mailing" (edited w/CKEditor in web; stored in `civicrm_mailing`), or...
* (C) Configure default header/footer (no CKEditor; stored in `civicrm_mailing_component`)
Practical recap: today, if you enable Flexmailer on a site that uses CKEditor for mailings, then either:
* Your mailings and templates will have broken links -- because they use `<a href="http://{action.unsubscribeUrl}">`.
* This seems more likely if you use (A)/(B) - because the web UI uses CKEditor.
* Your mailings and templates will be cleanly interoperable -- because they use `<a href="{action.unsubscribeUrl}">`.
* This seems more likely if you use (C) header/footer because the web UI uses textarea.
Approaches
----------
1. Add a mitigation to Flexmailer or TokenProcessor which removes extraneous schema during the rendering phase.
* _Strength_: Best interoperability
* _Criticism_: Adds quirky bits to rendering.
* _Variations_: Patch Flexmailer vs patch TokenProcessor.
* _Variations_: Apply cleanup before rendering (`http://{action.*}` => `{action.*}`) or after rendering (`http://https?://` => `https?://`).
2. Add an upgrade-task to remove extra `http://` in front of tokens.
* _Strength_: No quirky bits in rendering.
* _Criticism_: CKEditor is still there. Can only upgrade core tables. Rewrites history (`civicrm_mailing.body_html` of past mailings).
3. Do nothing - Downstream users should manually convert their mailings/templates.
* _Strength_: Look, ma, no hands!
* _Criticism_: We cannot measure how many users will be impacted by break. For users with a "Reuse/Copy" workflow, they cannot fix historical mailings in UI.5.57.0https://lab.civicrm.org/dev/core/-/issues/2895Emails can't resolve tokens for non-contact components for recipients added t...2021-10-13T20:23:45ZDaveDEmails can't resolve tokens for non-contact components for recipients added to the list after email form was openedhttps://github.com/civicrm/civicrm-core/pull/21745#discussion_r724286717
Affects 5.43 only.
e.g.
1. Create a case email, e.g. clicking on the mail icon in the roles section.
1. Add a recipient to the recipient field.
1. In the body pu...https://github.com/civicrm/civicrm-core/pull/21745#discussion_r724286717
Affects 5.43 only.
e.g.
1. Create a case email, e.g. clicking on the mail icon in the roles section.
1. Add a recipient to the recipient field.
1. In the body put something like `Dear {contact.display_name} Case {case.id}`
1. The email sent to the original recipient will resolve case.id. The added recipient will have it blank.
See below this also applies to other non-contact components, e.g. event tokens.5.43.0https://lab.civicrm.org/dev/core/-/issues/2892Replace event type token in action schedule changes event.event_type_id to pa...2021-10-06T08:34:02Zjustinfreeman (Agileware)Replace event type token in action schedule changes event.event_type_id to participant.event_type_id:labelReplace event type token in action schedule changes event.event_type_id to participant.event_type_id:label. But should be event.event_type_id to event.event_type_id:label
As identified by @magnolia61 here https://github.com/civicrm/civi...Replace event type token in action schedule changes event.event_type_id to participant.event_type_id:label. But should be event.event_type_id to event.event_type_id:label
As identified by @magnolia61 here https://github.com/civicrm/civicrm-core/pull/21666/files#r7200592855.43.0https://lab.civicrm.org/dev/core/-/issues/2891Empty custom participant date token causes no token to render at all2021-10-06T00:26:37Zmagnolia61Empty custom participant date token causes no token to render at allOverview
----------------------------------------
When a custom participant date token is empty it causes all other tokens in that scheduled reminder template to not render
Current behaviour
----------------------------------------
Just...Overview
----------------------------------------
When a custom participant date token is empty it causes all other tokens in that scheduled reminder template to not render
Current behaviour
----------------------------------------
Just found something strange on participant custom date fields:
When the participant date value is empty, it is not only not shown (obviously), but causes no tokens at all to render:
![afbeelding](https://user-images.githubusercontent.com/2195908/135983371-20e85981-03cc-449e-a4a6-cbfe5098c3ad.png)
Expected behaviour
----------------------------------------
When the field has a value the scheduled reminder tokens render fine:
![afbeelding](https://user-images.githubusercontent.com/2195908/135983208-a7e87a2f-3b24-4fe3-89d7-d257e74c0ecf.png)
Environment information
----------------------------------------
bleeding edge nightly (current master 5.43)
Comments
----------------------------------------
I think this was not the case when I first tested https://github.com/civicrm/civicrm-core/pull/21666 and is probably caused by another commit that has to do with dates and tokens.
Would it be an idea to also include event and participant custom tokens in the test? (textfield, datefield)5.43.0https://lab.civicrm.org/dev/core/-/issues/2887ical/ics files generated by Civi are not compatible with Outlook during Dayli...2023-12-13T15:33:23ZStoobical/ics files generated by Civi are not compatible with Outlook during Daylight SavingsOverview
----------------------------------------
Since the inclusion of timezone in the ical/ics files that CiviCRM produces RFC5545 timezone is technically correct but Outlook doesn't interpret them properly
Reproduction steps
-------...Overview
----------------------------------------
Since the inclusion of timezone in the ical/ics files that CiviCRM produces RFC5545 timezone is technically correct but Outlook doesn't interpret them properly
Reproduction steps
----------------------------------------
1. during daylight savings (until Nov 7 in this year, 2021) create an event
2. download the ics/ical file from the event 'info' page
3. open that ics/ical file in Outlook
4. notice that it is one hour forward (later) than should be
Commentary
----------------------------------------
Hi guys, I wanted to make you aware of a new twist on this issue since timezones were added to the Civi-generated ical/ics files. Good news and bad, but wanted to share my research.
Good news: timezones are good, and as you know ical/ics from Civi didn't have them until 5.37.
Bad news: timezone glitches in Outlook.
The standards are meticulous but illustrate the format here: https://icalendar.org/iCalendar-RFC-5545/3-8-3-1-time-zone-identifier.html and the TZ zones can be clearly seen here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
How does this relate to Outlook, might you ask? Good question. Well I scoured the internet and people unrelated to CiviCRM have reported issues with timezone discrepancies in Outlook....
- As far back as 2016: https://theeventscalendar.com/support/forums/topic/ical-timezone-issue-with-microsoft-outlook
- And as recently as 2019: https://answers.microsoft.com/en-us/msoffice/forum/all/outlook-cant-read-timezone-in-ics-file-a-slew-of/495cadf9-4630-48b5-99ce-88d94980f289
... what these tend to have in common is that the discrepancies happen during Daylight Savings, which we are in right now, and which ends Nov 7. And they all have to do with ical/ics files that use a format of "America/New_York" whereas Outlook uses a different naming convention.
But how does this relate to CiviCRM? An even better question. Prior to version CiviCRM 5.37 which was released in June, CiviCRM ical/ics files had NO timezone at all, here: #19762 I never knew this. Lack of timezone caused problems of its own, but with most folks who are in the same timezone it doesn't matter.
When I made a mandatory security update to 5.38 CiviCRM a few months ago, the problems surfaced for a large nonprofit organization that uses primarily Outlook. That is because although CiviCRM now creates its ical/ics file to the RFC5545 standard, Outlook does not (attached). And now that CiviCRM is putting in timezones, we notice the issue for the first time...but only in Outlook. In one of the above posts it clearly states that Outlook misinterprets America/New_York in Daylight Savings.
So all that to say this is where we stand, between a rock and a hard place, metaphorically but perhaps even literally getting Microsoft to change their software might be like moving a mountain. And CiviCRM, well-meaning though we may be, may not want to accommodate a change to Civi that doesn't meet standards.
Solution ?
--------------------------------
There might be an exception or compromise in this mess, but it will more likely be on the CiviCRM side. Originally detected by agilware on this repo: https://github.com/civicrm/civicrm-core/pull/19762
![comparison](/uploads/8ef08e1138430a9793a18ad7966581f3/comparison.png)
[outlook-created.ics](/uploads/dee2cccb0c4a19b61ff106cb54f8ee5a/outlook-created.ics)5.52.2justinfreeman (Agileware)justinfreeman (Agileware)https://lab.civicrm.org/dev/core/-/issues/2885Add contacts to Group action missing custom fields2021-10-08T00:52:16ZjaapjansmaAdd contacts to Group action missing custom fields**Steps to reproduce**
1. Create a custom set for Group
2. Add a field to this custom set.
3. Do a search of contacts
4. Select a couple of contacts
5. Select the action Group - Add contacts to group
6. In the next screen select Create ...**Steps to reproduce**
1. Create a custom set for Group
2. Add a field to this custom set.
3. Do a search of contacts
4. Select a couple of contacts
5. Select the action Group - Add contacts to group
6. In the next screen select Create New Group
**Expected results**
I expect the group custom fields so I can set them. See screenshot below.
![Screenshot_20211004_120405](/uploads/bb99814fd6d9e7b098d44eade569150b/Screenshot_20211004_120405.png)
**Actual results**
No custom fields are visible. See screenshot below.
![Screenshot_20211004_120628](/uploads/b567089f2d76b0e469fb84407469712d/Screenshot_20211004_120628.png)
**Environment**
CiviCRM 5.43.alpha1 and Drupal 9
**Notes**
This came up after testing the [Temporary Groups](https://lab.civicrm.org/extensions/temporarygroups) extension.
I will provide a PR.5.43.0jaapjansmajaapjansmahttps://lab.civicrm.org/dev/core/-/issues/2884New note date field defaults to empty on upgraded sites2021-10-07T23:27:35ZjamieNew note date field defaults to empty on upgraded sitesI think this fix is simple, but wanted a quick sanity check to make sure I'm not missing anything.
We noticed the problem on a 5.39 site that was upgraded from 5.33.
Thanks to the awesome [note date field changes](https://github.com/ci...I think this fix is simple, but wanted a quick sanity check to make sure I'm not missing anything.
We noticed the problem on a 5.39 site that was upgraded from 5.33.
Thanks to the awesome [note date field changes](https://github.com/civicrm/civicrm-core/pull/19738) we now have a date created field for notes.
And, from what I can gather from the thread, the [intent is to populate the note date with the current time stamp if left empty](https://github.com/civicrm/civicrm-core/pull/19738#issuecomment-802822600).
I tested this on a fresh install and it works great. But on upgraded sites, it leaves the `note_date` field empty.
I believe the problem is that the [upgrade code explicitly sets this field to accept NULL values](https://github.com/civicrm/civicrm-core/blob/666451eea04b57a2d6cef7482c9d6070fedf7212/CRM/Upgrade/Incremental/php/FiveThirtySeven.php#L71).
However, if you grep for `note_date` in `sql/civicrm.mysql` it's not specified:
sql/civicrm.mysql: `note_date` timestamp DEFAULT CURRENT_TIMESTAMP COMMENT 'Date attached to the note',
So I think the fix is to add an upgrade script for the next upgrade to alter this field and ensure it is set to `NOT NULL`.5.43.0https://lab.civicrm.org/dev/core/-/issues/2880No meaningful translation possible for "Cancel "2021-10-02T05:28:27ZDetlev SieberNo meaningful translation possible for "Cancel "Overview
----------------------------------------
civicrm/CRM/Event/Form/SelfSvcUpdate.php contains a selection of "transfer" and "cancel" for an event participation. However, "cancel" is a very common word which cannot be translated in ...Overview
----------------------------------------
civicrm/CRM/Event/Form/SelfSvcUpdate.php contains a selection of "transfer" and "cancel" for an event participation. However, "cancel" is a very common word which cannot be translated in a meaningful way in this context (at least for many languages, e.g. german).
"cancel registration" remains meaningful in english, but works better in other languages.
This string already exists in CRM/Event/Form/Registration/ParticipantConfirm.php, so most probably transifex already has the translation available for most languages.
Changing the string from "Cancel" to "Cancel Registration" will help - especially since this string already exists in the code and is already5.43.0https://lab.civicrm.org/dev/core/-/issues/2876Message about dependent extensions when installing an extension uses "key" in...2021-10-18T19:28:04ZDaveDMessage about dependent extensions when installing an extension uses "key" instead of labelFor example when you install stripe, you get
```
x
Extension Upgrade Failed
You will not be able to install/upgrade com.drastikbydesign.stripe until you have installed the mjwshared extension.
```
Now try to find "mjwshared" to install...For example when you install stripe, you get
```
x
Extension Upgrade Failed
You will not be able to install/upgrade com.drastikbydesign.stripe until you have installed the mjwshared extension.
```
Now try to find "mjwshared" to install it. If you don't already know that that's called "Payment shared" you can't find it. I think this changed when the extension screen stopped showing the keys which wasn't that long ago, but I wouldn't really call it a "regression".
It's at https://github.com/civicrm/civicrm-core/blob/8df2a2894845a30c9af289694cfd7f5373333b54/CRM/Extension/Downloader.php#L80
The second variable $extension is just a string so at first glance the label isn't readily available and it might need to do some kind of lookup.5.44.0https://lab.civicrm.org/dev/core/-/issues/2872Email to Activity processing: If there's a matching org contact and no matchi...2021-11-09T15:24:53Zlisandro_compucorpEmail to Activity processing: If there's a matching org contact and no matching individual, then file on the org instead of creating a new individualOverview
----------------------------------------
Hello CiviCRM team, on the automatic creation of email activities, we are trying to find a solution for the received emails that are associated with organizations, not individuals.
The e...Overview
----------------------------------------
Hello CiviCRM team, on the automatic creation of email activities, we are trying to find a solution for the received emails that are associated with organizations, not individuals.
The emails sent to an organization mail account are associated with a new contact of type `individual`, instead of the existent contact of type `organization`.
This exact same situation was raised a few years ago here: https://civicrm.stackexchange.com/questions/20200/autofiling-email-activities-via-emailprocessor-to-organization
Proposed behaviour
----------------------------------------
We would like to add the ability to save these organization emails on the expected contact. This would be configurable using a specific new setting.
We would do the change on https://github.com/civicrm/civicrm-core/blob/master/CRM/Utils/Mail/Incoming.php#L450
replacing the line for something like
```php
$cType = CRM_Core_BAO_MailSettings::defaultDAO()->save_organization_emails ? NULL : 'Individual';
$dao = CRM_Contact_BAO_Contact::matchContactOnEmail($email, $cType);
```
And adding the new field on MailSetting:
![new_screen](/uploads/6545b96b1b5e7dd1b3244573f86d762c/new_screen.png)
If you think it is an acceptable idea, we will create a PR.
Thanks!5.45.0https://lab.civicrm.org/dev/core/-/issues/2870Upgrade error - upgrading to 5.432021-09-29T22:27:14ZeileenUpgrade error - upgrading to 5.43I just hit this upgrading my local copy of the wmf db (it's unlikely to have much oddness in it as a local dev version)
From https://github.com/civicrm/civicrm-core/commit/9f3b9e969597d718a23a22f904c703338ce186fa
![image](/uploads/1f3e...I just hit this upgrading my local copy of the wmf db (it's unlikely to have much oddness in it as a local dev version)
From https://github.com/civicrm/civicrm-core/commit/9f3b9e969597d718a23a22f904c703338ce186fa
![image](/uploads/1f3e16ec59af641428453c1e52b03f1e/image.png)
SHOW CREATE TABLE
```
CREATE TABLE `civicrm_mapping_field` (
`id` int(10) unsigned NOT NULL AUTO_INCREMENT COMMENT 'Mapping Field ID',
`mapping_id` int(10) unsigned NOT NULL COMMENT 'Mapping to which this field belongs',
`name` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Mapping field key',
`contact_type` varchar(64) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Contact Type in mapping',
`column_number` int(10) unsigned NOT NULL COMMENT 'Column number for mapping set',
`location_type_id` int(10) unsigned DEFAULT NULL COMMENT 'Location type of this mapping, if required',
`phone_type_id` int(10) unsigned DEFAULT NULL COMMENT 'Which type of phone does this number belongs.',
`im_provider_id` int(10) unsigned DEFAULT NULL COMMENT 'Which type of IM Provider does this name belong.',
`website_type_id` int(10) unsigned DEFAULT NULL COMMENT 'Which type of website does this site belong',
`relationship_type_id` int(10) unsigned DEFAULT NULL COMMENT 'Relationship type, if required',
`relationship_direction` varchar(6) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
`grouping` int(10) unsigned DEFAULT 1 COMMENT 'Used to group mapping_field records into related sets (e.g. for criteria sets in search builder\n mappings).',
`operator` varchar(16) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'SQL WHERE operator for search-builder mapping fields (search criteria).',
`value` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'SQL WHERE value for search-builder mapping fields.',
PRIMARY KEY (`id`),
KEY `FK_civicrm_mapping_field_mapping_id` (`mapping_id`),
KEY `FK_civicrm_mapping_field_location_type_id` (`location_type_id`),
KEY `FK_civicrm_mapping_field_relationship_type_id` (`relationship_type_id`),
CONSTRAINT `FK_civicrm_mapping_field_location_type_id` FOREIGN KEY (`location_type_id`) REFERENCES `civicrm_location_type` (`id`),
CONSTRAINT `FK_civicrm_mapping_field_mapping_id` FOREIGN KEY (`mapping_id`) REFERENCES `civicrm_mapping` (`id`),
CONSTRAINT `FK_civicrm_mapping_field_relationship_type_id` FOREIGN KEY (`relationship_type_id`) REFERENCES `civicrm_relationship_type` (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci ROW_FORMAT=DYNAMIC```5.43.0