CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-06-05T05:06:28Zhttps://lab.civicrm.org/dev/core/-/issues/4329description is wrong for permission to view notes that are marked for author ...2023-06-05T05:06:28Ztpokorradescription is wrong for permission to view notes that are marked for author onlyOverview
----------------------------------------
I am wondering if the label in https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Permission.php#LL785C46-L785C46 is correct.
It is about the permission for viewing all notes. I...Overview
----------------------------------------
I am wondering if the label in https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Permission.php#LL785C46-L785C46 is correct.
It is about the permission for viewing all notes. It says: "even if they're marked admin only", but I would expect: "even if they're marked author only".
according to https://github.com/civicrm/civicrm-core/blob/master/sql/civicrm_data/civicrm_option_group/note_privacy.sqldata.php#L17
see https://chat.civicrm.org/civicrm/pl/ye4bu5w87b81mennu3at5ifcrr
Reproduction steps
----------------------------------------
1. Go to User Permissions in Drupal (/admin/people/permissions)
1. See the permission "CiviCRM: view all notes"
Current behaviour
----------------------------------------
The description says: View notes (for visible contacts) even if they're marked admin only
Expected behaviour
----------------------------------------
The description should say: View notes (for visible contacts) even if they're marked author only
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __CiviCRM:__ _5.60.0_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _8.1__
* __CMS:__ Drupal 9.8.5_
Comments
----------------------------------------
see the labels for the options for the notes: None or Author only.
https://github.com/civicrm/civicrm-core/blob/master/sql/civicrm_data/civicrm_option_group/note_privacy.sqldata.php#L17
There is nothing about "admin only"5.63.0https://lab.civicrm.org/dev/core/-/issues/4328Double opt-in requires traditional bounce handling to be enabled2023-06-28T06:55:29ZJonGoldDouble opt-in requires traditional bounce handling to be enabledOverview
----------------------------------------
The default double opt-in email says:
> You have a pending subscription to the {subscribe.group} mailing list. To confirm this subscription, reply to this email or click <a href="{subscri...Overview
----------------------------------------
The default double opt-in email says:
> You have a pending subscription to the {subscribe.group} mailing list. To confirm this subscription, reply to this email or click <a href="{subscribe.url}">here</a>.
However, "reply to this email" requires traditional bounce handling (with a bounce mailbox) to be set up. In this day and age that's less common compared to using a third party mailer that sends bounce notifications via API (to [Airmail](https://civicrm.org/extensions/airmail) or one of its many cousins).
Moreover, it's a usability issue to put "here" as the clickable text. It should be more like: "Please click here to <a href="{subscribe.url}">confirm your subscription.</a>.
I want to get concept approval - and also guidance on whether we should update existing templates or just new installs. Personally I think we should update any non-customized template.https://lab.civicrm.org/dev/core/-/issues/4327GroupTest occasionally failing due to new test2023-06-12T22:23:38ZlarsssandergreenGroupTest occasionally failing due to new testI've noted a [test failure here](https://github.com/civicrm/civicrm-core/blob/40728fa72022780372b2728315e323a55cab76bf/tests/phpunit/api/v4/Entity/GroupTest.php#L234) a couple times over the last few days, e.g. [here](https://test.civicr...I've noted a [test failure here](https://github.com/civicrm/civicrm-core/blob/40728fa72022780372b2728315e323a55cab76bf/tests/phpunit/api/v4/Entity/GroupTest.php#L234) a couple times over the last few days, e.g. [here](https://test.civicrm.org/job/CiviCRM-Core-Matrix-PR/2442/) or [here](https://test.civicrm.org/job/CiviCRM-Core-Matrix-PR/2434/). It looks like the two child groups get flipped sometimes.
This was just added a [few days ago](https://github.com/civicrm/civicrm-core/commit/187159263745660bac548b5cf2b5d30e1b8b9412), so tagging @colemanw.https://lab.civicrm.org/dev/core/-/issues/4326Notice errors on backoffice event registration2023-06-09T23:38:52ZJoeMurrayNotice errors on backoffice event registrationOverview
----------------------------------------
_Register a participant in backoffice. See notice errors._
Reproduction steps
----------------------------------------
1. On dmaster, click on **Events -> Register Event Participant**.
1...Overview
----------------------------------------
_Register a participant in backoffice. See notice errors._
Reproduction steps
----------------------------------------
1. On dmaster, click on **Events -> Register Event Participant**.
1. Select a contact, event fall fundraiser dinner, click **Save**.
1. Get three copies for different line numbers of "Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule()".
Current behaviour
----------------------------------------
![2023-05-31_12-59-37](/uploads/b2ec1cad1728b29ecc09742cd557d759/2023-05-31_12-59-37.png)
```
Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule() (line 825 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
Notice: Trying to get property '_id' of non-object in CRM_Event_Form_Participant::formRule() (line 828 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
Notice: Trying to get property '_action' of non-object in CRM_Event_Form_Participant::formRule() (line 836 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Event/Form/Participant.php).
```
Note: happens when recording payment and when not recording payment.
Expected behaviour
----------------------------------------
_No notice errors_
Environment information
----------------------------------------
dmaster
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.63.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/4325Extra `<br>` tags inserted into rich text fields2023-06-01T13:38:11ZdtwExtra `<br>` tags inserted into rich text fieldsOverview
----------------------------------------
Extra `<br>` tags being inserted between HTML elements in rich-text fields, including between list items! And two being inserted between paragraphs. The html is clean in the editor, but t...Overview
----------------------------------------
Extra `<br>` tags being inserted between HTML elements in rich-text fields, including between list items! And two being inserted between paragraphs. The html is clean in the editor, but this is how it's being rendered on the front-end.
https://civicrm.stackexchange.com/questions/31535/br-tags-inserted-in-rich-text-fields-custom-fieldsets-when-displayed-as-tabs
Reproduction steps
----------------------------------------
"I added a custom field set to contacts, which I set to appear in a tab, then a 'note' type field and set it to be rich text. On a contact record, I added a couple of paragraphs (by hitting return between them) - looks good on the backend, but 2 x `<br>` tags between each `<p>` appearing on the front-end."
Current behaviour
----------------------------------------
Extra `<br>` tags are added
![CiviCRM_Screenshot_2023-05-31_152744](/uploads/7d62b59e050c00c5b9405a2268685eaf/CiviCRM_Screenshot_2023-05-31_152744.png)
![CiviCRM_Screenshot_2023-05-31_152938](/uploads/182e333899f70faa9405c5fe64e154e8/CiviCRM_Screenshot_2023-05-31_152938.png)
Maybe related to this change: https://issues.civicrm.org/jira/browse/CRM-11598
Expected behaviour
----------------------------------------
Extra `<br>` tags should not be added. Spacing should be handled with CSS.
Comments
----------------------------------------
_Anything else you would like the reviewer to note._5.63.0https://lab.civicrm.org/dev/core/-/issues/4324Add Contribution Page settings for Review and Make Contribution button text2023-11-23T07:47:54ZlarsssandergreenAdd Contribution Page settings for Review and Make Contribution button textContribution Pages can be important to some organizations who do a lot of fundraising. It would be nice if the buttons were customizable, so they could say 'Donate', 'Give', 'Get Membership' or whatever the user might want.
Proposal: Ad...Contribution Pages can be important to some organizations who do a lot of fundraising. It would be nice if the buttons were customizable, so they could say 'Donate', 'Give', 'Get Membership' or whatever the user might want.
Proposal: Add two fields to Contribution Pages: review_button_text and submit_button_text. These settings could live on the main settings tab, underneath "Use a confirmation page?" with review_button_text hidden and shown conditionally. If these are populated, use these values, if not, fall back to the default (Contribute or Review your contribution followed by Make Contribution).https://lab.civicrm.org/dev/core/-/issues/4323Date is incorrect when editing a contribution2023-11-09T19:36:12ZJDrueryDate is incorrect when editing a contributionWhen editing a contribution, Date Received is always set 05/30/2013 in the edit dialog. Under Payment Details, the date is correct (see first and second images below). When adding a new date in the Edit Contribution dialog, the popup cal...When editing a contribution, Date Received is always set 05/30/2013 in the edit dialog. Under Payment Details, the date is correct (see first and second images below). When adding a new date in the Edit Contribution dialog, the popup calendar always defaults to May of 2013. The year selector doesn't allow selecting anything after 2013 (third and fourth images).
A workaround is to change Date Preferences for activityDateTime. Changing the end offset from the default setting of 10 to 0 allows for dates up to the current year. I suspect this bug is caused by the end offset being interpreted as number of years before the current year, instead of number of years after the current year. Setting the end offset to -10 has the same effect as setting it to +10 (only dates 10 years before the current year are allowed).
![image](/uploads/68cdb261f247a35c092d34cab44e8f52/image.png)
![image](/uploads/501943aeba9f96ff61e9a0cd5c7449d5/image.png)
![image](/uploads/cba0d6b5a42f2b81ec28cd8e77890062/image.png)
![image](/uploads/d4d9340b4c377ef828a4a4cadf3a09ac/image.png)5.66.0https://lab.civicrm.org/dev/core/-/issues/4322Smart groups in group tab for contact too slow2023-05-31T08:18:14ZyashodhaSmart groups in group tab for contact too slowSmart groups in group tab for contact too slow. This should be optimized.Smart groups in group tab for contact too slow. This should be optimized.yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/4321Mailing Report link on Contact Mailings broken for A/B tests2023-05-30T22:22:24ZlarsssandergreenMailing Report link on Contact Mailings broken for A/B testsOverview
----------------------------------------
If you try to view a Mailing Report for an A/B Mailing from the Contact Mailings tab, you get unknown path instead of the mailing report. See [chat discussion here](https://chat.civicrm.o...Overview
----------------------------------------
If you try to view a Mailing Report for an A/B Mailing from the Contact Mailings tab, you get unknown path instead of the mailing report. See [chat discussion here](https://chat.civicrm.org/civicrm/pl/5rsi3a9y67dozbc8gzzmt71eic). The issue is that there is a [redirect](https://github.com/civicrm/civicrm-core/blob/cf6c1ffdcb96f45743752e451345140bdcfd7305/CRM/Mailing/Page/Report.php#L86) when the mailing report is an A/B test and that redirect does not work through [crmApp.js](https://github.com/civicrm/civicrm-core/blob/master/ang/crmApp.js) because it changes the $location, which does not work in a modal.
Reproduction steps
----------------------------------------
1. Enable Mailings for Viewing Contacts on Admin - Customize Data and Screens - Display Preferences.
1. Click Mailing Report beside an A/B test mailing on the Mailings tab on a Contact
1. Pop up says unknown path, no mailing report
Comments
----------------------------------------
Would be happy to do some work on fixing this, but I'm not sure what the approach would be.https://lab.civicrm.org/dev/core/-/issues/4320API: Should NOT operators return NULL values?2023-07-13T23:50:59ZlarsssandergreenAPI: Should NOT operators return NULL values?If you do != 5 in SQL, you'll get all rows that aren't 5, not including null values. This is the same in the API and SearchKit. I wonder if this is the desired behaviour? I would think the assumption would be that if I search for all Con...If you do != 5 in SQL, you'll get all rows that aren't 5, not including null values. This is the same in the API and SearchKit. I wonder if this is the desired behaviour? I would think the assumption would be that if I search for all Contributions where the Contribution Page is != 5, I would get all Contributions except those that have Contribution Page = 5 — but what I actually get is all Contributions that have a Contribution Page, but where that Contribution Page isn't 5.
In other words, I think you'd generally expect that if you search all Contributions where Contribution Page = 5 OR Contribution Page != 5, you'd just get all Contributions, but you only get Contributions with a Contribution Page. Obviously, your expectation might change based on your familiarity with SQL.
This is the same for NOT LIKE, NOT REGEX, and so on.
On the one hand, it's generally better to keep the behaviour of the API operators the same as SQL to avoid confusion. On the other hand, I'm having a hard time imagining a search you might want to make with a NOT that you wouldn't want to include null values, so this seems unhelpful and potentially frustrating. Is this something we should consider changing?https://lab.civicrm.org/dev/core/-/issues/4319SearchKit + FormBuilder: In place edit using a list view2023-06-22T14:15:45Zsimon.hermannSearchKit + FormBuilder: In place edit using a list viewOverview
----------------------------------------
I was trying to embed a list view of a SearchKit in FormBuilder, where some of the entries have 'in-place edit' activated. When looking at the Afform I am able to click on those entries a...Overview
----------------------------------------
I was trying to embed a list view of a SearchKit in FormBuilder, where some of the entries have 'in-place edit' activated. When looking at the Afform I am able to click on those entries and the the green checkmark as well as the red X appear, however I am not able to edit the content of the entry.
Reproduction steps
----------------------------------------
1. Create a SearchKit with a list view
1. Activate the option 'in-place edit' for some of the entries.
1. Embed the list view in a Afform.
Current behaviour
----------------------------------------
The entries with 'in-place edit' are clickable and the green checkmark as well as the red X are showing. However, the input is shown but cannot be altered.
Expected behaviour
----------------------------------------
The input is shown and I can edit it.
Environment information
----------------------------------------
* __CiviCRM:__ 5.58.1 and 5.60
* __PHP:__ 7.4 and 8.1
* __CMS:__ WordPress 6.1.3https://lab.civicrm.org/dev/core/-/issues/4318Contributions sometimes lack line items, leads to fatal error upon "Download ...2023-06-21T00:11:44ZAllenShawContributions sometimes lack line items, leads to fatal error upon "Download Invoice"Originally reported at https://civicrm.stackexchange.com/questions/44907/contribution-has-no-line-items-shouldnt-that-be-impossible
**Problem and observation:**
On several sites I have found contributions which have no line items -- th...Originally reported at https://civicrm.stackexchange.com/questions/44907/contribution-has-no-line-items-shouldnt-that-be-impossible
**Problem and observation:**
On several sites I have found contributions which have no line items -- that is, rows in civicrm_contribution that have no corresponding rows in civicrm_line_item.
![no-line-items](/uploads/0f3958d00084586a43d7c04419a29ab7/no-line-items.png)
Responses at the above-linked SE question indicate that this is not normal.
This situation leads to a fatal error ("Return value of CRM_Financial_BAO_Order::getPriceSetID() must be of the type int, null returned") when attempting to generate a PDF invoice with "Download Invoice" for the given contribution, apparently on the assumption that this situation is not expected by core code.
**Detecting ffected sites:**
I've observed this on several sites (all currently running CiviCRM 5.58.1 but all having existed much longer), including one local dev site that sees relatively light usage.
This SQL query identifies contributions lacking line items:
```
SELECT count(*)
FROM
civicrm_contribution ctr
left join civicrm_line_item li on li.contribution_id = ctr.id
where li.id is null;
```
**Unable to repro:**
I'm unable to reproduce this situation at will, except by manually deleting rows in civicrm_line_item via API or SQL. It seems any contribution record will, by design, have at least one line_item, even if using a quick-config contribution instead of a visible price set, or if manually creating even a zero-dollar contribution in the back-end.
**Moving forward:**
Until we have a solid set of steps to repro, I'm not sure there's much we can do here. Hopefully this issue can serve as a place for others to share their findings (and hopefully we'll get to some repro steps at some point).https://lab.civicrm.org/dev/core/-/issues/4317Import contribution fails with custom fields2023-07-05T23:48:39ZPhilipp MichaelImport contribution fails with custom fieldsOverview
----------------------------------------
When importing contributions with field mappings to a custom field, the process fails after continuing from step 2 of 3.
Reproduction steps
----------------------------------------
1. Cl...Overview
----------------------------------------
When importing contributions with field mappings to a custom field, the process fails after continuing from step 2 of 3.
Reproduction steps
----------------------------------------
1. Click on **Contributions -> Import Contributions**.
1. Choose mandotory options and continue to step 2.
1. In "Matching CiviCRM Field" choose at least one custom field and try to continue to step 3
1. Got an error "**TypeError: CRM_Import_Parser::getFieldMetadata(): Return value must be of type array, null returned**".
Current behavior
----------------------------------------
Regardless of the provided CSV data, the process fails with:
```
TypeError: CRM_Import_Parser::getFieldMetadata(): Return value must be of type array, null returned in CRM_Import_Parser->getFieldMetadata() (line 1768 of /var/www/html/vendor/civicrm/civicrm-core/CRM/Import/Parser.php).
CRM_Import_Parser->getFieldMetadata('Zu_belastendes_Konto.nur_anstehende_Zuwendungen._IBAN') (Line: 165)
CRM_Contribute_Import_Parser_Contribution->getMappedRow(Array) (Line: 221)
CRM_Contribute_Import_Parser_Contribution->validateValues(Array) (Line: 2551)
CRM_Import_Parser->validateRow(Array) (Line: 1842)
CRM_Import_Parser->validate() (Line: 90)
CRM_Import_Form_MapField->postProcess() (Line: 612)
CRM_Core_Form->mainProcess() (Line: 144)
CRM_Core_StateMachine->perform(Object, 'next', 'Next') (Line: 43)
CRM_Core_QuickForm_Action_Next->perform(Object, 'next') (Line: 203)
HTML_QuickForm_Controller->handle(Object, 'next') (Line: 103)
HTML_QuickForm_Page->handle('next') (Line: 355)
CRM_Core_Controller->run(Array, NULL) (Line: 319)
CRM_Core_Invoke::runItem(Array) (Line: 69)
CRM_Core_Invoke::_invoke(Array) (Line: 36)
CRM_Core_Invoke::invoke(Array) (Line: 88)
Drupal\civicrm\Civicrm->invoke(Array) (Line: 83)
Drupal\civicrm\Controller\CivicrmController->main(Array, '')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
```
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.60/5.62/5.64_
* __PHP:__ _8.0_
* __CMS:__ _Drupal 9.5.9_
* __Database:__ _MariaDB 10.4.28_
Comments
----------------------------------------
I've tested latest versions and can reproduce it in 5.60 and later. It was probably caused with changes in [Update Contribution Import to use apiv4 field names, prior to adding hooks](https://github.com/civicrm/civicrm-core/pull/25886). The way of getting custom fields available for import has changed, which leads to different field keys respectively option values. Previously you got the short version "custom_xy", now you get a long database field name like one.
5.59:
![mapping-custom-fields-options-5.59](/uploads/e4f4adc83357fd0c3e7613b6f92d5bb2/mapping-custom-fields-options-5.59.png)
5.60 (and 5.62, 5.64):
![mapping-custom-fields-options-5.62](/uploads/d0f7573c8f279bc53c794949d3183ea9/mapping-custom-fields-options-5.62.png)
The import parser can't find related field meta data regarding to those keys.
I'm not sure, if those key names provided by the API are intended and therefor can't provide a PR.5.63.0https://lab.civicrm.org/dev/core/-/issues/4316Allow administrators to restrict which contacts will receive an email notific...2023-05-31T23:54:42Zayush_compucoAllow administrators to restrict which contacts will receive an email notification when an activity is assigned to a contactHow it works currently:
----------------------------------------
Administrators can only choose either to enable or disable sending email notifications (including a copy of the activity) when an activity is assigned to a contact OR limit...How it works currently:
----------------------------------------
Administrators can only choose either to enable or disable sending email notifications (including a copy of the activity) when an activity is assigned to a contact OR limit it to specific types of activity.
![image](/uploads/15806181b9f0204f847f4e8a8a70b817/image.png)
https://dmaster.demo.civicrm.org/civicrm/admin/setting/preferences/display?reset=1
**Improvement**
----------------------------------------
We would like to allow administrators to specify which groups of users would receive an email so that certain users can be assigned an activity, but they would not receive CiviCRM's default activity assignee email.
**Note**
----------------------------------------
Note, there is already some similar (but subtly different!) functionality on CiviCase for case activities:
![image](/uploads/7683b54741cb91ec61227f47c7eb87cc/image.png)
The above restricts **who can be selected** to be assigned an activity, whereas we are specifying **who would be sent** a notification for an activity.
**Proposed solution**
----------------------------------------
We propose adding a new functionality that allows administrators to specify which CiviCRM groups would receive an email notifications. This can be achieved by introducing a new dropdown field.
We would create 2 new settings for this under the setting for "Do not notify assignees for" <Activity types> on the Display Preferences page: https://dmaster.demo.civicrm.org/civicrm/admin/setting/preferences/display?reset=1 which states:
1. Restrict email recipients to groups
- <Select Group> (list all CiviCRM groups or smart groups)
- Multiselect
- Help: Limit which contacts will receive a CiviCRM activity notification email when an activity is assigned to them. You can select any group or smart group. Leave blank for no restriction. Note that you may still assign an activity to a contact who is not in the group, but they will not receive an email.
If the field is blank there will be no restriction. If a group is selected, emails will be restricted to only go to that group.
2. Restrict email recipients to Website Users
- Checkbox
- Help: Limit which contacts will receive a CiviCRM activity notification email to only be those who have a CMS user when an activity is assigned to them. Note that you may still assign an activity to a contact who does not have a CMS user, but they will not receive an email.
Emails will be suppressed in each case.
**Next steps**
----------------------------------------
We are prepared to submit a pull request (PR) for this feature. If the concept is approved, we will promptly submit the core PR.
Thank you.https://lab.civicrm.org/dev/core/-/issues/4315Undefined array warnings when editing the emails of a contact2023-06-06T05:54:59ZTobias KrauseUndefined array warnings when editing the emails of a contact- go to a contact
- click on "Add or edit email" when you hover over the email section
On click the following messages appear in watchdog:
```
Warning: Undefined array key "oplock_ts" in include() (Zeile 5 in C:\wamp64\www\civicrm\http...- go to a contact
- click on "Add or edit email" when you hover over the email section
On click the following messages appear in watchdog:
```
Warning: Undefined array key "oplock_ts" in include() (Zeile 5 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%97\973\973BB488%%Email.tpl.php)
Warning: Trying to access array offset on value of type null in include() (Zeile 5 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%97\973\973BB488%%Email.tpl.php)
```
When saving for each email the following error message appears in watchdog:
`Warning: Undefined array key "mailingOutboundOption" in include() (Zeile 37 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%09\098\0983F079%%Email.tpl.php)`https://lab.civicrm.org/dev/core/-/issues/4314Many undefined array and deprecated warnings when adding a new activity for a...2023-11-15T20:11:28ZTobias KrauseMany undefined array and deprecated warnings when adding a new activity for a contact- Open a contact and go to the "Activities" tab
- Click on "+ New Activity"
In many case we see a lot of warnings appearing in watchdog - in total 21 but it seems that the following 3 messages are repeated 7 times:
```
Warning: Undefi...- Open a contact and go to the "Activities" tab
- Click on "+ New Activity"
In many case we see a lot of warnings appearing in watchdog - in total 21 but it seems that the following 3 messages are repeated 7 times:
```
Warning: Undefined array key "params" in include() (Zeile 5 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%DF\DF0\DF0B0562%%RecurringEntity.hlp.php)
Warning: Trying to access array offset on value of type null in include() (Zeile 5 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%DF\DF0\DF0B0562%%RecurringEntity.hlp.php)
Deprecated function: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in smarty_modifier_lower() (Zeile 23 in C:\wamp64\www\civicrm\vendor\civicrm\civicrm-packages\Smarty\plugins\modifier.lower.php)
```
For the last warning: I mentioned it already in https://lab.civicrm.org/dev/core/-/issues/4312 - maybe this warning might be an issue on it's ownhttps://lab.civicrm.org/dev/core/-/issues/4313Undefined array keys warnings when activities of a contact are listed2023-06-06T05:55:14ZTobias KrauseUndefined array keys warnings when activities of a contact are listedWhen you open a contact and click on the tab "Activities" we see the following warnings in watchdog regardless of how many activities are listed there.
```
Warning: Undefined array key "addAssigneeContact" in include() (Zeile 7 in C:\wa...When you open a contact and click on the tab "Activities" we see the following warnings in watchdog regardless of how many activities are listed there.
```
Warning: Undefined array key "addAssigneeContact" in include() (Zeile 7 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%E3\E36\E366782B%%Tab.tpl.php)
Warning: Undefined array key "addTargetContact" in include() (Zeile 7 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%E3\E36\E366782B%%Tab.tpl.php)
Warning: Undefined array key "hideRelativeLabel" in include() (Zeile 9 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%48\480\480BECF5%%DatePickerRange.tpl.php)
```https://lab.civicrm.org/dev/core/-/issues/4312Undefined array key and deprecated warnings on contributions overview page2023-06-06T05:55:19ZTobias KrauseUndefined array key and deprecated warnings on contributions overview pageWhen going to /civicrm/contact/view/contribution many "array undefined" warnings appear in watchdog:
```
Warning: Undefined array key "selectedChild" in include() (Zeile 11 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\c...When going to /civicrm/contact/view/contribution many "array undefined" warnings appear in watchdog:
```
Warning: Undefined array key "selectedChild" in include() (Zeile 11 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%6F\6FD\6FDADEDF%%TabSelected.tpl.php)
Warning: Undefined array key "type" in include() (Zeile 17 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%3D\3D4\3D44E36C%%Selector.tpl.php)
**(I think this warning appears once for each contribution in the list)**
Warning: Undefined array key "softCredit" in include() (Zeile 93 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%84\843\843D5262%%Tab.tpl.php)
Warning: Undefined array key "payment_processor" in include() (Zeile 12 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%1B\1B6\1B6ACE3B%%ContributionRecurSelector.tpl.php)
Warning: Undefined array key "recurId" in include() (Zeile 12 in C:\wamp64\www\civicrm\httpdocs\sites\default\files\private\civicrm\templates_c\en_US\%%1B\1B6\1B6ACE3B%%ContributionRecurSelector.tpl.php)
Deprecated function: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in smarty_modifier_replace() (Zeile 25 in C:\wamp64\www\civicrm\vendor\civicrm\civicrm-packages\Smarty\plugins\modifier.replace.php)
```https://lab.civicrm.org/dev/core/-/issues/4311Undefined array key warnings when entering a report page2023-06-06T05:54:40ZTobias KrauseUndefined array key warnings when entering a report pageWhen a report page is accessed several warnings appear in watchdog. For example the path of one of the reports is /civicrm/report/instance/3, the warnings are:
```
Warning: Undefined array key "batch_id_op" in include() (Zeile 42 in sit...When a report page is accessed several warnings appear in watchdog. For example the path of one of the reports is /civicrm/report/instance/3, the warnings are:
```
Warning: Undefined array key "batch_id_op" in include() (Zeile 42 in sites\default\files\private\civicrm\templates_c\en_US\%%E0\E0C\E0C36992%%Filters.tpl.php)
Warning: Trying to access array offset on value of type null in include() (Zeile 42 in sites\default\files\private\civicrm\templates_c\en_US\%%E0\E0C\E0C36992%%Filters.tpl.php)
Warning: Undefined array key "type" in include() (Zeile 48 in sites\default\files\private\civicrm\templates_c\en_US\%%1B\1BD\1BD7DE8F%%Statistics.tpl.php)
Warning: Undefined array key "type" in include() (Zeile 51 in sites\default\files\private\civicrm\templates_c\en_US\%%1B\1BD\1BD7DE8F%%Statistics.tpl.php)
```https://lab.civicrm.org/dev/core/-/issues/4310Membership HTML output on contribution pages causing layout errors due to unc...2023-05-24T07:36:13ZFrancis (Agileware)Membership HTML output on contribution pages causing layout errors due to unclosed div - 5.61 regressionOverview
----------------------------------------
[commit:dfc5fb9](https://github.com/civicrm/civicrm-core/commit/dfc5fb948b0cb11947b3b75131b54b1c365f08b1) caused a regression in the display of the Membership block, where the logic wrapp...Overview
----------------------------------------
[commit:dfc5fb9](https://github.com/civicrm/civicrm-core/commit/dfc5fb948b0cb11947b3b75131b54b1c365f08b1) caused a regression in the display of the Membership block, where the logic wrapping the "makeContribution" context skips both the closing div and the javascript portion that replaces the auto renew checkbox with a note in force autorenewal mode.
Reproduction steps
----------------------------------------
1. Create a membership contribution page.
2. Attempt to use the contribution page.
Current behaviour
----------------------------------------
The membership block escapes its containment matrix, causing an unclosed div error on the form. This manifests in the browser as a layout nesting issue.
The [W3 validator](https://validator.w3.org/nu/) explains the problem as:
```
Error: End tag form seen, but there were open elements.
From line 1779, column 3; to line 1779, column 9
>↩ ↩ ↩ </form>↩
Error: Unclosed element div.
From line 692, column 3; to line 692, column 128
↩ ↩ <div class="crm-contribution-page-id-7 crm-block crm-contribution-main-form-block" data-page-id="7" data-page-template="main">↩↩
Fatal Error: Cannot recover after last error. Any further errors will be ignored.
From line 1779, column 3; to line 1779, column 9
>↩ ↩ ↩ </form>↩
```
In addition to this, if the membership type should force autorenewal, it may not due to a missing javascript section.
Expected behaviour
----------------------------------------
There should be no layout nesting issue, and all divs should be closed appropriately.
The script to advise the end use on autorenewal should function.
Environment information
----------------------------------------
* __CiviCRM:__ _Master, 5.61.x_
* __PHP:__ 8.0
* __CMS:__ WordPress 6.2.25.61.4