CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2019-12-05T03:06:22Zhttps://lab.civicrm.org/dev/core/-/issues/1435Membership and Event Related Contributions - shows all contributions2019-12-05T03:06:22Zaydunsaidan.saunders@squiffle.ukMembership and Event Related Contributions - shows all contributionsOverview
----------------------------------------
When viewing a membership or participant record, the related contributions show *all* contributions, not those related to the membership.
Reproduction steps
-----------------------------...Overview
----------------------------------------
When viewing a membership or participant record, the related contributions show *all* contributions, not those related to the membership.
Reproduction steps
----------------------------------------
1. Go to a contact's Memberships tab. (Or Events tab)
1. Click View on the Membership (Or Event)
Current behaviour
----------------------------------------
Observe that the 'Related Contributions' shows all contributions, not just those related to the membership/event.
Expected behaviour
----------------------------------------
Related Contributions should only show those related to the membership.
Comments
----------------------------------------
This used to work correctly - eg in 5.18.4
The membership view uses CRM_Contribute_Form_Search and passes a `contactId` and `memberId`. The handling of forced searches and the use of `$this->_formValues` in CRM_Contribute_Form_Search and CRM_Core_Form_Search has changed with the result that `memberId` is not passed into the query.
In https://github.com/civicrm/civicrm-core/blob/5.18/CRM/Contribute/Form/Search.php#L108 forced searches are performed after `$this->_formValues['contribution_membership_id']` is set at https://github.com/civicrm/civicrm-core/blob/5.18/CRM/Contribute/Form/Search.php#L101
The forced search is now carried out in `parent::preProcess()`. Retrieving `memberId` from the URL needs to happen somewhere before the query. Note that with the changes to setFormValues(), getFormValues() just assigning to `$this->_formValues['contribution_membership_id']` is not the right approach. The question (probably for @eileen) is what the right approach is now.
The issue applies to `participantId` and events.5.19.4https://lab.civicrm.org/dev/core/-/issues/1429CiviEvent - can't add event payment if the user already has previous paid events2019-12-05T06:50:32ZRoseLaniganCiviEvent - can't add event payment if the user already has previous paid eventsI have managed to replicate on the demo site:
* Added Brent Adams to one event (Rainforest Soccer) but with no payment
* Edited the event registration to add a payment, and I can see the 'Record payment' checkbox properly and I record a...I have managed to replicate on the demo site:
* Added Brent Adams to one event (Rainforest Soccer) but with no payment
* Edited the event registration to add a payment, and I can see the 'Record payment' checkbox properly and I record a payment - fine
* Added Brent Adams to a second event (Fall Fundraiser Dinner) but with no payment
* Tried to edit this registration and add a payment but there is no 'Record Payment' checkbox this time, and at the bottom of the registration page, it has incorrectly listed the payment for the first event and no ability to record the payment for this event.5.19.4eileeneileenhttps://lab.civicrm.org/dev/core/-/issues/1422Event Participants actions (Print Name Badges, Export...) ignores search crit...2019-12-09T01:47:09ZalainbEvent Participants actions (Print Name Badges, Export...) ignores search criteriaOverview
----------------------------------------
After a participant search from an event, the actions ignore the search criteria.
Reproduction steps
----------------------------------------
In the CiviCRM demo environment:
1. Click on...Overview
----------------------------------------
After a participant search from an event, the actions ignore the search criteria.
Reproduction steps
----------------------------------------
In the CiviCRM demo environment:
1. Click on **Events -> Manage Events**.
1. For e.g. the Rain-forest Cup Youth Soccer Tournament, click on the right-hand side, click on **Participants -> Registered, Attended, Pending...**.
1. Got 8 participants.
1. Click on **All 8 records -> Actions -> Name Badges Print**
1. The next screen shows **Number of selected participants: 18** instead of **8**.
Similar problem if you select the export action: the confirmation screen shows 8, but the actual export contains 18 lines.
Comments
----------------------------------------
I noticed that the function setDefaults() was removed from the file CRM/Event/Form/Search.php
between these changes:
* still there: https://lab.civicrm.org/dev/core/blob/8a6fde27c69f5e6e51fa91060fa67124d9ca9e18/CRM/Event/Form/Search.php
* removed: https://lab.civicrm.org/dev/core/blob/6fbf3a31a162dd5bdaff0db876360bc4e0f09a49/CRM/Event/Form/Search.php
when I add the function setDefaults() again in CRM/Event/Form/Search.php, the problem seems to be solved.
Can anyone confirm this?5.19.4https://lab.civicrm.org/dev/core/-/issues/1412CiviMail sent via wp-cli and cron mangles mailing urls on WP2019-11-26T20:23:49ZkcristianoCiviMail sent via wp-cli and cron mangles mailing urls on WPStarting in 5.19 we have an issue with URLs in CiviMail. If Track links is on the URLs get mangled. Dradt Emails are fine, as well as if you kick off the scheduled job manually (UI or CLI).
However, if cron runs the job the URLS are b...Starting in 5.19 we have an issue with URLs in CiviMail. If Track links is on the URLs get mangled. Dradt Emails are fine, as well as if you kick off the scheduled job manually (UI or CLI).
However, if cron runs the job the URLS are broken:
Mailing Urls expected:
https://example.org//wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
But we get:
https://example.org/home/example/public_html/wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
Tested Enviornments:
CiviCRM 5.19.x
WP: 5.3
wp-cli : 2.3 or 2.4
php 7.1 or 7.2 or 7.3
Cron run via script:
```sh
#!/bin/bash
/usr/local/bin/wp --user=civicron --url=https://example.org --path=/home/example/public_html --timezone="America/New_York" civicrm api job.execute auth=0
```
On Single site we can work around using `cv` or `cli.php` That fails on Multi-Domain
```sh
#/usr/local/bin/php /usr/local/bin/cv api job.execute --user=civicron --cwd=/home/example/public_html
```
Multi-Site Example:
WP MS 5.3
CiviCRM 5.19.1
php 7.1 (also tested 7.2)
wp-cli 2.4 (also tested 2.3)
cli.php results
```
you need to configure site : PHP Fatal error: Uncaught RuntimeException: Undefined constant: CIVICRM_UF_BASEURL in /home/members/example/sites/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress
.php:105
```
cv results
```
you need to configure site : PHP Fatal error: Uncaught RuntimeException: Undefined constant: CIVICRM_UF_BASEURL in /home/members/example/sites/example.org/web/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress
.php:105
```
script:
```sh
#!/bin/bash
#/usr/bin/php /home/members/example/sites/example.org/users/example/bin/cv api job.execute --user=civicron --cwd=/home/members/example/sites/example.org/users/example/web
#/usr/bin/php /home/members/example/sites/example.org/users/example/web/wp-content/plugins/civicrm/civicrm/bin/cli.php -s https://example-la.org -u civicron -p "civicrm" -e Job -a execute
#/usr/bin/php /home/members/example/sites/example.org/users/example/web/wp-content/plugins/civicrm/civicrm/bin/cli.php -s https://www.example.org -u civicron -p "civicrm" -e Job -a execute
/home/members/example/sites/example.org/users/example/bin/wp --user=tadpole --url=https://www.example.org --timezone="America/New_York" civicrm api job.execute auth=0
/home/members/example/sites/example.org/users/example/bin/wp --user=tadpole --url=https://another-example.org --timezone="America/New_York" civicrm api job.execute auth=0
```
We can fix the mangled URLS with a Work Around via .htaccess
```
#email redirect
RewriteEngine On
RewriteCond %{HTTP_HOST} ^example-la\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/example-la\.org\/$1" [R=301,L,QSA]
RewriteEngine On
RewriteCond %{HTTP_HOST} ^www.example\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/www\.example\.org\/$1" [R=301,L,QSA]
RewriteEngine On
RewriteCond %{HTTP_HOST} ^example\.org$ [NC]
RewriteRule ^home\/members\/example\/sites\/example.org\/web\/(.*)$ "https\:\/\/example\.org\/$1" [R=301,L,QSA]
```
Reviewed with @haystack and @andrei Chritian came up with this Patch that I added to our local repo: https://github.com/tadpolecc/civicrm/commit/9470e1fb51ef317ee6d3f211af1bbf99e91431db
PR will be coming as this is a regression5.19.3https://lab.civicrm.org/dev/core/-/issues/1409Record Refund fails due to thousands separator in amount2019-11-20T22:38:55ZkcristianoRecord Refund fails due to thousands separator in amountOverview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the...Overview
----------------------------------------
When recording a refund, such as on a change of registration level on an event, if the refund exceeds 1,000 the intial save will fail. This is due to the thousands separator being in the number
Reproduction steps
----------------------------------------
- Create an event Price set with two fee levels 5,000 and 1,000 $ € currency is not material
- Assign Price set to an event
- Add a Participant at 5,000 level and record payment
- Edit the event and change selections to the 1,000 level
- Go to the Contribution and Record Refund
- Choose Payment Method
- Enter Fee Amount
- Save
Current behaviour
----------------------------------------
The form does not save. A message appaears that the Net Amount should be equal to difference between the payment amount and the fee amount
![image](/uploads/33dc65dcfcbfddbb228f897cb2fbb4ca/image.png)
Expected behaviour
----------------------------------------
This error occurs due to the thousands separator. Remove it and it will save.
Expected behavior would be to either handle the thousands separator properly or not display it.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* Browser: FireFox 70
* CiviCRM: 5.19.1
* PHP: Tested on 7.2 and 7.3 (same behavior)
* CMS:WP 5.3_
* Database: MariaDB 10.1
* Web Server: Apache 2.4
Comments
----------------------------------------
There is a work around here, but this is a regression. Tested in 5.14.2 and it worked fine. I have not tested on 5.18 yet, as I wanted to get the report in.5.19.2https://lab.civicrm.org/dev/core/-/issues/1406Cannot filter by 'Member Since' in Membership Summary Report2019-11-20T21:46:44Zm robimorgan@palantetech.coopCannot filter by 'Member Since' in Membership Summary Report
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this is...
When selecting any date range as a filter in the Membership Summary Report, I get the below error. Have replicated here:
https://dmaster.demo.civicrm.org/civicrm/report/member/summary
This may be a quick fix, but I am creating this issue as I don't have time to dig into it now.
```
Nov 18 12:10:26 [error] $Fatal Error Details = Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -19
[message] => DB Error: no such field
[mode] => 16
[debug_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[type] => DB_Error
[user_info] => SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']
[to_string] => [db_error: message="DB Error: no such field" code=-19 mode=callback callback=CRM_Core_Error::handle prefix="" info="SELECT SQL_CALC_FOUND_ROWS COUNT( DISTINCT membership_civireport.id ) as civicrm_membership_member_count, membership_civireport.membership_type_id as civicrm_membership_membership_type_id, contribution_civireport.currency as civicrm_contribution_currency, IFNULL(SUM(contribution_civireport.total_amount), 0) as civicrm_contribution_total_amount_sum, COUNT(contribution_civireport.total_amount) as civicrm_contribution_total_amount_count, IFNULL(ROUND(AVG(contribution_civireport.total_amount),2), 0) as civicrm_contribution_total_amount_avg
FROM civicrm_membership membership_civireport
LEFT JOIN civicrm_contact contact_civireport ON ( membership_civireport.contact_id = contact_civireport.id )
LEFT JOIN civicrm_membership_status
ON (membership_civireport.status_id = civicrm_membership_status.id )
LEFT JOIN civicrm_membership_payment payment
ON ( membership_civireport.id = payment.membership_id )
LEFT JOIN civicrm_contribution contribution_civireport
ON payment.contribution_id = contribution_civireport.id WHERE membership_civireport.is_test = 0 AND
contact_civireport.is_deleted = 0 AND ( membership_civireport.membership_join_date >= 20191118000000 ) AND ( membership_civireport.membership_join_date <= 20191118235959 ) GROUP BY membership_civireport.membership_type_id WITH ROLLUP LIMIT 0, 50 [nativecode=1054 ** Unknown column 'membership_civireport.membership_join_date' in 'where clause']"]
)
```5.19.2https://lab.civicrm.org/dev/core/-/issues/1391Cancelled contributions are not greyed out in contribution lists2019-11-20T22:39:10ZPatrick Figelpfigel@greenpeace.orgCancelled contributions are not greyed out in contribution listsOverview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Sear...Overview
----------------------------------------
Cancelled contributions are no longer shown as greyed out and don't show a cancellation date in the contribution list.
Reproduction steps
----------------------------------------
1. Search for any cancelled contribution or open the contribution tab of a contact with a cancelled contribution.
Current behaviour
----------------------------------------
The contribution is not greyed out and does not show the cancellation date below the contribution status.
Expected behaviour
----------------------------------------
The contribution should be greyed out and show the cancellation date below the contribution status.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.19/5.18_
Comments
----------------------------------------
This seems to have regressed somewhere between 5.13 (where it works) and 5.18 (where it doesn't). I'm thinking it might have to do with the introduction of `cancel_date` in `civicrm_contribution_recur`.5.19.2https://lab.civicrm.org/dev/core/-/issues/1381Clicking on a contact's cases tab gives Network Error Unable to reach the server2019-11-11T03:27:10ZDaveDClicking on a contact's cases tab gives Network Error Unable to reach the serverI'm pretty sure this was working very recently so tagging regression. Seems related to recent search changes since it uses force=1. Can reproduce on dmaster.demo.
`Error: Call to undefined method CRM_Case_Form_Search::getGroupLabel() in...I'm pretty sure this was working very recently so tagging regression. Seems related to recent search changes since it uses force=1. Can reproduce on dmaster.demo.
`Error: Call to undefined method CRM_Case_Form_Search::getGroupLabel() in CRM_Core_Form_Search->addContactSearchFields() (line 441 of .../CRM/Core/Form/Search.php).`
~regression5.20.0https://lab.civicrm.org/dev/core/-/issues/1377Custom Search: Find Contributors by Aggregate Totals does not can use actions...2019-11-19T23:20:23ZCésarCustom Search: Find Contributors by Aggregate Totals does not can use actions with contactsHello,
I trying on dmaster demo to use the actions when results are displayed but doesn't working. I trying to find the error but only see the param: ```$this->_action = CRM_Core_Action::ADVANCED;``` https://github.com/civicrm/civicrm-c...Hello,
I trying on dmaster demo to use the actions when results are displayed but doesn't working. I trying to find the error but only see the param: ```$this->_action = CRM_Core_Action::ADVANCED;``` https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Form/Search.php#L182 who breaks the actions with this custom report.
In https://dmaster.demo.civicrm.org using custom search: "Find Contributors by Aggregate Totals"
![bug](/uploads/8ea17609ae8a63e729d619cf7bb6851b/bug.png)5.20.0https://lab.civicrm.org/dev/core/-/issues/1376Upgrade failure with 5.19 involving interaction between APIv4 and extensions2019-11-12T22:02:11ZjohnkUpgrade failure with 5.19 involving interaction between APIv4 and extensionsI have a Drupal based CiviCRM installation. Drupal is 8.7.9 and I've just upgraded (on my dev site) to 5.19.0. I found that I got an error:
```
Uncaught PHP Exception InvalidArgumentException: "The directory "/var/www/dev.acreresidency....I have a Drupal based CiviCRM installation. Drupal is 8.7.9 and I've just upgraded (on my dev site) to 5.19.0. I found that I got an error:
```
Uncaught PHP Exception InvalidArgumentException: "The directory "/var/www/dev.acreresidency.org/web/sites/default/files/civicrm/ext/org.civicrm.shoreditch/Civi/Api4/Service/Spec/Provider/" does not exist." at /var/www/dev.acreresidency.org/vendor/symfony/config/Resource/DirectoryResource.php line 36
```
I was able to get the site up and running, but I had to manually create a symlink within each of my CiviCRM extension directories (starting with org.civicrm.shoreditch, as in the log message here), named 'Civi' and pointing to my vendor/civicrm/civicrm-core/Civi directory.
There's something that's not got the right path set, I suppose. This seems like a bug, but it could also be something unusual about my installation environment. I use a composer setup. I'd like to better understand what the issue is, before I upgrade the main site to 5.19.5.19.1https://lab.civicrm.org/dev/core/-/issues/1374Save after edit on contribution search results loses search filter2019-11-20T22:39:30ZJoeMurraySave after edit on contribution search results loses search filterOn dmaster just now, I searched for contributions with amount from 800 to 800, got 18 results. Edited one of them and saved. Listing now shows all contributions (93). Opening Search criteria I see that the 800 to 800 criteria are still t...On dmaster just now, I searched for contributions with amount from 800 to 800, got 18 results. Edited one of them and saved. Listing now shows all contributions (93). Opening Search criteria I see that the 800 to 800 criteria are still there. Clicking search button gets back original search results of 18 records.
Seems like when closing edit form, there is a refresh of search, but the refresh is missing the criteria. IIRC, there was a recent fix where only the edited item showed up after saving the edit form. So possible regression. This is an irritation rather than crucial functionality.5.19.2https://lab.civicrm.org/dev/core/-/issues/1371E Notice 'info' Extension.php:248 -> When installing via cv2019-11-08T01:28:44Zluke.stewartE Notice 'info' Extension.php:248 -> When installing via cvOn a wordpress install running 5.19.beta1 I get the following E Notice when running cv ext:download
`
Notice: Undefined variable: info in /wp-content/plugins/civicrm/civicrm/api/v3/Extension.php on line 248
`
This looks like it ...On a wordpress install running 5.19.beta1 I get the following E Notice when running cv ext:download
`
Notice: Undefined variable: info in /wp-content/plugins/civicrm/civicrm/api/v3/Extension.php on line 248
`
This looks like it was introduced in https://github.com/civicrm/civicrm-core/commit/19ec0aa50bafbe5748fba71a7d94b2e891051717
Which introduces a new parameter to the checkRequirements function, which defaults to NULL.
My reading of this is that the new Check Requirements functionality is only designed to work if executed via the UI. However, it looks like the info parameter is only populated if the 'url' param doesn't exist. If it does exist then the info parameter is not created.
As long as the UI doesn't call this function with a url param then this should be fine, but I'm wondering if it makes sense to populate the $info variable if a url is passed as a parameter to civicrm_api3_extension_download, a quick fix for the E Notice would be to simply initialise this variable to NULL.5.19.1https://lab.civicrm.org/dev/core/-/issues/1361Duplicated inherited membership with multiple relationships when adding a new...2019-11-06T05:51:23Zagileware_pengyiDuplicated inherited membership with multiple relationships when adding a new relationshipInherited membership gets duplicated when adding a new relationship. However, enabling a disabled relationship won't cause the duplication.
Might relate to [this PR](https://github.com/civicrm/civicrm-core/pull/14410) and the referenced...Inherited membership gets duplicated when adding a new relationship. However, enabling a disabled relationship won't cause the duplication.
Might relate to [this PR](https://github.com/civicrm/civicrm-core/pull/14410) and the referenced PRs
### Step to reproduce
1. Membership Type A has option to inherit membership for Relationship A and Relationship B
1. Organisation A has Membership Type A, with status Current
1. Individual A, Relationship A to Organisation A is created
1. Individual A, Relationship B to Organisation A is created
1. Individual A has two memberships, one is duplicated
1. Individual A, Relationship A to Organisation A is disabled
1. Individual A, Relationship B to Organisation A is disabled
1. Individual A has no membership
1. Individual A, Relationship A to Organisation A is enabled
1. Individual A, Relationship B to Organisation A is enabled
1. Individual A has one membership
Agileware ref: CIVICRM-10635.20.0https://lab.civicrm.org/dev/core/-/issues/1360Programatic Installation of Extension after Upgrading CiviCRM causes Error2019-11-05T00:14:53ZCamilo RodríguezProgramatic Installation of Extension after Upgrading CiviCRM causes Error## Overview
We have a drupal profile we use to install drupal sites with CiviCRM and some common extensions. When running the profile, CiviCRM is upgraded to v5.19. After that, the extensions are installed, however, the first extension i...## Overview
We have a drupal profile we use to install drupal sites with CiviCRM and some common extensions. When running the profile, CiviCRM is upgraded to v5.19. After that, the extensions are installed, however, the first extension installation causes a database exception to be thrown. It doesn't matter what extension is installed, every time, the installation of the first extension will fail.
## How it Works Currently
These steps have to be done programatically and in a single process to cause the failure:
1. Upgrade CiviCRM to v5.19
1. Install any extension to CiviCRM
1. Exception is thrown.
## How it should work
1. Upgrade CiviCRM to v5.19
1. Install any extension to CiviCRM
1. CiviCRM is upgraded and all extensions are installed successfully.
## Technical Analysis
1. Upgrade `upgrade_5_19_alpha1()` creates a new `field on civicrm_status_pref` table. https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/php/FiveNineteen.php#L69-L74
1. At the end of the installation of the first extension, schema is synched by comparing the columns of every table in CiviCRM with its correspondig logging table, however, the columnStats cache in \Civi:$statics has already been be initialized, with `civicrm_status_pref` table missing the new `is_active` column.
1. Schema is synched using cached values for columnStats. System erroneously detects `log_civicrm_status_pref` is missing the `is_active` column and tries to create it again, causing the exception to be thrown.https://lab.civicrm.org/dev/core/-/issues/1348Find Activities not working in 5.19beta1 and master2019-10-30T01:36:30ZDaveDFind Activities not working in 5.19beta1 and masterIt's working in 5.18.4. In 5.19+ it just always returns all activities.
It's because of a change in CRM_Core_Form_Search::setFormValues(). This now calls $this->getFormValues(), but for activity search all that does is return NULL, so n...It's working in 5.18.4. In 5.19+ it just always returns all activities.
It's because of a change in CRM_Core_Form_Search::setFormValues(). This now calls $this->getFormValues(), but for activity search all that does is return NULL, so no form values get set.5.19.0DaveDDaveDhttps://lab.civicrm.org/dev/core/-/issues/1333Balance Due of completed contribution does not show as 0 but full amount in p...2019-10-22T00:07:05Zmagnolia61Balance Due of completed contribution does not show as 0 but full amount in payment receiptUsing 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the...Using 5.18.3 with patch https://github.com/civicrm/civicrm-core/pull/15545 (to be able to send the payment receipt at all)
I noticed that in different scenarios's (A. Pay the contribution in one payment & B. Pay it in a few payments)
the payment notification email shows the wrong amount for the Balance Due.
Interestingly it show the proper Balance Due when doing partial payments
```
Total Amount : 100
This Payment Amount : 60
Balance Due: 40
```
But at the final payment to full fill the contribution it shows the same as the full amount
```
Total Amount : 100
This Payment Amount : 100
Balance Due: 100
```5.18.4https://lab.civicrm.org/dev/core/-/issues/1332Payment details not saved correctly from Additional payment form2019-10-22T00:06:56ZeileenPayment details not saved correctly from Additional payment formDetail is https://github.com/civicrm/civicrm-core/pull/15537Detail is https://github.com/civicrm/civicrm-core/pull/155375.18.4https://lab.civicrm.org/dev/core/-/issues/1322payment_or_refund_notification 'FROM' address is missing2019-10-21T05:19:37Zmagnolia61payment_or_refund_notification 'FROM' address is missingThe Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
N...The Payment_or_refund mail (send when recording a payment) does not get send with us.
We get the message that the "FROM" address is missing. All other mails get send perfectly.
```
The mail library returned the following error message:
No From: address has been provided
```
When I change our outbound mail settings to database, I can see indeed the from address is missing from the headers.
The following header is from the add payment mail. This fails to send, lacks the 'From' field and is also missing the return path.
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_a5d5e8e8a2563fab89e0f4ae653c0aee"
To: Testuser
Subject: Payment Receipt -
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Date: Wed, 16 Oct 2019 12:52:43 +0200
```
The following mail is the contribution receipt. This gets send and has the From field in the header
```
MIME-Version: 1.0
Content-Type: multipart/alternative;
boundary="=_76561187d0121e320a4a0d0fdb8432cb"
From: "Testuser"
To: Testleid Groepsleiding
Subject: Contribution Receipt - Testleid Groepsleiding
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Return-Path: testuser@gmail.com
Date: Wed, 16 Oct 2019 12:52:16 +0200
```5.18.4https://lab.civicrm.org/dev/core/-/issues/1305Fatal error when sorting on a custom field in a profile listing2019-10-09T09:07:07ZDaveDFatal error when sorting on a custom field in a profile listingFollow on from https://lab.civicrm.org/dev/core/issues/1269#note_24297 and https://lab.civicrm.org/dev/core/issues/1269#note_24382 I'm able to reproduce the following on dmaster.demo and also a recent PR test site, but my local master se...Follow on from https://lab.civicrm.org/dev/core/issues/1269#note_24297 and https://lab.civicrm.org/dev/core/issues/1269#note_24382 I'm able to reproduce the following on dmaster.demo and also a recent PR test site, but my local master seems ok, but since it's been reported on [stackexchange](https://civicrm.stackexchange.com/questions/33226/cant-sort-search-result-table-by-column-when-the-column-shows-a-custom-field) and seems a problem on two official builds I'm ignoring my local install.
To reproduce:
1. Create a profile used for listings.
2. Include a custom field, e.g. the stock "Marital Status" one.
3. Use the profile in listings mode.
4. Try to sort by the custom field.
`Error: Class name must be a valid object or a string in CRM_Contact_BAO_Query->prepareOrderBy() (line 6422 of .../CRM/Contact/BAO/Query.php).`
It seems like the same thing as #1269, where fieldspec bao isn't defined for custom fields. I'll put up a PR that does the same thing as that ticket, just that because there seems to be something weird (or not weird) on my install I'm just guessing if it works.5.18.2https://lab.civicrm.org/dev/core/-/issues/1302Fatal error in export when using "Merge All Contacts with the Same Address" a...2019-10-08T17:27:07ZDaveDFatal error in export when using "Merge All Contacts with the Same Address" and Selected Fields instead of Primary FieldsSee https://civicrm.stackexchange.com/questions/33272/fatal-error-on-export-in-5-18-1/33273#33273
1. Do a contact search.
2. Select some results.
3. Choose Export from the Actions dropdown.
4. Choose Selected Fields.
5. Choose the optio...See https://civicrm.stackexchange.com/questions/33272/fatal-error-on-export-in-5-18-1/33273#33273
1. Do a contact search.
2. Select some results.
3. Choose Export from the Actions dropdown.
4. Choose Selected Fields.
5. Choose the option "Merge All Contacts with the Same Address".
6. Pick your selected fields.
7. Export.
Db error, because there's an extra comma being added at the end of the field list or possibly a field name is supposed to be there but comes out blank. Then it's followed by a php notice when you go to another page.
```
Database Error Code: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near ' PRIMARY KEY ( id ), INDEX index_street_address( street_address ) , INDEX i' at line 15, 1064
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -2
[message] => DB Error: syntax error
[mode] => 16
[debug_info] => CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]
[type] => DB_Error
[user_info] => CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]
[to_string] => [db_error: message="DB Error: syntax error" code=-2 mode=callback callback=CRM_Core_Error::handle prefix="" info="CREATE TABLE `civicrm_tmp_d_export_4fa32a2a24bde72ebb683e1e36771419` ( id int unsigned NOT NULL AUTO_INCREMENT, display_name varchar(128),
addressee varchar(255),
postal_greeting varchar(255),
email_greeting varchar(255),
street_name varchar(64),
household_name varchar(128),
street_address varchar(96),
city varchar(64),
state_province varchar(64),
civicrm_primary_id varchar(16),
master_id varchar(128),
state_province_id varchar(255),
postal_greeting_id varchar(16),
addressee_id varchar(16),
,
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX index_household_name( household_name )
,
INDEX index_civicrm_primary_id( civicrm_primary_id )
) ENGINE=InnoDB DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '
PRIMARY KEY ( id ),
INDEX index_street_address( street_address )
,
INDEX i' at line 15]"]
)
```
`Notice: Undefined index: sql_columns in CRM_Export_BAO_ExportProcessor->getSQLColumns() (line 927 of .../web/sites/all/modules/civicrm/CRM/Export/BAO/ExportProcessor.php`
@eileen @seamuslee5.18.2