CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-11-14T01:27:44Zhttps://lab.civicrm.org/dev/core/-/issues/3952Event badges, json may be broken (was CiviEvent - Date tokens may be misforma...2023-11-14T01:27:44ZtottenEvent badges, json may be broken (was CiviEvent - Date tokens may be misformatted)(*This is an offshoot from #3829. PR [24695](https://github.com/civicrm/civicrm-core/pull/24695) bundled in a partial fix for this date-token issue, but it looks to me like this is distinct from the barcode problem - and this still has s...(*This is an offshoot from #3829. PR [24695](https://github.com/civicrm/civicrm-core/pull/24695) bundled in a partial fix for this date-token issue, but it looks to me like this is distinct from the barcode problem - and this still has some TODOs.*)
v5.43 included an update for certain tokens. It recommended adding an explicit date filter:
* `{event.start_date}` => `{event.start_date|crmDate:"%B %E%f}`
* `{event.end_date}` => `{event.end_date|crmDate:"%B %E%f}`
Notably, the default content in `civicrm_print_label`.`data` has references to these tokens. It was updated by way of [873bfeb503caa413f17460](https://github.com/civicrm/civicrm-core/commit/873bfeb503caa413f17460dbe450b74fac3d6dbf#diff-b604dfcba0703a9cd5e9f1431451f657c2a580b1dfd8eb56e2c4e4a960c4b43c) (see `FiveFortyThree.php` and `civicrm_navigation.tpl`). However, the `data` field have special encoding requirements (JSON?), so it's not a simple string-substitution.
With [24695](https://github.com/civicrm/civicrm-core/pull/24695), it sounds like the escaping is fixed for new installs (5.54.1+). However, we probably need a cleanup/upgrade step for sites which either (a) installed 5.43-5.54 or (b) installed <5.43 and ran the upgrade.5.69.0https://lab.civicrm.org/dev/core/-/issues/3951AdminUI: Edit and Delete buttons don't work for Financial Types2022-10-28T02:27:08ZlarsssandergreenAdminUI: Edit and Delete buttons don't work for Financial TypesIn the new AdminUI screen for managing Financial Types, the Edit and Delete buttons don't work - they just bring up the same screen in a pop-up.
This was just [merged recently.](https://github.com/civicrm/civicrm-core/pull/24715)
Teste...In the new AdminUI screen for managing Financial Types, the Edit and Delete buttons don't work - they just bring up the same screen in a pop-up.
This was just [merged recently.](https://github.com/civicrm/civicrm-core/pull/24715)
Tested on dmaster (5.56).https://lab.civicrm.org/dev/core/-/issues/3950SearchKit: Campaign search doesn't work correctly2022-11-16T20:07:08ZlarsssandergreenSearchKit: Campaign search doesn't work correctlyIf you search for a contribution or a participant by campaign in SK, there are two options: Campaign Campaign Title and Campaign ID. If you search by Campaign Campaign Title, you can enter the campaign title by typing it in manually, but...If you search for a contribution or a participant by campaign in SK, there are two options: Campaign Campaign Title and Campaign ID. If you search by Campaign Campaign Title, you can enter the campaign title by typing it in manually, but there is no autocomplete. If you search by Campaign ID, then there is autocomplete, but the search does not actually work (shows no results because it is doing campaign_id:name when it should be doing campaign_id).
I think there should be just one Campaign search option, with autocomplete that also shows you the most recent active campaigns in the select for quickly picking a recent campaign.
Tested on dmaster (5.56).https://lab.civicrm.org/dev/core/-/issues/3949SearchKit: no JOIN available for ContactReference custom fields2023-05-11T04:35:35ZherbdoolSearchKit: no JOIN available for ContactReference custom fieldsI have a ContactReference custom field and an EntityRef field defined in XML schema on an entity. [Update: both are storing a single contact id] In SK I'd like to add a join to the Contact entity via the custom field. There is one availa...I have a ContactReference custom field and an EntityRef field defined in XML schema on an entity. [Update: both are storing a single contact id] In SK I'd like to add a join to the Contact entity via the custom field. There is one available for the EntityRef field, but not ContactReference custom field. I can make the join in API4 just fine.
This looks like a missing piece of functionality. Or I'm just not looking in the right place.https://lab.civicrm.org/dev/core/-/issues/3944SearchKit: Show count on both top and bottom of display2022-10-27T20:47:07ZlarsssandergreenSearchKit: Show count on both top and bottom of displayCurrently, the count of results in a SearchKit display is only shown on the bottom of the page. In core, totals are usually shown at the top and bottom of the page in search results. I think it would be more usable to also show the total...Currently, the count of results in a SearchKit display is only shown on the bottom of the page. In core, totals are usually shown at the top and bottom of the page in search results. I think it would be more usable to also show the total count in SearchKit displays at the top of the page, beside the Actions drop down menu. It's a good sanity check for users to be able to see how many entities they are doing an action on before doing so - they shouldn't have to scroll to the bottom of the page and then back up to see the count. It's also not always easy to see how many are selected or if you've selected just one page of results or the whole list.
Something simple like this, which would also show NNN selected of NNN results when some are selected.
![image](/uploads/0587e86d7faed05a9ecf441a64f93378/image.png)
This could be disabled by disabling show count for the display.https://lab.civicrm.org/dev/core/-/issues/3942Fatal Error in PHP 8.0 when passing an empty array to a custom checkboxes/sel...2023-01-29T06:17:46ZherbdoolFatal Error in PHP 8.0 when passing an empty array to a custom checkboxes/select field.When passing an empty array to a custom Checkboxes (or Select) field, under PHP 8.0 it gives a fatal error: `TypeError: mysqli_real_escape_string(): Argument #2 ($string) must be of type string, array given in mysqli_real_escape_string()...When passing an empty array to a custom Checkboxes (or Select) field, under PHP 8.0 it gives a fatal error: `TypeError: mysqli_real_escape_string(): Argument #2 ($string) must be of type string, array given in mysqli_real_escape_string() (line 880 of /app/vendor/pear/db/DB/mysqli.php).` There is no error in PHP 7.4.
Using CiviCRM 5.54.0.
For example:
```
$results = Address::update()
->addValue(Address_status.Fruit, [])
->addWhere('id', '=', 1)
->execture();
```
Where Address_status is the custom field group and Fruit is the checkboxes or select field with options.
I am assuming that either the error should be caught earlier by API4 or DAO and warn that empty arrays cannot be passed to this field type, or that it doesn't complain at all and converts the empty array to a serialized string, much like it does with populated arrays.https://lab.civicrm.org/dev/core/-/issues/3941CiviCRM fatal error on enabling `civiimport`2022-11-11T02:30:30ZeileenCiviCRM fatal error on enabling `civiimport`On master I firstly did an import and then enabled `civiimport` through the UI (on an otherwise freshly built site). On refresh it loads...
Note we should fix in 5.54 to ensure sites that enable the extension do not hit issues
![image]...On master I firstly did an import and then enabled `civiimport` through the UI (on an otherwise freshly built site). On refresh it loads...
Note we should fix in 5.54 to ensure sites that enable the extension do not hit issues
![image](/uploads/ca13d998ee3830566d7282ba55f79baa/image.png)
Note the backtrace
{{image.png}}5.55.0https://lab.civicrm.org/dev/core/-/issues/3939Import contributions: Contact matching by email no longer available2022-11-02T21:02:44ZDetlev SieberImport contributions: Contact matching by email no longer availableOverview
----------------------------------------
When importing contributions, step 2 of 3 defines matching fields.
Hereby, we also have to define how to match the contact, for which the contributions should be attached.
Matching of c...Overview
----------------------------------------
When importing contributions, step 2 of 3 defines matching fields.
Hereby, we also have to define how to match the contact, for which the contributions should be attached.
Matching of contacts is possible by contact ID, external identifier or by email.
However, starting with CiviCRM 5.54.0, email is no longer available for contact matching!
Also, if we select email and check "update this field mapping", the field "email" won't be saved anymore.
Reproduction steps
----------------------------------------
1. Click on **Contributions -> Import contributions**.
1. Select a file with emails and the other mandatory fields for contribution import
1. Within "Match Fields (step 2 of 3)": select email as contact match ```-> error "Missing required contact matching fields. email(weight 10) (Sum of all weights should be greater than or equal to threshold: 10)"```.
Current behaviour
----------------------------------------
Importing contributions seems to be based on the unsupervised de-dupe rule.
However, matching on email is not accepted anymore.
This issue started with 5.54.0. The previous version, 5.53.0 was still working as expected.
Expected behaviour
----------------------------------------
As in previous versions, it should be possible to identify contacts by using the email as contact matcher
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 105.0.3
* __CiviCRM:__ _5.54.0 (was working well with 5.52.x)
* __PHP:__ _7.4
* __CMS:__ _Drupal 7.52
* __Database:__ _MariaDB 10.5.15_
Comments
----------------------------------------
There is a workaround to import contributions using email as contact identifier:
* Add an empty column to the csv file, that shall be imported
* Use "External Identifier (match to contact)" as field match for that column
* Select email as field match
* make sure to have a unsupervised de-dupe rule that only uses email
-> this will import contributions based on the mail.
However, this workaround doesn't solve that part of the issue, that email is not saved in the field mapping.5.55.0https://lab.civicrm.org/dev/core/-/issues/3938SearchKit - arithmetic not working2022-10-30T16:27:08ZvitiusSearchKit - arithmetic not workingWhen you have custom field that is number or integer, arithmetic will not work.
How to reproduce this issue:
1) Create custom set on contact
2) Create custom field type integer name "testinteger"
3) Create search kit on Contact
4) Add "t...When you have custom field that is number or integer, arithmetic will not work.
How to reproduce this issue:
1) Create custom set on contact
2) Create custom field type integer name "testinteger"
3) Create search kit on Contact
4) Add "testinteger" field
5) In field transformation change "testinteger" to arithmetic like on picture bellow
6) Now when you click on search, you will not get any result
![image](/uploads/2861db81768ab80206b30ed1b20db46d/image.png)https://lab.civicrm.org/dev/core/-/issues/3937Importing "No" values to Boolean field results in empty2023-04-03T02:21:49ZelilisseckImporting "No" values to Boolean field results in emptyOverview
----------------------------------------
Contact imports to custom "Yes or No" fields work with values 1 or 0. "Yes" also appears to work.
If you import a "No" value, however, the field will be blank for that contact instead o...Overview
----------------------------------------
Contact imports to custom "Yes or No" fields work with values 1 or 0. "Yes" also appears to work.
If you import a "No" value, however, the field will be blank for that contact instead of having the "No"/0 label/value.
Technical details
----------------------------------------
["strtoboolstr"](https://github.com/civicrm/civicrm-core/blob/4ce53ba3de860a5d9aac1b1bbd22b7a29e839af2/CRM/Utils/String.php#L424) gets run twice on this data. [Once on the raw value returning a boolean](https://github.com/civicrm/civicrm-core/blob/902fc38d0d6cd9d09ee02f30cc6621747151a06a/CRM/Import/Parser.php#L1602) and [once later in the code here](https://github.com/civicrm/civicrm-core/blob/902fc38d0d6cd9d09ee02f30cc6621747151a06a/CRM/Contact/Import/Parser/Contact.php#L328)
When you run this on a boolean value (you shouldn't, according to the comments, but perhaps we should check for this), "Yes"/true will _look_ like it's working okay because the preg_match will match for (bool)true but it won't match for (bool)false. I'm sure this has something to do with a PHP oddity I know nothing about but related to the fact that `strlen((bool)true)` is `1` and `strlen((bool)false)` is `0`.
Proposed solution is:
1) Don't run strtoboolstr twice. We don't need that second iteration of it because it's already been run on the data. I'm not sure of any other impacts for this so also:
2) Write a test for importing to a Yes/No field with the 6 values that should work (1,0,yes,no,true,false). I've started writing this test following examples but i'm having trouble getting my import data actually in properly to run the assertEquals on. I will open a WIP PR with this test.
Any other thoughts welcome!
Reproduction steps
----------------------------------------
1. Create a custom field with data type "Yes or No"
2. Create a csv to import first,last,custom_fieldID with data for your custom field "Yes" and "No"
3. Run the import normally through the GUI in the Contacts > Import Contacts workflow
4. Observe custom field results on the imported contacts
Expected behaviour
----------------------------------------
According to code comments, this type of field import should accept "1", "0", "Yes", "No", "true", "false" and they should all fill a "Yes or No" field correctly.
Environment information
----------------------------------------
This was reproduced on the master branch in d9 (5.56.alpha1)5.61.0https://lab.civicrm.org/dev/core/-/issues/3936Import contributions (update existing) extremely slow2022-12-24T14:42:08ZDetlev SieberImport contributions (update existing) extremely slowOverview
----------------------------------------
On a large database, importing updates of existing contributions is extremely slow (about 10 times slower than inserting new contributions).
This is new with 5.53 or 5.54.
Reproduction ...Overview
----------------------------------------
On a large database, importing updates of existing contributions is extremely slow (about 10 times slower than inserting new contributions).
This is new with 5.53 or 5.54.
Reproduction steps
----------------------------------------
Reproducing requires large database with many contributions. Therefore not yet reproducible on sandbox.
Current behaviour
----------------------------------------
Inserting new contributions works on this specific production environment at a rate of 140 contributions per minute.
Updating existing contributions is at an average of only 13 contributions per minute.
Expected behaviour
----------------------------------------
Previously, updating existing contributions was slightly faster than inserting new contributions.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is neccessary. -->
* __Browser:__ _Firefox 105.0.3
* __CiviCRM:__ _5.54.0 (was working well with 5.52.x)
* __PHP:__ _7.4
* __CMS:__ _Drupal 7.52
* __Database:__ _MariaDB 10.5.15_
Comments
----------------------------------------
_none_https://lab.civicrm.org/dev/core/-/issues/3935PHP Notice: Undefined offset in _civicrm_member_roles_sync()2022-12-01T02:47:03ZAndrew WassonPHP Notice: Undefined offset in _civicrm_member_roles_sync()Overview
----------------------------------------
This is an issue that I have noticed in several Drupal 7 / CiviCRM websites. When the CiviCRM Member Roles Synch activity takes place, my recent log messages get inundated with PHP Notice...Overview
----------------------------------------
This is an issue that I have noticed in several Drupal 7 / CiviCRM websites. When the CiviCRM Member Roles Synch activity takes place, my recent log messages get inundated with PHP Notices:
> Notice: Undefined offset: x in _civicrm_member_roles_sync() (line 607 of /civicrm/drupal/modules/civicrm_member_roles/civicrm_member_roles.module).
Reproduction steps
----------------------------------------
1. Enable civicrm member roles sync.
1. Add a rule to synch some member type to a role.
1. Configure to run at Drupal Cron
1. Run Cron and observe as Reports -> Recent Log Messages get filled with notices.
Steps to Resolve
----------------------------------------
line 607 of /civicrm/drupal/modules/civicrm_member_roles/civicrm_member_roles.module contains the following statement:
`if (is_array($memberroles[$membership['membership_type_id']])) {`
If the array is not set then the notice will be raised so if we check it first as follows, the notice goes away:
`if (isset($memberroles[$membership['membership_type_id']]) && is_array($memberroles[$membership['membership_type_id']])) {`
Environment information
----------------------------------------
* __CiviCRM:__ _5.54.0_
* __PHP:__ _7.4/8.1__
* __CMS:__ _Drupal 7.92_
* __Database:__ _MySQL 5.7.4_
* __Web Server:__ _Apache 2.x_5.57.0https://lab.civicrm.org/dev/core/-/issues/3933Subscription history is not set when GroupContact is deleted via API42022-11-07T01:41:44ZlarsssandergreenSubscription history is not set when GroupContact is deleted via API4If a contact is deleted from a group via API4 (by deleting the GroupContact), no subscription history is recorded. I think it should be, as it is recorded if done via the UI or API3.
Tested on dmaster.
Edit: Removed some discussion abo...If a contact is deleted from a group via API4 (by deleting the GroupContact), no subscription history is recorded. I think it should be, as it is recorded if done via the UI or API3.
Tested on dmaster.
Edit: Removed some discussion about API3 that turned out to be a red herring.https://lab.civicrm.org/dev/core/-/issues/3932Event participant import fails, Cannot call constructor2022-10-24T23:56:29ZguitarmanEvent participant import fails, Cannot call constructorOverview
----------------------------------------
The import of event participants fails on Joomla with the following error: 0 Cannot call constructor
Reproduction steps
----------------------------------------
1. Click on Events / impo...Overview
----------------------------------------
The import of event participants fails on Joomla with the following error: 0 Cannot call constructor
Reproduction steps
----------------------------------------
1. Click on Events / import participants
2. Choose .csv-file and click on "submit" to import the file.
3. The error shows up immediately, CiviCRM is unable to import the file.
Current behaviour
----------------------------------------
The import of the file fails with error: 0 Cannot call constructor.
Joomla Call Stack (Debug)
| # | Function | Location |
|----|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------|
| 1 | () | JROOT/administrator/components/com_civicrm/civicrm/CRM/Event/Import/Parser/Participant.php:68 |
| 2 | CRM_Event_Import_Parser_Participant->__construct() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/DataSource.php:558 |
| 3 | CRM_Import_DataSource->getParser() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/DataSource.php:535 |
| 4 | CRM_Import_DataSource->getAdditionalTrackingFields() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/DataSource.php:518 |
| 5 | CRM_Import_DataSource->addTrackingFieldsToTable() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/DataSource/CSV.php:82 |
| 6 | CRM_Import_DataSource_CSV->initialize() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/Form/DataSource.php:199 |
| 7 | CRM_Import_Form_DataSource->instantiateDataSource() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/Form/DataSource.php:187 |
| 8 | CRM_Import_Form_DataSource->processDatasource() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Import/Form/DataSource.php:159 |
| 9 | CRM_Import_Form_DataSource->postProcess() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Form.php:573 |
| 10 | CRM_Core_Form->mainProcess() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/QuickForm/Action/Upload.php:152 |
| 11 | CRM_Core_QuickForm_Action_Upload->realPerform() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/QuickForm/Action/Upload.php:119 |
| 12 | CRM_Core_QuickForm_Action_Upload->perform() | JROOT/administrator/components/com_civicrm/civicrm/packages/HTML/QuickForm/Controller.php:203 |
| 13 | HTML_QuickForm_Controller->handle() | JROOT/administrator/components/com_civicrm/civicrm/packages/HTML/QuickForm/Page.php:103 |
| 14 | HTML_QuickForm_Page->handle() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Controller.php:355 |
| 15 | CRM_Core_Controller->run() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Invoke.php:319 |
| 16 | CRM_Core_Invoke::runItem() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Invoke.php:69 |
| 17 | CRM_Core_Invoke::_invoke() | JROOT/administrator/components/com_civicrm/civicrm/CRM/Core/Invoke.php:36 |
| 18 | CRM_Core_Invoke::invoke() | JROOT/administrator/components/com_civicrm/civicrm.php:121 |
| 19 | civicrm_invoke() | JROOT/administrator/components/com_civicrm/civicrm.php:40 |
| 20 | require_once() | JROOT/libraries/src/Component/ComponentHelper.php:402 |
| 21 | Joomla\CMS\Component\ComponentHelper::executeComponent() | JROOT/libraries/src/Component/ComponentHelper.php:377 |
| 22 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT/libraries/src/Application/AdministratorApplication.php:101 |
| 23 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT/libraries/src/Application/AdministratorApplication.php:159 |
| 24 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT/libraries/src/Application/CMSApplication.php:225 |
| 25 | Joomla\CMS\Application\CMSApplication->execute() | JROOT/administrator/index.php:51 | |
Expected behaviour
----------------------------------------
Civi should import the file and advance to step 2 / field mapping.
Environment information
----------------------------------------
* __CiviCRM:__ 5.54.0
* __PHP:__ 7.4
* __CMS:__ _Joomla 3.10.11_
* __Database:__ _MySQLi 5.5.5-10.3.35-MariaDB_
* __Web Server:__ _Apache_5.54.1https://lab.civicrm.org/dev/core/-/issues/3931Blank Invoice.pdf appearing when doing Offline contributions2023-05-18T23:35:49ZshaneonabikeBlank Invoice.pdf appearing when doing Offline contributionsHi there,
Recently, my client noticed that Offline contributions made via ```Submit a Credit Card Membership``` were sending out blank Invoice pdfs. I don't think that this was happening previously.
## How to reproduce
1. Go to new me...Hi there,
Recently, my client noticed that Offline contributions made via ```Submit a Credit Card Membership``` were sending out blank Invoice pdfs. I don't think that this was happening previously.
## How to reproduce
1. Go to new member contact record and select "Membership" tab
1. Choose "Submit credit card membership"
1. Enter membership details and select "Save"
1. Receipt is automatically sent to member
## CiviCRM details
+ CiviCRM 5.49.4
+ Drupal 7
## Log Error message
```
2022/10/21 09:48:39 [error] 25282#25282: *7533568 FastCGI sent in stderr: "emplate.php).PHP message: [notice] [php] [209.169.169.221] [uid:1] [https://test.org/civicrm/contact/view/membership] [https://test.org/civicrm/contact/view/membership?reset=1&action=add&cid=107793&context=membership&mode=test] Notice: Undefined variable: html in CRM_Contribute_Form_Task_Invoice::printPDF() (line 516 of /sites/all/modules/civicrm/CRM/Contribute/Form/Task/Invoice.php).
PHP message: [notice] [php] [209.169.169.221] [uid:1] [https://test.org/civicrm/contact/view/membership] [https://test.org/civicrm/contact/view/membership?reset=1&action=add&cid=107793&context=membership&mode=test] Notice: Only variable references should be returned by reference in CRM_Mailing_Event_BAO_Delivered::create() (line 34 of /sites/all/modules/civicrm/CRM/Mailing/Event/BAO/Delivered.php)" while reading response header from upstream, client: 209.169.169.221, server: test.org, request: "POST /civicrm/contact/view/membership HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php7.3-fpm.sock:", host: "test.org", referrer: "https://test.org/civicrm/contact/view/membership?reset=1&action=add&cid=107793&context=membership&mode=test"
```https://lab.civicrm.org/dev/core/-/issues/3929SearchKit feature request - filter by data segment2022-11-01T21:47:09ZJonGoldSearchKit feature request - filter by data segmentMy client has a request to be able to filter by data segments in a SK embedded in Form Builder.
My initial thought was that this would have to be done in PHP/JS and not SQL, which would have awful performance - but on further thought, I...My client has a request to be able to filter by data segments in a SK embedded in Form Builder.
My initial thought was that this would have to be done in PHP/JS and not SQL, which would have awful performance - but on further thought, I realized that data segments could be used as WHERE clauses.
If someone wants to message me on Mattermost with an estimate, I could bring it to my client.https://lab.civicrm.org/dev/core/-/issues/3927Import failure when related contact is a different contact type2022-10-24T21:47:07ZJonGoldImport failure when related contact is a different contact typeIn some import mappings, you can't import an Organization as a related contact to an Individual.
### Steps to Replicate
* Create a CSV with columns "First Name", "Last Name", and "Employer", with a corresponding row of data.
* On import...In some import mappings, you can't import an Organization as a related contact to an Individual.
### Steps to Replicate
* Create a CSV with columns "First Name", "Last Name", and "Employer", with a corresponding row of data.
* On import, map to First Name, Last Name, and "Employee of: Organization Name".
* Import.
### Expected Result
2 contacts created.
### Actual Result
Import fails, error shows "Mismatched contact type."
This is happening because `CRM_Contact_Import_Parser_Contact::lookupContactID()` calls `$this->getPossibleContactMatch` and passes the dedupe rule ID selected in the import UI. However, that rule is an Individual dedupe rule, and the related contact is an organization.
Brienne is working on a fix, we'll shout if we run into trouble.5.54.1JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/3926Need to increase data size for 'url' column on 'civicrm_website' table2022-10-28T15:46:49ZyashodhaNeed to increase data size for 'url' column on 'civicrm_website' tableOverview
----------------------------------------
Currently _url_ column of the _civicrm_website_ table is of maxlength 124. This is not sufficient for some website in which case it truncates and renders them useless.
Proposed behavio...Overview
----------------------------------------
Currently _url_ column of the _civicrm_website_ table is of maxlength 124. This is not sufficient for some website in which case it truncates and renders them useless.
Proposed behaviour
----------------------------------------
The Proposal is to change the maxlength of the _url_ column of the _civicrm_website_ table to 255 instead of 124.5.56.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/3923Search Kit does not populate Tag Name(s) when the condition is set to "Is One...2023-02-11T18:39:59ZbrienneSearch Kit does not populate Tag Name(s) when the condition is set to "Is One Of"Overview
----------------------------------------
When creating a search in Search Kit, the list of tag names to select does not populate when the Contact Tag entity is chosen and a condition of Tag Name "Is One Of"
Reproduction steps
-...Overview
----------------------------------------
When creating a search in Search Kit, the list of tag names to select does not populate when the Contact Tag entity is chosen and a condition of Tag Name "Is One Of"
Reproduction steps
----------------------------------------
1. Make sure that you have a Contact Tag with which to test (which can be set up via **Contacts >> Manage Tags >> Add Tag).
1. Go to **Search Kit** and click **New Search**
2. Make sure that the primary entity is *Contact*, then click **+Entity** and select **Contact Tags**
3. Under the *Contact Tags* entity, click **Add Condition** and select **Tag Name** and **Is One Of**
4. When you click in the select box to select the tag names, however, there are no drop down options nor auto-complete selects as you start typing.
Current behaviour
----------------------------------------
When you add a Contact Tag entity in Search Kit, and include a condition that uses "Is One Of" to limit the tag names, a list of those available tag names does not appear. While the features does still work if you type the full and exact name of the tag into the list, that shouldn't be necessary.
![Selection_076](/uploads/96c85e6ba9db93533b726f7bfa414c20/Selection_076.png)
*Note that in this photo, I am searching for a tag named "contact tag 1" that does not appear when typed into the text box, nor do any other options show before typing*
Expected behaviour
----------------------------------------
A drop down list of available tag names should appear when `Tag Name Is One Of` is set as the condition, and as you type in the text box the drop down list should filter accordingly.
Environment information
----------------------------------------
* __CiviCRM:__ _Master/5.55alpha1https://lab.civicrm.org/dev/core/-/issues/3922Calculation of relative date fiscal year previous_N is wrong2022-10-20T00:27:07ZDaveDCalculation of relative date fiscal year previous_N is wrongMeaning:
* previous => OK
* previous_1 => Not OK
* previous_2 => Not OK
* etc... Not OK
The problem is here: https://github.com/civicrm/civicrm-core/blob/5c890572f11b797acd19d2082697670440d8b1e0/CRM/Utils/Date.php#L1323 because that's a...Meaning:
* previous => OK
* previous_1 => Not OK
* previous_2 => Not OK
* etc... Not OK
The problem is here: https://github.com/civicrm/civicrm-core/blob/5c890572f11b797acd19d2082697670440d8b1e0/CRM/Utils/Date.php#L1323 because that's always going to mean "ending in the current fiscal year", which isn't correct for "previous_N".
`$to['Y'] = $fYear;`
Came up during review of https://github.com/civicrm/civicrm-core/pull/24752. It hasn't been noticed to-date because while the code is present, you'd have to manually add a previous_N.fiscal_year to the option values to make it appear in the UI. Only previous.fiscal_year is shipped with a stock install, and that works because it enters the `if` block above the above mentioned code, not the `else` block.
Here's a table, looking at __years only__, which has some extra stuff just for comparison because the wordings of these relative dates is not always clear in english. The main thing to look at is previous should be equivalent to previous_1, and you can see this is not the case.
| Type | Calendar | Fiscal |
|------------|----------------|--------------------|
| previous | 2020 | 2021 |
| previous_1 | NOT DEFINED | 2021 & 2022 :x: |
| previous_2 | 2020 & 2021 | 2020 & 2021 & 2022 :x: |
| earlier | forever - 2021 | NOT DEFINED |
| earlier_2 | NOT DEFINED | NOT DEFINED |
| ending | 2022 | NOT DEFINED |
| ending_2 | 2021 & 2022 | NOT DEFINED |5.56.0