CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2020-07-13T05:13:05Zhttps://lab.civicrm.org/dev/core/-/issues/1864Advanced Search returns contacts in Trash even if 'Search in Trash' not ticked.2020-07-13T05:13:05ZspalmstromAdvanced Search returns contacts in Trash even if 'Search in Trash' not ticked.Overview
----------------------------------------
Advanced Search returns deleted contacts (i.e. contacts in Trash) even if the '*Search in Trash*' is not ticked. Also, the Search results don't appear to know that the contact is deleted...Overview
----------------------------------------
Advanced Search returns deleted contacts (i.e. contacts in Trash) even if the '*Search in Trash*' is not ticked. Also, the Search results don't appear to know that the contact is deleted.
Reproduction steps
----------------------------------------
1. Click on **Advanced Search**.
1. Do not tick **Search in Trash**.
1. Click on "**Search**".
Current behaviour
----------------------------------------
Deleted contacts are returned in the list.
![image](/uploads/035f163f0704992b6ef88c2f5b64b493/image.png)
and
![image](/uploads/284b2b2f9a733564d0ee46590f69bfbc/image.png)
shows that the contact is in Trash.
Expected behaviour
----------------------------------------
Deleted contacts should not appear in the list.
Environment information
----------------------------------------
<!-- Some of the items below may not be relevant for every bug - if in doubt please include more information than you think is necessary. -->
* __Browser:__ _Irrelevant_
* __CiviCRM:__ _5.27.0_ but also appears in _5.29.alpha1_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
* __PHP:__ _Irrelevant__
* __CMS:__ _Joomla 3.9.6 but probably irrelevant_
* __Database:__ _MySQL 5.7.30 but probably irrelevant_
* __Web Server:__ _Irrelevant_
Comments
----------------------------------------
It was introduced in _5.27.0_. _5.26.2_ does not show this behaviour.5.27.2https://lab.civicrm.org/dev/core/-/issues/1862Regression - fatal error when merging contacts (when both in the same smart g...2020-07-23T16:00:03ZJKingsnorthRegression - fatal error when merging contacts (when both in the same smart group / mailing)@eileen | @mattwire
This PR https://github.com/civicrm/civicrm-core/pull/17072 has introduced a fatal error when merging contacts that are both in the same smart group.
This situation can be engineered on dmaster to demonstrate the is...@eileen | @mattwire
This PR https://github.com/civicrm/civicrm-core/pull/17072 has introduced a fatal error when merging contacts that are both in the same smart group.
This situation can be engineered on dmaster to demonstrate the issue.
The error displayed is:
`Fatal error: Uncaught CRM_Core_Exception: [0: Transaction integrity error: Expected to find active frame thrown in .../civicrm/Civi/Core/Transaction/Manager.php on line 93`
The root cause is something like:
`$Fatal Error Details = Array ( [callback] => Array ( [0] => CRM_Core_Error [1] => handle ) [code] => -5 [message] => DB Error: already exists [mode] => 16 [debug_info] => UPDATE civicrm_group_contact_cache SET contact_id = 159732 WHERE contact_id = 173002 [nativecode=1062 ** Duplicate entry '159732-212' for key 'UI_contact_group'] [type] => DB_Error [user_info] => UPDATE civicrm_group_contact_cache SET contact_id = 159732 WHERE contact_id = 173002 [nativecode=1062 ** Duplicate entry '159732-212' for key 'UI_contact_group'] [to_string] => [db_error: message="DB Error: already exists" code=-5 mode=callback callback=CRM_Core_Error::handle prefix="" info="UPDATE civicrm_group_contact_cache SET contact_id = 159732 WHERE contact_id = 173002 [nativecode=1062 ** Duplicate entry '159732-212' for key 'UI_contact_group']"] )`
It throws a duplicate key issue because it can't update the contact ID so they are in the civicrm_group_contact_cache table associated with the same group twice.
We need to:
- ensure that group_contact_cache is treated as a table that needs to be handled with `UPDATE IGNORE`.
- ideally, create a test that checks for merging two contacts that are members of the same smart group.5.27.2https://lab.civicrm.org/dev/core/-/issues/1860Unable to install 5.28 on Maria DB 10.3 on Ubuntu2020-07-09T21:47:08ZkcristianoUnable to install 5.28 on Maria DB 10.3 on UbuntuI am doing the RC testing and attempted a fresh install of 5.28 on ubuntu 20.04 with Maria DB 10.3, php 7.3
`Server version: 10.3.22-MariaDB-1ubuntu1 Ubuntu 20.04` is what I get for the MySQl version, but when I attempt a clean install:...I am doing the RC testing and attempted a fresh install of 5.28 on ubuntu 20.04 with Maria DB 10.3, php 7.3
`Server version: 10.3.22-MariaDB-1ubuntu1 Ubuntu 20.04` is what I get for the MySQl version, but when I attempt a clean install:
![image](/uploads/bf73af04958560c31fcf9d0e63f2e26a/image.png)
Install of 5.27.0 works fine, master exhibits the same error.
ping @seamusleehttps://lab.civicrm.org/dev/core/-/issues/1856Regression: Detailed "change log" is missing2020-07-12T23:04:50ZtapashRegression: Detailed "change log" is missingAfter upgrading to 5.27 the details of "change log" gone missing, although "Logging" is enabled in settings.
![Screenshot_2020-07-06_at_18.20.00](/uploads/94ac5e7e0ecd81cfee8c270449ce8dd4/Screenshot_2020-07-06_at_18.20.00.png)After upgrading to 5.27 the details of "change log" gone missing, although "Logging" is enabled in settings.
![Screenshot_2020-07-06_at_18.20.00](/uploads/94ac5e7e0ecd81cfee8c270449ce8dd4/Screenshot_2020-07-06_at_18.20.00.png)https://lab.civicrm.org/dev/core/-/issues/1847Offset is not respected in Date Preferences2020-07-15T00:47:07ZyashodhaOffset is not respected in Date PreferencesSteps to replicate :
- Navigate to Administer > Customize Data and Screens > Date Preferences
- Changed searchDate Start offset from 20 to 50:
![pref](/uploads/96847ace7528adc16ad37a7ad42692ed/pref.png)
The change had no affect on the...Steps to replicate :
- Navigate to Administer > Customize Data and Screens > Date Preferences
- Changed searchDate Start offset from 20 to 50:
![pref](/uploads/96847ace7528adc16ad37a7ad42692ed/pref.png)
The change had no affect on the range of years offered in search forms (i.e. there is only a 20 year range available 2010 - 2030)
![search](/uploads/a0fccd9f6e91c643a4bf755289a6e7e3/search.png)5.27.2https://lab.civicrm.org/dev/core/-/issues/1846Upgrading to 5.27 hits fatal errors getting to the upgrade screen2020-08-20T10:34:20ZeileenUpgrading to 5.27 hits fatal errors getting to the upgrade screenIn deploying the rc on a wordpress site just now I hit 3 places where DB queries failed before I could get to the upgrade screen (through the UI). One of these brought down the Wordpress site (a woo_commerce-civi api call) The problem i...In deploying the rc on a wordpress site just now I hit 3 places where DB queries failed before I could get to the upgrade screen (through the UI). One of these brought down the Wordpress site (a woo_commerce-civi api call) The problem is the new field civicrm_custom_field.serialize gets included in queries before it is in th DB
This patch got me there https://github.com/civicrm/civicrm-core/pull/17722 but drupal views is likely also an issue5.27.1https://lab.civicrm.org/dev/core/-/issues/1841[regression] Attempting to access Multi-Record Custom Field import results in...2020-07-01T02:11:20ZJonGold[regression] Attempting to access Multi-Record Custom Field import results in crash## To replicate
* You must start with a site where you've never visited this screen before (a demo site works well).
* Go to **Contacts » Import Contacts**.
* Click the **help** icon in the instructions (see screenshot item 1)
* Click th...## To replicate
* You must start with a site where you've never visited this screen before (a demo site works well).
* Go to **Contacts » Import Contacts**.
* Click the **help** icon in the instructions (see screenshot item 1)
* Click the **more** link in the help to access the Import Multi-Record Custom Value screen (see screenshot item 2).
![Selection_947](/uploads/95b8fb2da66f267362c4600bf6fa900d/Selection_947.png)
## Observed Result
An exception: `'Import Multi value custom data' is not a valid option for field mapping_type_id`.
## Expected result
The page loads.
## Notes
I believe this is a variant of the regression fixed in #1816. When translating a pseudoconstant to an ID when passing an API param, we now check the string against the `name` and not the `label`. This makes good sense, but `CRM_Core_BAO_Mapping::getCreateMappingValues()` creates the "Import Multi value custom data" Mapping record with a label that doesn't match the name - so a function that previously looked up the label is crashing with the exception above.
I solve this by explicitly setting the `name` field. Much as I'd like to have solved this by changing the search criteria, it's constructed programmatically in a way that would require a change to all the `name`s of existing Mapping Type option values, since they have spaces in them (boo!). This is the much safer fix.
Also, testing this only required one line of code! :)
## Backtrace
```
#0 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/Mapping.php(105): civicrm_api3("Mapping", "get", (Array:4))
#1 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/BAO/Mapping.php(157): CRM_Core_BAO_Mapping::getMappings("Import Multi value custom data")
#2 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Import/Form/DataSource.php(66): CRM_Core_BAO_Mapping::getCreateMappingValues("Import Multi value custom data")
#3 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Custom/Import/Form/DataSource.php(54): CRM_Import_Form_DataSource->buildQuickForm()
#4 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Form.php(609): CRM_Custom_Import_Form_DataSource->buildQuickForm()
#5 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/QuickForm/Action/Display.php(76): CRM_Core_Form->buildForm()
#6 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Controller.php(203): CRM_Core_QuickForm_Action_Display->perform(Object(CRM_Custom_Import_Form_DataSource), "display")
#7 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/packages/HTML/QuickForm/Page.php(103): HTML_QuickForm_Controller->handle(Object(CRM_Custom_Import_Form_DataSource), "display")
#8 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Controller.php(347): HTML_QuickForm_Page->handle("display")
#9 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(312): CRM_Core_Controller->run((Array:3), NULL)
#10 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(68): CRM_Core_Invoke::runItem((Array:14))
#11 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(36): CRM_Core_Invoke::_invoke((Array:3))
#12 /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/drupal/civicrm.module(456): CRM_Core_Invoke::invoke((Array:3))
#13 /home/jon/local/civicrm-buildkit/build/dmaster/web/includes/menu.inc(527): civicrm_invoke("import", "custom")
#14 /home/jon/local/civicrm-buildkit/build/dmaster/web/index.php(21): menu_execute_active_handler()
#15 {main}
```5.27.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/1824Fixes to dedupe getting dynamic references2020-06-19T02:35:54ZJonGoldFixes to dedupe getting dynamic referencesCivi 5.26 included [PR #17125](https://github.com/civicrm/civicrm-core/pull/17125), "Fix Dedupe entity_tag mangling bug". This introduced the new method `CRM_Core_DAO::getDynamicReferencesToTable()` and `CRM_Dedupe_MergeHandler::getTabl...Civi 5.26 included [PR #17125](https://github.com/civicrm/civicrm-core/pull/17125), "Fix Dedupe entity_tag mangling bug". This introduced the new method `CRM_Core_DAO::getDynamicReferencesToTable()` and `CRM_Dedupe_MergeHandler::getTablesRelatedToTheMergePair()`. However, there are two bugs in the implementation:
* It assumes that only one dynamic reference can exist between two tables. In addition to extensions that may introduce dynamic references, this is also untrue in core: `civicrm_pcp_block` has two dynamic references to `civicrm_contact`: Both `entity_id` and `target_entity_id`.
* It assumes that the column specifying the entity is always called `entity_table`, and this is hard-coded into the SQL in `getTablesRelatedToTheMergePair()`. However, this column isn't always `entity_table`. We should pull the correct column name from the metadata.
I don't think there's a Gitlab ticket for PR #17125, so I'm referencing the PR here instead.5.27.0JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/1823[regression] Contribution amount choices don't appear for anonymous users2020-06-16T10:20:13ZJonGold[regression] Contribution amount choices don't appear for anonymous users**Steps to replicate**
* Go to **Manage Contribution Pages** for any page.
* Go to **Amounts** tab.
* Click **Save**.
* View the contribution page as an anonymous user.
**Expected result**
You can select an amount to give.
**Actual res...**Steps to replicate**
* Go to **Manage Contribution Pages** for any page.
* Go to **Amounts** tab.
* Click **Save**.
* View the contribution page as an anonymous user.
**Expected result**
You can select an amount to give.
**Actual result**
Nope.
This regression was introduced by [this commit](https://github.com/civicrm/civicrm-core/pull/17122/commits/398683876c9abe34b8a7b7016b057af4ca9068e9#diff-6329da386c1213c4300469cf93a3d00cL2580) and specifically the one-line change to `CRM_Core_DAO`. Reverting that line fixes the problem - but given how low-level this is, I'm concerned about side effects. @colemanw - thoughts?5.26.2https://lab.civicrm.org/dev/core/-/issues/1822Added activity types don't appear in the type dropdown on New Activity2020-07-25T18:59:30ZDaveDAdded activity types don't appear in the type dropdown on New ActivityCan reproduce on dmaster.demo. Seems to have been working in 5.25. More investigation TBD.
1. Add a new activity type. (For Contacts and Cases.)
2. Go to Contacts - New Activity.
3. It isn't in the activity type dropdown. It does appear...Can reproduce on dmaster.demo. Seems to have been working in 5.25. More investigation TBD.
1. Add a new activity type. (For Contacts and Cases.)
2. Go to Contacts - New Activity.
3. It isn't in the activity type dropdown. It does appear if you go to a contact and then click on Actions. Clearing cache doesn't change anything.5.27.0https://lab.civicrm.org/dev/core/-/issues/1816[regression](for real this time) API doesn't allow passing option values by l...2020-06-25T16:47:52ZJonGold[regression](for real this time) API doesn't allow passing option values by labelThis is best replicated from the CLI.
In Civi 5.25 and below, when you use the API `create` action to modify a multiple-choice custom field (e.g. radio, checkboxes, etc.) you can pass either the OptionValue's `value` or `label`. Passin...This is best replicated from the CLI.
In Civi 5.25 and below, when you use the API `create` action to modify a multiple-choice custom field (e.g. radio, checkboxes, etc.) you can pass either the OptionValue's `value` or `label`. Passing a label no longer works. For example, on a site with the standard demo data, custom field 6 is a question, "How long have you been a donor?" Here are the potential options:
```
mysql> select label, value from civicrm_option_value WHERE option_group_id=99;
+-------------------+-------+
| label | value |
+-------------------+-------+
| Less than 1 year | 1 |
| 1-3 years | 2 |
| 4-6 years | 3 |
| 7-9 years | 4 |
| More than 9 years | 5 |
+-------------------+-------+
```
In Civi 5.25 and below, the following commands are equivalent:
```
cv api Contribution.create id=1 custom_6='1-3 years'
cv api Contribution.create id=1 custom_6=2
```
However, in Civi 5.26, if you run the first command, instead you get:
```json
{
"error_field": "custom_6",
"error_code": 2001,
"entity": "Contribution",
"action": "create",
"is_error": 1,
"error_message": "'1-3 years' is not a valid option for field custom_6"
}
```
`git bisect` tracks it down to [this commit](https://github.com/civicrm/civicrm-core/commit/1453c6db862950c135452bd36d20aa7f0e95c795) (attention @colemanw). Further testing tracks it down to the change in `CRM/Core/BAO/CustomField.php`; reverting that line fixes this.5.26.2https://lab.civicrm.org/dev/core/-/issues/1806Import Contribution of custom fields only accepts "Numeric Value" rather than...2020-06-16T10:20:04ZtapashImport Contribution of custom fields only accepts "Numeric Value" rather than "Label"It occurs after updating to CiviCRM v-5.26.x, on previous version it seems to have worked. And due to this issue I am not able to import hundreds of records.
When importing a contribution via csv with custom fields "Label", it comes wit...It occurs after updating to CiviCRM v-5.26.x, on previous version it seems to have worked. And due to this issue I am not able to import hundreds of records.
When importing a contribution via csv with custom fields "Label", it comes with an error **'Label' is not a valid option for field custom_xx.** Updating custom field set did not solve the issue.
If custom field is accessed this error message keep showing in drupal log
`"Warning: in_array() expects parameter 2 to be array, null given in CRM_Core_BAO_CustomField::setProfileDefaults() (line 1241 of /public_html//sites/all/modules/civicrm/CRM/Core/BAO/CustomField.php)."`
If custom fields are updated : This error message shows in log
`Notice: Undefined index: ADD in CRM_Logging_Schema->fixSchemaDifferencesFor() (line 437 of /home/webadmin/public_html/cmm/sites/all/modules/civicrm/CRM/Logging/Schema.php).`
5.26.2https://lab.civicrm.org/dev/core/-/issues/1797jquery validation type error on the credit card field2020-06-06T01:16:36Zalicefruminjquery validation type error on the credit card fieldOverview
----------------------------------------
On front end contribution forms with Credit Card Processing enabled, the [jQuery Validation Plugin](https://jqueryvalidation.org/creditcard-method/) is choking on the credit card field an...Overview
----------------------------------------
On front end contribution forms with Credit Card Processing enabled, the [jQuery Validation Plugin](https://jqueryvalidation.org/creditcard-method/) is choking on the credit card field and throwing the following error in the console: `TypeError: a.validator.methods[d] is undefined. Exception occurred when checking element credit_card_number, check the 'creditcard' method. jquery.validate.min.js:4:11231`
I think this broke when the jQuery Validation Plugin was updated with this [commit](https://github.com/civicrm/civicrm-core/pull/16625) in CiviCRM 5.25.
Reproduction steps
----------------------------------------
1. go to a front end contribution form with credit card processing set up
1. Enter a 1 into the credit card number field
Current behaviour
----------------------------------------
an error is thrown in the console.
NO validation error is thrown
SCREENSHOT FROM CiviCRM v5.25
![typeerror](/uploads/92a9c0bba3c9fd0f036e2178740f34b2/typeerror.png)
Expected behaviour
----------------------------------------
no error should appear in the console
an "Invalid credit card number" message should appear next to the field
SCREENSHOT FROM CiviCRM v5.24
![error](/uploads/310bda7df2cc96594ee8e53628537d3a/error.png)
Environment information
----------------------------------------
I was able to recreate this on http://wpmaster.demo.civicrm.org/ (CiviCRM v5.27) and (CiviCRM v5.25)5.26.1https://lab.civicrm.org/dev/core/-/issues/1794Deselected checkbox settings are not saved2020-06-06T01:16:09Zaydunsaidan.saunders@squiffle.ukDeselected checkbox settings are not savedOverview
----------------------------------------
See https://civicrm.stackexchange.com/questions/35803/some-checkbox-settings-not-applying
Reproduction steps
----------------------------------------
1. Click on **Administer > Customize...Overview
----------------------------------------
See https://civicrm.stackexchange.com/questions/35803/some-checkbox-settings-not-applying
Reproduction steps
----------------------------------------
1. Click on **Administer > Customize Data and Screens > Custom Fields**.
1. Choose a custom field set, **more > Settings**
1. Choose one of the selected tickboxes and deselect.
1. Save
1. Re-open the settings page and observe that the checkbox is still selected
Current behaviour
----------------------------------------
Deselected value is not saved
Expected behaviour
----------------------------------------
Deselected value is saved
Environment information
----------------------------------------
* __CiviCRM:__ _Master_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->
Confirmed on dmaster.demo.civicrm.org5.26.1https://lab.civicrm.org/dev/core/-/issues/1787Regression : File fields export results in DB error2021-03-22T20:15:23ZyashodhaRegression : File fields export results in DB errorIt was possible to export fields earlier
![export](/uploads/b55eb19f9b54375925777dcf3284a10d/export.png)
as the file field was exported as the link
But now it gives DB error as it looks like it is trying to put in content instead.
```
D...It was possible to export fields earlier
![export](/uploads/b55eb19f9b54375925777dcf3284a10d/export.png)
as the file field was exported as the link
But now it gives DB error as it looks like it is trying to put in content instead.
```
Database Error Code: Data too long for column 'custom_13' at row 1, 1406
Additional Details:
Array
(
[callback] => Array
(
[0] => CRM_Core_Error
[1] => handle
)
[code] => -1
[message] => DB Error: unknown error
[mode] => 16
[debug_info] =>
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]
[type] => DB_Error
[user_info] =>
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]
[to_string] => [db_error: message="DB Error: unknown error" code=-1 mode=callback callback=CRM_Core_Error::handle prefix="" info="
INSERT INTO civicrm_tmp_d_export_f8e0146418cb04e43d04334f268fd888 (`id`, `display_name`, `custom_13`, `participant_id`)
VALUES (1,'Mrs. Bernadette Ivanov',' <a href=\"/civicrm/file?reset=1&id=1&eid=42&fcs=66d344b164defb0da239223d1515c8a1b5e2305cd4be3c2527e18a2d6577acc4_1590738546_168\" class=\"crm-image-popup\" title=\"download.jpeg\">\n <i class=\"crm-i fa-file-image-o\" aria-hidden=\"true\"></i>\n </a>','42')
[nativecode=1406 ** Data too long for column 'custom_13' at row 1]"]
)
```
I was able to replicate this on dmaster as well
![dmaster](/uploads/3c55e8ed9b1552c7bd0f79022d6bd930/dmaster.png)5.28.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1784Contact restore from trash not working2020-06-01T00:07:09ZDaveDContact restore from trash not workingSee also https://civicrm.stackexchange.com/questions/35766/restore-from-trash-not-working-no-related-log-entries
Seems to be from here: https://github.com/civicrm/civicrm-core/commit/8e12bf072fe613c29da39614c8999a4041d7e1d2
In contactT...See also https://civicrm.stackexchange.com/questions/35766/restore-from-trash-not-working-no-related-log-entries
Seems to be from here: https://github.com/civicrm/civicrm-core/commit/8e12bf072fe613c29da39614c8999a4041d7e1d2
In contactTrashRestore() it used to fall through to the code below which does the save(). Then by just copying that block to deleteContact() and calling self::create() it doesn't work because it's expecting `contact_id` not `id`.
So would have started in 5.25.
The quick fix would be to use contact_id. But it sounds like there's a desire to deprecate this entire path of calling deleteContact in order to restore.5.26.0https://lab.civicrm.org/dev/core/-/issues/1780Export selected fields doesn't export related contacts if related info is pre...2020-06-04T04:12:51ZyashodhaExport selected fields doesn't export related contacts if related info is present in mappingSteps to replicate
* Search > *Find Contacts*
* Click the *Search* button > results in X contacts
* Select All contacts
* Actions > *Export Contacts*
* Use *Export PRIMARY fields*, all X contacts are exported
* Now try *Select Fields fo...Steps to replicate
* Search > *Find Contacts*
* Click the *Search* button > results in X contacts
* Select All contacts
* Actions > *Export Contacts*
* Use *Export PRIMARY fields*, all X contacts are exported
* Now try *Select Fields for Export* with some fields as related fields like employer, spouse of id etc
* *DO NOT MERGE*
* Export > only X-N contact records where N is the contacts that appeared in related contacts fields
I replicated this on dmaster and seems to be a regression when compared it with 4.7 site where no. of contacts exported was X regardless related fields are used in mapping or primary fields are used.5.26.0https://lab.civicrm.org/dev/core/-/issues/1747Regression: Fails to create smartgroup or refresh count of group2020-06-02T01:16:03ZPradeep Nayakpradpnayak@gmail.comRegression: Fails to create smartgroup or refresh count of groupOverview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refre...Overview
----------------------------------------
Since upgrading to 5.24 creating smart group using 'Date Added to CiviCRM' fails with DB Error: no such table. Also when a smart group is based on 'Date Added to CiviCRM' and try to refresh the count it fails with same error message
Reproduction steps
----------------------------------------
1. Navigate to CiviCRM >> Search >> Custom Searches >> Date Added to CiviCRM
1. Do a search on date and include in group.
1. Select all contact and try adding to smart group.
1. Got an error "**Fatal error: DB error**".
![smartGroupError](/uploads/3ea50e38bccd47141831b4990f6f6b0a/smartGroupError.gif)
Current behaviour
----------------------------------------
Get DB error 'Database Error Code: Table 'dmastercivi_g5lis.civicrm_tmp_e_ig_6f1e2d3b300d50a856f5cb9140996451' doesn't exist, 1146' when trying to create smart group or refresh count
Expected behaviour
----------------------------------------
smart should be created with correct contacts in it and also when refreshing the group count, the group should show correct count
Environment information
----------------------------------------
https://dmaster.demo.civicrm.org/5.26.0https://lab.civicrm.org/dev/core/-/issues/1740Cumulative contributions not being calculated with the correct criteria2020-05-05T23:28:45ZyashodhaCumulative contributions not being calculated with the correct criteriaThis is a regression in CiviCRM. I have confirmed the same in dmaster.
Steps to replicate:
====================
* Go to Contributions > Online Contribution Pages > Contributions > Cumulative
* Check the criteria for Date Receipt, it do...This is a regression in CiviCRM. I have confirmed the same in dmaster.
Steps to replicate:
====================
* Go to Contributions > Online Contribution Pages > Contributions > Cumulative
* Check the criteria for Date Receipt, it doesn't account for **end of** today's date but the start of today and all the contributions done today will NOT be listed.
*Issue with master*
Criteria
Date Received - less than or equal to "May 1st, 2020 **12:00 AM** " ...AND.
![dmaster](/uploads/5441660b74e3a05abe19ae245324a88a/dmaster.png)
*Before*
Contribution Date - less than or equal to "May 1st, 2020 **11:59 PM** " .
![demo](/uploads/434f94696dbc3049c9425085abe1c3c0/demo.png)
The parameter receive_date_high=20200501 has to translate to <= date 11:59 PM and will throw off all the other parameter forced searches as well.
In cumulative search link, do we even need to pass parameters for the date?5.25.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/1738Incorrect loading of default tab on Contribution Page2020-04-30T22:58:29ZjitendraIncorrect loading of default tab on Contribution PageTo replicate - click https://dmaster.demo.civicrm.org/civicrm/admin/contribute?reset=1 -> select Configure > Membership Settings should navigate to the Membership tab directly but instead is navigated to the first tab of the page(Setting...To replicate - click https://dmaster.demo.civicrm.org/civicrm/admin/contribute?reset=1 -> select Configure > Membership Settings should navigate to the Membership tab directly but instead is navigated to the first tab of the page(Settings).
Caused by changes made in https://github.com/civicrm/civicrm-core/pull/17066.5.26.0