CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-10-03T20:55:03Zhttps://lab.civicrm.org/dev/core/-/issues/4637Profile Update from SearchKit doesn't work2023-10-03T20:55:03ZlarsssandergreenProfile Update from SearchKit doesn't workIf you try to use Profile Update in SK, it pops up a modal to select the profile and then just closes when you click continue. Verified this is the behaviour back to at least 5.58. Probably makes more sense to get in-place editing workin...If you try to use Profile Update in SK, it pops up a modal to select the profile and then just closes when you click continue. Verified this is the behaviour back to at least 5.58. Probably makes more sense to get in-place editing working well enough to replace Profile Update, but at least we should remove it if is broken.https://lab.civicrm.org/dev/core/-/issues/4636Deleting group invalidates ACL2023-10-05T11:56:00Zaydunsaidan.saunders@squiffle.ukDeleting group invalidates ACLOverview
----------------------------------------
Groups used in ACL's can be deleted without warning resulting in invalid ACL's.
Setup
----------------------------------------
1. Create a group: TestGroup
1. Create an ACL: Role: Every...Overview
----------------------------------------
Groups used in ACL's can be deleted without warning resulting in invalid ACL's.
Setup
----------------------------------------
1. Create a group: TestGroup
1. Create an ACL: Role: Everyone, Operation: View, Type: Group, Group: TestGroup (just created)
1. Note that the ACL display will shows `Type` as 'Group' and shows the group name
1. In SQL, look at the `civicrm_acl` table and note the `object_table` is 'civicrm_group', and `object_id` is the new group id.
Now delete the TestGroup:
- There is no warning that this group is used in an ACL
- In the ACL display the group name is now blank - a situation which cannot be created through the Add or Edit ACL screens.
- In SQL, the `civicrm_acl` table still show the `object_id` as the now non-existent group id.
Prior to https://github.com/civicrm/civicrm-core/pull/27679 this causes DB Syntax Errors when calling `CRM_Contact_BAO_Contact_Permission::allow()`
Expected behaviour
----------------------------------------
Good question! Maybe a warning that the group is being used in an ACL, but what should then happen to the ACL? Disable it?
Environment information
----------------------------------------
* __CiviCRM:__ _Master but may be longstanding_ <!-- If this problem relates to an upgrade, then specify both old and new versions -->https://lab.civicrm.org/dev/core/-/issues/4634Replace all form-assigned variables from event workflow templates2024-02-22T05:21:07ZeileenReplace all form-assigned variables from event workflow templates**The goal is to remove all form based variables from the event workflow templates in order to**
1) make them work consistently from whereever they are called
2) make them display in preview mode (eg. with Message Admin extension)
3) re...**The goal is to remove all form based variables from the event workflow templates in order to**
1) make them work consistently from whereever they are called
2) make them display in preview mode (eg. with Message Admin extension)
3) reduce hacky code in the form layer with associated brittleness & fragility
4) eliminate the notices
5) make the code more similar on event templates
**To this end we have a few strategies**
1) Use tokens whereever possible. These are standardised across Workflow Templates & Event templates & follow consistent naming
2) Establish consistent variables to be assigned at the WorkFlow layer where tokens are not suitable
**Status**
**Workflow variables**
- `$participants` - this is an array of all participants associated with the registration with details in subkeys:
- contact_display_name
- line_items
- totals
- `$participantDetail` - the item from the above array that relates to the recipient participant
- `$isPrimary` is this the primary participant
- `$taxTerm` is broadly available in workflow templates - eg 'VAT'
- `$isShowLineItems` (comes from the price set is_quick_config)
**Tokens**
Tokens are available from event, participant, contact & contribution entities
**To do**
- [ ] Work through variables `$isOnWaitlist` `$isRequireApproval` (all event forms)
- [ ] Replace `$participant_status` with a token (online receipt)
- [ ] Replace is_pay_later with token (online receipt)
- [ ] Replace isAmountZero with token (online receipt)
- [ ] Replace isAdditionalParticipant with !$isPrimary (online receipt)
- [ ] Replace {$pay_later_receipt} with token (offline receipt)
- [ ] Replace event_confirm_text with token (online receipt)
- [ ] Replace `$receive_date`, financialType (online receipt)
- [ ] Replace isShowLocation with token (online receipt)
- [ ] Make sense of `$payer.name` (online receipt)
- [ ] Assign billingName, address from the ContributionWorkflowTrait or token - comes from civicrm_contribution.address_id.*
- [ ] Maybe credit_card_type, number etc come from the financial_trxn table
- [ ] Replace `$lineItems|@count` with something from the participant array & doesn't used smarty-2-only |@count (online & offline receipt)
- [ ] Replace $priceSetFieldsCount with something from the workflow message template layer, also `{foreach from=$lineItem item=pcount}` loop
- [ ] Replace $event.confirm_email_text with `$userText` offline receipt
- [ ] Move event_registration_receipt to event cart - this extension is being phased out so we can let it go once that is the case
- [ ] Move assigning `customGroups` to the workflow template (offline receipt) https://github.com/civicrm/civicrm-core/pull/27596
- [ ] Move assigning profiles to the workflow template (online receipt)
- [ ] Get tokens & token substution & examples working for remaining participant templates -transfered, cancelled etc
- [ ] $hookDiscountMessage - ? not surehttps://lab.civicrm.org/dev/core/-/issues/4633Fix extensions to work with Smarty3 - backticks2023-11-17T00:41:05ZeileenFix extensions to work with Smarty3 - backticksIn order to replace Smarty 2 with Smarty 3 we need to make minor changes to extensions so that they are compatible
UPDATE - the backticks seem to be less hurty than I thought so I misunderstood @larssg anaysis of when they DO cause issu...In order to replace Smarty 2 with Smarty 3 we need to make minor changes to extensions so that they are compatible
UPDATE - the backticks seem to be less hurty than I thought so I misunderstood @larssg anaysis of when they DO cause issues
Ref https://github.com/kanshin/CakeSmarty/blob/master/vendors/Smarty-3.0.9/SMARTY2_BC_NOTES
- [ ] Backticks should no longer be used in strings - unfortunately the advertised way of doing crmUrl included backticks - we should add to `civix upgrade` to include doing a regex to fix these
href="{crmURL p='civicrm/participant/add' q="reset=1&action=add&context=standalone&eid=`$event.id`"}"
this regex seems to work to find them
\".*`\$.*`\"
![image](/uploads/51b4097c2491e9d07b432605c7b3ed34/image.png)
![image](/uploads/8241c284e6cff66e766b832b5a3beaf6/image.png)
- [ ] Find extensions with older civix & run regex on them - for those with backticks this will fix. For the others it will allow Smarty3 to be run in the transition period
- [ ] Patch / hack Smarty2 to give deprecation notices for the above
- [ ] When we are closer to transitioning consider temporarily hacking string replace into smarty 3 fetch function
Extension list
- [ ] CiviRules
- [ ] UK Gift Aid https://lab.civicrm.org/extensions/ukgiftaid/-/merge_requests/41
- [ ] CiviCalender https://github.com/agiliway/com.agiliway.civicalendar/pull/34
- [ ] Elections https://lab.civicrm.org/extensions/elections/-/merge_requests/4https://lab.civicrm.org/dev/core/-/issues/4632Keyboard UI for SearchKit in-place editing2023-10-07T08:58:11ZnoahKeyboard UI for SearchKit in-place editingOverview
----------------------------------------
As of CiviCRM 5.66, SearchKit Displays offer "in-place editing" of some fields. The user interface requires a lot of clicking.
Current behaviour
----------------------------------------
...Overview
----------------------------------------
As of CiviCRM 5.66, SearchKit Displays offer "in-place editing" of some fields. The user interface requires a lot of clicking.
Current behaviour
----------------------------------------
To "edit in place", the user must
- click on the editable field (the *resting* version of the field turns into a *single-field mini-form*)
- click within the form control to edit the field's value; depending on the form control, the keyboard may/must be used to manipulate the value
- click a green checkmark button (the value is saved via an AJAX request and the field goes back into *resting* state) or a red "x" button (the field returns to *resting* state without any changes being applied); this step may also be accomplished using the keyboard
This process must be repeated for each editable field in every row.
Goal
----------------------------------------
Make it possible to perform edits within SearchKit Displays without any use of the mouse.
Questions
----------------------------------------
### Design
- What should the UX be, specifically? I.e. which keystrokes should map to which behaviors?
- Should multiple editing modes be available? (e.g. single-field form, single-row form, whole-result set form)?
- How can the UX be accessible to users with various abilities?
Some possible design dimensions:
| from | | to |
|----------------------|-----|---------------------------------------------------------------------|
| emphasis on display | ... | emphasis on editing |
| edit one field | ... | edit many fields fluidly (office app spreadsheet-style interface) |
| civicrm-specific ux | ... | ux paradigm borrowed from elsewhere |
| one-size-fits-all ux | ... | granular control over the ux for each column in each search display |
| hard-wired ux | ... | ux can be modified by hooks/events |
Some ideas that have already been floated:
- Tab/Shift-Tab to navigate between editable fields of the existing *single-field mini-form* style (@noah in [this PR](https://github.com/civicrm/civicrm-core/pull/27638))
- Excel-like spreadsheet UI (@civiuser in [this comment](https://github.com/civicrm/civicrm-core/pull/27638#issuecomment-1736327321))
- "Edit in place" action in the Display's "Actions" menu, which would switch on editing mode for a set of rows; save via "Save all changes" button (@civiuser in [this comment](https://github.com/civicrm/civicrm-core/pull/27638#issuecomment-1736327321))
- Replicate current "profile edit" UI ((@civiuser in [this comment](https://github.com/civicrm/civicrm-core/pull/27638#issuecomment-1736327321))
- add a new row to the table (e.g. Create a new entity) inline (@colemanw in [this chat thread](https://chat.civicrm.org/civicrm/pl/u8myu3q1g3g8jxaoajz5ya5q9w))
- (overlapping discussion) adding some minimal Aria controls to new FB/SK elements where there aren't native html elements (e.g. accordions/tabs) (@nicol in [this chat thread](https://chat.civicrm.org/civicrm/pl/17ytk6g8gbb4jk4csg56hxdjia))
### Development strategy
- What is possible to implement with the least effort/least change to current code (low-hanging fruit)?
- Should we grab that low-hanging fruit even if we haven't organized a larger UX plan?
- How big should we be thinking — i.e. should this discussion extend to FormBuilder as well?https://lab.civicrm.org/dev/core/-/issues/4631CiviGrant labels are...not good2024-02-15T15:50:15ZJonGoldCiviGrant labels are...not goodThe CiviGrant fields are strange.
The "Amount Requested" field has this description: *Requested grant amount, in original currency (optional)*.
"Total Amount" has this description: *Requested grant amount, in default currency*.
If you...The CiviGrant fields are strange.
The "Amount Requested" field has this description: *Requested grant amount, in original currency (optional)*.
"Total Amount" has this description: *Requested grant amount, in default currency*.
If you're creating a FormBuilder form for grant requests, it makes sense that you'd want a "Requested Amount" field - but you actually need to use "Total Amount". This is unintuitive, and there's nothing in the field labels to suggest anything about original vs. default currency.
I don't think "Total Amount" makes any real sense here as a label - if anything, I'd expect that to be the amount granted (except that's the "Amount Granted" field).
**Proposal**
"Total Amount" gets relabeled as "Total Amount Requested".
"Amount Requested" gets relabeled as "Amount Requested in Original Currency".https://lab.civicrm.org/dev/core/-/issues/4629Search Kit: DB Entity needs all columns to work2023-10-20T07:56:29Za.valllloveraSearch Kit: DB Entity needs all columns to workOverview
----------------------------------------
When using DB Entity you cannot delete columns, or the results will not be refreshed on the DB table
Reproduction steps
----------------------------------------
![DB_Entity_Rows](/uploa...Overview
----------------------------------------
When using DB Entity you cannot delete columns, or the results will not be refreshed on the DB table
Reproduction steps
----------------------------------------
![DB_Entity_Rows](/uploads/8ffa61cb9c3b70be840877c4505152e8/DB_Entity_Rows.gif)
Current behaviour
----------------------------------------
If you delete some columns in the DB Entity, you can Save the Search but it will not refresh the results in the DB Table.
The Api4 gets you more information about what's happening:
![image](/uploads/ec5d210a1fc5e4a952ce273f1960b7c7/image.png)
```
"info": "INSERT INTO `civicrm_sk_contacts_db_entity1` (id, sort_name)
SELECT `a`.`id` AS `id`,
`a`.`sort_name` AS `sort_name`,
`a`.`contact_type` AS `contact_type:label`,
`a`.`contact_sub_type` AS `contact_sub_type:label`
FROM civicrm_contact a
WHERE (`a`.`contact_type` = \"Individual\")
ORDER BY `a`.`sort_name` ASC
[nativecode=1136 ** Column count doesn't match value count at row 1]",
"db_error": "value count on row",
```
As you can see, the Insert above is not correct and that (I suspect) is the main reason of this behaviour.
Expected behaviour
----------------------------------------
Can alter the number of columns in the DB Entity, to only save the ones that you want on the DB Table.
Environment information
----------------------------------------
* __CiviCRM:__ _[dmaster](https://dmaster.demo.civicrm.org/civicrm/dashboard?reset=1)_ v.5.67.alpha1https://lab.civicrm.org/dev/core/-/issues/4628Search Kit: DB Entity doesn't work with Data Segment2023-10-20T07:56:10Za.valllloveraSearch Kit: DB Entity doesn't work with Data SegmentOverview
----------------------------------------
When you have fields with Data Segmentation and try to use the DB Entity, the search will never be saved in the database, it will stuck in neverending Saving status.
https://chat.civicrm...Overview
----------------------------------------
When you have fields with Data Segmentation and try to use the DB Entity, the search will never be saved in the database, it will stuck in neverending Saving status.
https://chat.civicrm.org/civicrm/pl/jkbfnoukuid38mhroyj1fer1mh
Reproduction steps
----------------------------------------
1. Create a Data Segmentation
1. Create a SK Search that includes the Data Segmentation previosly created
1. Use the DB Entity and try to Save the search while selecting the Data Segmentation field.
![SK_Db_Entity](/uploads/0dce391d884193738e5ca9f767da59ec/SK_Db_Entity.gif)
Current behaviour
----------------------------------------
When you want to save the Search, the DB Entity it enters into an infinite saving status.
![Saving_forever](/uploads/14c2f4b90e0c45176bd1a8424692df92/Saving_forever.gif)
Via api4 you can see that the table is not created in the DB.
![image](/uploads/24c59f656eb38276978c2a3b7fe00e81/image.png)
Expected behaviour
----------------------------------------
It saves the Search, create the Table in the DB and refresh the table with the content of the search.
Environment information
----------------------------------------
* __CiviCRM:__ [dmaster](https://dmaster.demo.civicrm.org/civicrm/dashboard?reset=1) v.5.67.alpha1https://lab.civicrm.org/dev/core/-/issues/4627Proposal: Membership type label2023-10-01T19:23:57Zmattwiremjw@mjwconsult.co.ukProposal: Membership type labelThe membership type table only has "name" and you cannot specify a separate label/title for display. This makes it problematic for portability/import/export as well as translation.
Proposal: Add new field "label" to MembershipType which...The membership type table only has "name" and you cannot specify a separate label/title for display. This makes it problematic for portability/import/export as well as translation.
Proposal: Add new field "label" to MembershipType which is used for display instead of the name.https://lab.civicrm.org/dev/core/-/issues/4626Reduce calls to CRM_Utils_System::url() in mailings2023-10-05T11:45:56ZJonGoldReduce calls to CRM_Utils_System::url() in mailingsOn Drupal 8+ and possibly on other CMSes, `CRM_Utils_System::url()` takes an absurdly long time to run. Seems like `\Drupal\Core\Utility\UnroutedUrlAssembler::assemble()` is the main culprit, but even that's only part of the problem.
W...On Drupal 8+ and possibly on other CMSes, `CRM_Utils_System::url()` takes an absurdly long time to run. Seems like `\Drupal\Core\Utility\UnroutedUrlAssembler::assemble()` is the main culprit, but even that's only part of the problem.
When generating VERP URLs, we call `CRM_Utils_System::url()` 5 times per email, to generate almost-identical URLs. Simply reducing that to one call per email cut my test mail sending by just over 25%!
There are further improvements to be made, I'd love to hear folks' feedback.
* Do we even need to call `\Drupal\Core\Url::fromUri()` every time we call `CRM_Utils_System::url()`? Is there a faster way to generate URLs?
* Many email service providers (Mailjet, Sparkpost etc.) emit a webhook on bounce. What if we created a "Disable VERP" setting?JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4625Inconsistent search result when "Modified By" field and apply an action2023-09-26T12:28:52Zthomas_SYSTOPIAInconsistent search result when "Modified By" field and apply an action**Description:**
When apply an action (like "Tag - add to contacts") on a search result using "Change Log->Modified By" field the result scope is lost. Instead the action would be applied to all contacts.
**Steps to reproduce** (tested...**Description:**
When apply an action (like "Tag - add to contacts") on a search result using "Change Log->Modified By" field the result scope is lost. Instead the action would be applied to all contacts.
**Steps to reproduce** (tested on https://d9-master.demo.civicrm.org/):
1. Use the advanced search form with "Change Log->Modified By" = _admin_. The result includes exactly one contact.
2. Choose "Tag - add to contacts" from the action menu.
3. You'll see "Number of selected contacts: 204" (204 are the sum of all contacts.)https://lab.civicrm.org/dev/core/-/issues/4622Running queues following the docs' example might lead to infinite loops2023-10-27T08:36:37ZjensschuppeRunning queues following the docs' example might lead to infinite loopsFollowing the [_Queue Reference_ example](https://docs.civicrm.org/dev/en/latest/framework/queues/#3-run-the-queue) for running a queue in `CRM_Queue_Runner::ERROR_CONTINUE` mode with a `while` loop that only `break`s for `is_continue!=1...Following the [_Queue Reference_ example](https://docs.civicrm.org/dev/en/latest/framework/queues/#3-run-the-queue) for running a queue in `CRM_Queue_Runner::ERROR_CONTINUE` mode with a `while` loop that only `break`s for `is_continue!=1` will lead to infinite loops when a queue item has not been released yet (e.g. due to the script terminating without an exception being caught and the queue being re-run before release of the next item).
That's because `CRM_Queue_Queue_Sql::claimItem()` fetches the _first_ queue item and filters for `release_time` _afterwards_ - yielding no result, but reporting more items to be in the queue (`is_continue=1`). The only way to catch these cases with code calling the `CRM_Queue_Runner::runNext()` method is to check for `is_error=1` and the `exception` message being `Failed to claim next task`.
So, I've got some questions regarding Queues:
* Is there any best practice for handling errors during `claimItem()` any better?
* Would you agree there should be another indicator in the task result for those cases, or maybe that exception actually being thrown?
* Alternatively, should `is_continue` be `0` instead for those cases (i.e. its meaning would change from _queue finished_ to _queue processing can continue_)?
* Can the `$lease_time` parameter for SQL queues' `claimItem()` be exposed to all queues, so that the caller can modify it?
I see that the query was altered with https://github.com/civicrm/civicrm-core/pull/15421 by @artfulrobothttps://lab.civicrm.org/dev/core/-/issues/4620CiviEvent dashboard: start date is 7 days ago2023-09-26T12:23:49ZmasettoCiviEvent dashboard: start date is 7 days agoI follow up https://civicrm.stackexchange.com/questions/22424/how-to-customize-events-dashboard.
The event dashboard now shows recent and upcoming events (where start date is 7 days ago OR later).
It would be convenient if the numbe...I follow up https://civicrm.stackexchange.com/questions/22424/how-to-customize-events-dashboard.
The event dashboard now shows recent and upcoming events (where start date is 7 days ago OR later).
It would be convenient if the number of days was configurable in the preferences of CiviEvents (`civicrm/admin/setting/preferences/event`).
Do you think it is useful and required by others as well?https://lab.civicrm.org/dev/core/-/issues/4619Eliminate `contributeMode`2023-09-26T12:23:10ZeileenEliminate `contributeMode``contributeMode` is the old concept when we thought we could categorise payment processors into 3-4 basic types that did the same stuff. We have mostly eliminated but it perseveres in a few places we want to kill
| Form | Used for |Alte...`contributeMode` is the old concept when we thought we could categorise payment processors into 3-4 basic types that did the same stuff. We have mostly eliminated but it perseveres in a few places we want to kill
| Form | Used for |Alternative|
| ------ | ------ |------------|
| Contribution_Confirm | Should the form `postProcess` hook be called before `doPayment` |? `$processor->supports('formAssumesNoReturn')` (I kinda feel it should be on the processor to call the hook but...|
| Contribution_Confirm | Should the button be called 'Continue' or 'Make Contribution' |Ditch? always 'Make Contribution'? Or do we need a `getText('continue_contribution_button)`|
|Event_Registration|Should emails be sent from the form (otherwise sent on completetransaction)|? `$processor->supports('formAssumesNoReturn')`|
|Event_Registration_Confirm|Should paypal express code be called|probably just a different hack|
|Event_Registration_Confirm::554|several places tricky stuff around doPayment| will need unravelling|
|Contribution Confirm.tpl|What text should we use for continue_instructions-section|?`paymentObject->getText('continue_contribution_instruction')` ?|
|Registration Thankyou.tpl|What text should be used arount 'Your registration has been processed successfully'|?`paymentObject->getText('event_success_instruction')` ?|
All other places are either doing nothing or are removablehttps://lab.civicrm.org/dev/core/-/issues/4618Tracking: Uses of {php} to remove from Smarty in order to allow upgrade to Sm...2023-09-26T03:17:14ZlarsssandergreenTracking: Uses of {php} to remove from Smarty in order to allow upgrade to Smarty 3+This is the complete list remaining (not including those in pending PRs)
- [ ] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/Contact/Form/Task/PDFLetterCommon.hlp#L27 (I think we can get the param directly in Smarty ...This is the complete list remaining (not including those in pending PRs)
- [ ] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/Contact/Form/Task/PDFLetterCommon.hlp#L27 (I think we can get the param directly in Smarty 3 or maybe it would be OK to hardcode docx and odt in here)
- [x] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/Admin/Page/APIExplorer.js#L752 (APIv3 Explorer ouputs {php} when we have an array, but in Smarty 3 we can pass in the array, so this can be removed)
- [ ] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/Campaign/Page/Petition/SocialNetwork.drupal#L28
- [ ] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/common/accesskeys.hlp#L11 (Could maybe redo this in JS)
- [ ] https://github.com/civicrm/civicrm-core/blob/master/templates/CRM/ACL/Header.tpl#L17
- [ ] https://github.com/civicrm/civicrm-core/blob/master/xml/templates/civicrm_msg_template.tplhttps://lab.civicrm.org/dev/core/-/issues/4617Running Job.update_greeting without updating customized greetings2023-10-18T08:06:00ZCharlotteRunning Job.update_greeting without updating customized greetingsOverview
----------------------------------------
For the scheduled job `update_greeting` there are two options for the parameter `force` which are explained by the [documentation](https://docs.civicrm.org/user/ca/latest/initial-set-up/...Overview
----------------------------------------
For the scheduled job `update_greeting` there are two options for the parameter `force` which are explained by the [documentation](https://docs.civicrm.org/user/ca/latest/initial-set-up/scheduled-jobs/#job_update_greeting) as follows:
- `0` only contacts with null values are updated (default)
- `1` update all contacts
There is no explanation about what happens with customized greetings when using `force = 1`.
It turns out that all customized greetings will be overridden by the standard greeting. I did not expect this.
It would be great to have another option
- `2` update all contacts excluding customized greetings
If this is not possible, then a more detailed documentation could be helpful.
This issue has also been described on [stackexchange](https://civicrm.stackexchange.com/questions/41709/running-job-update-greeting-without-updating-customized-greetings).
Work around
----------------------------------------
Use API v4 to set all greetings that are not customized greetings to NULL.
Here an example for individuals and email greeting:
```
$contacts = civicrm_api4('Contact', 'get', [
'where' => [
['email_greeting_custom', 'IS EMPTY'],
['contact_type', '=', 'Individual'],
],
'chain' => [
'name_me_0' => ['Contact', 'update', ['values' => ['id' => '$id', 'custom_greeting_display' => NULL]]],
],
]);
```
Afterwards, the greetings are not NULL but already contain the new standard greeting. There is no need to run the job `update_greeting` with `force = 0`.
Environment information
----------------------------------------
* __CiviCRM:__ 5.63.2
* __PHP:__ 8.1
* __CMS:__ Drupal 9https://lab.civicrm.org/dev/core/-/issues/4615Search Displays: improve the display of in-place-editable EntityReferences wh...2023-09-26T12:19:09ZnoahSearch Displays: improve the display of in-place-editable EntityReferences when at restThis feature request is about EntityReference/foreign-key fields with "in-place edit" turned on in Search Displays.
Let's use this example: a Saved Search for Contacts, where we want to be able to edit a contact's "Current Employer" inl...This feature request is about EntityReference/foreign-key fields with "in-place edit" turned on in Search Displays.
Let's use this example: a Saved Search for Contacts, where we want to be able to edit a contact's "Current Employer" inline.
Currently:
- "Current Employer Display Name" can be added as a field in the Search Display. However, "In-Place Edit" is not available for it.
- "Current Employer ID" can be added as a field in the Search Display, with "In-Place Edit". "In-Place Edit" and "Rewrite Text" can't be enabled at the same time.
- When the Display is rendered, all "Current Employer ID"s are shown simply as numeric contact ids.
- When you click on one of these numbers, an autocomplete widget appears, allowing you to search by name; choices are shown with name, contact type and contact id.
- When you submit/close the widget, the field goes back to just a number.
It would be great if:
- "Rewrite" could be used in conjunction with "In-Place Edit". That way, the search designer could choose how the value is displayed "at rest" (when not being edited). For example, "Currently Employer ID" could be rewritten with a token for "Current Employer Display Name".
- and, maybe, the search designer could just tick a box to display the "label" field for the referenced entity. This simpler option would disable the "rewrite".https://lab.civicrm.org/dev/core/-/issues/4614Search Displays: Let booleans be displayed as "instant-save" checkboxes2023-09-26T12:18:30ZnoahSearch Displays: Let booleans be displayed as "instant-save" checkboxesIn SearchKit, turning on "inline edit" for a boolean field results in a UI that involves three clicks to toggle the field value:
1. click the field to enter edit mode
2. click "Yes" or "No"
3. click the submit button
A much smoother UI...In SearchKit, turning on "inline edit" for a boolean field results in a UI that involves three clicks to toggle the field value:
1. click the field to enter edit mode
2. click "Yes" or "No"
3. click the submit button
A much smoother UI (one click instead of three) would be a single checkbox that saves immediately when toggled.https://lab.civicrm.org/dev/core/-/issues/4613Can't uncheck "display in table" for custom fields2023-09-26T12:18:06ZDaveDCan't uncheck "display in table" for custom fields1. Create a multivalued custom field group.
2. Create a custom field with "display in table" checked.
3. Edit the field and uncheck display in table.
4. Go to edit it again and note that it's checked.
This sounds familiar.1. Create a multivalued custom field group.
2. Create a custom field with "display in table" checked.
3. Edit the field and uncheck display in table.
4. Go to edit it again and note that it's checked.
This sounds familiar.https://lab.civicrm.org/dev/core/-/issues/4612Searchkit: copy MessageTemplate action2023-09-26T12:17:18Ztycho77Searchkit: copy MessageTemplate action## Overview
You want to create a copy of a message template directly from a Searchkit form, which you can then edit immediately.
## Example use-case
1. in a SearchKit-Form searching for **MessageTemplates**
2. there is a **menu-column...## Overview
You want to create a copy of a message template directly from a Searchkit form, which you can then edit immediately.
## Example use-case
1. in a SearchKit-Form searching for **MessageTemplates**
2. there is a **menu-column** added for selecting actions for one of the MessageTemplates shown
3. you want to select **Copy MessageTemplate**
## Current behaviour
1. you can already choose between CRUD functionalities for MessageTemplates
## Proposed behaviour
1. the copy takes the original name followed by " (copy)"
2. the search is reloaded, so that you can immediately see and edit the copy
## Comments
if this could be done with an hour's effort, there is concrete budget left for this.