CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2024-02-08T09:56:27Zhttps://lab.civicrm.org/dev/core/-/issues/4980Crash on thankyou page when no paymentProcessorObject is set2024-02-08T09:56:27ZBastien HoCrash on thankyou page when no paymentProcessorObject is setSince v5.69, I get this error on contribution pages, on "thank you".
```
PHP Fatal error: Uncaught Error: Call to a member function getText() on null in CRM/Contribute/Form/ContributionBase.php:995
```
In fact, the diff shows that a p...Since v5.69, I get this error on contribution pages, on "thank you".
```
PHP Fatal error: Uncaught Error: Call to a member function getText() on null in CRM/Contribute/Form/ContributionBase.php:995
```
In fact, the diff shows that a previous check has been removed
[-if ($isMonetary && $this->_paymentProcessor['object'] instanceof \CRM_Core_Payment) { -]
[- $paymentProcessorObject = $this->_paymentProcessor['object'];-]
[+if ($isMonetary) {+]
[+ $paymentProcessorObject = $this->getPaymentProcessorObject();+]
I suggest to implement a new check `if($paymentProcessorObject)`
In addition, a checkup should be implemented in _PaymentProcessorFormTrait.php_.5.69.5https://lab.civicrm.org/dev/core/-/issues/4977FormBuilder with relationship and custom field fields to encode correctly (5.70)2024-02-18T13:45:49ZbgmFormBuilder with relationship and custom field fields to encode correctly (5.70)Odd bug on 5.70/RC where it's generating afform markup that looks like:
```
<af-entity security="FBAC" type="Relationship"
name="Relationship2" label="Relation 2"
actions="{create: true, update: true}"
data="{contact_id_a: ['Indiv...Odd bug on 5.70/RC where it's generating afform markup that looks like:
```
<af-entity security="FBAC" type="Relationship"
name="Relationship2" label="Relation 2"
actions="{create: true, update: true}"
data="{contact_id_a: ['Individual1'], relationship_type_id: '13', "MyCustom.MyField": '1'}" />
```
This is a custom field on a relationship, that is used in the form. Because of the double-quotes around the MyCustom field, it's causing an AngualrJS syntax error.
To reproduce:
- Create a custom-group/field for Relationships
- Create a form that adds a relationship, and pre-selects a value for the custom field
![image](/uploads/04aa00dfd4def6189fe404ed6689ce91/image.png)
Save the form, then do a full page reload (sometimes it's not obvious at first). It will fail to load correctly, and JS errors in the console.
I can fix the syntax by manually editing the file, but then it creeps back when we do changes to the form.
For what it's worth, my test site is on PHP 8.0, and dmaster is on PHP 8.2.5.71.0colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/4974Event with no fees shows the fees section with just the word "Total" on the r...2024-02-07T22:37:29ZDaveDEvent with no fees shows the fees section with just the word "Total" on the register pageAnd says Undefined array key "quickConfig".
It doesn't affect registration, but is obviously wrong. In 5.71 caused by https://github.com/civicrm/civicrm-core/pull/29197 (yes the one I just merged 2 minutes ago - I figured it was better ...And says Undefined array key "quickConfig".
It doesn't affect registration, but is obviously wrong. In 5.71 caused by https://github.com/civicrm/civicrm-core/pull/29197 (yes the one I just merged 2 minutes ago - I figured it was better to get the waitlist fix in).5.71.0https://lab.civicrm.org/dev/core/-/issues/4973Credit card info not appearing on event confirm/thankyou page2024-02-08T09:56:27ZDaveDCredit card info not appearing on event confirm/thankyou pageAnd there's undefined array key errors about it.
I'm not sure when this started - it's not working in 5.69. Labelling as regression for now.And there's undefined array key errors about it.
I'm not sure when this started - it's not working in 5.69. Labelling as regression for now.5.69.5https://lab.civicrm.org/dev/core/-/issues/4970(regression) Extra receipt is sent when marking a contribution complete.2024-02-08T10:01:04ZJonGold(regression) Extra receipt is sent when marking a contribution complete.Overview
----------------------------------------
Starting in 5.69, changing a Pending contribution to Completed sends a receipt even if you choose not to.
Reproduction steps
----------------------------------------
1. Create a new pend...Overview
----------------------------------------
Starting in 5.69, changing a Pending contribution to Completed sends a receipt even if you choose not to.
Reproduction steps
----------------------------------------
1. Create a new pending contribution on the backend.
1. Click **Edit**.
1. Change the contribution to complete.
Current behaviour
----------------------------------------
If you don't select "Send Receipt", a receipt is sent.
If you *do* select "Send Receipt", 2 receipts are sent.
Expected behaviour
----------------------------------------
current situation minus 1.
Comments
----------------------------------------
The conversion from `transitionComponents()` to `Payment.create` is what occasioned this.5.69.5JonGoldJonGoldhttps://lab.civicrm.org/dev/core/-/issues/4968Can no longer edit status for a participant2024-02-07T18:56:07ZDaveDCan no longer edit status for a participant1. Register a participant. It doesn't happen with demo participants. Make a new participant.
2. Edit the participant and change status to e.g. Attended.
3. `ValueError: mysqli_query(): Argument 2 ($query) cannot be empty in mysqli_query(...1. Register a participant. It doesn't happen with demo participants. Make a new participant.
2. Edit the participant and change status to e.g. Attended.
3. `ValueError: mysqli_query(): Argument 2 ($query) cannot be empty in mysqli_query() (line 411 of /srv/buildkit/build/dmaster/web/sites/all/modules/civicrm/vendor/pear/db/DB/mysqli.php).`5.71.0https://lab.civicrm.org/dev/core/-/issues/4963(5.69 regression) Can't pay later on a membership price set2024-02-08T19:14:42ZJonGold(5.69 regression) Can't pay later on a membership price setIn 5.69, you can't select "Pay Later" for a membership price set. You get the warning "You cannot have auto-renewal on if you are paying later.", even when selecting a non-renewal option.
#### Steps to replicate
* On a demo site, chang...In 5.69, you can't select "Pay Later" for a membership price set. You get the warning "You cannot have auto-renewal on if you are paying later.", even when selecting a non-renewal option.
#### Steps to replicate
* On a demo site, change the "General" membership type to Auto-Renew required (reduce its membership term to 1 year also).
* Create a new price set with a single price field of type "Select".
* Provide both the General and Student options.
* Enable the price set on the membership contribution page, and enable "Pay Later".
* Select Student (which is *not* auto-renew), select "Pay Later", and attempt to submit.
I'm going to try to work on a fix, but I suspect #28871 or #28872 (or both) are the proximate cause. @eileen if something jumps out at you, let me know.5.70.0https://lab.civicrm.org/dev/core/-/issues/4962Resource URLs page doesn't load with Smarty32024-02-08T09:56:27ZJonGoldResource URLs page doesn't load with Smarty3Replicable on dmaster (and 5.69) by going to **Administer » System Settings » Resource URLs**.
Screen comes up mostly blank. This shows up in the PHP log.
```
PHP Warning: Undefined property: CRM_Admin_Form_Setting_Url::$_id in /home...Replicable on dmaster (and 5.69) by going to **Administer » System Settings » Resource URLs**.
Screen comes up mostly blank. This shows up in the PHP log.
```
PHP Warning: Undefined property: CRM_Admin_Form_Setting_Url::$_id in /home/jon/local/mysite/web/wp-content/plugins/civicrm/civicrm/CRM/Core/Form.php on line 2087"
PHP message: PHP Fatal error: Type of SmartyCompilerException::$line must be int (as in class Exception) in /home/jon/local/mysite/web/wp-content/plugins/civicrm/civicrm/packages/smarty3/vendor/smarty/smarty/libs/sysplugins/smartycompilerexception.php on line 8"
```5.69.5https://lab.civicrm.org/dev/core/-/issues/4960Regression: 5.70 active relationships not loading when Civi Case not enabled2024-02-03T02:54:13ZElliott EgglestonRegression: 5.70 active relationships not loading when Civi Case not enabledDisable CiviCase and navigate to a summary screen contact with relationships. In the tab list the Relationships tab is missing the count that shows up when CiviCase is enabled. If you click onto the tab you see the disabled relationships...Disable CiviCase and navigate to a summary screen contact with relationships. In the tab list the Relationships tab is missing the count that shows up when CiviCase is enabled. If you click onto the tab you see the disabled relationships but no enabled relationships load.
In the browser console you can see the following:
Post to https://dmaster.localhost:32353/civicrm/ajax/api4
with payload '{"run":["SearchDisplay","run",{"return":"page:1","savedSearch":"Contact_Summary_Relationships","display":"Contact_Summary_Relationships_Active","sort":{},"limit":50,"seed":1706885943746,"filters":{"near_contact_id":161,"is_current":true},"afform":"afsearchTabRel"}]}'
Comes back with 500 error
Object { error_code: 0, error_message: "API (Case, getLinks) does not exist (or the extension it belongs to is not enabled).", status: 500 }5.70.0https://lab.civicrm.org/dev/core/-/issues/4954Upgrade to Smarty4....2024-03-15T21:05:34ZeileenUpgrade to Smarty4....Now that we have upgraded many sites to Smarty3 & seem close to ironing out the issues I had a go at Smarty4 and was able to get it working. The extra fixes were entirely in our core compatibility layer so the challenges of moving a site...Now that we have upgraded many sites to Smarty3 & seem close to ironing out the issues I had a go at Smarty4 and was able to get it working. The extra fixes were entirely in our core compatibility layer so the challenges of moving a site from Smarty2 to Smarty4 are now equivalent to moving to Smarty3.
https://smarty-php.github.io/smarty/5.x/upgrading/#removed-php-constants
One annoying thing we did was name our Smarty mixin & the define in a version specific way. In fact there is nothing v2 specific about our mixin and the methodology of defining ` CIVICRM_SMARTY3_AUTOLOAD_PATH` works for Smarty4 as well as it does for Smarty3. If it wasn't for those naming issues I would recommend we simply replace the contents of packages/smarty3 with the Smarty 4 library.
However, given where we are I recommend we
1) merge Smarty4 into packages here https://github.com/civicrm/civicrm-packages/pull/380
2) add a new define `CIVICRM_SMARTY_AUTOLOAD_PATH` - respect it but fall back to `CIVICRM_SMARTY3_AUTOLOAD_PATH` if present
3) update our demo sites / build sites etc to Smarty4
4) update all our messaging to encourage people to use Smarty4 not 3 (but if they have already switched to 3 don't further message as being off Smarty2 is enough to flush out any extension or issues that would impede our medium term plans to put Smarty4 in vendor & stop shipping Smarty3
Note that Smarty4 hard-fails on `{php}` tags in tpls whereas Smarty3 has a backwards compatibility layer that would have supported it, had we chosen to enable it, which we didn't.5.72.0https://lab.civicrm.org/dev/core/-/issues/4953On a membership renewal, the member's existing membership is not preselected.2024-02-15T23:04:06ZrobbrandtOn a membership renewal, the member's existing membership is not preselected.After testing this with #4939, the issue still exists.
Our use case is with a membership price set, using a Select field type.
To replicate at the dmaster.demo.civicrm.org site, create a Membership Price Set, with one field. The field...After testing this with #4939, the issue still exists.
Our use case is with a membership price set, using a Select field type.
To replicate at the dmaster.demo.civicrm.org site, create a Membership Price Set, with one field. The field should be a Select type, and each of the 3 membership types should be added. Then change the existing Membership contribution page to use this price set rather than the manually entered one. Open the Live version of the contribution page, and sign up for any of the membership types and complete the transaction. Then go back to the live version of the contribution page and observe that the user's existing membership is not preselected.5.69.5https://lab.civicrm.org/dev/core/-/issues/4951Event registration under Windows fails2024-02-08T10:22:24ZspalmstromEvent registration under Windows fails## Overview
_This is similar to_ https://lab.civicrm.org/dev/core/-/issues/4928, but a different problem. See also Stack Exchange [smarty - Is it the end of the road for CiviCRM under Windows? - CiviCRM Stack Exchange](https://civicrm.s...## Overview
_This is similar to_ https://lab.civicrm.org/dev/core/-/issues/4928, but a different problem. See also Stack Exchange [smarty - Is it the end of the road for CiviCRM under Windows? - CiviCRM Stack Exchange](https://civicrm.stackexchange.com/questions/46268/is-it-the-end-of-the-road-for-civicrm-under-windows?noredirect=1#comment55844_46268) and [registration - Fatal error - unable to register for events with Smarty3 enabled - CiviCRM Stack Exchange](https://civicrm.stackexchange.com/questions/46311/fatal-error-unable-to-register-for-events-with-smarty3-enabled). I wonder if it is an issue with the use of Smarty3.
The final Register page crashes with:
```plaintext
The website encountered an unexpected error. Try again later.TypeError: Unsupported operand types: float + string in content_65ba5d1bd929c5_86413884() (line 408 of <drupal root>\vendor\civicrm\civicrm-packages\smarty3\vendor\smarty\smarty\libs\sysplugins\smarty_resource_recompiled.php(52) : eval()'d code).
```
followed by the stack trace.\`\`\`
## Reproduction steps
1. Register for an event.
2. Click on Review
3. Click on Register.
## Current behaviour
The web page returns:
```plaintext
The website encountered an unexpected error. Try again later.
TypeError: Unsupported operand types: float + string in content_65ba5d1bd929c5_86413884() (line 408 of <drupal root>\vendor\civicrm\civicrm-packages\smarty3\vendor\smarty\smarty\libs\sysplugins\smarty_resource_recompiled.php(52) : eval()'d code).
Smarty_Template_Resource_Base->getRenderedTemplateCode() (Line: 114)
Smarty_Template_Compiled->render() (Line: 216)
Smarty_Internal_Template->render() (Line: 232)
Smarty_Internal_TemplateBase->_execute() (Line: 116)
Smarty_Internal_TemplateBase->fetch() (Line: 24)
content_65ba5c676ca3f2_96523772() (Line: 123)
Smarty_Template_Resource_Base->getRenderedTemplateCode() (Line: 114)
Smarty_Template_Compiled->render() (Line: 216)
Smarty_Internal_Template->render() (Line: 232)
Smarty_Internal_TemplateBase->_execute() (Line: 116)
Smarty_Internal_TemplateBase->fetch() (Line: 1046)
CRM_Utils_String::parseOneOffStringThroughSmarty() (Line: 108)
Civi\Token\TokenCompatSubscriber->onRender() (Line: 220)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 263)
Civi\Core\CiviEventDispatcher->dispatch() (Line: 397)
Civi\Token\TokenProcessor->render() (Line: 327)
Civi\Token\TokenRow->render() (Line: 67)
CRM_Core_TokenSmarty::render() (Line: 374)
CRM_Core_BAO_MessageTemplate::renderTemplateRaw() (Line: 422)
CRM_Core_BAO_MessageTemplate::sendTemplate() (Line: 1254)
CRM_Event_BAO_Event::sendMail() (Line: 895)
CRM_Event_Form_Registration_Confirm->postProcess() (Line: 625)
CRM_Core_Form->mainProcess() (Line: 144)
CRM_Core_StateMachine->perform() (Line: 43)
CRM_Core_QuickForm_Action_Next->perform() (Line: 203)
HTML_QuickForm_Controller->handle() (Line: 103)
HTML_QuickForm_Page->handle() (Line: 355)
CRM_Core_Controller->run() (Line: 322)
CRM_Core_Invoke::runItem() (Line: 69)
CRM_Core_Invoke::_invoke() (Line: 36)
CRM_Core_Invoke::invoke() (Line: 88)
Drupal\civicrm\Civicrm->invoke() (Line: 83)
Drupal\civicrm\Controller\CivicrmController->main()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 704)
Drupal\Core\DrupalKernel->handle() (Line: 19)
```
## Expected behaviour
A registration confirmation page is displayed.
## Environment information
* **Browser:** _Edge_ but probably irrelevant.
* **CiviCRM:** _5.69.3_
* **PHP:** _8.3.1_ but probably irrelevant.
* **CMS:** _Drupal 10.2.2_
* **Database:** _MySQL 8.0.36_ but probably irrelevant.
* **Web Server:** _IIS 10_
## Comments
_Anything else you would like the reviewer to note._
I have tried debugging the issue and spent quite some time on this. I raising it as an issue as my knowledge of Smarty isn't that great, but I hope a Smarty expert has better insight.
I think the issue is due to Smarty creating a template 'on the fly' rather than using a text file template. In the call stack, there is
CRM_Utils_String::parseOneOffStringThroughSmarty() (Line: 108) which passes `plaintext 'eval:{eval var=$smartySingleUseString|smarty:nodefaults}'`.
Incidentally, the line numbers on the call stack are strange, they seem out by one entity - `plaintext CRM_Utils_String::parseOneOffStringThroughSmarty() (Line: 108)` is actually line 1046 which is in the line above.
It seems that the system is calling some epheremal code which we can't see. The NetBeans call stack has transient entries like: ![image](/uploads/3a4859a5ff1b41a1152677863bfa1713/image.png)
You are able to step through the entity beginning with dbgp:// but cannot see the code. I have been unable to find content_65ba5d1bd929c5_86413884() during debugging, let alone see line 408. This makes debugging rather difficult. If one could see the template it was trying to process, it would help.5.69.5https://lab.civicrm.org/dev/core/-/issues/4950Acivity tab timing out after 5.70 upgrade on large DB2024-02-08T19:14:09ZElliott EgglestonAcivity tab timing out after 5.70 upgrade on large DBThe admin_ui version of the activity tab is generating queries for some CIDs that don't return in a reasonable amount of time. EXPLAIN shows that filesort is being used for the first subquery.
One example query, generated for a contact ...The admin_ui version of the activity tab is generating queries for some CIDs that don't return in a reasonable amount of time. EXPLAIN shows that filesort is being used for the first subquery.
One example query, generated for a contact with only 18 activities: https://phabricator.wikimedia.org/P55961
Wikimedia's tracking task, with the SQL query explain: https://phabricator.wikimedia.org/T356269
Oddly, I WAS able to load the activities tab for my own user which has 700+ activities, so it's not just related to the number of activities on a contact.
If I just roll back 04078d359e298a5a02ea274404dcdb8af83225dd it restores the previous activity tab and I can load the CID's activity tab fine with no runaway query generated.5.70.0colemanwcolemanwhttps://lab.civicrm.org/dev/core/-/issues/4948v5.69.3 Receipt message not included in email2024-03-01T00:05:46ZBillCatherallv5.69.3 Receipt message not included in email## Overview
v5.69.3 (WordPress) the Additional Receipt Message sent out with contribution receipts is no longer included in the email message. It was working in v5.68.0, but after upgrading it doesn't get included in emails.
## Reprodu...## Overview
v5.69.3 (WordPress) the Additional Receipt Message sent out with contribution receipts is no longer included in the email message. It was working in v5.68.0, but after upgrading it doesn't get included in emails.
## Reproduction steps
1. Manage Contribution Pages, Receipt tab, Receipt Message.
2. It's filled in with the text we include in the receipt email.
3. Actual emails sent do not include this message.
## Current behavior
No error message. Emails are sent and payment information is included in the emails. But the additional message is not included.
## Expected behavior
Before the update the message was included in the email above the payment information.
## Environment information
* **CiviCRM:** _5.69.3_
* **PHP:** _8.1.25_
* **CMS:** _WordPress 6.4.2_5.69.5https://lab.civicrm.org/dev/core/-/issues/4945Regressions: v5.69.2 Radio Buttons default option not applying on load2024-02-08T10:39:44ZJonny ToomeyRegressions: v5.69.2 Radio Buttons default option not applying on loadOverview
----------------------------------------
When adding a radio button type question to a form, the selected default option no longer applied to the form
Steps to replicate
----------------------------------------
Create new Cust...Overview
----------------------------------------
When adding a radio button type question to a form, the selected default option no longer applied to the form
Steps to replicate
----------------------------------------
Create new Custom field or type radio button and set an option to default. Add the newly created custom field to a profile which is assigned to a contribution form. Upon viewing the form the radio buttons will not have a default selected
Issue replicated on test system (version 5.71.alpha1)
![radio_0](/uploads/1df8c2ef5600782c74ab1eca64572ec0/radio_0.PNG)
![radio_1](/uploads/422ccdae76683fbcf73faecad9e116cd/radio_1.PNG)
Default option works fine on field preview
![radio_preview](/uploads/c2216861c2bdebd9f4e99bf7ef4ea7fe/radio_preview.PNG)5.69.5https://lab.civicrm.org/dev/core/-/issues/4943Activity count on contact tab is always including case activities2024-01-29T13:29:26ZDaveDActivity count on contact tab is always including case activitiesRelated: https://lab.civicrm.org/dev/core/-/issues/4930Related: https://lab.civicrm.org/dev/core/-/issues/49305.70.0https://lab.civicrm.org/dev/core/-/issues/4942Event confirmation page is a bit messed up2024-02-06T15:14:43ZDaveDEvent confirmation page is a bit messed upIn master. Followup to #4918.
1. If you don't have a limit on max participants, the confirmation page gives you an error saying there are only 0 spaces left and you can't finish registering.
2. With a waitlist, you can't register since ...In master. Followup to #4918.
1. If you don't have a limit on max participants, the confirmation page gives you an error saying there are only 0 spaces left and you can't finish registering.
2. With a waitlist, you can't register since it just keeps taking you back to the register page.5.71.0https://lab.civicrm.org/dev/core/-/issues/4941Number field input validation does not respect decimal separator setting (eve...2024-02-12T17:14:12ZDetlev SieberNumber field input validation does not respect decimal separator setting (event custom field)## Overview
This is a variant of https://lab.civicrm.org/dev/core/-/issues/4154, regarding custom fields for events of type _This iPlease describe your problem or bug in detail._
_If you have already posted on __https://civicrm.stackex...## Overview
This is a variant of https://lab.civicrm.org/dev/core/-/issues/4154, regarding custom fields for events of type _This iPlease describe your problem or bug in detail._
_If you have already posted on __https://civicrm.stackexchange.com__ or __https://chat.civicrm.org__, please include the link to that conversation._
## Reproduction steps
1. Under Administer \> Localization \> Languages, Currency, Locations, set "Thousands Separator" to "." (dot) and "Decimal Delimiter" to "," (comma).
2. Create a custom field extending Events. Data type: Number.
3. Edit an existing event (or: add a new event). In the number field, enter a number that includes a comma, such as "1,5".
4. Press Save: nothing happens
5. Reload page: Error message appears "**Error One of parameters (value: 1,5) is not of the type Float**"
## Current behaviour
Validation fails with the error message "**Error One of parameters (value: 1,5) is not of the type Float**"
## Expected behaviour
Validation should not fail for decimal numbers with decimal separator ","
## Environment information
* **CiviCRM:** 5.69.3
* **PHP:** 7,4, 8.1
* **CMS:** Drupal, WordPress
## Comments
This bug was fixed for some fields with #4154 (https://github.com/civicrm/civicrm-core/pull/28369)
Also, I believe this is some kind of regression, because in a system of one of my clients, this did work \~15 months ago. However, tbh I have no clear idea when it broke. (and still, it cannot completely excluded that the existing data was entered with decimal separator ".")5.71.0https://lab.civicrm.org/dev/core/-/issues/4939Logged in user who has an existing membership is not seeing this mentioned on...2024-02-01T01:29:08ZpetednzLogged in user who has an existing membership is not seeing this mentioned on a Membership pagePREVIOUS
If logged in/checksum user who has a membership visits a membership page offering that Membership Type they were greeted with "Your XX Membership expires on YY"
CURRENT
Replicated on dmaster - no such message is showingPREVIOUS
If logged in/checksum user who has a membership visits a membership page offering that Membership Type they were greeted with "Your XX Membership expires on YY"
CURRENT
Replicated on dmaster - no such message is showing5.69.4https://lab.civicrm.org/dev/core/-/issues/4938Saving a civireport causes the report to crash with `TypeError: Cannot access...2024-01-27T04:53:42ZDaveDSaving a civireport causes the report to crash with `TypeError: Cannot access offset of type string on string in HTML_QuickForm_advmultiselect->toHtml`1. Edit some settings on a civireport.
2. Save the civireport.
3. TypeError: Cannot access offset of type string on string in HTML_QuickForm_advmultiselect->toHtml() (line 807 of ...\sites\all\modules\civicrm\packages\HTML\QuickForm\advm...1. Edit some settings on a civireport.
2. Save the civireport.
3. TypeError: Cannot access offset of type string on string in HTML_QuickForm_advmultiselect->toHtml() (line 807 of ...\sites\all\modules\civicrm\packages\HTML\QuickForm\advmultiselect.php).
There is no stacktrace so I'm not sure yet what it doesn't like.5.70.0