CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-06-20T20:41:20Zhttps://lab.civicrm.org/dev/core/-/issues/151Action to Update Recurring Contributions From Membership View is Never Shown2018-06-20T20:41:20ZCamilo RodrÃguezAction to Update Recurring Contributions From Membership View is Never Shown## Overview
The table added to view recurring contributions form the membership details view (https://lab.civicrm.org/dev/core/issues/38) was never showing the 'Edit' action. The table shown when looking at recurring contributions from w...## Overview
The table added to view recurring contributions form the membership details view (https://lab.civicrm.org/dev/core/issues/38) was never showing the 'Edit' action. The table shown when looking at recurring contributions from within a membership should behave exactly as the table shown on a contact's **Contributions** tab.
## How it Works Currently
The table added to view recurring contributions form the membership details view was never showing the 'Edit' action, even though the user had all necessary permissions.
## How it Should Work
If the 'Edit' action is shown on the list of recurring contributions of a contact on **Contributions** tab, it should also be available on the list shown within a membership.
## Comments
Related to change introduced in #385.4.0https://lab.civicrm.org/dev/core/-/issues/47Add "clone" functionality to scheduled jobs2018-06-17T23:18:56Zmattwiremjw@mjwconsult.co.ukAdd "clone" functionality to scheduled jobsThis adds a "clone" or "copy" function to the scheduled jobs page. It is implemented as an API (job.clone) which can be called via a link from the scheduled jobs listing.
Ref https://github.com/civicrm/civicrm-core/pull/11945This adds a "clone" or "copy" function to the scheduled jobs page. It is implemented as an API (job.clone) which can be called via a link from the scheduled jobs listing.
Ref https://github.com/civicrm/civicrm-core/pull/119455.4.0https://lab.civicrm.org/dev/core/-/issues/140Add missing pseudoconstant for option_group_id in CustomField2018-11-04T20:40:17ZMichael McAndrewAdd missing pseudoconstant for option_group_id in CustomFieldPseudoconstant tag was missing from the XML definition, meaning that one could not create custom fields and specify their select options without knowing the numerical ID.Pseudoconstant tag was missing from the XML definition, meaning that one could not create custom fields and specify their select options without knowing the numerical ID.5.4.0https://lab.civicrm.org/dev/core/-/issues/32Add option to disable cancel button on a profile form2023-04-28T01:39:33ZjitendraAdd option to disable cancel button on a profile formWhile setting up "subscribe" and "contact us" forms for a site, the default behaviour for a wordpress profile form of type "create" embedded via a shortcode is to show a cancel button.
This isn't really necessary for a single page form...While setting up "subscribe" and "contact us" forms for a site, the default behaviour for a wordpress profile form of type "create" embedded via a shortcode is to show a cancel button.
This isn't really necessary for a single page form with no existing data in it - but there doesn't appear to be a way to disable it.5.4.0https://lab.civicrm.org/dev/core/-/issues/3579Add pause/resume functionality to civicrm bulk mailing.2022-06-11T14:54:43ZjitendraAdd pause/resume functionality to civicrm bulk mailing.Scenario
Site admin is sending out a big blast but want to send out a press release without waiting for first job to end.Scenario
Site admin is sending out a big blast but want to send out a press release without waiting for first job to end.5.4.0https://lab.civicrm.org/dev/core/-/issues/101Allow further customization of search form in hooks2018-06-18T20:13:57ZmichaelAllow further customization of search form in hooksThe contact search form uses the template `templates/CRM/Contact/Form/Search/Criteria/Basic.tpl`. In the template there are already some conditionals to hide certain fields, such as
```
{if $form.group}
<td>
...
{/if}
```
However o...The contact search form uses the template `templates/CRM/Contact/Form/Search/Criteria/Basic.tpl`. In the template there are already some conditionals to hide certain fields, such as
```
{if $form.group}
<td>
...
{/if}
```
However only some fields are covered. For an extension developer who wants to hide more fields here it is difficult without causing warnings or breaking the layout.
It is now possible to override the fields on the basic search template by altering the fields array assigned to the template in a hook
---
Core PR: https://github.com/civicrm/civicrm-core/pull/120785.4.0https://lab.civicrm.org/dev/core/-/issues/56Cancel Recurring Contribution activity should has a source record id2018-06-18T20:14:06ZscardiniusCancel Recurring Contribution activity should has a source record idMethod `CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution()` creates new activity with type "Cancel Recurring Contribution". Field source_record_id should contains id of recurring contribution but it doesn't
```php
// curren...Method `CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution()` creates new activity with type "Cancel Recurring Contribution". Field source_record_id should contains id of recurring contribution but it doesn't
```php
// current, invalid
'source_record_id' => CRM_Utils_Array::value('source_record_id', $activityParams),
// fixed
'source_record_id' => $dao->recur_id,
```
https://github.com/civicrm/civicrm-core/blob/9a05ea5249f290bd92f813cfdb301b03b8186007/CRM/Contribute/BAO/ContributionRecur.php#L2855.4.0https://lab.civicrm.org/dev/core/-/issues/249Contact Export fails in 5.4 when trying to export using the All radio button2018-07-12T22:29:35ZseamusleeContact Export fails in 5.4 when trying to export using the All radio buttonAs per https://chat.civicrm.org/civicrm/pl/a8myronnftgt8mcehfa8ohcnbo when using the all contacts radio button to do an export the export fails in 5.4As per https://chat.civicrm.org/civicrm/pl/a8myronnftgt8mcehfa8ohcnbo when using the all contacts radio button to do an export the export fails in 5.45.4.0https://lab.civicrm.org/dev/core/-/issues/50Create Sub-tabs Under Contributions Tab for Contributions and Recurring Contr...2018-06-18T20:13:42ZCamilo RodrÃguezCreate Sub-tabs Under Contributions Tab for Contributions and Recurring Contributions## Overview
Currently, when viewing contributions on a contact's summary view, there are two tables being shown: one for contributions, the second for recurring contributions. The problem is when a contact has a lot of contributions, rec...## Overview
Currently, when viewing contributions on a contact's summary view, there are two tables being shown: one for contributions, the second for recurring contributions. The problem is when a contact has a lot of contributions, recurring contributions kind of get lost within the page, having to scroll down quite a bit to get to the required information. We'd like to have two subtabs within the contributions tab, so that we can choose either contributions or recurring contributions as needed. Furthermore, we'd also like to separate active from inactive recurring contributions within the recurring contributions tab, to have easier access to the information that is most likely to be needed.
## How it Works Currently
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Two tables are shown: first, contributions, and after it, recurring contributions.
## How it Should Work
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Two subtabs are shown within the page, one for contributions, the second for recurring contributions.
4. Contributions tab is selected by default, showing the contributions table.
5. Clicking on the recurring contributions tab shows two recurring contributions tables, the first one for active contributions, the second for inactive contributions.
## Acceptance Criteria
* Loading **Contributions** tab shows two subtabs, **Contributions** and **Recurring Contributions**.
* **Contributions** subtab is loaded by default.
* **Recurring Contributions** subtab has two tables, one for active contributions, the other one for inactive contributions.5.4.0https://lab.civicrm.org/dev/core/-/issues/203Cruft code in CRM_Core_BAO_OptionGroup::add()2018-06-23T02:30:00ZPradeep Nayakpradpnayak@gmail.comCruft code in CRM_Core_BAO_OptionGroup::add()PR at https://github.com/civicrm/civicrm-core/pull/12357/filesPR at https://github.com/civicrm/civicrm-core/pull/12357/files5.4.0https://lab.civicrm.org/dev/core/-/issues/202Empty row under currency drop down2018-08-20T15:21:29ZPradeep Nayakpradpnayak@gmail.comEmpty row under currency drop downThis is something i noticed on drupal7, CiviCRM 5.2.1 fresh install where i don't have default currency set under(Settings - Localization). The currency field on New Contribution and elsewhere shows an empty option as attached in screens...This is something i noticed on drupal7, CiviCRM 5.2.1 fresh install where i don't have default currency set under(Settings - Localization). The currency field on New Contribution and elsewhere shows an empty option as attached in screenshot
![Before](/uploads/672ac199ab60d3763a20d1c5968616b9/Before.png)
PR at https://github.com/civicrm/civicrm-core/pull/123565.4.0https://lab.civicrm.org/dev/core/-/issues/96Expose source column in booking report2018-06-29T18:52:04ZyashodhaExpose source column in booking reportExpose source column in booking report and as filter as well.Expose source column in booking report and as filter as well.5.4.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/187Fix typo in CRM_Grant_Form_Task that prevents retrieving session key from URL2018-06-21T21:41:15Zmattwiremjw@mjwconsult.co.ukFix typo in CRM_Grant_Form_Task that prevents retrieving session key from URLOverview
----------------------------------------
Identified during investigation for dev/core#158
Before
----------------------------------------
Cannot retrieve session key for Grant form task.
After
---------------------------------...Overview
----------------------------------------
Identified during investigation for dev/core#158
Before
----------------------------------------
Cannot retrieve session key for Grant form task.
After
----------------------------------------
Session key for Grant form task is retrieved just like all other tasks.
Technical Details
----------------------------------------
The wrong object was being used in static context ($this instead of $form).5.4.0https://lab.civicrm.org/dev/core/-/issues/118Fix where count() is used on an object that isn't an array nor implements Cou...2018-12-19T14:11:24ZseamusleeFix where count() is used on an object that isn't an array nor implements Countable for php7.2 (tested instances)```
<error type="PHPUnit_Framework_Error_Warning">CRM_Contribute_Import_Parser_ContributionTest::testImportParserWithSoftCreditsByExternalIdentifier with data set #0 ('.')
count(): Parameter must be an array or an object that...```
<error type="PHPUnit_Framework_Error_Warning">CRM_Contribute_Import_Parser_ContributionTest::testImportParserWithSoftCreditsByExternalIdentifier with data set #0 ('.')
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php:67
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
</testcase>
<testcase name="testImportParserWithSoftCreditsByExternalIdentifier with data set #1" assertions="8" time="0.685860">
<error type="PHPUnit_Framework_Error_Warning">CRM_Contribute_Import_Parser_ContributionTest::testImportParserWithSoftCreditsByExternalIdentifier with data set #1 (',')
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Import/Parser/ContributionTest.php:67
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgePaymentTest::testRetrieveZeroPledeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php:100
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgePaymentTest::testRetrieveStringPledgeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php:113
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgePaymentTest::testRetrieveKnownPledgeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php:127
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgePaymentTest::testDeletePledgePaymentsNormal
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php:137
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgePaymentTest::testDeletePledgePaymentsNullId
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgePaymentTest.php:160
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgeTest::testRetrieveZeroPledeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php:106
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
</testcase>
<testcase name="testRetrieveStringPledgeID" class="CRM_Pledge_BAO_PledgeTest" file="/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php" line="112" assertions="1" time="0.143334">
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgeTest::testRetrieveStringPledgeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php:117
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
</testcase>
<testcase name="testRetrieveKnownPledgeID" class="CRM_Pledge_BAO_PledgeTest" file="/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php" line="123" assertions="1" time="0.165138">
<error type="PHPUnit_Framework_Error_Warning">CRM_Pledge_BAO_PledgeTest::testRetrieveKnownPledgeID
count(): Parameter must be an array or an object that implements Countable
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php:147
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
</testcase>
<testcase name="testGetPledgeStartDate" class="CRM_Pledge_BAO_PledgeTest" file="/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php" line="153" assertions="1" time="0.149295">
<error type="PHPUnit_Framework_Error_Deprecated">CRM_Pledge_BAO_PledgeTest::testGetPledgeStartDate
The each() function is deprecated. This message will be suppressed on further calls
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/CRM/Pledge/BAO/Pledge.php:1203
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CRM/Pledge/BAO/PledgeTest.php:163
/home/seamus/buildkit/build/47.demo/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:182
/home/seamus/buildkit/bin/phpunit5:598
</error>
```
ping @eileen @monish.deb5.4.0https://lab.civicrm.org/dev/core/-/issues/144getCustomFieldID switch to API, add caching, add full string return option2018-06-17T23:18:27Zmattwiremjw@mjwconsult.co.ukgetCustomFieldID switch to API, add caching, add full string return optionIn most of my extensions I implement something like this: https://github.com/mattwire/uk.co.mjwconsult.recurmaster/blob/master/CRM/Recurmaster/Utils.php#L14
Because I want the lookup to be cached so I can use it multiple times without a...In most of my extensions I implement something like this: https://github.com/mattwire/uk.co.mjwconsult.recurmaster/blob/master/CRM/Recurmaster/Utils.php#L14
Because I want the lookup to be cached so I can use it multiple times without a performance issue (eg. within hooks). It is also useful to be able to return the full string equivalent (ie. custom_123 instead of 123) as it can then be used directly in parameter arrays like `$key = getCustomFieldID()` without doing: `$key = 'custom_' . getCustomFieldID()`
This is a proposal to update the core function getCustomFieldID so that it is more useful. It should also help towards https://lab.civicrm.org/dev/core/issues/1095.4.0https://lab.civicrm.org/dev/core/-/issues/222Importing contacts with dedupe rule does not use the rule2018-07-02T20:41:13ZscardiniusImporting contacts with dedupe rule does not use the ruleImporting contacts with dedupe rule does not use the rule because of invalid call to getDuplicateContacts() method
## how to reproduce
* open *Import Contacts* page
* choose csv file with contact with name and address already exists in...Importing contacts with dedupe rule does not use the rule because of invalid call to getDuplicateContacts() method
## how to reproduce
* open *Import Contacts* page
* choose csv file with contact with name and address already exists in db
* fill the form with *Dedupu rule* = **Name and Address (reserved) - General**
* ...several steps later ;-) at the end of importing you have additional contact with the same name and address
## technical aspect
```php
// current, invalid call
$ids = CRM_Contact_BAO_Contact::getDuplicateContacts($params, $params['contact_type'], 'Unsupervised', array(), CRM_Utils_Array::value('check_permissions', $params, $dedupeRuleGroupID));
// fixed
$ids = CRM_Contact_BAO_Contact::getDuplicateContacts($params, $params['contact_type'], 'Unsupervised', array(), CRM_Utils_Array::value('check_permissions', $params), $dedupeRuleGroupID);
```5.4.0https://lab.civicrm.org/dev/core/-/issues/88Make sure financial_type_id is set when a contribution is created2018-06-18T20:13:30Zmattwiremjw@mjwconsult.co.ukMake sure financial_type_id is set when a contribution is createdOverview
----------------------------------------
When a contribution is created via a contribution page (with a confirmation page) the parameter `financial_type_id` is not set if the contribution is not being created with a recurring co...Overview
----------------------------------------
When a contribution is created via a contribution page (with a confirmation page) the parameter `financial_type_id` is not set if the contribution is not being created with a recurring contribution.
PR: https://github.com/civicrm/civicrm-core/pull/11907
Before
----------------------------------------
`financial_type_id` is not set when a non-recurring contribution is submitted via a contribution page (with a confirmation page). But it is set when a recurring contribution is being created at the same time.
After
----------------------------------------
`financial_type_id` is always set for contribution params when submitted via a contribution page (with a confirmation page).
This makes it more consistent for use in payment processor extensions etc.5.4.0https://lab.civicrm.org/dev/core/-/issues/258Possible unreleased regression - message template update altered customised t...2018-07-18T22:12:09ZeileenPossible unreleased regression - message template update altered customised templateOn the site that I have upgraded to 5.4 I found my template customisations were gone. The upgrade code should only update the default template and templates in use that are the same as the default (I need to test further as it's conceiva...On the site that I have upgraded to 5.4 I found my template customisations were gone. The upgrade code should only update the default template and templates in use that are the same as the default (I need to test further as it's conceivable my defaults had been updated in error)5.4.0https://lab.civicrm.org/dev/core/-/issues/177Redis driver - Reports incorrect value for cache-miss2018-06-17T23:17:42ZtottenRedis driver - Reports incorrect value for cache-miss`CRM_Utils_Cache_Interface::get()` specifies that the return value for a non-existent cache-key is `NULL`. But `CRM_Utils_Cache_Redis::get()` returns `FALSE`. This makes it impossible to detect a cache-miss.`CRM_Utils_Cache_Interface::get()` specifies that the return value for a non-existent cache-key is `NULL`. But `CRM_Utils_Cache_Redis::get()` returns `FALSE`. This makes it impossible to detect a cache-miss.5.4.0https://lab.civicrm.org/dev/core/-/issues/124Registration approval issues2018-06-17T23:18:36Zaydunsaidan.saunders@squiffle.ukRegistration approval issuesFor events requiring approval:
1) The confirmation screen generates a warning:
`Warning: A non-numeric value encountered in XXX/civicrm/CRM/Event/Form/Registration/Confirm.php on line 262`
2) The pre-approval confirmation and post-appr...For events requiring approval:
1) The confirmation screen generates a warning:
`Warning: A non-numeric value encountered in XXX/civicrm/CRM/Event/Form/Registration/Confirm.php on line 262`
2) The pre-approval confirmation and post-approval confirmation emails both have the subject 'Registration Confirmation' which is confusing to recipients.
3) The pre-approval confirmation mail includes a Fees section which shows fees of 0 since the fees have not been selected at this stage. So it would be better to remove the Fees section from the pre-approval confirmation (but not the post-approval confirmation)5.4.0aydunsaidan.saunders@squiffle.ukaydunsaidan.saunders@squiffle.uk