CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-06-29T18:52:04Zhttps://lab.civicrm.org/dev/core/-/issues/96Expose source column in booking report2018-06-29T18:52:04ZyashodhaExpose source column in booking reportExpose source column in booking report and as filter as well.Expose source column in booking report and as filter as well.5.4.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/88Make sure financial_type_id is set when a contribution is created2018-06-18T20:13:30Zmattwiremjw@mjwconsult.co.ukMake sure financial_type_id is set when a contribution is createdOverview
----------------------------------------
When a contribution is created via a contribution page (with a confirmation page) the parameter `financial_type_id` is not set if the contribution is not being created with a recurring co...Overview
----------------------------------------
When a contribution is created via a contribution page (with a confirmation page) the parameter `financial_type_id` is not set if the contribution is not being created with a recurring contribution.
PR: https://github.com/civicrm/civicrm-core/pull/11907
Before
----------------------------------------
`financial_type_id` is not set when a non-recurring contribution is submitted via a contribution page (with a confirmation page). But it is set when a recurring contribution is being created at the same time.
After
----------------------------------------
`financial_type_id` is always set for contribution params when submitted via a contribution page (with a confirmation page).
This makes it more consistent for use in payment processor extensions etc.5.4.0https://lab.civicrm.org/dev/core/-/issues/56Cancel Recurring Contribution activity should has a source record id2018-06-18T20:14:06ZscardiniusCancel Recurring Contribution activity should has a source record idMethod `CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution()` creates new activity with type "Cancel Recurring Contribution". Field source_record_id should contains id of recurring contribution but it doesn't
```php
// curren...Method `CRM_Contribute_BAO_ContributionRecur::cancelRecurContribution()` creates new activity with type "Cancel Recurring Contribution". Field source_record_id should contains id of recurring contribution but it doesn't
```php
// current, invalid
'source_record_id' => CRM_Utils_Array::value('source_record_id', $activityParams),
// fixed
'source_record_id' => $dao->recur_id,
```
https://github.com/civicrm/civicrm-core/blob/9a05ea5249f290bd92f813cfdb301b03b8186007/CRM/Contribute/BAO/ContributionRecur.php#L2855.4.0https://lab.civicrm.org/dev/core/-/issues/50Create Sub-tabs Under Contributions Tab for Contributions and Recurring Contr...2018-06-18T20:13:42ZCamilo RodrÃguezCreate Sub-tabs Under Contributions Tab for Contributions and Recurring Contributions## Overview
Currently, when viewing contributions on a contact's summary view, there are two tables being shown: one for contributions, the second for recurring contributions. The problem is when a contact has a lot of contributions, rec...## Overview
Currently, when viewing contributions on a contact's summary view, there are two tables being shown: one for contributions, the second for recurring contributions. The problem is when a contact has a lot of contributions, recurring contributions kind of get lost within the page, having to scroll down quite a bit to get to the required information. We'd like to have two subtabs within the contributions tab, so that we can choose either contributions or recurring contributions as needed. Furthermore, we'd also like to separate active from inactive recurring contributions within the recurring contributions tab, to have easier access to the information that is most likely to be needed.
## How it Works Currently
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Two tables are shown: first, contributions, and after it, recurring contributions.
## How it Should Work
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Two subtabs are shown within the page, one for contributions, the second for recurring contributions.
4. Contributions tab is selected by default, showing the contributions table.
5. Clicking on the recurring contributions tab shows two recurring contributions tables, the first one for active contributions, the second for inactive contributions.
## Acceptance Criteria
* Loading **Contributions** tab shows two subtabs, **Contributions** and **Recurring Contributions**.
* **Contributions** subtab is loaded by default.
* **Recurring Contributions** subtab has two tables, one for active contributions, the other one for inactive contributions.5.4.0https://lab.civicrm.org/dev/core/-/issues/47Add "clone" functionality to scheduled jobs2018-06-17T23:18:56Zmattwiremjw@mjwconsult.co.ukAdd "clone" functionality to scheduled jobsThis adds a "clone" or "copy" function to the scheduled jobs page. It is implemented as an API (job.clone) which can be called via a link from the scheduled jobs listing.
Ref https://github.com/civicrm/civicrm-core/pull/11945This adds a "clone" or "copy" function to the scheduled jobs page. It is implemented as an API (job.clone) which can be called via a link from the scheduled jobs listing.
Ref https://github.com/civicrm/civicrm-core/pull/119455.4.0https://lab.civicrm.org/dev/core/-/issues/41Search Builder: Not empty with date or integer custom fields gives a sql warning2019-03-07T19:25:44ZsamuelsovSearch Builder: Not empty with date or integer custom fields gives a sql warningMentioned by @bgm for a contact reference in mattermost https://chat.civicrm.org/civicrm/pl/49hcecoy5bb9mmsnrfzuzt9a4y and reproduced with a date custom field.
To reproduce :
* create a contactReference custom field or a date custom ...Mentioned by @bgm for a contact reference in mattermost https://chat.civicrm.org/civicrm/pl/49hcecoy5bb9mmsnrfzuzt9a4y and reproduced with a date custom field.
To reproduce :
* create a contactReference custom field or a date custom field
* populate some data on a few records
* use the Search Builder to search on that field, with condition "where [field] is not empty"
Here is an example of query that Mysql doesn't like :
```sql
CREATE TEMPORARY TABLE civicrm_temp_group_contact_cache1062 (SELECT 16 as group_id, contact_a.id as id FROM civicrm_contact contact_a
LEFT JOIN civicrm_value_cfa_contact_2 ON civicrm_value_cfa_contact_2.entity_id = `contact_a`.id WHERE ( ( contact_a.contact_type = "individual" AND (NULLIF(civicrm_value_cfa_contact_2.date_de_validation_manuelle_23, '') IS NOT NULL) ) ) AND (contact_a.is_deleted = 0) AND contact_a.id NOT IN (
SELECT contact_id FROM civicrm_group_contact
WHERE civicrm_group_contact.status = "Removed"
AND civicrm_group_contact.group_id = 16 ) );
```
The warning is :
```sql
SHOW warnings;
+---------+------+------------------------------+
| Level | Code | Message |
+---------+------+------------------------------+
| Warning | 1292 | Incorrect datetime value: '' |
+---------+------+------------------------------+
1 row in set (0.00 sec)
```5.4.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/32Add option to disable cancel button on a profile form2023-04-28T01:39:33ZjitendraAdd option to disable cancel button on a profile formWhile setting up "subscribe" and "contact us" forms for a site, the default behaviour for a wordpress profile form of type "create" embedded via a shortcode is to show a cancel button.
This isn't really necessary for a single page form...While setting up "subscribe" and "contact us" forms for a site, the default behaviour for a wordpress profile form of type "create" embedded via a shortcode is to show a cancel button.
This isn't really necessary for a single page form with no existing data in it - but there doesn't appear to be a way to disable it.5.4.0