CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2018-05-28T02:48:08Zhttps://lab.civicrm.org/dev/core/-/issues/117Remove usage of each() This is deprecated in php7.22018-05-28T02:48:08ZseamusleeRemove usage of each() This is deprecated in php7.2The following parts of the code still used each() which is an older format of foreach
```
CRM/Activity/BAO/Query.php: while (list(, $k) = each($value)) {
CRM/Activity/BAO/Query.php: while (list($k, $v) = each($value)...The following parts of the code still used each() which is an older format of foreach
```
CRM/Activity/BAO/Query.php: while (list(, $k) = each($value)) {
CRM/Activity/BAO/Query.php: while (list($k, $v) = each($value)) {
CRM/Case/XMLProcessor/Report.php: while (list($gid, $group_values) = each($groupTree)) {
CRM/Case/XMLProcessor/Report.php: while (list($id, $field_values) = each($group_values['fields'])) {
CRM/Event/Form/Participant.php: while (list($k, $dupeCheckContactId) = each($this->_contactIds)) {
CRM/Member/Form/MembershipView.php: $dir = each($relDirection);
CRM/Member/BAO/Membership.php: while (($available > 0) && ($params = each($queue))) {
CRM/Pledge/BAO/Pledge.php: list($field, $value) = each($startDate);
CRM/Pledge/BAO/PledgeBlock.php: list($field, $value) = each($date);
CRM/Report/Form/Contribute/Recur.php: while (list(, $suffix) = each($date_suffixes)) {
CRM/Report/Form/ActivitySummary.php: while (list(, $suffix) = each($date_suffixes)) {
CRM/Utils/Migrate/Import.php: while (list($group_id, $fields) = each($fields_indexed_by_group_id)) {
CRM/Utils/Migrate/Import.php: while (list(, $customFieldXML) = each($fields)) {
CRM/Utils/Token.php: while (list($key) = each($greetingTokens)) {
```
ping @eileen @monish.deb5.3.0https://lab.civicrm.org/dev/core/-/issues/116Search builder searches on primary addresses are producing unexpected results2018-05-21T11:34:30ZAndryg8Search builder searches on primary addresses are producing unexpected resultsLooking at civicrm.demo.civihosting.com v5.0.0. as well as our v5.2beta1 dev site, I am getting weird results for various search builder searches:
Contacts > Country > Primary is empty - returns many addresses, many of which have countr...Looking at civicrm.demo.civihosting.com v5.0.0. as well as our v5.2beta1 dev site, I am getting weird results for various search builder searches:
Contacts > Country > Primary is empty - returns many addresses, many of which have country field AND are set to primary
Contacts > Country > Home is empty - seems to behave correctly.
Contacts > Country > Primary is NULL - same as above
Contacts > Country > Primary is regex - produces an error:
`
^united$ is not of the type Positive`
Hope that's useful info! Our 5.2Beta1 site has the fixes for https://lab.civicrm.org/dev/core/issues/1065.3.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/105Manage PCP URL Wrong for the notification email under wordpress2018-05-15T07:19:09ZaniesshsethhManage PCP URL Wrong for the notification email under wordpress5.3.0https://lab.civicrm.org/dev/core/-/issues/100Membership Detail report throw DB error2018-05-25T05:45:46ZyashodhaMembership Detail report throw DB errorMembership Detail report throw DB error due to acl clause applied twice.Membership Detail report throw DB error due to acl clause applied twice.5.3.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/99Search builder doesn't retain selected (boolean) option after searching2018-05-06T01:04:55ZMonish DebSearch builder doesn't retain selected (boolean) option after searchingSteps to replicate:
1. Go to `Search Builder`
2. Choose Contact >> Do not email (or any other Boolean field) >> = >> Select `Yes`
3. Submit
After submit, you will see the select option is replaced by text field with 1 as it's value:
![t...Steps to replicate:
1. Go to `Search Builder`
2. Choose Contact >> Do not email (or any other Boolean field) >> = >> Select `Yes`
3. Submit
After submit, you will see the select option is replaced by text field with 1 as it's value:
![test-multiple-before](/uploads/eea36e30389dcb871e0765137fc81150/test-multiple-before.gif)5.3.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/85mail() backend fails when empty Cc and Bcc parameters are passed2018-05-21T02:22:12Zmattwiremjw@mjwconsult.co.ukmail() backend fails when empty Cc and Bcc parameters are passedOn some servers the PHP mail() function fails to send email if empty 'Cc' or 'Bcc' headers are set.On some servers the PHP mail() function fails to send email if empty 'Cc' or 'Bcc' headers are set.5.3.0https://lab.civicrm.org/dev/core/-/issues/80Current Employer is not reset after relationship is updated2018-05-14T22:46:20ZjitendraCurrent Employer is not reset after relationship is updatedReplicated on dmaster.
- Add an employer relationship for a contact.
- Current Employer is correctly set.
- Edit the relationship to some other type eg. "Volunteer For" -> Save.
- Current Employer Field is still set to the previous value.Replicated on dmaster.
- Add an employer relationship for a contact.
- Current Employer is correctly set.
- Edit the relationship to some other type eg. "Volunteer For" -> Save.
- Current Employer Field is still set to the previous value.5.3.0jitendrajitendrahttps://lab.civicrm.org/dev/core/-/issues/69'state_province_name' token not working for alternate billing addresses2018-05-16T09:21:00Zvarshith'state_province_name' token not working for alternate billing addresses## Overview ##
This issue is related to this existing issue
https://issues.civicrm.org/jira/browse/CRM-21830
The PR for the above issue is here
https://github.com/civicrm/civicrm-core/pull/11776
Though this fixes the basic issue, it ...## Overview ##
This issue is related to this existing issue
https://issues.civicrm.org/jira/browse/CRM-21830
The PR for the above issue is here
https://github.com/civicrm/civicrm-core/pull/11776
Though this fixes the basic issue, it still doesn't work for all fields.
## How it works currently ##
If state_province field name is not of the form "state_province-{$billingLocationTypeID}", then state_province_name is empty. Which means field names of form 'billing_state_province-{#}' and 'billing_state_province_id-{#}' results in empty state_province_name when "state_province_name" token is used.5.3.0https://lab.civicrm.org/dev/core/-/issues/61Split edit message templates permission2018-10-05T01:39:35ZajesamsonSplit edit message templates permissionThe `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system...The `edit message templates` permission currently grants access to user-driven messages and system workflow message. The implication of this is that, there is no way of restricting a particular user to just user-driven messages or system workflow messages.
It is therefore better to split `edit message templates` into two granular permissions (`edit user-driven message templates` and `edit system workflow message templates`) so that user access can be better managed.
![before](/uploads/896ebbdb81b419fb607750667c569486/before.gif)5.3.0https://lab.civicrm.org/dev/core/-/issues/55Hide Adding Option Link for Locked Option Groups2018-05-17T10:55:18ZmichaelHide Adding Option Link for Locked Option GroupsYou can edit option values from a few different places:
1. `civicrm/admin/options?gid=<option_group_id>`
1. `civicrm/admin/options/<option_group_name>`
1. `civicrm/admin/custom/group/field/option?action=browse&gid=<custom_group_id>&fid=...You can edit option values from a few different places:
1. `civicrm/admin/options?gid=<option_group_id>`
1. `civicrm/admin/options/<option_group_name>`
1. `civicrm/admin/custom/group/field/option?action=browse&gid=<custom_group_id>&fid=<custom_field_id>`
When "is_locked" = 1 only the first method hides the button to add new option values.
The button to add an option value should be hidden for the two places where it is highlighted in the above screenshots
##### From Option Group Edit Page Using Group ID
This works as expected and the button to add a new option is hidden
![image](/uploads/4a3567b69cc961cd2e6b580c60e62f30/image.png)
##### From Custom Field Edit page
![image](/uploads/c2a00e7f49e59eea7b6b3efe6720e7e6/image.png)
##### From Option Group Edit Page Using Group Name
![image](/uploads/9e1d94a9f3f729dbc88cdf92760108a9/image.png)5.3.0https://lab.civicrm.org/dev/core/-/issues/43Google geocoding now seems to require an API key, settings page text needs up...2018-05-29T23:12:10ZlarsssandergreenGoogle geocoding now seems to require an API key, settings page text needs updateThe explanatory text on the geocoding settings page indicates that Google doesn't need an API key, but geocoding will no longer work without an API key:
https://developers.google.com/maps/documentation/geocoding/get-api-key
(and I can ...The explanatory text on the geocoding settings page indicates that Google doesn't need an API key, but geocoding will no longer work without an API key:
https://developers.google.com/maps/documentation/geocoding/get-api-key
(and I can verify that it does not work until you put in an API key). You also do need to enter your API key in the second set of fields (contra the text "You can leave the Geocoding fields blank if you are using Google as your mapping provider.")
Suggest changing the text on the settings page to reflect the update.5.3.0https://lab.civicrm.org/dev/core/-/issues/40Show Contributions Associated to Recurring Contribution on Detailed View2018-06-04T00:31:14ZCamilo RodrÃguezShow Contributions Associated to Recurring Contribution on Detailed View## Overview
Currently, when viewing a recurring contribution from contact's detailed view (on Contributions tab), the only information shown is its basic information. It would be great if we could also see the contributions related to th...## Overview
Currently, when viewing a recurring contribution from contact's detailed view (on Contributions tab), the only information shown is its basic information. It would be great if we could also see the contributions related to that contribution on that same view.
## How it Works Currently
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Click the **view** action on a recurring contribution.
4. Only basic information for the recurring contribution is shown. Related contributions are not shown.
## How it Should Work
1. Go to a contact with that has contributions and recurring contributions.
2. Click on contributions tab.
3. Click the **view** action on a recurring contribution.
4. Basic information for the recurring contribution is shown and a table with related contributions is also shown.
## Acceptance Criteria
* On the "View Recurring Contribution" modal, a "Contribution" accordion should be added to the bottom.
* Accordion should show a table listing all contributions that are linked to this recurring contribution.
* The table should have the look and behaviour of the current contribution table in contact record's contribution tab.5.3.0https://lab.civicrm.org/dev/core/-/issues/38Recurring Contribution Information on Membership Modal2018-05-29T18:22:20ZCamilo RodrÃguezRecurring Contribution Information on Membership Modal## Overview
Currently, when viewing a membership from contact's detailed view (on memberships tab), it is hard to tell if a membership has any recurring contributions associated to it, even though you can see all payments done for the me...## Overview
Currently, when viewing a membership from contact's detailed view (on memberships tab), it is hard to tell if a membership has any recurring contributions associated to it, even though you can see all payments done for the membership. It would be good if you could see both payments and recurring contributions associated to the membership, similar to how both are shown on Contact's contribution tab.
## How it Works Currently
1. Go to a contact with that has memberships, contributions and recurring contributions.
2. Click on memberships tab.
3. Click the **view** action on a membership.
4. Membership details are shown, including payments. Recurring contributions are not shown.
## How it Should Work
1. Go to a contact with that has memberships, contributions and recurring contributions.
2. Click on memberships tab.
3. Click the **view** action on a membership.
4. Membership details are shown, including payments. Recurring contributions are also shown, just after the table with membership contributions.
## Accepatance Criteria
* Relabel the "Related Contributions" accordion to "Related Contributions and Recurring Contributions".
* A contributions section is shown on the accordion showing a table of all contributions that are linked to the membership.
* A recurring contribution section showing a table of all recurring contributions that are linked to the membership.
* The recurring contributions section should reuse the recurring contribution table structure in Contact's contribution tab.
* Actions for recurring contributions work as in contributions Tab.5.3.0https://lab.civicrm.org/dev/core/-/issues/35avoid template variable leakage when processing more than one recurring contr...2023-04-28T01:39:33Zjamieavoid template variable leakage when processing more than one recurring contribution in a sessionThis bug happens if you have more than one iATS recurring contribution and an earlier contribution is assigned to a soft credit, but one or more later contributions are not assigned to a soft credit.
The later contributions have the sof...This bug happens if you have more than one iATS recurring contribution and an earlier contribution is assigned to a soft credit, but one or more later contributions are not assigned to a soft credit.
The later contributions have the soft credit information inserted into their receipt because the email message template variables are not properly cleared.
iATS processes multiple recurring contributions in a single session via a cron job, so may be uniquely triggering this error (although the bug is with CiviCRM Core).5.3.0https://lab.civicrm.org/dev/core/-/issues/30Exporting master address contact even if no master address contact is defined2023-04-28T01:39:33ZsamuelsovExporting master address contact even if no master address contact is definedExporting "Master address contact" should give the master contact only if there is a master_id defined for this address but currently, if there is no master_id, the first master address id found for this contact is used.
```php
class C...Exporting "Master address contact" should give the master contact only if there is a master_id defined for this address but currently, if there is no master_id, the first master address id found for this contact is used.
```php
class CRM_Contact_BAO_Contact extends CRM_Contact_DAO_Contact {
...
public static function getMasterDisplayName($masterAddressId = NULL, $contactId = NULL) {
$masterDisplayName = NULL;
$sql = NULL;
if (!$masterAddressId && !$contactId) {
return $masterDisplayName;
}
if ($masterAddressId) {
$sql = "
SELECT display_name from civicrm_contact
LEFT JOIN civicrm_address ON ( civicrm_address.contact_id = civicrm_contact.id )
WHERE civicrm_address.id = " . $masterAddressId;
}
// ==> is there any reason to do that ?
elseif ($contactId) {
$sql = "
SELECT display_name from civicrm_contact cc, civicrm_address add1
LEFT JOIN civicrm_address add2 ON ( add1.master_id = add2.id )
WHERE cc.id = add2.contact_id AND add1.contact_id = " . $contactId;
}
$masterDisplayName = CRM_Core_DAO::singleValueQuery($sql);
return $masterDisplayName;
}
```5.3.0