CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2023-09-06T16:08:21Zhttps://lab.civicrm.org/dev/core/-/issues/60"Check number" isn't shown on Pay Later event registrations when edited2023-09-06T16:08:21Zlaryn"Check number" isn't shown on Pay Later event registrations when editedThis happens to me with an event registration that comes through 'webform_civicrm' as a "Pending (Pay Later)". When I try to edit the participant record to record a payment, the "Check Number" field never shows up despite "Check" being s...This happens to me with an event registration that comes through 'webform_civicrm' as a "Pending (Pay Later)". When I try to edit the participant record to record a payment, the "Check Number" field never shows up despite "Check" being selected as the payment instrument.
**I was able to reproduce on a demo server by doing the following**:
* Create a registration, marking it as "Pending (Pay Later)" and unchecking "Record Payment"
* Edit the new participant you just created, check "Record Payment" and make sure "Check" is selected as the payment instrument.
No "Check Number" field is shown.
![Screen_Shot_2018-04-11_at_3.52.02_PM](/uploads/02f92e016aa97074be80d410ca596db1/Screen_Shot_2018-04-11_at_3.52.02_PM.jpg)5.2.0eileeneileenhttps://lab.civicrm.org/dev/core/-/issues/3564All unsubscribe group members are excluded from a mailing with a manually spe...2022-06-11T14:54:11ZlolcodeAll unsubscribe group members are excluded from a mailing with a manually specified unsubscribe group (group_type=Base) if the unsubscribe group is a Smart groupAll unsubscribe group members are excluded from a mailing with a manually specified unsubscribe group (group_type=Base) if the unsubscribe group is a Smart group.
**To reproduce:** Create a smart group with some members in it. Some mem...All unsubscribe group members are excluded from a mailing with a manually specified unsubscribe group (group_type=Base) if the unsubscribe group is a Smart group.
**To reproduce:** Create a smart group with some members in it. Some members may also be added and removed manually as usual. Search for some contacts including some who are in that smart group and choose the action to send/schedule a bulk email. When creating the mail select the Smart group as your unsubscribe group.
**The expected result:** The mailing is not sent to any contacts in the search who are in the smart un-subscribe group with the status "Removed".
**The result:** The mailing is not sent to any contacts in the search who are in the smart un-subscribe group at all.5.2.0https://lab.civicrm.org/dev/core/-/issues/89Batch update participants with checkboxes fails2019-03-28T15:57:21ZStoobBatch update participants with checkboxes fails![gl-1](/uploads/4ef7cf6b8b67b0e784fadb2002700cbc/gl-1.png)
![gl-2](/uploads/d4291f1ad6a2bdfaecfb654e754cceba/gl-2.png)
Error message.
> Sorry, due to an error... '' is not a valid option for field custom_93![gl-1](/uploads/4ef7cf6b8b67b0e784fadb2002700cbc/gl-1.png)
![gl-2](/uploads/d4291f1ad6a2bdfaecfb654e754cceba/gl-2.png)
Error message.
> Sorry, due to an error... '' is not a valid option for field custom_935.2.0https://lab.civicrm.org/dev/core/-/issues/86CIVICRM_MAIL_LOG_AND_SEND does not work properly2018-11-18T21:03:25Zmattwiremjw@mjwconsult.co.ukCIVICRM_MAIL_LOG_AND_SEND does not work properlyIn the packages/Mail it is mistyped as "CIVICRM_MAIL_LOG_AND SEND" (ie. missing an underscore): https://github.com/civicrm/civicrm-packages/pull/204
In CiviCRM core the administrator is not notified if it is set: https://github.com/civi...In the packages/Mail it is mistyped as "CIVICRM_MAIL_LOG_AND SEND" (ie. missing an underscore): https://github.com/civicrm/civicrm-packages/pull/204
In CiviCRM core the administrator is not notified if it is set: https://github.com/civicrm/civicrm-core/pull/12037
In the docs it is missing altogether: https://github.com/civicrm/civicrm-dev-docs/pull/5265.2.0https://lab.civicrm.org/dev/core/-/issues/114Email-Invoices fails since 4.7.31 because of invalid From-Addresses2018-05-16T02:43:17Zthomas_SYSTOPIAEmail-Invoices fails since 4.7.31 because of invalid From-AddressesReproduce:
1. Enable Tax and Invoicing (in "CiviContribute Component Settings")
2. Setup a From-Email-Adress
3. Create a Contribution
4. Use "Email Invoice" to send an Invoice.
You get: "**Validation failed for: from-email-address**"
T...Reproduce:
1. Enable Tax and Invoicing (in "CiviContribute Component Settings")
2. Setup a From-Email-Adress
3. Create a Contribution
4. Use "Email Invoice" to send an Invoice.
You get: "**Validation failed for: from-email-address**"
The reason could be found in CRM/Contribute/Form/Task/Invoice.php[460:465]:
```
$fromEmail = CRM_Core_BAO_Email::getFromEmail();
// from email address
if (isset($params['from_email_address'])) \{
$fromEmailAddress = CRM_Utils_Array::value($params['from_email_address'], $fromEmail);
}
```
The values of $fromEmail are html-escaped versions of the email-adresses. They might be useful for Select-Options in HTML-Forms. But they won't work for real email-headers.5.2.0https://lab.civicrm.org/dev/core/-/issues/78Incorrect Payment Processor for Recurring Payments2018-11-17T02:47:01ZjitendraIncorrect Payment Processor for Recurring PaymentsThe issue arises due to there being two AuthNet payment processors, one for both A1 and A2. And the CiviCRM code is (naively) written assuming there'd be a maximum of one. So when AuthNet calls into CiviCRM to notify it of a successful r...The issue arises due to there being two AuthNet payment processors, one for both A1 and A2. And the CiviCRM code is (naively) written assuming there'd be a maximum of one. So when AuthNet calls into CiviCRM to notify it of a successful recurring payment, for the A1 payments it is loading the A2 payment processor — and then failing.
The attached patch uses information from the address that AuthNet posts its updates to, which can signal which payment processor to use.5.2.0https://lab.civicrm.org/dev/core/-/issues/158intra-rc regression group contacts list and export limits results to 500 records2018-06-15T09:05:26Zlcdwebintra-rc regression group contacts list and export limits results to 500 recordsTo reproduce:
* create a group and add > 500 contacts to it
* go to the manage groups page and click contacts for that group to get the listing
* select all records and choose the export contacts action
* only 500 records are select...To reproduce:
* create a group and add > 500 contacts to it
* go to the manage groups page and click contacts for that group to get the listing
* select all records and choose the export contacts action
* only 500 records are selected for export
This appears to be a regression caused by this PR: https://github.com/civicrm/civicrm-core/pull/12110
Specifically the changes to Select.php -- haven't yet figured out where the breakdown is. What's interesting is that if you search for the group contacts via advanced search, the export works as expected. It's only when triggering after the manage groups > contacts link that the export list is truncated.5.2.0https://lab.civicrm.org/dev/core/-/issues/72PayflowPro throws error due to more than 4 decimal places2018-04-30T22:08:25ZyashodhaPayflowPro throws error due to more than 4 decimal placesPayflowPro throws error due to more than 4 decimal places
> Payment Processor Error message: 9013: Error - from payment processor: [4 Invalid amount]
> 9013: Error - from payment processor: [4 Invalid amount]
This was introduced in
ht...PayflowPro throws error due to more than 4 decimal places
> Payment Processor Error message: 9013: Error - from payment processor: [4 Invalid amount]
> 9013: Error - from payment processor: [4 Invalid amount]
This was introduced in
https://github.com/civicrm/civicrm-core/pull/11016
where database changes supported decimal upto 9 places.
**Before patch**
![payflow_before](/uploads/076f9b7a26906f24006898c670ad4345/payflow_before.png)
**After patch**
![payflow_after](/uploads/da4ecc053566b989aed53d42daa26068/payflow_after.png)5.2.0yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/137Possible regression on case search - placeholder2018-05-28T02:48:05ZeileenPossible regression on case search - placeholderMentioned here -
https://github.com/civicrm/civicrm-core/pull/11759#pullrequestreview-122555717
Opened this so we don;'t lose track of it
@monish.debMentioned here -
https://github.com/civicrm/civicrm-core/pull/11759#pullrequestreview-122555717
Opened this so we don;'t lose track of it
@monish.deb5.2.0https://lab.civicrm.org/dev/core/-/issues/91Prevent un-workable searches in search builder (was search builder improvements)2018-05-03T23:37:58ZMonish DebPrevent un-workable searches in search builder (was search builder improvements)Earlier there was a requirement where we need to remove specific MySQL operators which are not valid for specific data type e.g. String type doesn't work with >, <, <= and >= operators. And here's the fix https://github.com/civicrm/civic...Earlier there was a requirement where we need to remove specific MySQL operators which are not valid for specific data type e.g. String type doesn't work with >, <, <= and >= operators. And here's the fix https://github.com/civicrm/civicrm-core/commit/759094bdfa40531e4ec0cf0a644d9edd6b9247cf done earlier as per which it is fetching all columns which are String type and passing them into a separate JSON string identified as ```stringFields``` and another formatted list of valid string operators as ```stringOperators```. Similarly to identify date fields and to do a specific operation on such fields we are passing another variable ```dateFields```. These JSON object in JS are later used to specific operations. Now on the other hand, recently, I encountered another issue where the Boolean type columns don't work with IS EMPTY/IS NOT EMPTY operator and eventually leads to DB syntax error. So if I follow the same approach I need to assign another JSON string, which won't be an ideal fix. This lead me to do following 3 changes to improve the code:
1. Assign a single list of all data columns which are either Boolean, String or Date (as currently, these are the only kind that needs attention)
2. Use this list (as ```fieldTypes```) in JS to filter the operator or do field specific operations like covert a input search field to datepicker if the chosen search field is date kind.
3. Reduce list of variable assignment.5.2.0Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/81Warnings from CustomGroup and CustomField create functions2018-04-30T22:08:39ZmichaelWarnings from CustomGroup and CustomField create functionsBoth CustomGroup and CustomField seem to treat `create` as a method only for creating new entities. Although updates do work, a few places in the code expect that you have included some value in the params that you don't intend to update...Both CustomGroup and CustomField seem to treat `create` as a method only for creating new entities. Although updates do work, a few places in the code expect that you have included some value in the params that you don't intend to update.
For example:
```
$params = ['id' => 1, 'is_active' => 0];
civicrm_api3('CustomField', 'create', $params);
```
Will produce a warning (from a test I wrote for this):
```
Failure in api call for CustomGroup create: Undefined index: extends
#0 /repos/civicrm-core/CRM/Core/BAO/CustomGroup.php(64): PHPUnit_Util_ErrorHandler::handleError(8, 'Undefined index...', '/repos/civicrm-...', 64, Array)
```
---
https://github.com/civicrm/civicrm-core/pull/12033/files5.2.0