CiviCRM Core issueshttps://lab.civicrm.org/dev/core/-/issues2019-11-17T20:57:15Zhttps://lab.civicrm.org/dev/core/-/issues/680"Date Received" for contributions no longer mandatory, also breaks financial ...2019-11-17T20:57:15Zfabian_SYSTOPIA"Date Received" for contributions no longer mandatory, also breaks financial transactionsThis issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contri...This issue affects at least versions >5.3 - I was able to reproduce it on the current master as well. I would consider it a rather critical bug but maybe there is more to it (new, not fully finished feature)?
**Description**
The contribution field "Date Received" used to be mandatory which imho had several good and important reasons. It is now possible to create a contribution without a date both via the UI and the Rest API.
Having a contribution without a date messes up views, reports and any function based on the contribution date such as receipts or invoices.
Also it creates a financial transaction without a date which cannot be good. In the UI, financial transactions still require a date.
**How to reproduce**
Create a new contribution via the UI and delete the date and time in the field "Date Received". Contribution date and financial transaction date will be empty.5.10https://lab.civicrm.org/dev/core/-/issues/695Custom Search results selection failure2019-02-05T04:27:09Zaydunsaidan.saunders@squiffle.ukCustom Search results selection failureSymptom: When viewing custom search results, it is possible to select all records, but individual selections do not change the count and enable action dropdowns. This does not occur for all custom searches.
Analysis: The selections are...Symptom: When viewing custom search results, it is possible to select all records, but individual selections do not change the count and enable action dropdowns. This does not occur for all custom searches.
Analysis: The selections are saved by `CRM_Core_PrevNextCache_Sql::markSelection()` which updates the prevnext cache. However, if the results are not already in the prevnext cache, the selections are not saved. The cache is filled by `CRM_Contact_Selector::fillupPrevNextCache()` which it does by taking the result of the custom search's `contactIDs()` method and doing a string replace to form the query used for the cache and if the string replace fails, no results are saved in the cache and therefore individual results cannot be selected.
The string replacement method is case sensitive, so if the custom search specifies `contact_a.id as contact_id` then the replacement works, but specifying `contact_a.id AS contact_id` fails.
The whole approach seems rather fragile but making the string replacement case insensitive reduces that slightly, and hopefully saves developer frustration trying to track down why an innocuous select statement case change results in UI failures.5.10aydunsaidan.saunders@squiffle.ukaydunsaidan.saunders@squiffle.ukhttps://lab.civicrm.org/dev/core/-/issues/679Groups and Tags affect search results when using Search Builder2019-02-05T04:27:09ZRoseLaniganGroups and Tags affect search results when using Search BuilderTo recreate (in both the Drupal sandbox and WordPress sandbox):
* Create a group the normal way, e.g. Contact Types = Individuals
* Go to Search Builder - if I just choose fields such as contact Type, Street Address, Email... the resu...To recreate (in both the Drupal sandbox and WordPress sandbox):
* Create a group the normal way, e.g. Contact Types = Individuals
* Go to Search Builder - if I just choose fields such as contact Type, Street Address, Email... the results display properly
* However, if I include a Group or Tag as a parameter, e.g. Group = the group created in step 1, or Tag IS empty, the results only show the first result, although it's clear from the counter that there are more results (screenshot included).
![Untitled](/uploads/a36d03302b83ef3862a10b3191bbfe6b/Untitled.png)
First spotted on 5.9.0 and can recreate on 5.11.alpha5.10https://lab.civicrm.org/dev/core/-/issues/671"Display Result As" in Advanced search is not working.2019-02-04T20:46:42Zjitendra"Display Result As" in Advanced search is not working.On Dmaster -
1. Navigate to Advanced Search.
2. Select "Display Result As" to a value eg "related contact" -> "Parent of".
3. Hit Search.
Seems to be due to the changes made in https://github.com/civicrm/civicrm-core/pull/13250/files#di...On Dmaster -
1. Navigate to Advanced Search.
2. Select "Display Result As" to a value eg "related contact" -> "Parent of".
3. Hit Search.
Seems to be due to the changes made in https://github.com/civicrm/civicrm-core/pull/13250/files#diff-4709aadbb3a8fe3eafe15d2fdc83ecf8R317
@monish.deb @eileen It seems we already pass $this->_formValues as a reference param to convertFormValues(), so not sure why it is reset to the value returned by the function? Does that mean any changes made inside convertFormValues() is not considered by the process?5.10https://lab.civicrm.org/dev/core/-/issues/656unreleased regression - attendee report generates undefined property notice2019-01-14T02:07:11ZJonGoldunreleased regression - attendee report generates undefined property noticeYou can replicate this on dmaster demo by clicking "Refresh Results" on the "Attendee List" report. You'll get this notice once per contact:
```
Notice: Undefined property: CRM_Report_Form_Event_ParticipantListing::$campaigns in CRM_Re...You can replicate this on dmaster demo by clicking "Refresh Results" on the "Attendee List" report. You'll get this notice once per contact:
```
Notice: Undefined property: CRM_Report_Form_Event_ParticipantListing::$campaigns in CRM_Report_Form_Event_ParticipantListing->alterDisplay() (line 748 of /srv/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Report/Form/Event/ParticipantListing.php).
```
Ping @yashodha
Ref: core#4915.10https://lab.civicrm.org/dev/core/-/issues/653New Events defaulting to event template after first page2019-01-30T20:49:51ZRoseLaniganNew Events defaulting to event template after first pageCan recreate on the dmaster.
* Create Event Template (Events > Event Template)
* Create new event (Events > New Event)
* Use template
* When click 'Continue' to proceed beyond first page, it takes the user to the template's page 2 (...Can recreate on the dmaster.
* Create Event Template (Events > Event Template)
* Create new event (Events > New Event)
* Use template
* When click 'Continue' to proceed beyond first page, it takes the user to the template's page 2 (location) rather than the new event's location page
* If you click back to info and settings, that has the url link as if the event has been created, the it's a dead link.
* It creates a duplicate template, but no event.
Using v5.9.05.10https://lab.civicrm.org/dev/core/-/issues/651error exporting contributions with soft credits2019-03-07T19:55:31Zericgerror exporting contributions with soft creditswhen trying to export contributions with soft credits I got the following error
unknown column 'Array' in 'group statement'
[civicrm 5.9; drupal 7.x; mariadb; php 7.1]
I traced it to line 152 of
CRM/Export/BAO/Export.php
changing
$...when trying to export contributions with soft credits I got the following error
unknown column 'Array' in 'group statement'
[civicrm 5.9; drupal 7.x; mariadb; php 7.1]
I traced it to line 152 of
CRM/Export/BAO/Export.php
changing
$groupBy = array('contribution_search_scredit_combined.id', 'contribution_search_scredit_combined.scredit_id');
to
$groupBy = "contribution_search_scredit_combined.id, contribution_search_scredit_combined.scredit_id";
resolved the issue for me.
(I really need to learn how to do proper pull requests)5.10https://lab.civicrm.org/dev/core/-/issues/626Case Activities no longer show overdue items first.2018-12-29T21:21:27ZRayWrightCase Activities no longer show overdue items first.Previously, the listings of activities on cases would show overdue items first.
![CaseAct-01](/uploads/744e76b6db7657cd80aded49ebb453d3/CaseAct-01.png)
When datatables were being integrated CRM-16363 https://github.com/civicrm/civicrm-...Previously, the listings of activities on cases would show overdue items first.
![CaseAct-01](/uploads/744e76b6db7657cd80aded49ebb453d3/CaseAct-01.png)
When datatables were being integrated CRM-16363 https://github.com/civicrm/civicrm-core/commit/ad280fb669e26f136bb9f56b29556ad70a78d3a6#diff-ff123c4a302e96ad0dfa6e93247dd242 they added a sort order to the table directly int the template file - resulting in this:
![CaseAct-02](/uploads/267ede7aa3a41ca0ea648af419ead426/CaseAct-02.png)
The logic to sort by overdue items first lives in the Case/BAO/Case.php file (line 1042 in 5.5.3)
`ORDER BY overdue_date ASC, display_date DESC, weight DESC";`
Simply removing the data-order 'filter' from the tpl file reverts to the previous behavior. I've put in a PR as well.5.10https://lab.civicrm.org/dev/core/-/issues/3566Public View link does not show from Scheduled and Sent screen2022-06-11T14:54:15ZseamusleePublic View link does not show from Scheduled and Sent screenWhen you view a list of scheduled and sent mailings you cannot access the Public View url link even tho the code suggests it should be availableWhen you view a list of scheduled and sent mailings you cannot access the Public View url link even tho the code suggests it should be available5.10https://lab.civicrm.org/dev/core/-/issues/3231Correct Mailing Report unique Count2022-04-22T15:51:27ZsunilCorrect Mailing Report unique CountMailing -> Scheduled and Sent Mailings -> Report
Unique Opens -> Report
Total Opens -> Report
Both Report show same count.Mailing -> Scheduled and Sent Mailings -> Report
Unique Opens -> Report
Total Opens -> Report
Both Report show same count.5.10https://lab.civicrm.org/dev/core/-/issues/625DB error on Case Summary report dev/core#6032018-12-30T09:14:00ZDon WijesooriyaDB error on Case Summary report dev/core#603As mentioned in dev/core#603, filtering case summary report by "Active Relationship?" throws a DB field not found error.
The submitted PR only makes it a non-mandatory field.
Seen on dmaster ( 5.10.alpha1 )
## Steps to reproduce:
1....As mentioned in dev/core#603, filtering case summary report by "Active Relationship?" throws a DB field not found error.
The submitted PR only makes it a non-mandatory field.
Seen on dmaster ( 5.10.alpha1 )
## Steps to reproduce:
1. Go to Reports->Case Reports->New Case Report
2. Select Case Summary Report
3. Deselect "Staff Member" and "Relationship" fields
4. Go to Filters tab
![summary_report](/uploads/6adbf062de3def6e64ca1a42812f09f7/summary_report.png)
5. For "Active Relationship?" select operator "Is equal to" and value "Yes"
6. Click on View Results
7. Throws the following error
![error](/uploads/5ea31c37c155b70b7517eedf73b26433/error.png)
## Issue
As mentioned in dev/core#603, the bug is due to this condition: `if ($this->_relField)`
![FromClause](/uploads/cb96fe716027aafcaf71b4fbd38ea1aa/FromClause.png)5.10https://lab.civicrm.org/dev/core/-/issues/623civicrm_mailing_bounce_type.threshold = 30 for 'Away' is that correct?2018-12-29T04:47:10ZStoobcivicrm_mailing_bounce_type.threshold = 30 for 'Away' is that correct?I searched for "civicrm_mailing_bounce_type" and could find no issues. @seamuslee wanted confirmation that '30' is the correct number of civicrm_mailing_bounce_type.threshold for type=2 "Away".
I can confirm that 30 is the default valu...I searched for "civicrm_mailing_bounce_type" and could find no issues. @seamuslee wanted confirmation that '30' is the correct number of civicrm_mailing_bounce_type.threshold for type=2 "Away".
I can confirm that 30 is the default value in 5.6+, if not older. This default was changed from 3 to 30 at some point, not sure when. 3 is listed in the documentation, and there is a PR to change that part of the documentation.5.10https://lab.civicrm.org/dev/core/-/issues/622User Dashboard doesn't show Edit Contact Information link2019-01-01T20:47:10ZyashodhaUser Dashboard doesn't show Edit Contact Information link_Edit Contact Information_ is not loading on the dashboard.
The buggy logic leads to having links getting overwritten._Edit Contact Information_ is not loading on the dashboard.
The buggy logic leads to having links getting overwritten.5.10yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/610Page title displays twice if the activity type is set in Activity form2018-12-29T22:59:37ZyashodhaPage title displays twice if the activity type is set in Activity formSteps to replicate :
* Go to https://dmaster.demo.civicrm.org/civicrm/activity?reset=1&action=add&context=standalone&atype=2
* Page title displays twice
![activity_bug](/uploads/dcb4e9453ef30a5352b0755a471443c9/activity_bug.png)
It show...Steps to replicate :
* Go to https://dmaster.demo.civicrm.org/civicrm/activity?reset=1&action=add&context=standalone&atype=2
* Page title displays twice
![activity_bug](/uploads/dcb4e9453ef30a5352b0755a471443c9/activity_bug.png)
It shows properly if a new activity form doesn't have activity type set.
https://dmaster.demo.civicrm.org/civicrm/activity?reset=1&action=add&context=standalone5.10yashodhayashodhahttps://lab.civicrm.org/dev/core/-/issues/607Search Builder fails with an error when searching for State if the location t...2018-12-19T20:41:32ZkainukSearch Builder fails with an error when searching for State if the location type differs from the display name.To reproduce on the dmaster.
1. Goto https://dmaster.demo.civicrm.org/civicrm/admin/locationType?reset=1
1. Change the name of Other (nr 4) to other.
1. Start the search builder.
1. Create the following search ![screen01](/uploads/3cd446...To reproduce on the dmaster.
1. Goto https://dmaster.demo.civicrm.org/civicrm/admin/locationType?reset=1
1. Change the name of Other (nr 4) to other.
1. Start the search builder.
1. Create the following search ![screen01](/uploads/3cd4464f5e344f1a2866d0d2f4b3bc2d/screen01.jpg)
1. The search ends with a *DB Error - Syntax Error*5.10https://lab.civicrm.org/dev/core/-/issues/603DB error on Case Summary report2018-12-30T09:13:53ZmathavanDB error on Case Summary reportOn Case Summary report,
When run report without any changes are any filters then you would this warning message
![Warning_message](/uploads/d58a69dbbf72d9916ac87a3cde5c9583/Warning_message.png)
Then unselect the Staff Member Column and...On Case Summary report,
When run report without any changes are any filters then you would this warning message
![Warning_message](/uploads/d58a69dbbf72d9916ac87a3cde5c9583/Warning_message.png)
Then unselect the Staff Member Column and Relationship column on Column tab and run the report would end up with DB Error unknown column.
![unselectRelationshipFields](/uploads/78f1e4e8e732f70a4a65a7f266249c7a/unselectRelationshipFields.png)
![DB_Error](/uploads/ce1803449623eb3d62c539cfa06aa8a1/DB_Error.png)
I think is because of filter "Active Relationship" is set to "Yes" by default.
![Filter](/uploads/92151f98651b2deec706a7c2c06ee6ea/Filter.png)
Because there is no relationship table has been added in from clause based on this condition
![FromClause](/uploads/3126c43f0ebc4905fe368085d0ad0df0/FromClause.png)5.10https://lab.civicrm.org/dev/core/-/issues/592ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception...2018-12-13T06:41:13ZBjörn EndresArgumentCountError: Too few arguments to function CiviCRM_API3_Exception...Full message:
``ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception::__construct(), 1 passed in [drupal root]/sites/all/modules/civicrm/Civi/API/Api3SelectQuery.php on line 130 and at least 2 expected in CiviCRM_API...Full message:
``ArgumentCountError: Too few arguments to function CiviCRM_API3_Exception::__construct(), 1 passed in [drupal root]/sites/all/modules/civicrm/Civi/API/Api3SelectQuery.php on line 130 and at least 2 expected in CiviCRM_API3_Exception->__construct()
``
I'm assuming the ``new \CiviCRM_API3_Exception(`` call has escaped the author when fixing all ``new CiviCRM_API3_Exception(`` occurrences after the signature change.
Seems to affect ``5.7.2`` and later.
I'll post a PR right away.5.10https://lab.civicrm.org/dev/core/-/issues/576Fix issue where fields are dropped from XML files because version comparison ...2018-12-06T19:58:51ZseamusleeFix issue where fields are dropped from XML files because version comparison between the add key and the build version failsOn master we are seeing build failures in the matrix tests at the moment because doing `if (5.3 <= 5.10)` effectively is proving to be false so DAO files are being re-generated to exclude specific fields causing errors.On master we are seeing build failures in the matrix tests at the moment because doing `if (5.3 <= 5.10)` effectively is proving to be false so DAO files are being re-generated to exclude specific fields causing errors.5.10https://lab.civicrm.org/dev/core/-/issues/192Search builder fails for != smart group filter2018-12-17T20:07:12ZjitendraSearch builder fails for != smart group filter- Create a smart group.
- Open Search Builder and add this filter - Contacts -> Group -> !- -> Smart group
The != operator is ignored and the result will list all contacts belonging to the above smart group instead of excluding them.- Create a smart group.
- Open Search Builder and add this filter - Contacts -> Group -> !- -> Smart group
The != operator is ignored and the result will list all contacts belonging to the above smart group instead of excluding them.5.10Monish DebMonish Debhttps://lab.civicrm.org/dev/core/-/issues/104Get Tests to pass on PHP7.22018-12-10T03:36:53ZseamusleeGet Tests to pass on PHP7.2This is a meta issue for getting our tests to run against PHP7.2 ping @monish.deb @eileen @tottenThis is a meta issue for getting our tests to run against PHP7.2 ping @monish.deb @eileen @totten5.10seamusleeseamuslee